)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3404117867a66f7c504ae5fa175a6badb801edcb","unresolved":false,"context_lines":[{"line_number":486,"context_line":"        except Exception as e:"},{"line_number":487,"context_line":"            reason \u003d _(\"Get PMEM namespaces by ndctl utility failed; \""},{"line_number":488,"context_line":"                       \"ensure ndctl is installed: %s\") % e"},{"line_number":489,"context_line":"            raise exception.GetPMEMNamespaceFailed(reason\u003dreason)"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        if not output:"},{"line_number":492,"context_line":"            return {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_13d54f47","line":489,"updated":"2020-01-23 11:41:10.000000000","message":"I meant to add a test for this since it clearly wasn\u0027t covered. Can do that in a follow-up once people find this patch :)","commit_id":"ab0f68d142ad8de7d1377f77387369bbd4daed18"}],"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3404117867a66f7c504ae5fa175a6badb801edcb","unresolved":false,"context_lines":[{"line_number":521,"context_line":"    creating an overlay. By default it creates raw files, but will use qcow2"},{"line_number":522,"context_line":"    when creating a disk from a qcow2 if force_raw_images is not set in config."},{"line_number":523,"context_line":"    \"\"\""},{"line_number":524,"context_line":"    def __init__(self, instance, disk_name\u003d\u0027\u0027, path\u003d\u0027\u0027):"},{"line_number":525,"context_line":"        self.disk_name \u003d disk_name"},{"line_number":526,"context_line":"        path \u003d (path or os.path.join(libvirt_utils.get_instance_path(instance),"},{"line_number":527,"context_line":"                                     disk_name))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_9337ffaf","line":524,"updated":"2020-01-23 11:41:10.000000000","message":"This was changed because the type checker complained about \u0027os.path.join\u0027 not being able to handle None, which would happen if neither \u0027path\u0027 nor \u0027disk_name\u0027 were set. That won\u0027t happen in practice but this _is_ safer so why not. The alternative is to raise if neither of these are set. That\u0027s longer but I\u0027d be okay with it too","commit_id":"ab0f68d142ad8de7d1377f77387369bbd4daed18"}]}