)]}'
{"id":"openstack%2Fnova~703405","triplet_id":"openstack%2Fnova~master~I063488a2ad4924ffe2a48cbfc0c3c750221d37b7","project":"openstack/nova","branch":"master","topic":"pytype","hashtags":[],"change_id":"I063488a2ad4924ffe2a48cbfc0c3c750221d37b7","subject":"requirements: Limit hacking to one minor version","status":"MERGED","created":"2020-01-20 14:37:04.000000000","updated":"2020-01-23 11:26:37.000000000","submitted":"2020-01-23 11:21:18.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"703405-1579778478827-fa858c1e","meta_rev_id":"a0282022af387e52d80e8f3478650b9b12334514","_number":703405,"virtual_id_number":703405,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2020-01-20 17:09:18.000000000","_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"date":"2020-01-20 17:41:57.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2020-01-20 16:26:59.000000000","_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"date":"2020-01-20 17:22:39.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"date":"2020-01-22 10:54:15.000000000","_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"date":"2020-01-20 15:01:50.000000000","_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-01-23 11:21:18.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":2,"date":"2020-01-22 15:26:47.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":1,"date":"2020-01-20 14:45:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":1,"date":"2020-01-20 14:39:21.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":2,"date":"2020-01-20 15:35:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":1,"date":"2020-01-22 15:26:47.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-01-20 14:39:21.000000000","updated_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"},{"updated":"2020-01-20 14:45:05.000000000","updated_by":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"reviewer":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"state":"REVIEWER"},{"updated":"2020-01-20 15:01:50.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2020-01-20 15:35:46.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2020-01-20 16:26:59.000000000","updated_by":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-01-20 17:09:18.000000000","updated_by":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-01-20 17:22:39.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-01-20 17:41:57.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2020-01-22 15:26:47.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2020-01-23 11:21:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"27895531bc869da474fc483c1f0932e546264d9d","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-01-20 14:37:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"33edc864c3f6a4fd8ad01e6e02f10e2d7bb47330","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-01-20 14:39:21.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"d233529def3e1f23aeb84c622e9eace962b06219","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2020-01-20 14:45:05.000000000","message":"Patch Set 1: Code-Review+1\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"eb240aa6b8d0304c48164031069b81f625f6f36f","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-01-20 15:01:50.000000000","message":"Patch Set 1:\n\nBuild SUCCESSFUL (check pipeline).\n\n- pmem-tempest-plugin-filtered http://52.27.155.124/05/703405/1/check/pmem-tempest-plugin-filtered/7e0fe8d/ : SUCCESS in 23m 32s","accounts_in_message":[],"_revision_number":1},{"id":"c9222917da11169d4184791d71b076ca1d587aa6","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2020-01-20 15:35:46.000000000","message":"Patch Set 1: Code-Review+2\n\nmake sense","accounts_in_message":[],"_revision_number":1},{"id":"53fd2c332b233924e8bd2c47189e5c2959ee21e0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-20 16:26:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-api-guide https://zuul.opendev.org/t/openstack/build/1dbcb180533e484d8f7215b163cbdc1f : SUCCESS in 5m 42s\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/c5416a0933c643a2af21c806054223b8 : SUCCESS in 6m 40s\n- requirements-check https://zuul.opendev.org/t/openstack/build/67909440de214bdba538c48d8b7d1aee : SUCCESS in 4m 27s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/1da0e9028e8e4a9b9d92d297eafa1219 : SUCCESS in 18m 59s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9f3af6d2f97845afb21e3035a07bc8d9 : SUCCESS in 16m 10s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/081fb2bc09d54ea0be0da93ab306d27e : SUCCESS in 9m 28s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/fa4692594f4543488cf4141b6f7291ed : SUCCESS in 19m 53s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/bc1da0c2f7b04941b0c54be483b0ffc2 : SUCCESS in 14m 07s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c9e3224edff84169a985ce0f90c2b0f5 : SUCCESS in 11m 33s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/8a710f14654e4107b14a0008a6513cf7 : SUCCESS in 39m 13s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/17ac518c7ad042f9b34badb43e5ccf45 : SUCCESS in 24m 08s","accounts_in_message":[],"_revision_number":1},{"id":"7625d5a788d55c431f279fa88a25c068c14d3d16","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2020-01-20 16:26:59.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_VxFlexOS_NOVA http://publiclogs.emc.com/05/703405/1/check/EMC_VxFlexOS_NOVA/5b90fd4/EMC_VxFlexOS_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC VxFlexOS CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_VxFlexOS_CI","accounts_in_message":[],"_revision_number":1},{"id":"09ef32ea5790133298ff7a99d406ef3e08eedd30","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2020-01-20 17:09:18.000000000","message":"Patch Set 1:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-05-703405-1 : FAILURE \n\nSee https://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI for rechecking and info.","accounts_in_message":[],"_revision_number":1},{"id":"91bbdd06dd985aa2aca18482cf31ef7d78193b21","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-01-20 17:22:39.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/05/703405/1/check/tempest-dsvm-full-xenial/38b734c/ : FAILURE in 1h 23m 31s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/05/703405/1/check/tempest-dsvm-full-xenial-py3/adcd69e/ : FAILURE in 1h 24m 30s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/05/703405/1/check/grenade-dsvm-xenial/d4111ef/ : FAILURE in 2h 43m 36s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2d5165bf39a9a65e5a6006ea9b5f2507ef1e8a06","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-01-20 17:41:57.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/703405/1 : SUCCESS in 2h 31m 06s","accounts_in_message":[],"_revision_number":1},{"id":"f06bd023102736f2729167ae9037e885a83f06b7","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2020-01-21 14:54:44.000000000","message":"Patch Set 1: Code-Review-1\n\nI thought this was the purpose of running nova jobs in the requirements repo.\n\n...mm, where they run unit and functional, but not pep8.\n\nIMO it would be better to add that (run nova pep8 in requirements) rather than freezing this requirement until someone remembers to go try a new version. You could probably convince me otherwise, but for now...","accounts_in_message":[],"_revision_number":1},{"id":"4ddb1f025103df9c337f13be8bbad1f09a8d4d06","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-01-21 15:36:31.000000000","message":"Patch Set 1:\n\n\u003e I thought this was the purpose of running nova jobs in the\n \u003e requirements repo.\n \u003e \n \u003e ...mm, where they run unit and functional, but not pep8.\n \u003e \n \u003e IMO it would be better to add that (run nova pep8 in requirements)\n \u003e rather than freezing this requirement until someone remembers to go\n \u003e try a new version. You could probably convince me otherwise, but\n \u003e for now...\n\nAdding pep8 job on requirement does not actually help. hacking is blakclist requirement so it does not need to match with what in g-r. each project are free to use any version of hacking. To avoid any failure on project side when hacking version is bump, capping it on project side was decided.","accounts_in_message":[],"_revision_number":1},{"id":"38cb445dfe94bbb65116b8d40e3efb420a8f2c84","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2020-01-21 18:56:41.000000000","message":"Patch Set 1:\n\nStill not sure that we should cap it proactively rather than reacting when it changes, either by (a) accommodating the change (which was presumably made for a reason), or (b) capping/blacklisting at that time if (a) is deemed infeasible.\n\nIOW, my main beef is that if we land this, we\u0027ll never upgrade hacking again. I just see this as a break from the usual way of doing things, which is as it is for a reason.","accounts_in_message":[],"_revision_number":1},{"id":"38130867dea5ac6e0459cd63c86e23d60053b4af","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-01-22 10:54:15.000000000","message":"Patch Set 1:\n\n\u003e Still not sure that we should cap it proactively rather than\n \u003e reacting when it changes, either by (a) accommodating the change\n \u003e (which was presumably made for a reason), or (b) capping/blacklisting\n \u003e at that time if (a) is deemed infeasible.\n \u003e \n \u003e IOW, my main beef is that if we land this, we\u0027ll never upgrade\n \u003e hacking again. I just see this as a break from the usual way of\n \u003e doing things, which is as it is for a reason.\n\nIt\u0027s not a break from the usual way of doing things when upper-constraints isn\u0027t involved though. We\u0027ve historically always had a very narrow range of requirements for hacking [1][2] so this is returning to the norm. Note also that those links show that we _do_ in fact bump hacking every now and then (I care about it, at least)\n\n[1] https://github.com/openstack/nova/blob/19.0.0/test-requirements.txt#L5\n[2] https://github.com/openstack/nova/blob/20.0.0/test-requirements.txt#L5","accounts_in_message":[],"_revision_number":1},{"id":"fb30a317f304331e4cf7b4f03932f2f0aee1b81f","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2020-01-22 15:26:47.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n\u003e You could probably convince me otherwise\n\nDone :)","accounts_in_message":[],"_revision_number":1},{"id":"1f2d061de7e28ff4e604e18ca5c08f2e0e1edced","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-01-22 16:37:00.000000000","message":"Patch Set 1:\n\n\u003e \u003e Still not sure that we should cap it proactively rather than\n \u003e \u003e reacting when it changes, either by (a) accommodating the change\n \u003e \u003e (which was presumably made for a reason), or (b)\n \u003e capping/blacklisting\n \u003e \u003e at that time if (a) is deemed infeasible.\n \u003e \u003e\n \u003e \u003e IOW, my main beef is that if we land this, we\u0027ll never upgrade\n \u003e \u003e hacking again. I just see this as a break from the usual way of\n \u003e \u003e doing things, which is as it is for a reason.\n \u003e \n \u003e It\u0027s not a break from the usual way of doing things when\n \u003e upper-constraints isn\u0027t involved though. We\u0027ve historically always\n \u003e had a very narrow range of requirements for hacking [1][2] so this\n \u003e is returning to the norm. Note also that those links show that we\n \u003e _do_ in fact bump hacking every now and then (I care about it, at\n \u003e least)\n \u003e \n \u003e [1] https://github.com/openstack/nova/blob/19.0.0/test-requirements.txt#L5\n \u003e [2] https://github.com/openstack/nova/blob/20.0.0/test-requirements.txt#L5\n\nyeah, I preferred not to leave this uncap otherwise it block nova gate for some time.","accounts_in_message":[],"_revision_number":1},{"id":"0fdcb9a351d3f84cdcbd6b3c0e9a99fa7b5b6e99","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-23 01:44:52.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"c6d6e6f8601bfdf54ebd1dad463c89b8ac7a290b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-23 11:21:18.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"b44ac3f981a0041ece1ca3376d8ab9a09e77924a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-23 11:21:18.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-api-guide https://zuul.opendev.org/t/openstack/build/52d952f3c3a64a1189f19a50718c0079 : SUCCESS in 8m 11s\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/de5096b9375a4b439d920cb1cb6c5a21 : SUCCESS in 7m 49s\n- requirements-check https://zuul.opendev.org/t/openstack/build/7d36a46be52f486680cb92f55830708b : SUCCESS in 5m 27s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5a03bff2b24143b593d4f7065ae207ce : SUCCESS in 16m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e12502647a474a94b57dbd5feb409fb1 : SUCCESS in 10m 56s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/81e021ab62aa4d68922fc2b79bf46a08 : SUCCESS in 15m 28s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/bbcc63b720924c6ea5673c2242793c0a : SUCCESS in 18m 50s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/90ddfc526db041d1a46b16aa9d8b47c4 : SUCCESS in 14m 54s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/6e825f3ab22d448eb62b0de40a29d0e5 : SUCCESS in 41m 42s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/2f45c5d89528428aa121a88dad4ca70b : SUCCESS in 17m 00s","accounts_in_message":[],"_revision_number":1},{"id":"2aba274d2ac3591a0e7e9862ca4cf7cc6b10905a","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-23 11:26:37.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-api-guide https://zuul.opendev.org/t/openstack/build/7460832a07204cc58fb175be0bf488a6 : SUCCESS in 1m 14s\n- promote-api-ref https://zuul.opendev.org/t/openstack/build/f8bd2bd81a294e4b98d783e258d401aa : SUCCESS in 1m 10s\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4a9d4bcdd75e4a8ca370d80ffb639a8c : SUCCESS in 1m 35s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/736658edcbeb4d58a2cb5cbe45fff3ea : SUCCESS in 1m 18s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"233f2715dd3c72b5a1d07ce37f2aeb53ce37dabb","revisions":{"233f2715dd3c72b5a1d07ce37f2aeb53ce37dabb":{"kind":"REWORK","_number":1,"created":"2020-01-20 14:37:04.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/05/703405/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/05/703405/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/05/703405/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/05/703405/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/05/703405/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/05/703405/1"}}},"commit":{"parents":[{"commit":"e3da87a45dc9302c1c9d9418ed2b80a8c68d1507","subject":"Switch to hacking 2.x","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e3da87a45dc9302c1c9d9418ed2b80a8c68d1507"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2020-01-20 14:35:19.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2020-01-20 14:35:19.000000000","tz":0},"subject":"requirements: Limit hacking to one minor version","message":"requirements: Limit hacking to one minor version\n\nIt is possible, though unlikely, that hacking might introduce new rules\nin a minor version that would break the gate for nova. See this off\nbefore it can ever be an issue by doing $subject.\n\nChange-Id: I063488a2ad4924ffe2a48cbfc0c3c750221d37b7\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/233f2715dd3c72b5a1d07ce37f2aeb53ce37dabb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/233f2715dd3c72b5a1d07ce37f2aeb53ce37dabb"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
