)]}'
{"nova/api/openstack/compute/security_groups.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"740930a0ea58327e4ef298d80fee3d11b2628605","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        context \u003d _authorize_context(req)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        try:"},{"line_number":161,"context_line":"            id \u003d security_group_api.validate_id(id)"},{"line_number":162,"context_line":"            security_group \u003d security_group_api.get(context, id)"},{"line_number":163,"context_line":"        except exception.SecurityGroupNotFound as exp:"},{"line_number":164,"context_line":"            raise exc.HTTPNotFound(explanation\u003dexp.format_message())"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_10a5ceb5","line":161,"range":{"start_line":161,"start_character":0,"end_line":161,"end_character":51},"updated":"2020-03-12 18:50:45.000000000","message":"+1. all these place we are validating the id first so no chance of getting name.","commit_id":"7e0d2547c135ca678ae058c3af7c828c23fe5297"}],"nova/compute/api.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5ed46ab5f4406cf0cba39ad648c48494e60e63f6","unresolved":false,"context_lines":[{"line_number":898,"context_line":"            context, requested_networks, max_count)"},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"        kernel_id, ramdisk_id \u003d self._handle_kernel_and_ramdisk("},{"line_number":901,"context_line":"            context, kernel_id, ramdisk_id, boot_meta)"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"        config_drive \u003d self._check_config_drive(config_drive)"},{"line_number":904,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_5505d40f","line":901,"updated":"2020-03-06 13:13:17.000000000","message":"unrelated","commit_id":"7e0d2547c135ca678ae058c3af7c828c23fe5297"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"06d2d69a7248d66a66a702023dca471a3c77f152","unresolved":false,"context_lines":[{"line_number":898,"context_line":"            context, requested_networks, max_count)"},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"        kernel_id, ramdisk_id \u003d self._handle_kernel_and_ramdisk("},{"line_number":901,"context_line":"            context, kernel_id, ramdisk_id, boot_meta)"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"        config_drive \u003d self._check_config_drive(config_drive)"},{"line_number":904,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_3f195279","line":901,"in_reply_to":"1fa4df85_5505d40f","updated":"2020-03-19 16:01:44.000000000","message":"yes although this does follow the recommenation that if you have to split a function call across multiple line that you move all argument to the second line so im ok with this.","commit_id":"7e0d2547c135ca678ae058c3af7c828c23fe5297"}],"nova/network/security_group_api.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"740930a0ea58327e4ef298d80fee3d11b2628605","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    return id"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def validate_name("},{"line_number":58,"context_line":"        context: nova_context.RequestContext,"},{"line_number":59,"context_line":"        name: str):"},{"line_number":60,"context_line":"    \"\"\"Validate a security group name and return the corresponding UUID."}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_9079be30","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":17},"updated":"2020-03-12 18:50:45.000000000","message":"It converts the name to id not just validate. can we rename this to something like:\n get_sec_group_id_from_name() ?","commit_id":"7e0d2547c135ca678ae058c3af7c828c23fe5297"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"06d2d69a7248d66a66a702023dca471a3c77f152","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    return id"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def validate_name("},{"line_number":58,"context_line":"        context: nova_context.RequestContext,"},{"line_number":59,"context_line":"        name: str):"},{"line_number":60,"context_line":"    \"\"\"Validate a security group name and return the corresponding UUID."}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_1f533619","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":17},"in_reply_to":"1fa4df85_1c37c401","updated":"2020-03-19 16:01:44.000000000","message":"+1 ya that makes sense too me. i think that could be done in a follow up patch but if you respine then ya do it in this one.\n\nvalidate_name to me would imply it either return a bool or it returns nothing and raise an exception if its invalid\nso ya the new name is much more descriptive and corralates with my mental model of what this does more closely.","commit_id":"7e0d2547c135ca678ae058c3af7c828c23fe5297"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4270e1f7ba406f966d14c20e1e7ea7490d01781a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    return id"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def validate_name("},{"line_number":58,"context_line":"        context: nova_context.RequestContext,"},{"line_number":59,"context_line":"        name: str):"},{"line_number":60,"context_line":"    \"\"\"Validate a security group name and return the corresponding UUID."}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_1c37c401","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":17},"in_reply_to":"1fa4df85_9079be30","updated":"2020-03-19 15:53:25.000000000","message":"Good call. Happy to rename here or in a follow-up","commit_id":"7e0d2547c135ca678ae058c3af7c828c23fe5297"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5ed46ab5f4406cf0cba39ad648c48494e60e63f6","unresolved":false,"context_lines":[{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    # NOTE(jeffrey4l): list all the security groups when following"},{"line_number":333,"context_line":"    # conditions are met"},{"line_number":334,"context_line":"    #   * names and ids don\u0027t exist."},{"line_number":335,"context_line":"    #   * it is admin context and all_tenants exist in search_opts."},{"line_number":336,"context_line":"    #   * project is not specified."},{"line_number":337,"context_line":"    list_all_tenants \u003d (context.is_admin and"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_b53e88be","line":334,"range":{"start_line":334,"start_character":1,"end_line":334,"end_character":36},"updated":"2020-03-06 13:13:17.000000000","message":"this seems outdated now","commit_id":"7e0d2547c135ca678ae058c3af7c828c23fe5297"}]}