)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ae3cf234e921eefa113a6b4f69febefa420d872d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"build_and_run_instance(). This requires a bump in compute rpcapi version."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] https://review.opendev.org/#/c/631244/54/nova/compute/manager.py@2652"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I26395d57bd4ba55276b7514baa808f9888639e11"},{"line_number":20,"context_line":"APIImpact: Adds new compute rpcapi version 5.11"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_65347d48","line":18,"updated":"2020-02-03 06:04:15.000000000","message":"blueprint: nova-cyborg-interaction","commit_id":"8730d45aa9a2152b8653134a4e661cfc4fdc5487"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"99664506e1900cf7262785303f1026649bf22ca2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"build_and_run_instance(). This requires a bump in compute rpcapi version."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] https://review.opendev.org/#/c/631244/54/nova/compute/manager.py@2652"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I26395d57bd4ba55276b7514baa808f9888639e11"},{"line_number":20,"context_line":"APIImpact: Adds new compute rpcapi version 5.11"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_03d02152","line":18,"in_reply_to":"3fa7e38b_65347d48","updated":"2020-02-03 09:44:35.000000000","message":"Done","commit_id":"8730d45aa9a2152b8653134a4e661cfc4fdc5487"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2a6c5889285b409a5bee0939d66e19e2d12fd7cd","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Blueprint: nova-cyborg-interaction"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I26395d57bd4ba55276b7514baa808f9888639e11"},{"line_number":22,"context_line":"APIImpact: Adds new compute rpcapi version 5.11"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_80972047","line":22,"updated":"2020-02-03 15:24:35.000000000","message":"This is for impacts to the REST API not the RPC API, which is all you have here, so remove this.","commit_id":"34003bf5c8e61abada4ec2a01ee700a842c4f6ed"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"be5d3a2c1f96025db3378bc549e7224beba1f14c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Blueprint: nova-cyborg-interaction"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I26395d57bd4ba55276b7514baa808f9888639e11"},{"line_number":22,"context_line":"APIImpact: Adds new compute rpcapi version 5.11"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_8124e6b2","line":22,"in_reply_to":"3fa7e38b_80972047","updated":"2020-02-05 04:30:49.000000000","message":"Done","commit_id":"34003bf5c8e61abada4ec2a01ee700a842c4f6ed"}],"nova/compute/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2a6c5889285b409a5bee0939d66e19e2d12fd7cd","unresolved":false,"context_lines":[{"line_number":2075,"context_line":"                     filter_properties, admin_password\u003dNone,"},{"line_number":2076,"context_line":"                     injected_files\u003dNone, requested_networks\u003dNone,"},{"line_number":2077,"context_line":"                     security_groups\u003dNone, block_device_mapping\u003dNone,"},{"line_number":2078,"context_line":"                     accel_uuids\u003dNone, node\u003dNone, limits\u003dNone, host_list\u003dNone):"},{"line_number":2079,"context_line":""},{"line_number":2080,"context_line":"        @utils.synchronized(instance.uuid)"},{"line_number":2081,"context_line":"        def _locked_do_build_and_run_instance(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_605ea4e9","line":2078,"range":{"start_line":2078,"start_character":21,"end_line":2078,"end_character":37},"updated":"2020-02-03 15:24:35.000000000","message":"This needs to go at the end to maintain compatibility with older versioned calls. Currently, RPC calls are dispatched by keyword so this will *work* but it can subtly break any other code that calls into here not through the RPC machinery.\n\nThe rest of the cases here aren\u0027t as important, but it also just seems really odd to add a new parameter in the middle like this.","commit_id":"34003bf5c8e61abada4ec2a01ee700a842c4f6ed"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"38e0ae4df5324ad58d2f0549a3c9bacc36b888a8","unresolved":false,"context_lines":[{"line_number":2075,"context_line":"                     filter_properties, admin_password\u003dNone,"},{"line_number":2076,"context_line":"                     injected_files\u003dNone, requested_networks\u003dNone,"},{"line_number":2077,"context_line":"                     security_groups\u003dNone, block_device_mapping\u003dNone,"},{"line_number":2078,"context_line":"                     accel_uuids\u003dNone, node\u003dNone, limits\u003dNone, host_list\u003dNone):"},{"line_number":2079,"context_line":""},{"line_number":2080,"context_line":"        @utils.synchronized(instance.uuid)"},{"line_number":2081,"context_line":"        def _locked_do_build_and_run_instance(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_774ae124","line":2078,"range":{"start_line":2078,"start_character":21,"end_line":2078,"end_character":37},"in_reply_to":"3fa7e38b_605ea4e9","updated":"2020-02-04 06:22:04.000000000","message":"Ok. The reason I did it this way is : (a) as you said, this is a kwarg and can go anywhere, and (b) I tried to keep accel_uuids right after the block device mapping param, as we done in other patches. But I\u0027ll change the order.","commit_id":"34003bf5c8e61abada4ec2a01ee700a842c4f6ed"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3a4c21935050eecb3b55e6776ad6d7daec060f15","unresolved":false,"context_lines":[{"line_number":2239,"context_line":"            self.compute_task_api.build_instances(context, [instance],"},{"line_number":2240,"context_line":"                    image, filter_properties, admin_password,"},{"line_number":2241,"context_line":"                    injected_files, requested_networks, security_groups,"},{"line_number":2242,"context_line":"                    block_device_mapping, accel_uuids,"},{"line_number":2243,"context_line":"                    request_spec\u003drequest_spec, host_lists\u003d[host_list])"},{"line_number":2244,"context_line":"            return build_results.RESCHEDULED"},{"line_number":2245,"context_line":"        except (exception.InstanceNotFound,"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_f66ef363","line":2242,"range":{"start_line":2242,"start_character":42,"end_line":2242,"end_character":53},"updated":"2020-02-18 15:02:41.000000000","message":"Where are you adding this to the conductor RPC API? Since you\u0027re not calling this as a kwarg, I\u0027m guessing you\u0027re actually just getting shoved into another positional parameter without warning. Again, I ask you to add new arguments as kwargs, and to the end of the parameter list.\n\nThis is at least one reason why you\u0027re not getting the ARQs passed back in on reschedule.","commit_id":"ac0f74a3d37db0ffd2a68466935788a74c117308"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"f5df7d87cce662f2d2eca05b0555efcb04cbd7ee","unresolved":false,"context_lines":[{"line_number":2239,"context_line":"            self.compute_task_api.build_instances(context, [instance],"},{"line_number":2240,"context_line":"                    image, filter_properties, admin_password,"},{"line_number":2241,"context_line":"                    injected_files, requested_networks, security_groups,"},{"line_number":2242,"context_line":"                    block_device_mapping, accel_uuids,"},{"line_number":2243,"context_line":"                    request_spec\u003drequest_spec, host_lists\u003d[host_list])"},{"line_number":2244,"context_line":"            return build_results.RESCHEDULED"},{"line_number":2245,"context_line":"        except (exception.InstanceNotFound,"}],"source_content_type":"text/x-python","patch_set":14,"id":"1fa4df85_a6ece8f3","line":2242,"range":{"start_line":2242,"start_character":42,"end_line":2242,"end_character":53},"in_reply_to":"3fa7e38b_f66ef363","updated":"2020-02-23 08:33:28.000000000","message":"Done","commit_id":"ac0f74a3d37db0ffd2a68466935788a74c117308"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"393517bf9565766562f5a27c4e7ce36ec33c4055","unresolved":false,"context_lines":[{"line_number":2659,"context_line":"            manager.py@2627"},{"line_number":2660,"context_line":""},{"line_number":2661,"context_line":"        :param dp_name: Device profile name. Caller ensures this is valid."},{"line_number":2662,"context_line":"        :param instance: instance object"},{"line_number":2663,"context_line":"        :returns: List of ARQs for which bindings have completed,"},{"line_number":2664,"context_line":"                  successfully or otherwise"},{"line_number":2665,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_6b3783ff","line":2662,"updated":"2020-02-18 12:35:55.000000000","message":"missing param doc","commit_id":"ac0f74a3d37db0ffd2a68466935788a74c117308"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"f5df7d87cce662f2d2eca05b0555efcb04cbd7ee","unresolved":false,"context_lines":[{"line_number":2659,"context_line":"            manager.py@2627"},{"line_number":2660,"context_line":""},{"line_number":2661,"context_line":"        :param dp_name: Device profile name. Caller ensures this is valid."},{"line_number":2662,"context_line":"        :param instance: instance object"},{"line_number":2663,"context_line":"        :returns: List of ARQs for which bindings have completed,"},{"line_number":2664,"context_line":"                  successfully or otherwise"},{"line_number":2665,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_78e2be9e","line":2662,"in_reply_to":"3fa7e38b_6b3783ff","updated":"2020-02-23 08:33:28.000000000","message":"Done","commit_id":"ac0f74a3d37db0ffd2a68466935788a74c117308"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"393517bf9565766562f5a27c4e7ce36ec33c4055","unresolved":false,"context_lines":[{"line_number":2666,"context_line":""},{"line_number":2667,"context_line":"        cyclient \u003d cyborg.get_client(context)"},{"line_number":2668,"context_line":"        events \u003d [(\u0027accelerator-request-bound\u0027, arq_uuid)"},{"line_number":2669,"context_line":"                  for arq_uuid in arq_uuids]"},{"line_number":2670,"context_line":"        timeout \u003d CONF.arq_binding_timeout or None"},{"line_number":2671,"context_line":"        with self.virtapi.wait_for_instance_event("},{"line_number":2672,"context_line":"                instance, events, deadline\u003dtimeout):"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_eb2293b7","line":2669,"range":{"start_line":2669,"start_character":34,"end_line":2669,"end_character":43},"updated":"2020-02-18 12:35:55.000000000","message":"this can be None if the RPC is pinned to \u003c 5.11","commit_id":"ac0f74a3d37db0ffd2a68466935788a74c117308"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"f5df7d87cce662f2d2eca05b0555efcb04cbd7ee","unresolved":false,"context_lines":[{"line_number":2666,"context_line":""},{"line_number":2667,"context_line":"        cyclient \u003d cyborg.get_client(context)"},{"line_number":2668,"context_line":"        events \u003d [(\u0027accelerator-request-bound\u0027, arq_uuid)"},{"line_number":2669,"context_line":"                  for arq_uuid in arq_uuids]"},{"line_number":2670,"context_line":"        timeout \u003d CONF.arq_binding_timeout or None"},{"line_number":2671,"context_line":"        with self.virtapi.wait_for_instance_event("},{"line_number":2672,"context_line":"                instance, events, deadline\u003dtimeout):"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_38fc463f","line":2669,"range":{"start_line":2669,"start_character":34,"end_line":2669,"end_character":43},"in_reply_to":"3fa7e38b_760683cf","updated":"2020-02-23 08:33:28.000000000","message":"Done","commit_id":"ac0f74a3d37db0ffd2a68466935788a74c117308"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5979c967ba43e5ae1d101cfae57edd4fd3a8f97f","unresolved":false,"context_lines":[{"line_number":2666,"context_line":""},{"line_number":2667,"context_line":"        cyclient \u003d cyborg.get_client(context)"},{"line_number":2668,"context_line":"        events \u003d [(\u0027accelerator-request-bound\u0027, arq_uuid)"},{"line_number":2669,"context_line":"                  for arq_uuid in arq_uuids]"},{"line_number":2670,"context_line":"        timeout \u003d CONF.arq_binding_timeout or None"},{"line_number":2671,"context_line":"        with self.virtapi.wait_for_instance_event("},{"line_number":2672,"context_line":"                instance, events, deadline\u003dtimeout):"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_760683cf","line":2669,"range":{"start_line":2669,"start_character":34,"end_line":2669,"end_character":43},"in_reply_to":"3fa7e38b_eb2293b7","updated":"2020-02-18 14:50:14.000000000","message":"Yeah, I\u0027m wondering if it can (unintentionally) also become None during a reschedule, per Sean\u0027s testing here:\n\nhttp://paste.openstack.org/show/789700/","commit_id":"ac0f74a3d37db0ffd2a68466935788a74c117308"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b0960362fefb22c787b37c316a9a06dcc72f912c","unresolved":false,"context_lines":[{"line_number":2671,"context_line":"            events \u003d [(\u0027accelerator-request-bound\u0027, arq_uuid)"},{"line_number":2672,"context_line":"                      for arq_uuid in arq_uuids]"},{"line_number":2673,"context_line":"        else:"},{"line_number":2674,"context_line":"            events \u003d []"},{"line_number":2675,"context_line":"        timeout \u003d CONF.arq_binding_timeout or None"},{"line_number":2676,"context_line":"        with self.virtapi.wait_for_instance_event("},{"line_number":2677,"context_line":"                instance, events, deadline\u003dtimeout):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1fa4df85_f5b4b637","line":2674,"updated":"2020-02-24 16:18:02.000000000","message":"This is not honoring the older version, per the RPC contract. In the previous rev, gibi was not asking you to just avoid crashing if arq_events is None, but rather continue to honor the old version.\n\nYou need to continue to do the lookup by instance for the old case, if arq_uuids is not passed in, so that if an operator upgrades to this version, but has pinned the compute version during the upgrade, you continue to work. Otherwise if they do that you will just silently ignore the arqs that conductor has set up for you, even though before this change you would have handled them properly.","commit_id":"f549c89d72586bad4ddf238b45124eb036b265b5"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"6345dbb588f870740614ddbf7c2e957e51fb8a59","unresolved":false,"context_lines":[{"line_number":2671,"context_line":"            events \u003d [(\u0027accelerator-request-bound\u0027, arq_uuid)"},{"line_number":2672,"context_line":"                      for arq_uuid in arq_uuids]"},{"line_number":2673,"context_line":"        else:"},{"line_number":2674,"context_line":"            events \u003d []"},{"line_number":2675,"context_line":"        timeout \u003d CONF.arq_binding_timeout or None"},{"line_number":2676,"context_line":"        with self.virtapi.wait_for_instance_event("},{"line_number":2677,"context_line":"                instance, events, deadline\u003dtimeout):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1fa4df85_913c1bc9","line":2674,"in_reply_to":"1fa4df85_f5b4b637","updated":"2020-03-01 21:54:20.000000000","message":"Done","commit_id":"f549c89d72586bad4ddf238b45124eb036b265b5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7672236b4f97eef2eead8e7ed8ff54563d3f013c","unresolved":false,"context_lines":[{"line_number":2661,"context_line":"        \"\"\""},{"line_number":2662,"context_line":""},{"line_number":2663,"context_line":"        cyclient \u003d cyborg.get_client(context)"},{"line_number":2664,"context_line":"        if arq_uuids:"},{"line_number":2665,"context_line":"            events \u003d [(\u0027accelerator-request-bound\u0027, arq_uuid)"},{"line_number":2666,"context_line":"                      for arq_uuid in arq_uuids]"},{"line_number":2667,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":16,"id":"1fa4df85_6d2896e1","line":2664,"updated":"2020-03-23 17:03:02.000000000","message":"If no arqs are passed into us because we don\u0027t have a device profile, and are using all new code, this will be [] and thus evaluate to false.","commit_id":"5b5f01370729bad07b77176453026dd0710b6b29"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7672236b4f97eef2eead8e7ed8ff54563d3f013c","unresolved":false,"context_lines":[{"line_number":2665,"context_line":"            events \u003d [(\u0027accelerator-request-bound\u0027, arq_uuid)"},{"line_number":2666,"context_line":"                      for arq_uuid in arq_uuids]"},{"line_number":2667,"context_line":"        else:"},{"line_number":2668,"context_line":"            arqs \u003d cyclient.get_arqs_for_instance(instance.uuid)"},{"line_number":2669,"context_line":"            arq_uuids \u003d [arq[\u0027uuid\u0027] for arq in arqs]"},{"line_number":2670,"context_line":"            events \u003d [(\u0027accelerator-request-bound\u0027, arq_uuid)"},{"line_number":2671,"context_line":"                      for arq_uuid in arq_uuids]"}],"source_content_type":"text/x-python","patch_set":16,"id":"1fa4df85_2d505e5d","line":2668,"updated":"2020-03-23 17:03:02.000000000","message":"So here, won\u0027t we do an unnecessary lookup to cyborg for those ARQs, assuming that we have them but weren\u0027t passed them because of downlevel RPC? If so, I think you should make this code closer to this:\n\n if arq_uuids is None:\n     # We got passed None, so we\u0027re backlevel\n     # Check for flavor device profile\n     # If device profile, then query cyborg\n else:\n     # We either got an empty list on purpose, or a real list\n     # Generate the event list (which might be empty)\n\nright?","commit_id":"5b5f01370729bad07b77176453026dd0710b6b29"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9943bdc478ef6c34fe673bc85e28ab38bb17fa80","unresolved":false,"context_lines":[{"line_number":2660,"context_line":"        \"\"\""},{"line_number":2661,"context_line":""},{"line_number":2662,"context_line":"        cyclient \u003d cyborg.get_client(context)"},{"line_number":2663,"context_line":"        if arq_uuids:"},{"line_number":2664,"context_line":"            events \u003d [(\u0027accelerator-request-bound\u0027, arq_uuid)"},{"line_number":2665,"context_line":"                      for arq_uuid in arq_uuids]"},{"line_number":2666,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_e7beda63","line":2663,"range":{"start_line":2663,"start_character":11,"end_line":2663,"end_character":20},"updated":"2020-03-19 13:41:01.000000000","message":"you should check for is None to avoid calling cyborg if an empty arq_uuids list is passed from the conductor.","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[{"line_number":2660,"context_line":"        \"\"\""},{"line_number":2661,"context_line":""},{"line_number":2662,"context_line":"        cyclient \u003d cyborg.get_client(context)"},{"line_number":2663,"context_line":"        if arq_uuids:"},{"line_number":2664,"context_line":"            events \u003d [(\u0027accelerator-request-bound\u0027, arq_uuid)"},{"line_number":2665,"context_line":"                      for arq_uuid in arq_uuids]"},{"line_number":2666,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_2e291d89","line":2663,"range":{"start_line":2663,"start_character":11,"end_line":2663,"end_character":20},"in_reply_to":"1fa4df85_e7beda63","updated":"2020-03-22 01:29:07.000000000","message":"Done","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9943bdc478ef6c34fe673bc85e28ab38bb17fa80","unresolved":false,"context_lines":[{"line_number":2668,"context_line":"            arq_uuids \u003d [arq[\u0027uuid\u0027] for arq in arqs]"},{"line_number":2669,"context_line":"            events \u003d [(\u0027accelerator-request-bound\u0027, arq_uuid)"},{"line_number":2670,"context_line":"                      for arq_uuid in arq_uuids]"},{"line_number":2671,"context_line":""},{"line_number":2672,"context_line":"        timeout \u003d CONF.arq_binding_timeout"},{"line_number":2673,"context_line":"        with self.virtapi.wait_for_instance_event("},{"line_number":2674,"context_line":"                instance, events, deadline\u003dtimeout):"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_8774c6d0","line":2671,"updated":"2020-03-19 13:41:01.000000000","message":"the whole if-else thing can be simplified to:\n\n    if arq_uuids is None:\n        arqs \u003d cyclient.get_arqs_for_instance(instance.uuid)\n        arq_uuids \u003d [arq[\u0027uuid\u0027] for arq in arqs]\n\n    events \u003d [(\u0027accelerator-request-bound\u0027, arq_uuid)\n              for arq_uuid in arq_uuids]","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[{"line_number":2668,"context_line":"            arq_uuids \u003d [arq[\u0027uuid\u0027] for arq in arqs]"},{"line_number":2669,"context_line":"            events \u003d [(\u0027accelerator-request-bound\u0027, arq_uuid)"},{"line_number":2670,"context_line":"                      for arq_uuid in arq_uuids]"},{"line_number":2671,"context_line":""},{"line_number":2672,"context_line":"        timeout \u003d CONF.arq_binding_timeout"},{"line_number":2673,"context_line":"        with self.virtapi.wait_for_instance_event("},{"line_number":2674,"context_line":"                instance, events, deadline\u003dtimeout):"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_4e2ed992","line":2671,"in_reply_to":"1fa4df85_8774c6d0","updated":"2020-03-22 01:29:07.000000000","message":"Done","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9943bdc478ef6c34fe673bc85e28ab38bb17fa80","unresolved":false,"context_lines":[{"line_number":2682,"context_line":"                self.virtapi.exit_wait_early(early_events)"},{"line_number":2683,"context_line":""},{"line_number":2684,"context_line":"        # Since a timeout in wait_for_instance_event will raise, we get"},{"line_number":2685,"context_line":"        # here only if all binding events have been received."},{"line_number":2686,"context_line":"        resolved_uuids \u003d [arq[\u0027uuid\u0027] for arq in resolved_arqs]"},{"line_number":2687,"context_line":"        if sorted(resolved_uuids) !\u003d sorted(arq_uuids):"},{"line_number":2688,"context_line":"            # Query Cyborg to get all."},{"line_number":2689,"context_line":"            arqs \u003d cyclient.get_arqs_for_instance(instance.uuid)"},{"line_number":2690,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_872286b8","line":2687,"range":{"start_line":2685,"start_character":0,"end_line":2687,"end_character":55},"updated":"2020-03-19 13:41:01.000000000","message":"whoa, is this a bugfix? or the baseline comparison is still valid but we can optimize the amount of data we are comparing?","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6452e270753185945efb8e6dc27cb119f196e5a2","unresolved":false,"context_lines":[{"line_number":2682,"context_line":"                self.virtapi.exit_wait_early(early_events)"},{"line_number":2683,"context_line":""},{"line_number":2684,"context_line":"        # Since a timeout in wait_for_instance_event will raise, we get"},{"line_number":2685,"context_line":"        # here only if all binding events have been received."},{"line_number":2686,"context_line":"        resolved_uuids \u003d [arq[\u0027uuid\u0027] for arq in resolved_arqs]"},{"line_number":2687,"context_line":"        if sorted(resolved_uuids) !\u003d sorted(arq_uuids):"},{"line_number":2688,"context_line":"            # Query Cyborg to get all."},{"line_number":2689,"context_line":"            arqs \u003d cyclient.get_arqs_for_instance(instance.uuid)"},{"line_number":2690,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":21,"id":"df33271e_296a7f7f","line":2687,"range":{"start_line":2685,"start_character":0,"end_line":2687,"end_character":55},"in_reply_to":"1fa4df85_2b4d8f99","updated":"2020-03-23 12:18:38.000000000","message":"I see. Thanks.","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[{"line_number":2682,"context_line":"                self.virtapi.exit_wait_early(early_events)"},{"line_number":2683,"context_line":""},{"line_number":2684,"context_line":"        # Since a timeout in wait_for_instance_event will raise, we get"},{"line_number":2685,"context_line":"        # here only if all binding events have been received."},{"line_number":2686,"context_line":"        resolved_uuids \u003d [arq[\u0027uuid\u0027] for arq in resolved_arqs]"},{"line_number":2687,"context_line":"        if sorted(resolved_uuids) !\u003d sorted(arq_uuids):"},{"line_number":2688,"context_line":"            # Query Cyborg to get all."},{"line_number":2689,"context_line":"            arqs \u003d cyclient.get_arqs_for_instance(instance.uuid)"},{"line_number":2690,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_2b4d8f99","line":2687,"range":{"start_line":2685,"start_character":0,"end_line":2687,"end_character":55},"in_reply_to":"1fa4df85_872286b8","updated":"2020-03-22 01:29:07.000000000","message":"Neither a bug fix nor an optimization. If the conductor passes a list of arq_uuids, we do not have the corresponding ARQs, but just the UUIDs. So, we can only compare the UUIDs, not the entire ARQs.","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"}],"nova/compute/rpcapi.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ae3cf234e921eefa113a6b4f69febefa420d872d","unresolved":false,"context_lines":[{"line_number":1439,"context_line":"                  \"host_list\": host_list,"},{"line_number":1440,"context_line":"                 }"},{"line_number":1441,"context_line":"        client \u003d self.router.client(ctxt)"},{"line_number":1442,"context_line":"        version \u003d \u00275.11\u0027"},{"line_number":1443,"context_line":"        cctxt \u003d client.prepare(server\u003dhost, version\u003dversion)"},{"line_number":1444,"context_line":"        cctxt.cast(ctxt, \u0027build_and_run_instance\u0027, **kwargs)"},{"line_number":1445,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_25e9a5aa","line":1442,"updated":"2020-02-03 06:04:15.000000000","message":"You are changing the request paramters in kwargs, so you also need to be compatible with 5.0 rpc version. such as:\n\n        version \u003d \u00275.11\u0027\n        if not client.can_send_version(version):\n            kwargs.pop(\u0027accel_uuids\u0027)\n            version \u003d \u00275.0\u0027","commit_id":"8730d45aa9a2152b8653134a4e661cfc4fdc5487"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"99664506e1900cf7262785303f1026649bf22ca2","unresolved":false,"context_lines":[{"line_number":1439,"context_line":"                  \"host_list\": host_list,"},{"line_number":1440,"context_line":"                 }"},{"line_number":1441,"context_line":"        client \u003d self.router.client(ctxt)"},{"line_number":1442,"context_line":"        version \u003d \u00275.11\u0027"},{"line_number":1443,"context_line":"        cctxt \u003d client.prepare(server\u003dhost, version\u003dversion)"},{"line_number":1444,"context_line":"        cctxt.cast(ctxt, \u0027build_and_run_instance\u0027, **kwargs)"},{"line_number":1445,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_e89844cc","line":1442,"in_reply_to":"3fa7e38b_25e9a5aa","updated":"2020-02-03 09:44:35.000000000","message":"Done","commit_id":"8730d45aa9a2152b8653134a4e661cfc4fdc5487"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2a6c5889285b409a5bee0939d66e19e2d12fd7cd","unresolved":false,"context_lines":[{"line_number":1419,"context_line":"    def build_and_run_instance(self, ctxt, instance, host, image, request_spec,"},{"line_number":1420,"context_line":"            filter_properties, admin_password\u003dNone, injected_files\u003dNone,"},{"line_number":1421,"context_line":"            requested_networks\u003dNone, security_groups\u003dNone,"},{"line_number":1422,"context_line":"            block_device_mapping\u003dNone, accel_uuids\u003dNone, node\u003dNone,"},{"line_number":1423,"context_line":"            limits\u003dNone, host_list\u003dNone):"},{"line_number":1424,"context_line":"        # NOTE(edleafe): compute nodes can only use the dict form of limits."},{"line_number":1425,"context_line":"        if isinstance(limits, objects.SchedulerLimits):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_0021f04f","line":1422,"range":{"start_line":1422,"start_character":39,"end_line":1422,"end_character":55},"updated":"2020-02-03 15:24:35.000000000","message":"Same, this should (a) match the manager call and (b) go at the end to avoid breaking the signature for older code.","commit_id":"34003bf5c8e61abada4ec2a01ee700a842c4f6ed"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"38e0ae4df5324ad58d2f0549a3c9bacc36b888a8","unresolved":false,"context_lines":[{"line_number":1419,"context_line":"    def build_and_run_instance(self, ctxt, instance, host, image, request_spec,"},{"line_number":1420,"context_line":"            filter_properties, admin_password\u003dNone, injected_files\u003dNone,"},{"line_number":1421,"context_line":"            requested_networks\u003dNone, security_groups\u003dNone,"},{"line_number":1422,"context_line":"            block_device_mapping\u003dNone, accel_uuids\u003dNone, node\u003dNone,"},{"line_number":1423,"context_line":"            limits\u003dNone, host_list\u003dNone):"},{"line_number":1424,"context_line":"        # NOTE(edleafe): compute nodes can only use the dict form of limits."},{"line_number":1425,"context_line":"        if isinstance(limits, objects.SchedulerLimits):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_37d1c92f","line":1422,"range":{"start_line":1422,"start_character":39,"end_line":1422,"end_character":55},"in_reply_to":"3fa7e38b_0021f04f","updated":"2020-02-04 06:22:04.000000000","message":"Done","commit_id":"34003bf5c8e61abada4ec2a01ee700a842c4f6ed"}],"nova/conductor/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b0960362fefb22c787b37c316a9a06dcc72f912c","unresolved":false,"context_lines":[{"line_number":840,"context_line":"            try:"},{"line_number":841,"context_line":"                resource_provider_mapping \u003d ("},{"line_number":842,"context_line":"                    local_reqspec.get_request_group_mapping())"},{"line_number":843,"context_line":"                accel_uuids \u003d self._create_and_bind_arqs("},{"line_number":844,"context_line":"                    context, instance.uuid, instance.flavor.extra_specs,"},{"line_number":845,"context_line":"                    host.nodename, resource_provider_mapping)"},{"line_number":846,"context_line":"            except Exception as exc:"}],"source_content_type":"text/x-python","patch_set":15,"id":"1fa4df85_b5d63e4f","line":843,"updated":"2020-02-24 16:18:02.000000000","message":"Isn\u0027t this just obscuring the accel_uuids you plumbed in via RPC? Why pass them if you\u0027re not going to use them?","commit_id":"f549c89d72586bad4ddf238b45124eb036b265b5"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"6345dbb588f870740614ddbf7c2e957e51fb8a59","unresolved":false,"context_lines":[{"line_number":840,"context_line":"            try:"},{"line_number":841,"context_line":"                resource_provider_mapping \u003d ("},{"line_number":842,"context_line":"                    local_reqspec.get_request_group_mapping())"},{"line_number":843,"context_line":"                accel_uuids \u003d self._create_and_bind_arqs("},{"line_number":844,"context_line":"                    context, instance.uuid, instance.flavor.extra_specs,"},{"line_number":845,"context_line":"                    host.nodename, resource_provider_mapping)"},{"line_number":846,"context_line":"            except Exception as exc:"}],"source_content_type":"text/x-python","patch_set":15,"id":"1fa4df85_71739f4e","line":843,"in_reply_to":"1fa4df85_b5d63e4f","updated":"2020-03-01 21:54:20.000000000","message":"Fixed.","commit_id":"f549c89d72586bad4ddf238b45124eb036b265b5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7672236b4f97eef2eead8e7ed8ff54563d3f013c","unresolved":false,"context_lines":[{"line_number":1619,"context_line":"                # this one."},{"line_number":1620,"context_line":"                continue"},{"line_number":1621,"context_line":""},{"line_number":1622,"context_line":"            accel_uuids \u003d []"},{"line_number":1623,"context_line":"            try:"},{"line_number":1624,"context_line":"                resource_provider_mapping \u003d ("},{"line_number":1625,"context_line":"                    request_spec.get_request_group_mapping())"}],"source_content_type":"text/x-python","patch_set":22,"id":"df33271e_2712a359","line":1622,"updated":"2020-03-23 17:03:02.000000000","message":"You don\u0027t need this right? We\u0027ll always set it, or we explode and never get to the point where it\u0027s uninitialized?","commit_id":"858ed8f824574f433d8f4fc7a606ce6e9eac29f3"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"4cc8865436daf6be935e5f2bd375932810c2cbb7","unresolved":false,"context_lines":[{"line_number":1619,"context_line":"                # this one."},{"line_number":1620,"context_line":"                continue"},{"line_number":1621,"context_line":""},{"line_number":1622,"context_line":"            accel_uuids \u003d []"},{"line_number":1623,"context_line":"            try:"},{"line_number":1624,"context_line":"                resource_provider_mapping \u003d ("},{"line_number":1625,"context_line":"                    request_spec.get_request_group_mapping())"}],"source_content_type":"text/x-python","patch_set":22,"id":"df33271e_67f47987","line":1622,"in_reply_to":"df33271e_005f84e2","updated":"2020-03-26 00:55:35.000000000","message":"+1, agree with sean, this is friendly for subsequent delivery.","commit_id":"858ed8f824574f433d8f4fc7a606ce6e9eac29f3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c084332745b2edc0300290b599f4c3c9f4991176","unresolved":false,"context_lines":[{"line_number":1619,"context_line":"                # this one."},{"line_number":1620,"context_line":"                continue"},{"line_number":1621,"context_line":""},{"line_number":1622,"context_line":"            accel_uuids \u003d []"},{"line_number":1623,"context_line":"            try:"},{"line_number":1624,"context_line":"                resource_provider_mapping \u003d ("},{"line_number":1625,"context_line":"                    request_spec.get_request_group_mapping())"}],"source_content_type":"text/x-python","patch_set":22,"id":"df33271e_005f84e2","line":1622,"in_reply_to":"df33271e_2712a359","updated":"2020-03-23 21:03:04.000000000","message":"its not needed but i actully think this is more readable.\n\ni still find it strange that try/if/while/for/with statements\ndont actully create a scope so fi we remove this then i would prefer if we move lines 1638-1655 into the try block before the except clause as the distance between the assignment in accel_uuids in the try and its use on line 1655 would be easy to miss.\n\nlines 1638-1655 only ever execute if the try block never throws so its the same behaviour logically.","commit_id":"858ed8f824574f433d8f4fc7a606ce6e9eac29f3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3252dbc8ec69cbff812d86902a5a6af20ce9b735","unresolved":false,"context_lines":[{"line_number":1619,"context_line":"                # this one."},{"line_number":1620,"context_line":"                continue"},{"line_number":1621,"context_line":""},{"line_number":1622,"context_line":"            accel_uuids \u003d []"},{"line_number":1623,"context_line":"            try:"},{"line_number":1624,"context_line":"                resource_provider_mapping \u003d ("},{"line_number":1625,"context_line":"                    request_spec.get_request_group_mapping())"}],"source_content_type":"text/x-python","patch_set":22,"id":"df33271e_5efe166b","line":1622,"in_reply_to":"df33271e_67f47987","updated":"2020-03-30 20:19:00.000000000","message":"Well, my argument is that when I see something like this, followed by setting it inside a block, it tells me that the author is expecting to potentially fall through the next block, be it a conditional or an exception handler. Conventions are powerful.","commit_id":"858ed8f824574f433d8f4fc7a606ce6e9eac29f3"}],"nova/conductor/rpcapi.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b0960362fefb22c787b37c316a9a06dcc72f912c","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                  \"security_groups\": security_groups,"},{"line_number":363,"context_line":"                  \"request_spec\": request_spec,"},{"line_number":364,"context_line":"                  \"host_lists\": host_lists,"},{"line_number":365,"context_line":"                  \"accel_uuids\": accel_uuids,"},{"line_number":366,"context_line":"                  }"},{"line_number":367,"context_line":"        version \u003d \u00271.19\u0027"},{"line_number":368,"context_line":"        if not self.client.can_send_version(version):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1fa4df85_15971293","line":365,"updated":"2020-02-24 16:18:02.000000000","message":"This requires a version bump to the conductor RPC API!","commit_id":"f549c89d72586bad4ddf238b45124eb036b265b5"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"6345dbb588f870740614ddbf7c2e957e51fb8a59","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                  \"security_groups\": security_groups,"},{"line_number":363,"context_line":"                  \"request_spec\": request_spec,"},{"line_number":364,"context_line":"                  \"host_lists\": host_lists,"},{"line_number":365,"context_line":"                  \"accel_uuids\": accel_uuids,"},{"line_number":366,"context_line":"                  }"},{"line_number":367,"context_line":"        version \u003d \u00271.19\u0027"},{"line_number":368,"context_line":"        if not self.client.can_send_version(version):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1fa4df85_11902b43","line":365,"in_reply_to":"1fa4df85_15971293","updated":"2020-03-01 21:54:20.000000000","message":"Dropped this.","commit_id":"f549c89d72586bad4ddf238b45124eb036b265b5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9943bdc478ef6c34fe673bc85e28ab38bb17fa80","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                  \"security_groups\": security_groups,"},{"line_number":363,"context_line":"                  \"request_spec\": request_spec,"},{"line_number":364,"context_line":"                  \"host_lists\": host_lists,"},{"line_number":365,"context_line":"                  }"},{"line_number":366,"context_line":"        version \u003d \u00271.19\u0027"},{"line_number":367,"context_line":"        if not self.client.can_send_version(version):"},{"line_number":368,"context_line":"            version \u003d \u00271.18\u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_02052411","line":365,"updated":"2020-03-19 13:41:01.000000000","message":"seems unrelated","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                  \"security_groups\": security_groups,"},{"line_number":363,"context_line":"                  \"request_spec\": request_spec,"},{"line_number":364,"context_line":"                  \"host_lists\": host_lists,"},{"line_number":365,"context_line":"                  }"},{"line_number":366,"context_line":"        version \u003d \u00271.19\u0027"},{"line_number":367,"context_line":"        if not self.client.can_send_version(version):"},{"line_number":368,"context_line":"            version \u003d \u00271.18\u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_0e2461ae","line":365,"in_reply_to":"1fa4df85_02052411","updated":"2020-03-22 01:29:07.000000000","message":"Done","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"}],"nova/tests/functional/test_servers.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ae3cf234e921eefa113a6b4f69febefa420d872d","unresolved":false,"context_lines":[{"line_number":7721,"context_line":"        self.assertEqual(usage, 0)"},{"line_number":7722,"context_line":""},{"line_number":7723,"context_line":"    def test_create_server(self):"},{"line_number":7724,"context_line":"        self.flags(compute\u003d\u00275.11\u0027, group\u003d\u0027upgrade_levels\u0027)"},{"line_number":7725,"context_line":"        flavor_id \u003d self._create_acc_flavor()"},{"line_number":7726,"context_line":"        server_name \u003d \u0027accel_server1\u0027"},{"line_number":7727,"context_line":"        server \u003d self._create_server("}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_a532755c","line":7724,"range":{"start_line":7724,"start_character":8,"end_line":7724,"end_character":58},"updated":"2020-02-03 06:04:15.000000000","message":"I think we cannot bump compute version to 5.11.","commit_id":"8730d45aa9a2152b8653134a4e661cfc4fdc5487"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"99664506e1900cf7262785303f1026649bf22ca2","unresolved":false,"context_lines":[{"line_number":7721,"context_line":"        self.assertEqual(usage, 0)"},{"line_number":7722,"context_line":""},{"line_number":7723,"context_line":"    def test_create_server(self):"},{"line_number":7724,"context_line":"        self.flags(compute\u003d\u00275.11\u0027, group\u003d\u0027upgrade_levels\u0027)"},{"line_number":7725,"context_line":"        flavor_id \u003d self._create_acc_flavor()"},{"line_number":7726,"context_line":"        server_name \u003d \u0027accel_server1\u0027"},{"line_number":7727,"context_line":"        server \u003d self._create_server("}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_a8a24cfa","line":7724,"range":{"start_line":7724,"start_character":8,"end_line":7724,"end_character":58},"in_reply_to":"3fa7e38b_a532755c","updated":"2020-02-03 09:44:35.000000000","message":"Since we are testing Cyborg functionality specifically, I think we need the new rpcapi version here.","commit_id":"8730d45aa9a2152b8653134a4e661cfc4fdc5487"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"393517bf9565766562f5a27c4e7ce36ec33c4055","unresolved":false,"context_lines":[{"line_number":7604,"context_line":"        self.assertEqual(usage, 0)"},{"line_number":7605,"context_line":""},{"line_number":7606,"context_line":"    def test_create_server(self):"},{"line_number":7607,"context_line":"        self.flags(compute\u003d\u00275.11\u0027, group\u003d\u0027upgrade_levels\u0027)"},{"line_number":7608,"context_line":"        flavor_id \u003d self._create_acc_flavor()"},{"line_number":7609,"context_line":"        server_name \u003d \u0027accel_server1\u0027"},{"line_number":7610,"context_line":"        server \u003d self._create_server("}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_5d8cca80","line":7607,"updated":"2020-02-18 12:35:55.000000000","message":"Why this is here? If I remove it the test still passes.\n\nIn the other hand we need a separate test case with compute RPC pinned to 5.10. I\u0027ve checked and it reproduce the problem I noted in the compute/manager code:\n\n    Traceback (most recent call last):\n      File \"/home/opnfv/rtox/nova/functional-py37/nova/compute/manager.py\", line 2607, in _build_resources\n        context, dp_name, instance, accel_uuids)\n      File \"/home/opnfv/rtox/nova/functional-py37/nova/compute/manager.py\", line 2669, in _get_bound_arq_resources\n        for arq_uuid in arq_uuids]\n    TypeError: \u0027NoneType\u0027 object is not iterable","commit_id":"ac0f74a3d37db0ffd2a68466935788a74c117308"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"f5df7d87cce662f2d2eca05b0555efcb04cbd7ee","unresolved":false,"context_lines":[{"line_number":7604,"context_line":"        self.assertEqual(usage, 0)"},{"line_number":7605,"context_line":""},{"line_number":7606,"context_line":"    def test_create_server(self):"},{"line_number":7607,"context_line":"        self.flags(compute\u003d\u00275.11\u0027, group\u003d\u0027upgrade_levels\u0027)"},{"line_number":7608,"context_line":"        flavor_id \u003d self._create_acc_flavor()"},{"line_number":7609,"context_line":"        server_name \u003d \u0027accel_server1\u0027"},{"line_number":7610,"context_line":"        server \u003d self._create_server("}],"source_content_type":"text/x-python","patch_set":14,"id":"1fa4df85_26eb18b1","line":7607,"in_reply_to":"3fa7e38b_5d8cca80","updated":"2020-02-23 08:33:28.000000000","message":"Will come back to this later.","commit_id":"ac0f74a3d37db0ffd2a68466935788a74c117308"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7672236b4f97eef2eead8e7ed8ff54563d3f013c","unresolved":false,"context_lines":[{"line_number":6425,"context_line":"                security_groups\u003dself.security_groups,"},{"line_number":6426,"context_line":"                block_device_mapping\u003dself.block_device_mapping,"},{"line_number":6427,"context_line":"                node\u003dself.node, limits\u003dself.limits, host_list\u003dfake_host_list,"},{"line_number":6428,"context_line":"                accel_uuids\u003dNone)"},{"line_number":6429,"context_line":""},{"line_number":6430,"context_line":"        self._instance_action_events(mock_start, mock_finish)"},{"line_number":6431,"context_line":"        self._assert_build_instance_update(mock_save)"}],"source_content_type":"text/x-python","patch_set":16,"id":"1fa4df85_cdbbca6f","line":6428,"range":{"start_line":6428,"start_character":28,"end_line":6428,"end_character":32},"updated":"2020-03-23 17:03:02.000000000","message":"In all of test tests which are representing the fully-upgraded case, this should be [] right? Like, if a new conductor is using the new RPC version, we\u0027ll get [] for every instance that doesn\u0027t have any ARQs right?","commit_id":"5b5f01370729bad07b77176453026dd0710b6b29"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7672236b4f97eef2eead8e7ed8ff54563d3f013c","unresolved":false,"context_lines":[{"line_number":6508,"context_line":"                          self.injected_files, self.admin_pass,"},{"line_number":6509,"context_line":"                          self.requested_networks, self.security_groups,"},{"line_number":6510,"context_line":"                          self.block_device_mapping, self.node, self.limits,"},{"line_number":6511,"context_line":"                          self.filter_properties, self.accel_uuids)"},{"line_number":6512,"context_line":"        mock_save.assert_has_calls(["},{"line_number":6513,"context_line":"            mock.call(),"},{"line_number":6514,"context_line":"            mock.call(),"}],"source_content_type":"text/x-python","patch_set":16,"id":"1fa4df85_2dacde32","line":6511,"range":{"start_line":6511,"start_character":50,"end_line":6511,"end_character":66},"updated":"2020-03-23 17:03:02.000000000","message":"Same argument here about this being None, but why did you start using self.accel_uuids here and explicit None in the cases above?","commit_id":"5b5f01370729bad07b77176453026dd0710b6b29"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9943bdc478ef6c34fe673bc85e28ab38bb17fa80","unresolved":false,"context_lines":[{"line_number":6517,"context_line":"        mock_build_and_run.side_effect \u003d exception.RescheduledException("},{"line_number":6518,"context_line":"            reason\u003d\u0027\u0027, instance_uuid\u003dself.instance.uuid)"},{"line_number":6519,"context_line":""},{"line_number":6520,"context_line":"        with mock.patch.object("},{"line_number":6521,"context_line":"            self.compute.network_api, \u0027get_instance_nw_info\u0027,"},{"line_number":6522,"context_line":"        ):"},{"line_number":6523,"context_line":"            self.compute._do_build_and_run_instance("}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_82c35489","side":"PARENT","line":6520,"updated":"2020-03-19 13:41:01.000000000","message":"why don\u0027t we need this any more? is this related to the current patch?","commit_id":"7433d6378c08cfe9755c6e5281b755d99f9f18ce"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[{"line_number":6517,"context_line":"        mock_build_and_run.side_effect \u003d exception.RescheduledException("},{"line_number":6518,"context_line":"            reason\u003d\u0027\u0027, instance_uuid\u003dself.instance.uuid)"},{"line_number":6519,"context_line":""},{"line_number":6520,"context_line":"        with mock.patch.object("},{"line_number":6521,"context_line":"            self.compute.network_api, \u0027get_instance_nw_info\u0027,"},{"line_number":6522,"context_line":"        ):"},{"line_number":6523,"context_line":"            self.compute._do_build_and_run_instance("}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_4e3d798d","side":"PARENT","line":6520,"in_reply_to":"1fa4df85_82c35489","updated":"2020-03-22 01:29:07.000000000","message":"Done","commit_id":"7433d6378c08cfe9755c6e5281b755d99f9f18ce"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9943bdc478ef6c34fe673bc85e28ab38bb17fa80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"1fa4df85_42155ce4","updated":"2020-03-19 13:41:01.000000000","message":"the change in this file is a lot noisier than it could be","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"1fa4df85_4ec2595b","in_reply_to":"1fa4df85_42155ce4","updated":"2020-03-22 01:29:07.000000000","message":"Done","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[{"line_number":6356,"context_line":"                requested_networks\u003dself.requested_networks,"},{"line_number":6357,"context_line":"                security_groups\u003dself.security_groups,"},{"line_number":6358,"context_line":"                block_device_mapping\u003dself.block_device_mapping, node\u003dself.node,"},{"line_number":6359,"context_line":"                limits\u003dself.limits, host_list\u003dfake_host_list, accel_uuids\u003dNone)"},{"line_number":6360,"context_line":""},{"line_number":6361,"context_line":"        self._assert_build_instance_hook_called(mock_hooks,"},{"line_number":6362,"context_line":"                                                build_results.ACTIVE)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_0e11c104","line":6359,"range":{"start_line":6359,"start_character":60,"end_line":6359,"end_character":78},"updated":"2020-03-22 01:29:07.000000000","message":"Removed these occurrences too.","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9943bdc478ef6c34fe673bc85e28ab38bb17fa80","unresolved":false,"context_lines":[{"line_number":6387,"context_line":"                    port_id\u003duuids.port_instance)],"},{"line_number":6388,"context_line":"                security_groups\u003dself.security_groups,"},{"line_number":6389,"context_line":"                block_device_mapping\u003dself.block_device_mapping,"},{"line_number":6390,"context_line":"                node\u003dself.node, limits\u003dself.limits, host_list\u003dfake_host_list,"},{"line_number":6391,"context_line":"                accel_uuids\u003dNone)"},{"line_number":6392,"context_line":"        requested_network \u003d mock_build_and_run.call_args[0][5][0]"},{"line_number":6393,"context_line":"        self.assertEqual(\u0027fake_network_id\u0027, requested_network.network_id)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_425d5c13","line":6390,"range":{"start_line":6390,"start_character":16,"end_line":6390,"end_character":31},"updated":"2020-03-19 13:41:01.000000000","message":"this wrapping change seems unnecessary.","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[{"line_number":6387,"context_line":"                    port_id\u003duuids.port_instance)],"},{"line_number":6388,"context_line":"                security_groups\u003dself.security_groups,"},{"line_number":6389,"context_line":"                block_device_mapping\u003dself.block_device_mapping,"},{"line_number":6390,"context_line":"                node\u003dself.node, limits\u003dself.limits, host_list\u003dfake_host_list,"},{"line_number":6391,"context_line":"                accel_uuids\u003dNone)"},{"line_number":6392,"context_line":"        requested_network \u003d mock_build_and_run.call_args[0][5][0]"},{"line_number":6393,"context_line":"        self.assertEqual(\u0027fake_network_id\u0027, requested_network.network_id)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_8e8b7166","line":6390,"range":{"start_line":6390,"start_character":16,"end_line":6390,"end_character":31},"in_reply_to":"1fa4df85_425d5c13","updated":"2020-03-22 01:29:07.000000000","message":"Done","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9943bdc478ef6c34fe673bc85e28ab38bb17fa80","unresolved":false,"context_lines":[{"line_number":6388,"context_line":"                security_groups\u003dself.security_groups,"},{"line_number":6389,"context_line":"                block_device_mapping\u003dself.block_device_mapping,"},{"line_number":6390,"context_line":"                node\u003dself.node, limits\u003dself.limits, host_list\u003dfake_host_list,"},{"line_number":6391,"context_line":"                accel_uuids\u003dNone)"},{"line_number":6392,"context_line":"        requested_network \u003d mock_build_and_run.call_args[0][5][0]"},{"line_number":6393,"context_line":"        self.assertEqual(\u0027fake_network_id\u0027, requested_network.network_id)"},{"line_number":6394,"context_line":"        self.assertEqual(\u002710.0.0.1\u0027, str(requested_network.address))"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_e2848860","line":6391,"updated":"2020-03-19 13:41:01.000000000","message":"accel_uuids defaulted to None anyhow.","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[{"line_number":6388,"context_line":"                security_groups\u003dself.security_groups,"},{"line_number":6389,"context_line":"                block_device_mapping\u003dself.block_device_mapping,"},{"line_number":6390,"context_line":"                node\u003dself.node, limits\u003dself.limits, host_list\u003dfake_host_list,"},{"line_number":6391,"context_line":"                accel_uuids\u003dNone)"},{"line_number":6392,"context_line":"        requested_network \u003d mock_build_and_run.call_args[0][5][0]"},{"line_number":6393,"context_line":"        self.assertEqual(\u0027fake_network_id\u0027, requested_network.network_id)"},{"line_number":6394,"context_line":"        self.assertEqual(\u002710.0.0.1\u0027, str(requested_network.address))"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_2eea7d0e","line":6391,"in_reply_to":"1fa4df85_e2848860","updated":"2020-03-22 01:29:07.000000000","message":"Done","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9943bdc478ef6c34fe673bc85e28ab38bb17fa80","unresolved":false,"context_lines":[{"line_number":6423,"context_line":"                requested_networks\u003dself.requested_networks,"},{"line_number":6424,"context_line":"                security_groups\u003dself.security_groups,"},{"line_number":6425,"context_line":"                block_device_mapping\u003dself.block_device_mapping,"},{"line_number":6426,"context_line":"                node\u003dself.node, limits\u003dself.limits, host_list\u003dfake_host_list,"},{"line_number":6427,"context_line":"                accel_uuids\u003dNone)"},{"line_number":6428,"context_line":""},{"line_number":6429,"context_line":"        self._instance_action_events(mock_start, mock_finish)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_a27a1074","line":6426,"updated":"2020-03-19 13:41:01.000000000","message":"ditto","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[{"line_number":6423,"context_line":"                requested_networks\u003dself.requested_networks,"},{"line_number":6424,"context_line":"                security_groups\u003dself.security_groups,"},{"line_number":6425,"context_line":"                block_device_mapping\u003dself.block_device_mapping,"},{"line_number":6426,"context_line":"                node\u003dself.node, limits\u003dself.limits, host_list\u003dfake_host_list,"},{"line_number":6427,"context_line":"                accel_uuids\u003dNone)"},{"line_number":6428,"context_line":""},{"line_number":6429,"context_line":"        self._instance_action_events(mock_start, mock_finish)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_aedd0d71","line":6426,"in_reply_to":"1fa4df85_a27a1074","updated":"2020-03-22 01:29:07.000000000","message":"Done","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9943bdc478ef6c34fe673bc85e28ab38bb17fa80","unresolved":false,"context_lines":[{"line_number":6424,"context_line":"                security_groups\u003dself.security_groups,"},{"line_number":6425,"context_line":"                block_device_mapping\u003dself.block_device_mapping,"},{"line_number":6426,"context_line":"                node\u003dself.node, limits\u003dself.limits, host_list\u003dfake_host_list,"},{"line_number":6427,"context_line":"                accel_uuids\u003dNone)"},{"line_number":6428,"context_line":""},{"line_number":6429,"context_line":"        self._instance_action_events(mock_start, mock_finish)"},{"line_number":6430,"context_line":"        self._assert_build_instance_update(mock_save)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_c27f0c64","line":6427,"updated":"2020-03-19 13:41:01.000000000","message":"ditto","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[{"line_number":6424,"context_line":"                security_groups\u003dself.security_groups,"},{"line_number":6425,"context_line":"                block_device_mapping\u003dself.block_device_mapping,"},{"line_number":6426,"context_line":"                node\u003dself.node, limits\u003dself.limits, host_list\u003dfake_host_list,"},{"line_number":6427,"context_line":"                accel_uuids\u003dNone)"},{"line_number":6428,"context_line":""},{"line_number":6429,"context_line":"        self._instance_action_events(mock_start, mock_finish)"},{"line_number":6430,"context_line":"        self._assert_build_instance_update(mock_save)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_cedac976","line":6427,"in_reply_to":"1fa4df85_c27f0c64","updated":"2020-03-22 01:29:07.000000000","message":"Done","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9943bdc478ef6c34fe673bc85e28ab38bb17fa80","unresolved":false,"context_lines":[{"line_number":6701,"context_line":"                requested_networks\u003dself.requested_networks,"},{"line_number":6702,"context_line":"                security_groups\u003dself.security_groups,"},{"line_number":6703,"context_line":"                block_device_mapping\u003dself.block_device_mapping,"},{"line_number":6704,"context_line":"                node\u003dself.node, limits\u003dself.limits, host_list\u003dfake_host_list,"},{"line_number":6705,"context_line":"                accel_uuids\u003dNone)"},{"line_number":6706,"context_line":""},{"line_number":6707,"context_line":"        self._assert_build_instance_hook_called(mock_hooks,"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_023d248e","line":6704,"updated":"2020-03-19 13:41:01.000000000","message":"unnecessary change of line wrap","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[{"line_number":6701,"context_line":"                requested_networks\u003dself.requested_networks,"},{"line_number":6702,"context_line":"                security_groups\u003dself.security_groups,"},{"line_number":6703,"context_line":"                block_device_mapping\u003dself.block_device_mapping,"},{"line_number":6704,"context_line":"                node\u003dself.node, limits\u003dself.limits, host_list\u003dfake_host_list,"},{"line_number":6705,"context_line":"                accel_uuids\u003dNone)"},{"line_number":6706,"context_line":""},{"line_number":6707,"context_line":"        self._assert_build_instance_hook_called(mock_hooks,"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_0e430115","line":6704,"in_reply_to":"1fa4df85_023d248e","updated":"2020-03-22 01:29:07.000000000","message":"Done","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9943bdc478ef6c34fe673bc85e28ab38bb17fa80","unresolved":false,"context_lines":[{"line_number":6794,"context_line":"                requested_networks\u003dself.requested_networks,"},{"line_number":6795,"context_line":"                security_groups\u003dself.security_groups,"},{"line_number":6796,"context_line":"                block_device_mapping\u003dself.block_device_mapping,"},{"line_number":6797,"context_line":"                node\u003dself.node, limits\u003dself.limits, host_list\u003dfake_host_list,"},{"line_number":6798,"context_line":"                accel_uuids\u003dNone)"},{"line_number":6799,"context_line":""},{"line_number":6800,"context_line":"        self._assert_build_instance_hook_called(mock_hooks,"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_225140da","line":6797,"updated":"2020-03-19 13:41:01.000000000","message":"ditto","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[{"line_number":6794,"context_line":"                requested_networks\u003dself.requested_networks,"},{"line_number":6795,"context_line":"                security_groups\u003dself.security_groups,"},{"line_number":6796,"context_line":"                block_device_mapping\u003dself.block_device_mapping,"},{"line_number":6797,"context_line":"                node\u003dself.node, limits\u003dself.limits, host_list\u003dfake_host_list,"},{"line_number":6798,"context_line":"                accel_uuids\u003dNone)"},{"line_number":6799,"context_line":""},{"line_number":6800,"context_line":"        self._assert_build_instance_hook_called(mock_hooks,"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_aef98dc8","line":6797,"in_reply_to":"1fa4df85_225140da","updated":"2020-03-22 01:29:07.000000000","message":"Done","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9943bdc478ef6c34fe673bc85e28ab38bb17fa80","unresolved":false,"context_lines":[{"line_number":6844,"context_line":"                requested_networks\u003dself.requested_networks,"},{"line_number":6845,"context_line":"                security_groups\u003dself.security_groups,"},{"line_number":6846,"context_line":"                block_device_mapping\u003dself.block_device_mapping,"},{"line_number":6847,"context_line":"                node\u003dself.node, limits\u003dself.limits, host_list\u003dfake_host_list,"},{"line_number":6848,"context_line":"                accel_uuids\u003dNone)"},{"line_number":6849,"context_line":""},{"line_number":6850,"context_line":"        self._assert_build_instance_hook_called(mock_hooks,"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_424ebc38","line":6847,"updated":"2020-03-19 13:41:01.000000000","message":"ditto","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[{"line_number":6844,"context_line":"                requested_networks\u003dself.requested_networks,"},{"line_number":6845,"context_line":"                security_groups\u003dself.security_groups,"},{"line_number":6846,"context_line":"                block_device_mapping\u003dself.block_device_mapping,"},{"line_number":6847,"context_line":"                node\u003dself.node, limits\u003dself.limits, host_list\u003dfake_host_list,"},{"line_number":6848,"context_line":"                accel_uuids\u003dNone)"},{"line_number":6849,"context_line":""},{"line_number":6850,"context_line":"        self._assert_build_instance_hook_called(mock_hooks,"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_cef649d8","line":6847,"in_reply_to":"1fa4df85_424ebc38","updated":"2020-03-22 01:29:07.000000000","message":"Done","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9943bdc478ef6c34fe673bc85e28ab38bb17fa80","unresolved":false,"context_lines":[{"line_number":7000,"context_line":"                          self.compute._build_and_run_instance,"},{"line_number":7001,"context_line":"                          self.context, self.instance, self.image,"},{"line_number":7002,"context_line":"                          self.injected_files, self.admin_pass,"},{"line_number":7003,"context_line":"                          self.requested_networks, self.security_groups,"},{"line_number":7004,"context_line":"                          self.block_device_mapping, self.node, self.limits,"},{"line_number":7005,"context_line":"                          self.filter_properties, self.accel_uuids)"},{"line_number":7006,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_026684c2","line":7003,"updated":"2020-03-19 13:41:01.000000000","message":"ditto","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[{"line_number":7000,"context_line":"                          self.compute._build_and_run_instance,"},{"line_number":7001,"context_line":"                          self.context, self.instance, self.image,"},{"line_number":7002,"context_line":"                          self.injected_files, self.admin_pass,"},{"line_number":7003,"context_line":"                          self.requested_networks, self.security_groups,"},{"line_number":7004,"context_line":"                          self.block_device_mapping, self.node, self.limits,"},{"line_number":7005,"context_line":"                          self.filter_properties, self.accel_uuids)"},{"line_number":7006,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_eeb22506","line":7003,"in_reply_to":"1fa4df85_026684c2","updated":"2020-03-22 01:29:07.000000000","message":"Done","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9943bdc478ef6c34fe673bc85e28ab38bb17fa80","unresolved":false,"context_lines":[{"line_number":7127,"context_line":"                    self.instance, self.image, self.injected_files,"},{"line_number":7128,"context_line":"                    self.admin_pass, self.requested_networks,"},{"line_number":7129,"context_line":"                    self.security_groups, self.block_device_mapping,"},{"line_number":7130,"context_line":"                    self.node, self.limits, self.filter_properties,"},{"line_number":7131,"context_line":"                    self.accel_uuids)"},{"line_number":7132,"context_line":""},{"line_number":7133,"context_line":"            _validate_instance_group_policy.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_a25690cd","line":7130,"updated":"2020-03-19 13:41:01.000000000","message":"ditto","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[{"line_number":7127,"context_line":"                    self.instance, self.image, self.injected_files,"},{"line_number":7128,"context_line":"                    self.admin_pass, self.requested_networks,"},{"line_number":7129,"context_line":"                    self.security_groups, self.block_device_mapping,"},{"line_number":7130,"context_line":"                    self.node, self.limits, self.filter_properties,"},{"line_number":7131,"context_line":"                    self.accel_uuids)"},{"line_number":7132,"context_line":""},{"line_number":7133,"context_line":"            _validate_instance_group_policy.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_0eb8e1e2","line":7130,"in_reply_to":"1fa4df85_a25690cd","updated":"2020-03-22 01:29:07.000000000","message":"Done","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9943bdc478ef6c34fe673bc85e28ab38bb17fa80","unresolved":false,"context_lines":[{"line_number":7409,"context_line":"            with self.compute._build_resources(self.context, self.instance,"},{"line_number":7410,"context_line":"                    self.requested_networks, self.security_groups, self.image,"},{"line_number":7411,"context_line":"                    self.block_device_mapping,"},{"line_number":7412,"context_line":"                    self.resource_provider_mapping, self.accel_uuids):"},{"line_number":7413,"context_line":"                pass"},{"line_number":7414,"context_line":"        except Exception as e:"},{"line_number":7415,"context_line":"            self.assertIsInstance(e, exception.BuildAbortException)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_a20bf0d2","line":7412,"range":{"start_line":7412,"start_character":20,"end_line":7412,"end_character":50},"updated":"2020-03-19 13:41:01.000000000","message":"ditto","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[{"line_number":7409,"context_line":"            with self.compute._build_resources(self.context, self.instance,"},{"line_number":7410,"context_line":"                    self.requested_networks, self.security_groups, self.image,"},{"line_number":7411,"context_line":"                    self.block_device_mapping,"},{"line_number":7412,"context_line":"                    self.resource_provider_mapping, self.accel_uuids):"},{"line_number":7413,"context_line":"                pass"},{"line_number":7414,"context_line":"        except Exception as e:"},{"line_number":7415,"context_line":"            self.assertIsInstance(e, exception.BuildAbortException)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_aed0ad20","line":7412,"range":{"start_line":7412,"start_character":20,"end_line":7412,"end_character":50},"in_reply_to":"1fa4df85_a20bf0d2","updated":"2020-03-22 01:29:07.000000000","message":"Done","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9943bdc478ef6c34fe673bc85e28ab38bb17fa80","unresolved":false,"context_lines":[{"line_number":7880,"context_line":"                    self.instance, self.image, self.injected_files,"},{"line_number":7881,"context_line":"                    self.admin_pass, self.requested_networks,"},{"line_number":7882,"context_line":"                    self.security_groups, self.block_device_mapping,"},{"line_number":7883,"context_line":"                    self.node, self.limits, self.filter_properties,"},{"line_number":7884,"context_line":"                    self.accel_uuids)"},{"line_number":7885,"context_line":"            expected_call \u003d mock.call(self.context, self.instance,"},{"line_number":7886,"context_line":"                    \u0027create.error\u0027, fault\u003dexc)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_82f6f4d6","line":7883,"updated":"2020-03-19 13:41:01.000000000","message":"dito","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[{"line_number":7880,"context_line":"                    self.instance, self.image, self.injected_files,"},{"line_number":7881,"context_line":"                    self.admin_pass, self.requested_networks,"},{"line_number":7882,"context_line":"                    self.security_groups, self.block_device_mapping,"},{"line_number":7883,"context_line":"                    self.node, self.limits, self.filter_properties,"},{"line_number":7884,"context_line":"                    self.accel_uuids)"},{"line_number":7885,"context_line":"            expected_call \u003d mock.call(self.context, self.instance,"},{"line_number":7886,"context_line":"                    \u0027create.error\u0027, fault\u003dexc)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_cecde985","line":7883,"in_reply_to":"1fa4df85_82f6f4d6","updated":"2020-03-22 01:29:07.000000000","message":"Done","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9943bdc478ef6c34fe673bc85e28ab38bb17fa80","unresolved":false,"context_lines":[{"line_number":7952,"context_line":"                self.instance, self.image, self.injected_files,"},{"line_number":7953,"context_line":"                self.admin_pass, self.requested_networks,"},{"line_number":7954,"context_line":"                self.security_groups, self.block_device_mapping,"},{"line_number":7955,"context_line":"                self.node, self.limits, self.filter_properties,"},{"line_number":7956,"context_line":"                request_spec, self.accel_uuids)"},{"line_number":7957,"context_line":""},{"line_number":7958,"context_line":"        mock_networks.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_42fc7cb4","line":7955,"updated":"2020-03-19 13:41:01.000000000","message":"ditto","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[{"line_number":7952,"context_line":"                self.instance, self.image, self.injected_files,"},{"line_number":7953,"context_line":"                self.admin_pass, self.requested_networks,"},{"line_number":7954,"context_line":"                self.security_groups, self.block_device_mapping,"},{"line_number":7955,"context_line":"                self.node, self.limits, self.filter_properties,"},{"line_number":7956,"context_line":"                request_spec, self.accel_uuids)"},{"line_number":7957,"context_line":""},{"line_number":7958,"context_line":"        mock_networks.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_8ec37157","line":7955,"in_reply_to":"1fa4df85_42fc7cb4","updated":"2020-03-22 01:29:07.000000000","message":"Done","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9943bdc478ef6c34fe673bc85e28ab38bb17fa80","unresolved":false,"context_lines":[{"line_number":7991,"context_line":"                self.instance, self.image, self.injected_files,"},{"line_number":7992,"context_line":"                self.admin_pass, self.requested_networks,"},{"line_number":7993,"context_line":"                self.security_groups, self.block_device_mapping,"},{"line_number":7994,"context_line":"                self.node, self.limits, self.filter_properties,"},{"line_number":7995,"context_line":"                request_spec, self.accel_uuids)"},{"line_number":7996,"context_line":""},{"line_number":7997,"context_line":"    def test_build_with_resource_request_sriov_rp_wrongly_formatted_name(self):"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_02344492","line":7994,"updated":"2020-03-19 13:41:01.000000000","message":"ditto","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[{"line_number":7991,"context_line":"                self.instance, self.image, self.injected_files,"},{"line_number":7992,"context_line":"                self.admin_pass, self.requested_networks,"},{"line_number":7993,"context_line":"                self.security_groups, self.block_device_mapping,"},{"line_number":7994,"context_line":"                self.node, self.limits, self.filter_properties,"},{"line_number":7995,"context_line":"                request_spec, self.accel_uuids)"},{"line_number":7996,"context_line":""},{"line_number":7997,"context_line":"    def test_build_with_resource_request_sriov_rp_wrongly_formatted_name(self):"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_2ea27daf","line":7994,"in_reply_to":"1fa4df85_02344492","updated":"2020-03-22 01:29:07.000000000","message":"Done","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9943bdc478ef6c34fe673bc85e28ab38bb17fa80","unresolved":false,"context_lines":[{"line_number":8016,"context_line":"                self.instance, self.image, self.injected_files,"},{"line_number":8017,"context_line":"                self.admin_pass, self.requested_networks,"},{"line_number":8018,"context_line":"                self.security_groups, self.block_device_mapping,"},{"line_number":8019,"context_line":"                self.node, self.limits, self.filter_properties,"},{"line_number":8020,"context_line":"                request_spec, self.accel_uuids)"},{"line_number":8021,"context_line":""},{"line_number":8022,"context_line":"    def test_build_with_resource_request_more_than_one_providers(self):"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_a2245061","line":8019,"updated":"2020-03-19 13:41:01.000000000","message":"ditto","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[{"line_number":8016,"context_line":"                self.instance, self.image, self.injected_files,"},{"line_number":8017,"context_line":"                self.admin_pass, self.requested_networks,"},{"line_number":8018,"context_line":"                self.security_groups, self.block_device_mapping,"},{"line_number":8019,"context_line":"                self.node, self.limits, self.filter_properties,"},{"line_number":8020,"context_line":"                request_spec, self.accel_uuids)"},{"line_number":8021,"context_line":""},{"line_number":8022,"context_line":"    def test_build_with_resource_request_more_than_one_providers(self):"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_4ea7b9be","line":8019,"in_reply_to":"1fa4df85_a2245061","updated":"2020-03-22 01:29:07.000000000","message":"Done","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9943bdc478ef6c34fe673bc85e28ab38bb17fa80","unresolved":false,"context_lines":[{"line_number":8036,"context_line":"            self.instance, self.image, self.injected_files,"},{"line_number":8037,"context_line":"            self.admin_pass, self.requested_networks,"},{"line_number":8038,"context_line":"            self.security_groups, self.block_device_mapping,"},{"line_number":8039,"context_line":"            self.node, self.limits, self.filter_properties,"},{"line_number":8040,"context_line":"            request_spec, self.accel_uuids)"},{"line_number":8041,"context_line":""},{"line_number":8042,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_c2294c37","line":8039,"updated":"2020-03-19 13:41:01.000000000","message":"ditto","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[{"line_number":8036,"context_line":"            self.instance, self.image, self.injected_files,"},{"line_number":8037,"context_line":"            self.admin_pass, self.requested_networks,"},{"line_number":8038,"context_line":"            self.security_groups, self.block_device_mapping,"},{"line_number":8039,"context_line":"            self.node, self.limits, self.filter_properties,"},{"line_number":8040,"context_line":"            request_spec, self.accel_uuids)"},{"line_number":8041,"context_line":""},{"line_number":8042,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_eea785bb","line":8039,"in_reply_to":"1fa4df85_c2294c37","updated":"2020-03-22 01:29:07.000000000","message":"Done","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6452e270753185945efb8e6dc27cb119f196e5a2","unresolved":false,"context_lines":[{"line_number":6507,"context_line":"                          self.requested_networks, self.security_groups,"},{"line_number":6508,"context_line":"                          self.block_device_mapping, self.node,"},{"line_number":6509,"context_line":"                          self.limits, self.filter_properties,"},{"line_number":6510,"context_line":"                          self.accel_uuids)"},{"line_number":6511,"context_line":"        mock_save.assert_has_calls(["},{"line_number":6512,"context_line":"            mock.call(),"},{"line_number":6513,"context_line":"            mock.call(),"}],"source_content_type":"text/x-python","patch_set":22,"id":"df33271e_a9120fb0","line":6510,"updated":"2020-03-23 12:18:38.000000000","message":"could be dropped too","commit_id":"858ed8f824574f433d8f4fc7a606ce6e9eac29f3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7672236b4f97eef2eead8e7ed8ff54563d3f013c","unresolved":false,"context_lines":[{"line_number":6507,"context_line":"                          self.requested_networks, self.security_groups,"},{"line_number":6508,"context_line":"                          self.block_device_mapping, self.node,"},{"line_number":6509,"context_line":"                          self.limits, self.filter_properties,"},{"line_number":6510,"context_line":"                          self.accel_uuids)"},{"line_number":6511,"context_line":"        mock_save.assert_has_calls(["},{"line_number":6512,"context_line":"            mock.call(),"},{"line_number":6513,"context_line":"            mock.call(),"}],"source_content_type":"text/x-python","patch_set":22,"id":"df33271e_4ca8ac1e","line":6510,"in_reply_to":"df33271e_a9120fb0","updated":"2020-03-23 17:03:02.000000000","message":"Could, but why? Except during an upgrade accel_uuids will be non-None right? So why wouldn\u0027t we want all of our tests to be running compute manager code close to how it will be in production?","commit_id":"858ed8f824574f433d8f4fc7a606ce6e9eac29f3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6452e270753185945efb8e6dc27cb119f196e5a2","unresolved":false,"context_lines":[{"line_number":6998,"context_line":"                          self.requested_networks, self.security_groups,"},{"line_number":6999,"context_line":"                          self.block_device_mapping, self.node,"},{"line_number":7000,"context_line":"                          self.limits, self.filter_properties,"},{"line_number":7001,"context_line":"                          self.accel_uuids)"},{"line_number":7002,"context_line":""},{"line_number":7003,"context_line":"        mock_save.assert_has_calls(["},{"line_number":7004,"context_line":"            mock.call(),"}],"source_content_type":"text/x-python","patch_set":22,"id":"df33271e_e9237704","line":7001,"updated":"2020-03-23 12:18:38.000000000","message":"can be dropped too","commit_id":"858ed8f824574f433d8f4fc7a606ce6e9eac29f3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6452e270753185945efb8e6dc27cb119f196e5a2","unresolved":false,"context_lines":[{"line_number":7123,"context_line":"                    self.instance, self.image, self.injected_files,"},{"line_number":7124,"context_line":"                    self.admin_pass, self.requested_networks,"},{"line_number":7125,"context_line":"                    self.security_groups, self.block_device_mapping, self.node,"},{"line_number":7126,"context_line":"                    self.limits, self.filter_properties, self.accel_uuids)"},{"line_number":7127,"context_line":""},{"line_number":7128,"context_line":"            _validate_instance_group_policy.assert_called_once_with("},{"line_number":7129,"context_line":"                    self.context, self.instance, {})"}],"source_content_type":"text/x-python","patch_set":22,"id":"df33271e_291effb9","line":7126,"updated":"2020-03-23 12:18:38.000000000","message":"ditto","commit_id":"858ed8f824574f433d8f4fc7a606ce6e9eac29f3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6452e270753185945efb8e6dc27cb119f196e5a2","unresolved":false,"context_lines":[{"line_number":7223,"context_line":"                          self.admin_pass, self.requested_networks,"},{"line_number":7224,"context_line":"                          self.security_groups, self.block_device_mapping,"},{"line_number":7225,"context_line":"                          self.node, self.limits, self.filter_properties,"},{"line_number":7226,"context_line":"                          self.accel_uuids)"},{"line_number":7227,"context_line":""},{"line_number":7228,"context_line":"        mock_save.assert_called_once_with()"},{"line_number":7229,"context_line":"        mock_notify.assert_has_calls(["}],"source_content_type":"text/x-python","patch_set":22,"id":"df33271e_8978ebf8","line":7226,"updated":"2020-03-23 12:18:38.000000000","message":"ditto","commit_id":"858ed8f824574f433d8f4fc7a606ce6e9eac29f3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6452e270753185945efb8e6dc27cb119f196e5a2","unresolved":false,"context_lines":[{"line_number":7803,"context_line":"                    self.image, self.injected_files, self.admin_pass,"},{"line_number":7804,"context_line":"                    self.requested_networks, self.security_groups,"},{"line_number":7805,"context_line":"                    self.block_device_mapping, self.node, self.limits,"},{"line_number":7806,"context_line":"                    self.filter_properties, self.accel_uuids)"},{"line_number":7807,"context_line":"            expected_call \u003d mock.call(self.context, self.instance,"},{"line_number":7808,"context_line":"                    \u0027create.end\u0027, extra_usage_info\u003d{\u0027message\u0027: u\u0027Success\u0027},"},{"line_number":7809,"context_line":"                    network_info\u003d[])"}],"source_content_type":"text/x-python","patch_set":22,"id":"df33271e_096cdb34","line":7806,"updated":"2020-03-23 12:18:38.000000000","message":"ditto","commit_id":"858ed8f824574f433d8f4fc7a606ce6e9eac29f3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6452e270753185945efb8e6dc27cb119f196e5a2","unresolved":false,"context_lines":[{"line_number":7835,"context_line":"                    self.image, self.injected_files, self.admin_pass,"},{"line_number":7836,"context_line":"                    self.requested_networks, self.security_groups,"},{"line_number":7837,"context_line":"                    self.block_device_mapping, self.node, self.limits,"},{"line_number":7838,"context_line":"                    self.filter_properties, self.accel_uuids)"},{"line_number":7839,"context_line":""},{"line_number":7840,"context_line":"            updates \u003d {\u0027vm_state\u0027: u\u0027active\u0027, \u0027access_ip_v6\u0027:"},{"line_number":7841,"context_line":"                    netaddr.IPAddress(\u00272001:db8:0:1:dcad:beff:feef:1\u0027),"}],"source_content_type":"text/x-python","patch_set":22,"id":"df33271e_e9689722","line":7838,"updated":"2020-03-23 12:18:38.000000000","message":"ditto","commit_id":"858ed8f824574f433d8f4fc7a606ce6e9eac29f3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6452e270753185945efb8e6dc27cb119f196e5a2","unresolved":false,"context_lines":[{"line_number":7875,"context_line":"                    self.instance, self.image, self.injected_files,"},{"line_number":7876,"context_line":"                    self.admin_pass, self.requested_networks,"},{"line_number":7877,"context_line":"                    self.security_groups, self.block_device_mapping, self.node,"},{"line_number":7878,"context_line":"                    self.limits, self.filter_properties, self.accel_uuids)"},{"line_number":7879,"context_line":"            expected_call \u003d mock.call(self.context, self.instance,"},{"line_number":7880,"context_line":"                    \u0027create.error\u0027, fault\u003dexc)"},{"line_number":7881,"context_line":"            create_error_call \u003d mock_notify.call_args_list["}],"source_content_type":"text/x-python","patch_set":22,"id":"df33271e_4976e308","line":7878,"updated":"2020-03-23 12:18:38.000000000","message":"ditto","commit_id":"858ed8f824574f433d8f4fc7a606ce6e9eac29f3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6452e270753185945efb8e6dc27cb119f196e5a2","unresolved":false,"context_lines":[{"line_number":7900,"context_line":"                self.admin_pass, self.requested_networks,"},{"line_number":7901,"context_line":"                self.security_groups, self.block_device_mapping, self.node,"},{"line_number":7902,"context_line":"                self.limits, self.filter_properties, request_spec,"},{"line_number":7903,"context_line":"                self.accel_uuids)"},{"line_number":7904,"context_line":""},{"line_number":7905,"context_line":"        mock_networks.assert_called_once_with("},{"line_number":7906,"context_line":"            self.context, self.instance, self.requested_networks,"}],"source_content_type":"text/x-python","patch_set":22,"id":"df33271e_29739f17","line":7903,"updated":"2020-03-23 12:18:38.000000000","message":"ditto","commit_id":"858ed8f824574f433d8f4fc7a606ce6e9eac29f3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6452e270753185945efb8e6dc27cb119f196e5a2","unresolved":false,"context_lines":[{"line_number":7947,"context_line":"                self.admin_pass, self.requested_networks,"},{"line_number":7948,"context_line":"                self.security_groups, self.block_device_mapping, self.node,"},{"line_number":7949,"context_line":"                self.limits, self.filter_properties, request_spec,"},{"line_number":7950,"context_line":"                self.accel_uuids)"},{"line_number":7951,"context_line":""},{"line_number":7952,"context_line":"        mock_networks.assert_called_once_with("},{"line_number":7953,"context_line":"            self.context, self.instance, self.requested_networks,"}],"source_content_type":"text/x-python","patch_set":22,"id":"df33271e_89610b3d","line":7950,"updated":"2020-03-23 12:18:38.000000000","message":"ditto","commit_id":"858ed8f824574f433d8f4fc7a606ce6e9eac29f3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6452e270753185945efb8e6dc27cb119f196e5a2","unresolved":false,"context_lines":[{"line_number":7986,"context_line":"                self.admin_pass, self.requested_networks,"},{"line_number":7987,"context_line":"                self.security_groups, self.block_device_mapping, self.node,"},{"line_number":7988,"context_line":"                self.limits, self.filter_properties, request_spec,"},{"line_number":7989,"context_line":"                self.accel_uuids)"},{"line_number":7990,"context_line":""},{"line_number":7991,"context_line":"    def test_build_with_resource_request_sriov_rp_wrongly_formatted_name(self):"},{"line_number":7992,"context_line":"        request_spec \u003d objects.RequestSpec("}],"source_content_type":"text/x-python","patch_set":22,"id":"df33271e_69664754","line":7989,"updated":"2020-03-23 12:18:38.000000000","message":"ditto","commit_id":"858ed8f824574f433d8f4fc7a606ce6e9eac29f3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6452e270753185945efb8e6dc27cb119f196e5a2","unresolved":false,"context_lines":[{"line_number":8011,"context_line":"                self.admin_pass, self.requested_networks,"},{"line_number":8012,"context_line":"                self.security_groups, self.block_device_mapping, self.node,"},{"line_number":8013,"context_line":"                self.limits, self.filter_properties, request_spec,"},{"line_number":8014,"context_line":"                self.accel_uuids)"},{"line_number":8015,"context_line":""},{"line_number":8016,"context_line":"    def test_build_with_resource_request_more_than_one_providers(self):"},{"line_number":8017,"context_line":"        request_spec \u003d objects.RequestSpec("}],"source_content_type":"text/x-python","patch_set":22,"id":"df33271e_c95b1385","line":8014,"updated":"2020-03-23 12:18:38.000000000","message":"ditto","commit_id":"858ed8f824574f433d8f4fc7a606ce6e9eac29f3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6452e270753185945efb8e6dc27cb119f196e5a2","unresolved":false,"context_lines":[{"line_number":8031,"context_line":"            self.admin_pass, self.requested_networks,"},{"line_number":8032,"context_line":"            self.security_groups, self.block_device_mapping, self.node,"},{"line_number":8033,"context_line":"            self.limits, self.filter_properties, request_spec,"},{"line_number":8034,"context_line":"            self.accel_uuids)"},{"line_number":8035,"context_line":""},{"line_number":8036,"context_line":""},{"line_number":8037,"context_line":"class ComputeManagerErrorsOutMigrationTestCase(test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":22,"id":"df33271e_0955fb50","line":8034,"updated":"2020-03-23 12:18:38.000000000","message":"ditto","commit_id":"858ed8f824574f433d8f4fc7a606ce6e9eac29f3"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"4cc8865436daf6be935e5f2bd375932810c2cbb7","unresolved":false,"context_lines":[{"line_number":5958,"context_line":"        self.requested_networks \u003d []"},{"line_number":5959,"context_line":"        self.security_groups \u003d []"},{"line_number":5960,"context_line":"        self.block_device_mapping \u003d []"},{"line_number":5961,"context_line":"        self.accel_uuids \u003d None"},{"line_number":5962,"context_line":"        self.filter_properties \u003d {\u0027retry\u0027: {\u0027num_attempts\u0027: 1,"},{"line_number":5963,"context_line":"                                            \u0027hosts\u0027: [[self.compute.host,"},{"line_number":5964,"context_line":"                                                       \u0027fake-node\u0027]]}}"}],"source_content_type":"text/x-python","patch_set":23,"id":"df33271e_073acd32","line":5961,"range":{"start_line":5961,"start_character":8,"end_line":5961,"end_character":31},"updated":"2020-03-26 00:55:35.000000000","message":"nit: we init accell_uuids \u003d [] in \nhttps://review.opendev.org/#/c/704227/23/nova/conductor/manager.py@1622, maybe we also need to init it to [].\n\nlater: in build_and_run_instance() as a parameter default value is None https://review.opendev.org/#/c/704227/23/nova/compute/manager.py@2078, it\u0027s ok.","commit_id":"6de4a5b6c144d7c0bfcf933c63a7c9a8c73d3677"}],"nova/tests/unit/compute/test_rpcapi.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ae3cf234e921eefa113a6b4f69febefa420d872d","unresolved":false,"context_lines":[{"line_number":939,"context_line":"                admin_password\u003d\u0027passwd\u0027, injected_files\u003dNone,"},{"line_number":940,"context_line":"                requested_networks\u003d[\u0027network1\u0027], security_groups\u003dNone,"},{"line_number":941,"context_line":"                block_device_mapping\u003dNone, node\u003d\u0027node\u0027, limits\u003d[],"},{"line_number":942,"context_line":"                host_list\u003dNone, version\u003d\u00275.0\u0027)"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"    def test_quiesce_instance(self):"},{"line_number":945,"context_line":"        self._test_compute_api(\u0027quiesce_instance\u0027, \u0027call\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_c523f111","side":"PARENT","line":942,"range":{"start_line":942,"start_character":32,"end_line":942,"end_character":44},"updated":"2020-02-03 06:04:15.000000000","message":"keep 5.0 rpc version is run.","commit_id":"71a5d23d7c068240c7c20a2cb0f6132cc7f693ea"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"122a87a0f2af2e5c6ca6bb55ebba7e91c704ef1a","unresolved":false,"context_lines":[{"line_number":939,"context_line":"                admin_password\u003d\u0027passwd\u0027, injected_files\u003dNone,"},{"line_number":940,"context_line":"                requested_networks\u003d[\u0027network1\u0027], security_groups\u003dNone,"},{"line_number":941,"context_line":"                block_device_mapping\u003dNone, node\u003d\u0027node\u0027, limits\u003d[],"},{"line_number":942,"context_line":"                host_list\u003dNone, version\u003d\u00275.0\u0027)"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"    def test_quiesce_instance(self):"},{"line_number":945,"context_line":"        self._test_compute_api(\u0027quiesce_instance\u0027, \u0027call\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_c8e1c833","side":"PARENT","line":942,"range":{"start_line":942,"start_character":32,"end_line":942,"end_character":44},"in_reply_to":"3fa7e38b_c523f111","updated":"2020-02-03 08:19:55.000000000","message":"Sorry, this should be changed to 5.11, and you can combine test_build_and_run_instance_with_accel_uuids() in test_build_and_run_instance(), if you want to clear in 5.11 that it supports build and run instance with accel_uuids, you can write some comments in this test case.","commit_id":"71a5d23d7c068240c7c20a2cb0f6132cc7f693ea"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"99664506e1900cf7262785303f1026649bf22ca2","unresolved":false,"context_lines":[{"line_number":939,"context_line":"                admin_password\u003d\u0027passwd\u0027, injected_files\u003dNone,"},{"line_number":940,"context_line":"                requested_networks\u003d[\u0027network1\u0027], security_groups\u003dNone,"},{"line_number":941,"context_line":"                block_device_mapping\u003dNone, node\u003d\u0027node\u0027, limits\u003d[],"},{"line_number":942,"context_line":"                host_list\u003dNone, version\u003d\u00275.0\u0027)"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"    def test_quiesce_instance(self):"},{"line_number":945,"context_line":"        self._test_compute_api(\u0027quiesce_instance\u0027, \u0027call\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_e32f0555","side":"PARENT","line":942,"range":{"start_line":942,"start_character":32,"end_line":942,"end_character":44},"in_reply_to":"3fa7e38b_c8e1c833","updated":"2020-02-03 09:44:35.000000000","message":"Done","commit_id":"71a5d23d7c068240c7c20a2cb0f6132cc7f693ea"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2a6c5889285b409a5bee0939d66e19e2d12fd7cd","unresolved":false,"context_lines":[{"line_number":941,"context_line":"                admin_password\u003d\u0027passwd\u0027, injected_files\u003dNone,"},{"line_number":942,"context_line":"                requested_networks\u003d[\u0027network1\u0027], security_groups\u003dNone,"},{"line_number":943,"context_line":"                block_device_mapping\u003dNone, accel_uuids\u003dNone,"},{"line_number":944,"context_line":"                node\u003d\u0027node\u0027, limits\u003d[], host_list\u003dNone, version\u003d\u00275.11\u0027)"},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"    def test_quiesce_instance(self):"},{"line_number":947,"context_line":"        self._test_compute_api(\u0027quiesce_instance\u0027, \u0027call\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_c08d1837","line":944,"updated":"2020-02-03 15:24:35.000000000","message":"You need to add a test for the case where version is clamped to something below 5.11 and accel_uuids is passed to the client side.","commit_id":"34003bf5c8e61abada4ec2a01ee700a842c4f6ed"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"38e0ae4df5324ad58d2f0549a3c9bacc36b888a8","unresolved":false,"context_lines":[{"line_number":941,"context_line":"                admin_password\u003d\u0027passwd\u0027, injected_files\u003dNone,"},{"line_number":942,"context_line":"                requested_networks\u003d[\u0027network1\u0027], security_groups\u003dNone,"},{"line_number":943,"context_line":"                block_device_mapping\u003dNone, accel_uuids\u003dNone,"},{"line_number":944,"context_line":"                node\u003d\u0027node\u0027, limits\u003d[], host_list\u003dNone, version\u003d\u00275.11\u0027)"},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"    def test_quiesce_instance(self):"},{"line_number":947,"context_line":"        self._test_compute_api(\u0027quiesce_instance\u0027, \u0027call\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_f7da5148","line":944,"in_reply_to":"3fa7e38b_c08d1837","updated":"2020-02-04 06:22:04.000000000","message":"Done","commit_id":"34003bf5c8e61abada4ec2a01ee700a842c4f6ed"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"81f7f9b2ca6859d57277861f00bf0bc29f2d24a0","unresolved":false,"context_lines":[{"line_number":940,"context_line":"                request_spec\u003d{\u0027request\u0027: \u0027spec\u0027}, filter_properties\u003d[],"},{"line_number":941,"context_line":"                admin_password\u003d\u0027passwd\u0027, injected_files\u003dNone,"},{"line_number":942,"context_line":"                requested_networks\u003d[\u0027network1\u0027], security_groups\u003dNone,"},{"line_number":943,"context_line":"                block_device_mapping\u003dNone, accel_uuids\u003dNone,"},{"line_number":944,"context_line":"                node\u003d\u0027node\u0027, limits\u003d[], host_list\u003dNone, version\u003d\u00275.11\u0027)"},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"    def test_build_and_run_instance_old_rpcapi(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_c6751e01","line":943,"range":{"start_line":943,"start_character":43,"end_line":943,"end_character":59},"updated":"2020-02-04 15:57:48.000000000","message":"You\u0027re still missing the other half of my comment from before, where you provide an actual accel_uuids value and assert that it\u0027s passed to the other side.","commit_id":"c3d438dee25526b03158dbea7729648e127e9441"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"3cef1e6eb692025b6ec7d3eab57739e2140f19bb","unresolved":false,"context_lines":[{"line_number":940,"context_line":"                request_spec\u003d{\u0027request\u0027: \u0027spec\u0027}, filter_properties\u003d[],"},{"line_number":941,"context_line":"                admin_password\u003d\u0027passwd\u0027, injected_files\u003dNone,"},{"line_number":942,"context_line":"                requested_networks\u003d[\u0027network1\u0027], security_groups\u003dNone,"},{"line_number":943,"context_line":"                block_device_mapping\u003dNone, accel_uuids\u003dNone,"},{"line_number":944,"context_line":"                node\u003d\u0027node\u0027, limits\u003d[], host_list\u003dNone, version\u003d\u00275.11\u0027)"},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"    def test_build_and_run_instance_old_rpcapi(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_a7d9f955","line":943,"range":{"start_line":943,"start_character":43,"end_line":943,"end_character":59},"in_reply_to":"3fa7e38b_c6751e01","updated":"2020-02-04 21:06:37.000000000","message":"I see. Your comment sounded like there needs to be another test case with rpcapi \u003c 5.11 that passes the accel_uuids (and checks they don\u0027t get passed). Anyways, no issues, I can address this.","commit_id":"c3d438dee25526b03158dbea7729648e127e9441"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"81f7f9b2ca6859d57277861f00bf0bc29f2d24a0","unresolved":false,"context_lines":[{"line_number":959,"context_line":"                host\u003d\u0027host\u0027, image\u003d\u0027image\u0027,"},{"line_number":960,"context_line":"                request_spec\u003dself.fake_request_spec_obj,"},{"line_number":961,"context_line":"                filter_properties\u003d{},"},{"line_number":962,"context_line":"                accel_uuids\u003d\u0027938af7f9-f136-4e5a-bdbe-3b6feab54311\u0027)"},{"line_number":963,"context_line":""},{"line_number":964,"context_line":"        mock_client.can_send_version.assert_called_once_with(\u00275.11\u0027)"},{"line_number":965,"context_line":"        mock_client.prepare.assert_called_with("}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_262192fe","line":962,"range":{"start_line":962,"start_character":28,"end_line":962,"end_character":66},"updated":"2020-02-04 15:57:48.000000000","message":"This should be a list, no? I know it doesn\u0027t matter because it\u0027s just dropped in this case, but...","commit_id":"c3d438dee25526b03158dbea7729648e127e9441"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"3cef1e6eb692025b6ec7d3eab57739e2140f19bb","unresolved":false,"context_lines":[{"line_number":959,"context_line":"                host\u003d\u0027host\u0027, image\u003d\u0027image\u0027,"},{"line_number":960,"context_line":"                request_spec\u003dself.fake_request_spec_obj,"},{"line_number":961,"context_line":"                filter_properties\u003d{},"},{"line_number":962,"context_line":"                accel_uuids\u003d\u0027938af7f9-f136-4e5a-bdbe-3b6feab54311\u0027)"},{"line_number":963,"context_line":""},{"line_number":964,"context_line":"        mock_client.can_send_version.assert_called_once_with(\u00275.11\u0027)"},{"line_number":965,"context_line":"        mock_client.prepare.assert_called_with("}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_47e045fa","line":962,"range":{"start_line":962,"start_character":28,"end_line":962,"end_character":66},"in_reply_to":"3fa7e38b_262192fe","updated":"2020-02-04 21:06:37.000000000","message":"Done","commit_id":"c3d438dee25526b03158dbea7729648e127e9441"}],"nova/tests/unit/conductor/test_conductor.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9943bdc478ef6c34fe673bc85e28ab38bb17fa80","unresolved":false,"context_lines":[{"line_number":487,"context_line":"        self.useFixture(cast_as_call.CastAsCall(self))"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"        mock_getaz.return_value \u003d \u0027myaz\u0027"},{"line_number":490,"context_line":"        mock_create_bind_arqs.return_value \u003d []"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        self.conductor.build_instances(self.context,"},{"line_number":493,"context_line":"                instances\u003dinstances,"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_02c2045a","line":490,"range":{"start_line":490,"start_character":45,"end_line":490,"end_character":47},"updated":"2020-03-19 13:41:01.000000000","message":"nit: I would use mock.sentinel here to be able to assert that what was really passed in is coming out","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"e9ed0d3584d3f70168a597867b2208195be668e0","unresolved":false,"context_lines":[{"line_number":487,"context_line":"        self.useFixture(cast_as_call.CastAsCall(self))"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"        mock_getaz.return_value \u003d \u0027myaz\u0027"},{"line_number":490,"context_line":"        mock_create_bind_arqs.return_value \u003d []"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        self.conductor.build_instances(self.context,"},{"line_number":493,"context_line":"                instances\u003dinstances,"}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_4ea1f9f7","line":490,"range":{"start_line":490,"start_character":45,"end_line":490,"end_character":47},"in_reply_to":"1fa4df85_02c2045a","updated":"2020-03-22 01:29:07.000000000","message":"Done","commit_id":"35fa68814479f963b867cbe141f1e41259489a5c"}]}