)]}'
{"nova/tests/virt/vmwareapi/test_driver_api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e7470d52a0bc5ef1644a3a6ab6145031f03718e5","unresolved":false,"context_lines":[{"line_number":769,"context_line":""},{"line_number":770,"context_line":"    def test_spawn_with_download_flat_image(self):"},{"line_number":771,"context_line":"        uuid \u003d \"fake-tmp-uuid\""},{"line_number":772,"context_line":"        with mock.patch.object(uuidutils, \u0027generate_uuid\u0027,"},{"line_number":773,"context_line":"                               return_value\u003duuid):"},{"line_number":774,"context_line":"            with mock.patch.object(image_transfer, \u0027download_flat_image\u0027) as m:"},{"line_number":775,"context_line":"                self._create_vm()"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F0ZA%3D","line":772,"updated":"2014-03-13 16:03:29.000000000","message":"you could use this as a decorator for the function","commit_id":"024b9f5cb2ff143b07ace771ebc702aeff203f66"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e7470d52a0bc5ef1644a3a6ab6145031f03718e5","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"                           fake_create_config_drive)"},{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":"        self._create_vm()"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"        info \u003d self.conn.get_info({\u0027name\u0027: 1, \u0027uuid\u0027: self.uuid,"},{"line_number":1136,"context_line":"                                   \u0027node\u0027: self.instance_node})"},{"line_number":1137,"context_line":"        self.stubs.Set(self.conn._volumeops, \"attach_disk_to_vm\","}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F0Y0%3D","line":1134,"updated":"2014-03-13 16:03:29.000000000","message":"do we need this new line","commit_id":"024b9f5cb2ff143b07ace771ebc702aeff203f66"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e48ae008a8dc4eb8703abe6f387ac596f5343d3b","unresolved":false,"context_lines":[{"line_number":779,"context_line":""},{"line_number":780,"context_line":"    def test_spawn_with_download_flat_image(self):"},{"line_number":781,"context_line":"        uuid \u003d \"fake-tmp-uuid\""},{"line_number":782,"context_line":"        with mock.patch.object(uuidutils, \u0027generate_uuid\u0027,"},{"line_number":783,"context_line":"                               return_value\u003duuid):"},{"line_number":784,"context_line":"            with mock.patch.object(image_transfer, \u0027download_flat_image\u0027) as m:"},{"line_number":785,"context_line":"                self._create_vm()"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2ByQY%3D","line":782,"updated":"2014-03-24 11:35:32.000000000","message":"you could do this as a decorator to the method","commit_id":"a0b256432f78e31b9da084f32935cd8a93fc44e8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e48ae008a8dc4eb8703abe6f387ac596f5343d3b","unresolved":false,"context_lines":[{"line_number":781,"context_line":"        uuid \u003d \"fake-tmp-uuid\""},{"line_number":782,"context_line":"        with mock.patch.object(uuidutils, \u0027generate_uuid\u0027,"},{"line_number":783,"context_line":"                               return_value\u003duuid):"},{"line_number":784,"context_line":"            with mock.patch.object(image_transfer, \u0027download_flat_image\u0027) as m:"},{"line_number":785,"context_line":"                self._create_vm()"},{"line_number":786,"context_line":"                file_path \u003d \"%s/%s/%s/%s-flat.vmdk\" % ("},{"line_number":787,"context_line":"                    \"vmware_temp\", uuid, \"fake_image_uuid\", \"fake_image_uuid\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2ByQQ%3D","line":784,"updated":"2014-03-24 11:35:32.000000000","message":"ditto","commit_id":"a0b256432f78e31b9da084f32935cd8a93fc44e8"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e7470d52a0bc5ef1644a3a6ab6145031f03718e5","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            image_size_kb, datastore_name, datacenter_name, upload_location):"},{"line_number":193,"context_line":"        \"\"\"Fetch image from Glance to ESX datastore.\"\"\""},{"line_number":194,"context_line":"        LOG.debug(_(\"Downloading image file data %(image_ref)s to the ESX \""},{"line_number":195,"context_line":"                    \"data store %(datastore_name)s\") %"},{"line_number":196,"context_line":"                    {\u0027image_ref\u0027: instance[\u0027image_ref\u0027],"},{"line_number":197,"context_line":"                     \u0027datastore_name\u0027: datastore_name},"},{"line_number":198,"context_line":"                  instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F0Yk%3D","line":195,"updated":"2014-03-13 16:03:29.000000000","message":"please use a , instead of the %","commit_id":"024b9f5cb2ff143b07ace771ebc702aeff203f66"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e7470d52a0bc5ef1644a3a6ab6145031f03718e5","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            file_path\u003dupload_location)"},{"line_number":218,"context_line":"        LOG.debug(_(\"Downloaded image file data %(image_ref)s to \""},{"line_number":219,"context_line":"                    \"%(upload_location)s on the ESX data store \""},{"line_number":220,"context_line":"                    \"%(datastore_name)s\") %"},{"line_number":221,"context_line":"                    {\u0027image_ref\u0027: instance[\u0027image_ref\u0027],"},{"line_number":222,"context_line":"                     \u0027upload_location\u0027: upload_location,"},{"line_number":223,"context_line":"                     \u0027datastore_name\u0027: datastore_name},"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F0Ys%3D","line":220,"updated":"2014-03-13 16:03:29.000000000","message":"please use a , instead of the %","commit_id":"024b9f5cb2ff143b07ace771ebc702aeff203f66"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e48ae008a8dc4eb8703abe6f387ac596f5343d3b","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            image_size_kb, datastore_name, datacenter_name, upload_location):"},{"line_number":199,"context_line":"        \"\"\"Fetch image from Glance to ESX datastore.\"\"\""},{"line_number":200,"context_line":"        LOG.debug(_(\"Downloading image file data %(image_ref)s to the ESX \""},{"line_number":201,"context_line":"                    \"data store %(datastore_name)s\") %"},{"line_number":202,"context_line":"                    {\u0027image_ref\u0027: instance[\u0027image_ref\u0027],"},{"line_number":203,"context_line":"                     \u0027datastore_name\u0027: datastore_name},"},{"line_number":204,"context_line":"                  instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2ByQI%3D","line":201,"updated":"2014-03-24 11:35:32.000000000","message":"please use , instead of %","commit_id":"a0b256432f78e31b9da084f32935cd8a93fc44e8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e48ae008a8dc4eb8703abe6f387ac596f5343d3b","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            file_path\u003dupload_location)"},{"line_number":224,"context_line":"        LOG.debug(_(\"Downloaded image file data %(image_ref)s to \""},{"line_number":225,"context_line":"                    \"%(upload_location)s on the ESX data store \""},{"line_number":226,"context_line":"                    \"%(datastore_name)s\") %"},{"line_number":227,"context_line":"                    {\u0027image_ref\u0027: instance[\u0027image_ref\u0027],"},{"line_number":228,"context_line":"                     \u0027upload_location\u0027: upload_location,"},{"line_number":229,"context_line":"                     \u0027datastore_name\u0027: datastore_name},"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2ByQE%3D","line":226,"updated":"2014-03-24 11:35:32.000000000","message":"ditto","commit_id":"a0b256432f78e31b9da084f32935cd8a93fc44e8"}],"nova/virt/vmwareapi/vmware_images.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"4aa9a87eec012973e8d69ed862f08919e2298848","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    # image service # wrapper object, which we obtained with the private"},{"line_number":242,"context_line":"    # image.api method."},{"line_number":243,"context_line":"    (image_service, image_id) \u003d IMAGE_API._get_session_and_image_id("},{"line_number":244,"context_line":"            context, instance[\u0027image_ref\u0027])"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    metadata \u003d IMAGE_API.get(context, instance[\u0027image_ref\u0027])"},{"line_number":247,"context_line":"    image_size \u003d int(metadata[\u0027size\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aa7fdbe_11075a1a","line":244,"updated":"2014-10-23 16:58:32.000000000","message":"No. Under no circumstances should the olso.vmware.image_transfer.download() method take an internal nova.image.glance.GlanceImageService object as a parameter. You should not need to call any internal method like IMAGE_API._get_session_and_image_id().","commit_id":"6ccdcdd6fde8fbf1e0e83a49492f6b736a99824f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"4aa9a87eec012973e8d69ed862f08919e2298848","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    image_transfer.download_flat_image("},{"line_number":250,"context_line":"        context,"},{"line_number":251,"context_line":"        CONF.vmware.image_transfer_timeout_secs,"},{"line_number":252,"context_line":"        image_service,"},{"line_number":253,"context_line":"        image_id,"},{"line_number":254,"context_line":"        host\u003dhost,"},{"line_number":255,"context_line":"        port\u003dport,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aa7fdbe_3108de27","line":252,"updated":"2014-10-23 16:58:32.000000000","message":"Whatever image_transfer.download_flat_image() is using the image_service object for, it needs to be refactored. You should be simply supplying read-only information to download_flat_image(), not a pointer to an internal manager object (that\u0027s what GlanceImageService is...)","commit_id":"6ccdcdd6fde8fbf1e0e83a49492f6b736a99824f"}]}