)]}'
{"nova/api/openstack/common.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"19204f70549467a4b735307e50d620531720e5be","unresolved":false,"context_lines":[{"line_number":572,"context_line":"        port resource request move support, False otherwise."},{"line_number":573,"context_line":"    \"\"\""},{"line_number":574,"context_line":"    return False"},{"line_number":575,"context_line":""},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"def instance_has_port_with_resource_request(instance_uuid, network_api):"},{"line_number":578,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_fa44e875","side":"PARENT","line":575,"updated":"2020-03-06 17:04:57.000000000","message":"I\u0027m confused about this. We can\u0027t just say that because the plumbing is there now, that we can enable this right?\n\nIf I upgrade my control plane before my computes, then the control plane will start letting me unshelve instances with qos ports, but my computes are unable to obey the request.\n\nDon\u0027t we need to replace with with either a selective or global service version check and only start allowing this action when we know the computes have been upgraded to be able to handle it?","commit_id":"3db615fd7567a823cae2f2b4ee7abbdd7054df38"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"33e7bfcea82d034e9d44348117415886c59d8d06","unresolved":false,"context_lines":[{"line_number":572,"context_line":"        port resource request move support, False otherwise."},{"line_number":573,"context_line":"    \"\"\""},{"line_number":574,"context_line":"    return False"},{"line_number":575,"context_line":""},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"def instance_has_port_with_resource_request(instance_uuid, network_api):"},{"line_number":578,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_04d2265d","side":"PARENT","line":575,"in_reply_to":"1fa4df85_bd80aaf6","updated":"2020-03-18 14:39:58.000000000","message":"Done","commit_id":"3db615fd7567a823cae2f2b4ee7abbdd7054df38"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"99e64164b697f83625c5304f4be4f6ecd59e862a","unresolved":false,"context_lines":[{"line_number":572,"context_line":"        port resource request move support, False otherwise."},{"line_number":573,"context_line":"    \"\"\""},{"line_number":574,"context_line":"    return False"},{"line_number":575,"context_line":""},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"def instance_has_port_with_resource_request(instance_uuid, network_api):"},{"line_number":578,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_bd80aaf6","side":"PARENT","line":575,"in_reply_to":"1fa4df85_fa44e875","updated":"2020-03-06 17:28:29.000000000","message":"I will add a global service version check. And retrofit the rest of the move API calls to call this check.","commit_id":"3db615fd7567a823cae2f2b4ee7abbdd7054df38"}],"nova/api/openstack/compute/shelve.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b05ddafd1549ba90059a5b08835c6b9e7908de97","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                    req)):"},{"line_number":103,"context_line":"            msg \u003d _(\"The unshelve action on a server with ports having \""},{"line_number":104,"context_line":"                    \"resource requests, like a port with a QoS minimum \""},{"line_number":105,"context_line":"                    \"bandwidth policy, is not supported with this \""},{"line_number":106,"context_line":"                    \"microversion\")"},{"line_number":107,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_daafac27","side":"PARENT","line":106,"range":{"start_line":105,"start_character":39,"end_line":106,"end_character":33},"updated":"2020-03-06 17:02:17.000000000","message":"We were exposing this to the user, which means (to me) that we were telling them that a microversion bump will be their signal that this works at some point. It seems weird to now be deciding against a microversion signal for this...","commit_id":"3db615fd7567a823cae2f2b4ee7abbdd7054df38"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"99e64164b697f83625c5304f4be4f6ecd59e862a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                    req)):"},{"line_number":103,"context_line":"            msg \u003d _(\"The unshelve action on a server with ports having \""},{"line_number":104,"context_line":"                    \"resource requests, like a port with a QoS minimum \""},{"line_number":105,"context_line":"                    \"bandwidth policy, is not supported with this \""},{"line_number":106,"context_line":"                    \"microversion\")"},{"line_number":107,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_bd418aab","side":"PARENT","line":106,"range":{"start_line":105,"start_character":39,"end_line":106,"end_character":33},"in_reply_to":"1fa4df85_daafac27","updated":"2020-03-06 17:28:29.000000000","message":"I think this check predated the decision not to bump the microversion for the move support. And then I forgot to go back and update the error message not to forecast such bump. I guess we have to leave with this situation","commit_id":"3db615fd7567a823cae2f2b4ee7abbdd7054df38"}],"releasenotes/notes/support-unshelving-servers-with-neutron-ports-with-resource-request-d91a282fe56c7489.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"074fab4e953c0688cc9da5f48e8a480c207b2b09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3fa7e38b_778cda38","updated":"2020-02-07 14:48:20.000000000","message":"Could have appended this to the existing reno too, though maybe the filenames of those are quite specific also?","commit_id":"14b807ba8be1bf717ae31bc1ffe17bae94d0789c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f26943314b018db53bf1cd59d3b41b26621361c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3fa7e38b_754da091","in_reply_to":"3fa7e38b_778cda38","updated":"2020-02-10 09:36:11.000000000","message":"yeah I was too specific when I created the first reno for these patches. So I kept creating new renos each step. I can add a patch top of this that merges the 3 renos for ussuri into one.\n\nDone in https://review.opendev.org/706766","commit_id":"14b807ba8be1bf717ae31bc1ffe17bae94d0789c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"074fab4e953c0688cc9da5f48e8a480c207b2b09","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The server ``unshelve`` action API now supports servers with neutron"},{"line_number":5,"context_line":"    ports having resource requests, e.g. ports that have QoS minimum bandwidth"},{"line_number":6,"context_line":"    rules attached."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_f7a0caa6","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":0},"updated":"2020-02-07 14:48:20.000000000","message":"nit: extra newlines","commit_id":"14b807ba8be1bf717ae31bc1ffe17bae94d0789c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f26943314b018db53bf1cd59d3b41b26621361c7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The server ``unshelve`` action API now supports servers with neutron"},{"line_number":5,"context_line":"    ports having resource requests, e.g. ports that have QoS minimum bandwidth"},{"line_number":6,"context_line":"    rules attached."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_552504bf","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":0},"in_reply_to":"3fa7e38b_f7a0caa6","updated":"2020-02-10 09:36:11.000000000","message":"We need a lint for renos :D\nDone.","commit_id":"14b807ba8be1bf717ae31bc1ffe17bae94d0789c"}]}