)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f2abfc1166364647a27a26a4b552ff033f9c0461","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This includes a couple of fixes and removes the need for custom"},{"line_number":10,"context_line":"workarounds, like the removal of the \u0027address_string\u0027 helper at [1]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://github.com/novnc/websockify/commit/be9823bf"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9b1d57fd513386e552afbbc8a59cf3a4c54b6908"},{"line_number":15,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_540bffd2","line":12,"updated":"2020-02-05 17:37:37.000000000","message":"Note for posterity: the original commit that added the \u0027address_string\u0027 helper did so because reverse dns lookup was happening as a result of logging a message:\n\nhttps://github.com/openstack/nova/commit/c0f773a616fb48bf699539c5ac18bd9c55a540c9","commit_id":"ebef2b5bfdb213e04ba9787ee2a14739ce953d4b"}],"nova/console/websocketproxy.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"20059d0af0aa476250c3560add164e287c649af1","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # NOTE(rpodolyaka): override the superclass implementation here and"},{"line_number":99,"context_line":"        # explicitly disable the reverse DNS lookup, which might fail on some"},{"line_number":100,"context_line":"        # deployments due to DNS configuration and break VNC access completely"},{"line_number":101,"context_line":"        return str(self.client_address[0])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def verify_origin_proto(self, connect_info, origin_proto):"},{"line_number":104,"context_line":"        if \u0027access_url_base\u0027 not in connect_info:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_9e5c38f0","side":"PARENT","line":101,"updated":"2020-02-05 16:20:06.000000000","message":"Sorry, I don\u0027t understand how the linked commit:\n\nhttps://github.com/novnc/websockify/commit/be9823bf\n\nis related to the helper removal here. The commit is making an update to a log_message method which is just changing what is logged. Whereas this helper is explicitly using the client_address property in place of address_string for not only logging but everything.\n\nAFAICT, we would still need this helper unless there is some other commit in websockify that is handling this desired disabling of reverse DNS lookup, that you could reference in the commit message.","commit_id":"94861a00491fb9541a21b467002d9d7f2996b920"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f2abfc1166364647a27a26a4b552ff033f9c0461","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # NOTE(rpodolyaka): override the superclass implementation here and"},{"line_number":99,"context_line":"        # explicitly disable the reverse DNS lookup, which might fail on some"},{"line_number":100,"context_line":"        # deployments due to DNS configuration and break VNC access completely"},{"line_number":101,"context_line":"        return str(self.client_address[0])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def verify_origin_proto(self, connect_info, origin_proto):"},{"line_number":104,"context_line":"        if \u0027access_url_base\u0027 not in connect_info:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b44d933d","side":"PARENT","line":101,"in_reply_to":"3fa7e38b_79887619","updated":"2020-02-05 17:37:37.000000000","message":"I just looked this up, apparently the original commit you referenced _would_ fix the issue because the reverse dns lookup was happening as a result of simply logging a message (I did not expect this):\n\nhttps://github.com/openstack/nova/commit/c0f773a616fb48bf699539c5ac18bd9c55a540c9","commit_id":"94861a00491fb9541a21b467002d9d7f2996b920"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e013fc9f1fe4d6618d565a87ec50df57916972f7","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # NOTE(rpodolyaka): override the superclass implementation here and"},{"line_number":99,"context_line":"        # explicitly disable the reverse DNS lookup, which might fail on some"},{"line_number":100,"context_line":"        # deployments due to DNS configuration and break VNC access completely"},{"line_number":101,"context_line":"        return str(self.client_address[0])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def verify_origin_proto(self, connect_info, origin_proto):"},{"line_number":104,"context_line":"        if \u0027access_url_base\u0027 not in connect_info:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_79887619","side":"PARENT","line":101,"in_reply_to":"3fa7e38b_9e5c38f0","updated":"2020-02-05 17:10:25.000000000","message":"My point was that 0.9.0 removes the last user of this helper function:\n\n  $ ag address_string\n  $ git log -S address_string --oneline  | head -1\n  be9823b Use client IP in logs, not host\n\nHowever, now that I\u0027m looking at it again, there were only ever references to this function, never an actual definition itself. I wonder what\u0027s defining that? Let me go root that out...\n\nLater: whadyaknow, this is actually from core Python. Looks like this correct but for completely different reasons - behavior is the default in Python 3.6 [1][2]. I\u0027ll rework the commit message.\n\n[1] https://github.com/python/cpython/blob/v2.7/Lib/BaseHTTPServer.py#L486-L495\n[2] https://github.com/python/cpython/blob/v3.6.0/Lib/http/server.py#L598-L601","commit_id":"94861a00491fb9541a21b467002d9d7f2996b920"}]}