)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"86ab82f78da2a662a24a93c54a9adecd2db3c1fb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"hardware: Add TODO to remove \u0027(un)pin_cpu_with_siblings\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With the newly introduced translation of \u0027hw:cpu_thread_policy\u0027 to"},{"line_number":10,"context_line":"require or avoid the \u0027HW_CPU_HYPERTHREADING\u0027 trait, we no longer fake"},{"line_number":11,"context_line":"non-SMT hosts by reserving the thread siblings of each core used by an"},{"line_number":12,"context_line":"instance. As such, once we\u0027re in a world where all hosts have switched"},{"line_number":13,"context_line":"to reporting PCPUs and this trait (or at least are capable of it), we"},{"line_number":14,"context_line":"will no longer need the functionality these methods enable. Add a TODO"},{"line_number":15,"context_line":"to remind us to remove them."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_07f4805a","line":12,"range":{"start_line":10,"start_character":52,"end_line":12,"end_character":9},"updated":"2020-05-14 07:54:52.000000000","message":"nit: well that is a slight miscariterisation\nwe were never faking non smt hosts we were allocating an entire physical core to the vm instead of just a hardware thread. it was never about emulating a fake non smt host.\nit was an important capabilt to allow operators to dyncmaicly manage thread vs core allocation. its really a shame we had to remove it due to placement limitations but it is what it is.","commit_id":"4ccec62fd1fe2e1e509c5a3a674a37cca37bc936"}],"nova/virt/hardware.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"86ab82f78da2a662a24a93c54a9adecd2db3c1fb","unresolved":false,"context_lines":[{"line_number":2220,"context_line":"            if instance_cell.cpuset_reserved:"},{"line_number":2221,"context_line":"                pinned_cpus |\u003d instance_cell.cpuset_reserved"},{"line_number":2222,"context_line":""},{"line_number":2223,"context_line":"            # TODO(stephenfin): Remove the \u0027_with_siblings\u0027 variants when we"},{"line_number":2224,"context_line":"            # drop support for \u0027vcpu_pin_set\u0027 since they will then be no-ops"},{"line_number":2225,"context_line":"            if free:"},{"line_number":2226,"context_line":"                if (instance_cell.cpu_thread_policy \u003d\u003d"},{"line_number":2227,"context_line":"                        fields.CPUThreadAllocationPolicy.ISOLATE):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_87fff032","line":2224,"range":{"start_line":2223,"start_character":11,"end_line":2224,"end_character":76},"updated":"2020-05-14 07:54:52.000000000","message":"nit: it might have been better to put this on the function definitions not the usage","commit_id":"4ccec62fd1fe2e1e509c5a3a674a37cca37bc936"}]}