)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"df543d08bd0491e01e91924f63795d9a0cd6d4bb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-06 10:16:21 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rework how we check for extensions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are couple of changes we can make here:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_d0536ddd","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":34},"updated":"2020-02-06 12:34:00.000000000","message":"OK, real quick: can you change this wording to \"Neutron extensions\"? It\u0027s obvious when you look at the code change, but just looking at the commit message, I have no idea what\u0027s going on.","commit_id":"bab22afab0c108c33e57ce09e356d6b21817e0b6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9b471df4dfee816892895619f82fa9ab6e01d32a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-06 10:16:21 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rework how we check for extensions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are couple of changes we can make here:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_eb079e6f","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":34},"in_reply_to":"3fa7e38b_d0536ddd","updated":"2020-02-06 13:51:51.000000000","message":"Done","commit_id":"bab22afab0c108c33e57ce09e356d6b21817e0b6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"31b00faec7d3010bd2009a99c1b4c9c0571d4895","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- Always attempt to refresh the cache before checking if an extension is"},{"line_number":12,"context_line":"  enabled."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- Using extension slugs as our reference point rather than extension"},{"line_number":15,"context_line":"  names. They seem like a better thing to use as a constant and are"},{"line_number":16,"context_line":"  similar fixed."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- Be consistent in how we name and call the extension check functions"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bf51134e_1faa6418","line":16,"range":{"start_line":14,"start_character":2,"end_line":16,"end_character":16},"updated":"2020-06-30 13:20:57.000000000","message":"stephen means he is converting form using the extention name\nto the stevadore  entrypoint alis when he says slugs\n\nas those are in slug-case vs snake_case or \"Title Case\"","commit_id":"f9ed824aae9bae33f9e439120e91020f2fc8368b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"31b00faec7d3010bd2009a99c1b4c9c0571d4895","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  names. They seem like a better thing to use as a constant and are"},{"line_number":16,"context_line":"  similar fixed."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- Be consistent in how we name and call the extension check functions"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- Add documentation for what each extension doing/used for"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bf51134e_5f4a1c83","line":18,"range":{"start_line":18,"start_character":2,"end_line":18,"end_character":69},"updated":"2020-06-30 13:20:57.000000000","message":"this one is less clear to me that its correct.\n\nhas is shorter to type yes btu suport was actully a better name.\n\nthat said i think this is ok.","commit_id":"f9ed824aae9bae33f9e439120e91020f2fc8368b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9a89d83d2c69cbb63ad07c373a4cbe685a856bf1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"97b86810_4138a139","updated":"2022-01-23 23:58:04.000000000","message":"lgtm","commit_id":"0f7f95b917b5a48779a327c45bd4a8558efcc7a3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"94904e0ff1a77360777c4839d5ed5ff4f7d3a13d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"0e872f72_a5151791","updated":"2022-02-03 15:12:07.000000000","message":"recheck","commit_id":"0f7f95b917b5a48779a327c45bd4a8558efcc7a3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7485557555d046ada17ec6b10c60337370705173","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2d0e2548_bb433ce1","updated":"2022-02-04 16:58:28.000000000","message":"recheck","commit_id":"0f7f95b917b5a48779a327c45bd4a8558efcc7a3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4048b0c4f207e4b807be98ec7d5d68544b07b1f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"79643ee4_2cc352ab","updated":"2022-02-03 11:43:03.000000000","message":"recheck","commit_id":"0f7f95b917b5a48779a327c45bd4a8558efcc7a3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"87bad7c5a4fb17f3687071402684b16116240612","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"8b4549c0_1dbcc9d8","updated":"2022-02-08 14:39:19.000000000","message":"recheck","commit_id":"0f7f95b917b5a48779a327c45bd4a8558efcc7a3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"870dd4f9e04ca82d54e2b494a4137fae2b4bf7e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ab48f92f_3d8cea44","updated":"2022-02-02 19:04:24.000000000","message":"recheck  tempest.api.compute.servers.test_device_tagging.TaggedAttachmentsTest.test_tagged_attachment","commit_id":"0f7f95b917b5a48779a327c45bd4a8558efcc7a3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5be54882b1465b77eda2abcc547c7180caea5521","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c1ba07e5_c2376a68","updated":"2022-02-02 15:34:03.000000000","message":"this has been a long time in the works\nim happy with this version so +2+w","commit_id":"0f7f95b917b5a48779a327c45bd4a8558efcc7a3"}],"nova/network/constants.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"6ad29eb4ee579eafa66fd0595c40158f60b172f5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# Core extensions"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"DNS_INTEGRATION \u003d \u0027dns-integration\u0027"},{"line_number":30,"context_line":"MULTI_PROVIDER \u003d \u0027multi-provider\u0027"},{"line_number":31,"context_line":"FIP_PORT_DETAILS \u003d \u0027fip-port-details\u0027"},{"line_number":32,"context_line":"PORT_BINDING_EXTENDED \u003d \u0027binding-extended\u0027"},{"line_number":33,"context_line":"SUBSTR_PORT_FILTERING \u003d \u0027ip-substring-filtering\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_52a188a6","line":30,"updated":"2020-02-10 22:41:49.000000000","message":"Used to be MULTI_NET_EXT, right?","commit_id":"a03f483d8f537b2c44325c3fdcfc604596ce5e91"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"47158e88f7672e777b5bdaa1eea5cd8d89cb2ae0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# Core extensions"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"DNS_INTEGRATION \u003d \u0027dns-integration\u0027"},{"line_number":30,"context_line":"MULTI_PROVIDER \u003d \u0027multi-provider\u0027"},{"line_number":31,"context_line":"FIP_PORT_DETAILS \u003d \u0027fip-port-details\u0027"},{"line_number":32,"context_line":"PORT_BINDING_EXTENDED \u003d \u0027binding-extended\u0027"},{"line_number":33,"context_line":"SUBSTR_PORT_FILTERING \u003d \u0027ip-substring-filtering\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_b71dfcbe","line":30,"in_reply_to":"3fa7e38b_52a188a6","updated":"2020-04-24 10:13:44.000000000","message":"Correct","commit_id":"a03f483d8f537b2c44325c3fdcfc604596ce5e91"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"6ad29eb4ee579eafa66fd0595c40158f60b172f5","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Third-party extensions"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"VNIC_INDEX \u003d \u0027vnic-index\u0027  # this is provided by the vmware_nsx project"},{"line_number":38,"context_line":"QOS_QUEUE \u003d \u0027qos-queue\u0027  # TODO(stephenfin): what defines this? Xen?"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Search fields"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_f2919451","line":37,"updated":"2020-02-10 22:41:49.000000000","message":"Used to be VNIC_INDEX_EXT, right?","commit_id":"a03f483d8f537b2c44325c3fdcfc604596ce5e91"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"47158e88f7672e777b5bdaa1eea5cd8d89cb2ae0","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Third-party extensions"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"VNIC_INDEX \u003d \u0027vnic-index\u0027  # this is provided by the vmware_nsx project"},{"line_number":38,"context_line":"QOS_QUEUE \u003d \u0027qos-queue\u0027  # TODO(stephenfin): what defines this? Xen?"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Search fields"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_f77ca4ec","line":37,"in_reply_to":"3fa7e38b_f2919451","updated":"2020-04-24 10:13:44.000000000","message":"++","commit_id":"a03f483d8f537b2c44325c3fdcfc604596ce5e91"}],"nova/network/neutron.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"31b00faec7d3010bd2009a99c1b4c9c0571d4895","unresolved":false,"context_lines":[{"line_number":1253,"context_line":"            self.extensions.clear()"},{"line_number":1254,"context_line":"            self.extensions \u003d {ext[\u0027alias\u0027]: ext for ext in extensions_list}"},{"line_number":1255,"context_line":""},{"line_number":1256,"context_line":"    def _has_extension(self, extension, context\u003dNone, client\u003dNone):"},{"line_number":1257,"context_line":"        \"\"\"Check if the provided neutron extension is enabled."},{"line_number":1258,"context_line":""},{"line_number":1259,"context_line":"        :param extension: The alias of the extension to check"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_221bcf73","line":1256,"range":{"start_line":1256,"start_character":3,"end_line":1256,"end_character":67},"updated":"2020-06-30 13:20:57.000000000","message":"so this is really the only thing im not partically happy with\n\nwhen we have a contex it is normally placed first so this is breaking that convention\n\ni would be tempted to make the client required an pull the client create out of the function.\n\nit just bugs me that in your attempt to make things consitnt you are breaking a different convention we have.","commit_id":"f9ed824aae9bae33f9e439120e91020f2fc8368b"}],"nova/tests/unit/network/test_neutron.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5be54882b1465b77eda2abcc547c7180caea5521","unresolved":true,"context_lines":[{"line_number":3480,"context_line":"                                      \u0027provider:network_type\u0027: \u0027vxlan\u0027}]}}"},{"line_number":3481,"context_line":"        test_ext_list \u003d {\u0027extensions\u0027:"},{"line_number":3482,"context_line":"                            [{\u0027name\u0027: \u0027Multi Provider Network\u0027,"},{"line_number":3483,"context_line":"                             \u0027alias\u0027: \u0027multi-provider\u0027}]}"},{"line_number":3484,"context_line":""},{"line_number":3485,"context_line":"        mock_client \u003d mock_get_client.return_value"},{"line_number":3486,"context_line":"        mock_client.list_extensions.return_value \u003d test_ext_list"}],"source_content_type":"text/x-python","patch_set":12,"id":"06b190dd_00e28173","line":3483,"range":{"start_line":3483,"start_character":30,"end_line":3483,"end_character":54},"updated":"2022-02-02 15:34:03.000000000","message":"this is a good catch by the way\n\nthey are different thigns to this is important to have right.","commit_id":"0f7f95b917b5a48779a327c45bd4a8558efcc7a3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bbb0e65ffc5e74afb39b9423c52164fe720bdbc0","unresolved":false,"context_lines":[{"line_number":3480,"context_line":"                                      \u0027provider:network_type\u0027: \u0027vxlan\u0027}]}}"},{"line_number":3481,"context_line":"        test_ext_list \u003d {\u0027extensions\u0027:"},{"line_number":3482,"context_line":"                            [{\u0027name\u0027: \u0027Multi Provider Network\u0027,"},{"line_number":3483,"context_line":"                             \u0027alias\u0027: \u0027multi-provider\u0027}]}"},{"line_number":3484,"context_line":""},{"line_number":3485,"context_line":"        mock_client \u003d mock_get_client.return_value"},{"line_number":3486,"context_line":"        mock_client.list_extensions.return_value \u003d test_ext_list"}],"source_content_type":"text/x-python","patch_set":12,"id":"4d2f8dd4_7bb517c0","line":3483,"range":{"start_line":3483,"start_character":30,"end_line":3483,"end_character":54},"in_reply_to":"06b190dd_00e28173","updated":"2022-02-02 16:39:03.000000000","message":"Yup, just a silly typo I suspect but good to have it correct","commit_id":"0f7f95b917b5a48779a327c45bd4a8558efcc7a3"}]}