)]}'
{"nova/compute/api.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"55cfdbcbbe3871b1a9928fbfe1db0ec74621d00b","unresolved":false,"context_lines":[{"line_number":1200,"context_line":"                        base_options[\u0027pci_requests\u0027], filter_properties,"},{"line_number":1201,"context_line":"                        instance_group, base_options[\u0027availability_zone\u0027],"},{"line_number":1202,"context_line":"                        security_groups\u003dsecurity_groups,"},{"line_number":1203,"context_line":"                        port_resource_requests\u003dport_resource_requests)"},{"line_number":1204,"context_line":""},{"line_number":1205,"context_line":"                if block_device_mapping:"},{"line_number":1206,"context_line":"                    # Record whether or not we are a BFV instance"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ba41d964","side":"PARENT","line":1203,"updated":"2020-02-07 15:42:13.000000000","message":"Instead of this I would rename the port_resource_requests to resource_requests in the signature of the from_components(). and pass the combined list here. But I know Dan disagrees. Anyhow the rest of the refactor looks good to me so I won\u0027t block on this.","commit_id":"4a7c4ab1d41a852f168d172ae5d5d3c88a27b77f"}],"nova/objects/request_spec.py":[{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"baba7953ffade924503a1dbdcccf71169448435d","unresolved":false,"context_lines":[{"line_number":512,"context_line":"        spec_obj.requested_destination \u003d filter_properties.get("},{"line_number":513,"context_line":"            \u0027requested_destination\u0027)"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        # TODO(gibi): do the creation of the unnumbered group and any"},{"line_number":516,"context_line":"        # numbered group from the flavor by moving the logic from"},{"line_number":517,"context_line":"        # nova.scheduler.utils.resources_from_request_spec() here. See also"},{"line_number":518,"context_line":"        # the comment in the definition of requested_resources field."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_da2295a6","side":"PARENT","line":515,"updated":"2020-02-07 15:19:58.000000000","message":"This TODO is dropped in the refactor.","commit_id":"4a7c4ab1d41a852f168d172ae5d5d3c88a27b77f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f021fce066fe4aadf8703b6f2d5058a8f7ae6e91","unresolved":false,"context_lines":[{"line_number":512,"context_line":"        spec_obj.requested_destination \u003d filter_properties.get("},{"line_number":513,"context_line":"            \u0027requested_destination\u0027)"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        # TODO(gibi): do the creation of the unnumbered group and any"},{"line_number":516,"context_line":"        # numbered group from the flavor by moving the logic from"},{"line_number":517,"context_line":"        # nova.scheduler.utils.resources_from_request_spec() here. See also"},{"line_number":518,"context_line":"        # the comment in the definition of requested_resources field."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_88bdb704","side":"PARENT","line":515,"in_reply_to":"3fa7e38b_da2295a6","updated":"2020-02-07 16:33:23.000000000","message":"Yeah, I did that on purpose, because I don\u0027t think it\u0027s relevant anymore. Gibi, do you agree?","commit_id":"4a7c4ab1d41a852f168d172ae5d5d3c88a27b77f"}]}