)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3c9cdbccb7e17938be2c2f86377d3414d87b66fd","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"AZ is user facing thing so that any user can list the AZ and use the"},{"line_number":19,"context_line":"same for creating server. Code is behaving as expected but policy"},{"line_number":20,"context_line":"rule check_str is confusingso let\u0027 correct it to base.RULE_ANY."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://github.com/openstack/nova/blob/c16315165ce307c605cf4b608b2df3aa06f46982/nova/policies/attach_interfaces.py#L28"},{"line_number":23,"context_line":"[2] https://github.com/openstack/nova/blob/1fcd74730d343b7cee12a0a50ea537dc4ff87f65/nova/api/openstack/compute/availability_zone.py#L111"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_f2a88d21","line":20,"range":{"start_line":20,"start_character":18,"end_line":20,"end_character":29},"updated":"2020-02-12 21:15:44.000000000","message":"confusing, so","commit_id":"ed4db78aab97baba50c52acd3b6c0a2a6540fdb9"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3c9cdbccb7e17938be2c2f86377d3414d87b66fd","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"AZ is user facing thing so that any user can list the AZ and use the"},{"line_number":19,"context_line":"same for creating server. Code is behaving as expected but policy"},{"line_number":20,"context_line":"rule check_str is confusingso let\u0027 correct it to base.RULE_ANY."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://github.com/openstack/nova/blob/c16315165ce307c605cf4b608b2df3aa06f46982/nova/policies/attach_interfaces.py#L28"},{"line_number":23,"context_line":"[2] https://github.com/openstack/nova/blob/1fcd74730d343b7cee12a0a50ea537dc4ff87f65/nova/api/openstack/compute/availability_zone.py#L111"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_92a35944","line":20,"range":{"start_line":20,"start_character":30,"end_line":20,"end_character":34},"updated":"2020-02-12 21:15:44.000000000","message":"let\u0027s","commit_id":"ed4db78aab97baba50c52acd3b6c0a2a6540fdb9"}],"nova/policies/availability_zone.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8a6eade504654bbef5141fd185b61b07608e34d5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":26,"context_line":"        POLICY_ROOT % \u0027list\u0027,"},{"line_number":27,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":28,"context_line":"        \"List availability zone information without host information\","},{"line_number":29,"context_line":"        ["},{"line_number":30,"context_line":"            {"},{"line_number":31,"context_line":"                \u0027method\u0027: \u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e609b728","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":70},"updated":"2020-02-12 16:41:39.000000000","message":"AZ is user facing things so should we open this for everyone? or admin only, Looking for feedback.","commit_id":"c81d5f412885b954472ee3a983be8727fc097e9a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a0d57cdf3484675ef01bd30c63122fe29061e9a2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":26,"context_line":"        POLICY_ROOT % \u0027list\u0027,"},{"line_number":27,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":28,"context_line":"        \"List availability zone information without host information\","},{"line_number":29,"context_line":"        ["},{"line_number":30,"context_line":"            {"},{"line_number":31,"context_line":"                \u0027method\u0027: \u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_17c99b22","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":70},"in_reply_to":"3fa7e38b_46020b74","updated":"2020-02-12 20:13:16.000000000","message":"done","commit_id":"c81d5f412885b954472ee3a983be8727fc097e9a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"12b468847c4544071cdc000cf4dcb4b073728875","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":26,"context_line":"        POLICY_ROOT % \u0027list\u0027,"},{"line_number":27,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":28,"context_line":"        \"List availability zone information without host information\","},{"line_number":29,"context_line":"        ["},{"line_number":30,"context_line":"            {"},{"line_number":31,"context_line":"                \u0027method\u0027: \u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_46020b74","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":70},"in_reply_to":"3fa7e38b_66e86714","updated":"2020-02-12 17:14:06.000000000","message":"Sorry, please ignore my previous reply. I had thought this API was doing something to GET the AZ of a particular instance.\n\nAs you noted on IRC, this API is just listing all available AZs, which are user-facing and makes sense to be available to everyone. And correct it should not be admin-only because non-admin users need to be able to see what AZs they can use when they make a instance create request.","commit_id":"c81d5f412885b954472ee3a983be8727fc097e9a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0f41faeff1f6c0ab4977beeb1e22aefc28512849","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":26,"context_line":"        POLICY_ROOT % \u0027list\u0027,"},{"line_number":27,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":28,"context_line":"        \"List availability zone information without host information\","},{"line_number":29,"context_line":"        ["},{"line_number":30,"context_line":"            {"},{"line_number":31,"context_line":"                \u0027method\u0027: \u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_66e86714","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":70},"in_reply_to":"3fa7e38b_e609b728","updated":"2020-02-12 16:50:19.000000000","message":"I agree that it should not be admin-only because it is user-facing, but I think it should be admin_or_owner so that by default, only project members can see which AZ an instance is in. By default I don\u0027t think all members of all projects should be able to see a particular instance\u0027s AZ that is not in their project.\n\nIs there a way we can fix this as a bug like the other admin_or_owner bugs you have fixed so far?","commit_id":"c81d5f412885b954472ee3a983be8727fc097e9a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"06cb296ce1984b1880505a9f3cb5402d9797458d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"availability_zone_policies \u003d ["},{"line_number":25,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":26,"context_line":"        POLICY_ROOT % \u0027list\u0027,"},{"line_number":27,"context_line":"        base.RULE_ANY,"},{"line_number":28,"context_line":"        \"List availability zone information without host information\","},{"line_number":29,"context_line":"        ["},{"line_number":30,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_68835056","line":27,"updated":"2020-02-12 22:32:25.000000000","message":"Looks like you might need this change in this patch?\n\nhttps://review.opendev.org/#/c/706682/5/nova/tests/unit/test_policy.py","commit_id":"ed4db78aab97baba50c52acd3b6c0a2a6540fdb9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fd8a00ea0fd6121a35b8f11efddee2ac754c96fd","unresolved":false,"context_lines":[{"line_number":24,"context_line":"availability_zone_policies \u003d ["},{"line_number":25,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":26,"context_line":"        POLICY_ROOT % \u0027list\u0027,"},{"line_number":27,"context_line":"        base.RULE_ANY,"},{"line_number":28,"context_line":"        \"List availability zone information without host information\","},{"line_number":29,"context_line":"        ["},{"line_number":30,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_28c79899","line":27,"in_reply_to":"3fa7e38b_68835056","updated":"2020-02-12 22:35:56.000000000","message":"true, I missed to fix that in this patch.","commit_id":"ed4db78aab97baba50c52acd3b6c0a2a6540fdb9"}]}