)]}'
{"nova/virt/disk/api.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"6e15cca3673aa6fc43207d358a971a81c43b44c1","unresolved":false,"context_lines":[{"line_number":665,"context_line":"    if not host:"},{"line_number":666,"context_line":"        try:"},{"line_number":667,"context_line":"            utils.execute("},{"line_number":668,"context_line":"                \u0027virt-sparsify\u0027, \u0027-q\u0027, \u0027--check-tmpdir\u0027, \u0027fail\u0027, src, dest)"},{"line_number":669,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":670,"context_line":"            LOG.info("},{"line_number":671,"context_line":"                _(\"Unable to use virt-sparcify for doing copy of disk: %s\"), e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F91OA%3D","line":668,"updated":"2014-02-03 15:02:22.000000000","message":"This raises a tricky question. On the one hand I applaud your use of virt-sparsify tool since it avoids having to re-invent the wheel.\n\nOn the other hand though, virt-sparsify is only going to be work on hosts with KVM or QEMU, so anyone using Xen/VMWare/etc is not going to be able to use this code. Although we do rely on libguestfs elsewhere in nova/virt/disk module, that usage is optional with a non-libguesfs based fallback which works on other hypervisors.\n\nIOW if we want this method to live in the common  nova/virt/disk/api.py module I think we need to have a non-libguestfs solution available too. If we can\u0027t provide that, then this should live inside something like nova/virt/libvirt/disk.py instead.\n\nMy other concern is that virt-sparsify is operating outside the bounds of any resource controls set against the flavour. That said, other operations nova does against the disk also share this issue, so its probably not a showstopper.","commit_id":"74817e11d7123b6c4b517e600c0ec89ffc0fd651"}]}