)]}'
{"nova/policies/deferred_delete.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c84db21e7b802cfaa61fdac2aabbdc919265ce59","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                \u0027path\u0027: \u0027/servers/{server_id}/action (forceDelete)\u0027"},{"line_number":38,"context_line":"            }"},{"line_number":39,"context_line":"        ],"},{"line_number":40,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027])"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_bb09e92c","line":40,"updated":"2020-03-02 14:33:06.000000000","message":"ah... so having both of these means it kinda changes nothing here, got it...","commit_id":"5fe51dd99296bb61e4482d53ec975cdc41faa289"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6d30376cb062c16ebb2cf52b15400a2f030eb822","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                \u0027path\u0027: \u0027/servers/{server_id}/action (forceDelete)\u0027"},{"line_number":38,"context_line":"            }"},{"line_number":39,"context_line":"        ],"},{"line_number":40,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027])"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_91d38060","line":40,"in_reply_to":"1fa4df85_bb09e92c","updated":"2020-03-04 19:35:04.000000000","message":"yeah, for nova if both scope allow does not change anything from existing one till we get rid of deprecated old rules.","commit_id":"5fe51dd99296bb61e4482d53ec975cdc41faa289"}],"nova/tests/unit/policies/test_deferred_delete.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"32988b77304c92fe917ccd8f094a70ca05c8ada9","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        # Check that system admin or owner is able to force delete or"},{"line_number":119,"context_line":"        # restore server."},{"line_number":120,"context_line":"        self.admin_authorized_contexts \u003d ["},{"line_number":121,"context_line":"            self.system_admin_context, self.legacy_admin_context,"},{"line_number":122,"context_line":"            self.project_admin_context, self.project_member_context,"},{"line_number":123,"context_line":"            self.project_reader_context, self.project_foo_context]"},{"line_number":124,"context_line":"        # Check that non-system and non-admin/owner is not able to force delete"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_f0a1c0aa","line":121,"range":{"start_line":121,"start_character":39,"end_line":121,"end_character":64},"updated":"2020-03-02 14:12:46.000000000","message":"Hmmm, OK, maybe its all the admin_or_owner ones I am getting confused about.","commit_id":"5fe51dd99296bb61e4482d53ec975cdc41faa289"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6d30376cb062c16ebb2cf52b15400a2f030eb822","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        # Check that system admin or owner is able to force delete or"},{"line_number":119,"context_line":"        # restore server."},{"line_number":120,"context_line":"        self.admin_authorized_contexts \u003d ["},{"line_number":121,"context_line":"            self.system_admin_context, self.legacy_admin_context,"},{"line_number":122,"context_line":"            self.project_admin_context, self.project_member_context,"},{"line_number":123,"context_line":"            self.project_reader_context, self.project_foo_context]"},{"line_number":124,"context_line":"        # Check that non-system and non-admin/owner is not able to force delete"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_11c79098","line":121,"range":{"start_line":121,"start_character":39,"end_line":121,"end_character":64},"in_reply_to":"1fa4df85_f0a1c0aa","updated":"2020-03-04 19:35:04.000000000","message":"true, it is for admin_or_owner where we have to allow both scope.","commit_id":"5fe51dd99296bb61e4482d53ec975cdc41faa289"}]}