)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"771837df6bb0d924f4e7a708a348ed9a515c1912","unresolved":false,"context_lines":[{"line_number":9067,"context_line":"            \u0027data\u0027: {\u0027device_path\u0027: \u0027/fake\u0027,"},{"line_number":9068,"context_line":"                     \u0027access_mode\u0027: \u0027rw\u0027}"},{"line_number":9069,"context_line":"        }"},{"line_number":9070,"context_line":"        new_size \u003d units.Gi"},{"line_number":9071,"context_line":""},{"line_number":9072,"context_line":"        xml_no_disk \u003d \"\u003cdomain\u003e\u003cdevices\u003e\u003c/devices\u003e\u003c/domain\u003e\""},{"line_number":9073,"context_line":"        dom \u003d fakelibvirt.Domain(drvr._get_connection(), xml_no_disk, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_a3a02638","line":9070,"updated":"2020-02-19 16:33:59.000000000","message":"not that it matters, but would \u002720 * units.Gi\u0027 be a little more self-explanatory?","commit_id":"63148e7df9d05a5794c7cb0a303dbc3b5e40b6ae"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1069c9819a3766a84d2851a7caf75fb72044afa0","unresolved":false,"context_lines":[{"line_number":9067,"context_line":"            \u0027data\u0027: {\u0027device_path\u0027: \u0027/fake\u0027,"},{"line_number":9068,"context_line":"                     \u0027access_mode\u0027: \u0027rw\u0027}"},{"line_number":9069,"context_line":"        }"},{"line_number":9070,"context_line":"        new_size \u003d units.Gi"},{"line_number":9071,"context_line":""},{"line_number":9072,"context_line":"        xml_no_disk \u003d \"\u003cdomain\u003e\u003cdevices\u003e\u003c/devices\u003e\u003c/domain\u003e\""},{"line_number":9073,"context_line":"        dom \u003d fakelibvirt.Domain(drvr._get_connection(), xml_no_disk, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_a3256dad","line":9070,"in_reply_to":"3fa7e38b_a3a02638","updated":"2020-03-04 10:45:24.000000000","message":"Yup that\u0027s actually a typo.","commit_id":"63148e7df9d05a5794c7cb0a303dbc3b5e40b6ae"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"771837df6bb0d924f4e7a708a348ed9a515c1912","unresolved":false,"context_lines":[{"line_number":9253,"context_line":"        # The LUKSv1 payload offset as reported by qemu-img info in bytes."},{"line_number":9254,"context_line":"        payload_offset \u003d 2048 * units.Ki"},{"line_number":9255,"context_line":"        # The new size is provided to Libvirt virDomainBlockResize"},{"line_number":9256,"context_line":"        new_size_minus_offset \u003d (new_size - payload_offset)"},{"line_number":9257,"context_line":""},{"line_number":9258,"context_line":"        drvr._host.get_guest \u003d mock.Mock(return_value\u003dguest)"},{"line_number":9259,"context_line":"        drvr._extend_volume \u003d mock.Mock(return_value\u003dnew_size)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_03657a1c","line":9256,"range":{"start_line":9256,"start_character":31,"end_line":9256,"end_character":33},"updated":"2020-02-19 16:33:59.000000000","message":"nit: don\u0027t need dem brackets","commit_id":"63148e7df9d05a5794c7cb0a303dbc3b5e40b6ae"}],"nova/virt/libvirt/guest.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"771837df6bb0d924f4e7a708a348ed9a515c1912","unresolved":false,"context_lines":[{"line_number":792,"context_line":"        return self._guest._domain.blockCommit("},{"line_number":793,"context_line":"            self._disk, base, top, self.COMMIT_DEFAULT_BANDWIDTH, flags\u003dflags)"},{"line_number":794,"context_line":""},{"line_number":795,"context_line":"    def resize(self, size, size_in_bytes\u003dTrue):"},{"line_number":796,"context_line":"        \"\"\"Resize block device to size, by default in bytes."},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"        This resizes the block device within the instance to the given size."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_a3f26668","line":795,"range":{"start_line":795,"start_character":25,"end_line":795,"end_character":46},"updated":"2020-02-19 16:33:59.000000000","message":"We don\u0027t appear to be using this? Do we need it? If so, can you note it in the commit message? If not, can you drop it?","commit_id":"63148e7df9d05a5794c7cb0a303dbc3b5e40b6ae"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ae1215ab811972214e72a5acea82475c57adff2e","unresolved":false,"context_lines":[{"line_number":792,"context_line":"        return self._guest._domain.blockCommit("},{"line_number":793,"context_line":"            self._disk, base, top, self.COMMIT_DEFAULT_BANDWIDTH, flags\u003dflags)"},{"line_number":794,"context_line":""},{"line_number":795,"context_line":"    def resize(self, size):"},{"line_number":796,"context_line":"        \"\"\"Resize block device to the given size in bytes."},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"        This resizes the block device within the instance to the given size."},{"line_number":799,"context_line":""},{"line_number":800,"context_line":"        :param size: The size to resize the device to in bytes."},{"line_number":801,"context_line":"        \"\"\""},{"line_number":802,"context_line":"        flags \u003d libvirt.VIR_DOMAIN_BLOCK_RESIZE_BYTES"},{"line_number":803,"context_line":"        self._guest._domain.blockResize(self._disk, size, flags\u003dflags)"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"    def is_job_complete(self):"},{"line_number":806,"context_line":"        \"\"\"Return True if the job is complete, False otherwise"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_ac54c722","line":803,"range":{"start_line":795,"start_character":6,"end_line":803,"end_character":70},"updated":"2020-03-11 12:09:30.000000000","message":"ok so the flags are hardcoded. i guess this is fine.\n\nthe blockresize funcitonis coming form libvirt right so we can make this the default so we just defualt it here in our calling code.","commit_id":"0fcd0dc502471751a0777a4a7cc3407d7efdaa11"}]}