)]}'
{"id":"openstack%2Fnova~707887","triplet_id":"openstack%2Fnova~stable%2Fqueens~Iafba419fe86446ffe636721f523fb619f8f787b3","project":"openstack/nova","branch":"stable/queens","hashtags":[],"change_id":"Iafba419fe86446ffe636721f523fb619f8f787b3","subject":"Restore soft-deleted compute node with same uuid","status":"ABANDONED","created":"2020-02-14 18:09:51.000000000","updated":"2020-02-17 15:47:18.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"960941d4df873e8539a4835b8622c12bf7250964","_number":707887,"virtual_id_number":707887,"owner":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2020-02-14 18:21:09.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2020-02-14 20:57:09.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"date":"2020-02-14 18:16:17.000000000","_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-02-14 20:07:23.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"date":"2020-02-14 18:09:51.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-14 18:09:51.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2020-02-14 18:16:17.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2020-02-14 18:21:09.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2020-02-14 20:07:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-02-14 20:57:09.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f66c5e7763cf17040575310bf8f57cd5b8a4203a","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-02-14 18:09:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1d0ec21db061d83f87084a58f72f18c9bf66fdc2","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-02-14 18:16:17.000000000","message":"Patch Set 1:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered http://52.27.155.124/87/707887/1/check/pmem-tempest-plugin-filtered/9081bf2/ : POST_FAILURE in 4m 46s","accounts_in_message":[],"_revision_number":1},{"id":"c7b58e236b3ef224054758bb7c2c115081bb2cba","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-02-14 18:21:09.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/707887/1 : FAILURE in 8m 58s","accounts_in_message":[],"_revision_number":1},{"id":"53e42a1547b49a4a198359399b0db9f3863b3360","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-14 20:07:23.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e46556a346f343959492cf61f70347eb : SUCCESS in 10m 10s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/7382e0c6fdb842d0a1f5d9d2c0f8f821 : SUCCESS in 14m 02s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/12a5424f63b148cf90c6c4727e3ed7ad : SUCCESS in 14m 22s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/f21fb30747e5406ca48e3b60ec0d0588 : SUCCESS in 7m 57s\n- tempest-full https://zuul.opendev.org/t/openstack/build/66f6f5dbe4f04c84b71a6a79973d439a : SUCCESS in 1h 31m 26s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/0df91cc000af4557926cc5afb03e46cf : SUCCESS in 55m 31s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/1f636624389b429289c58ff295cf1b50 : SUCCESS in 1h 19m 35s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/d107ec0f0f7e498d92efc14d2a452fb6 : SUCCESS in 50m 57s (non-voting)\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/c3db025223324e14a22907b5f3ace96c : SUCCESS in 44m 57s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/3c4122d0776c422da952a8b00e6c6a4d : SUCCESS in 58m 14s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/3bf323a5ff754cbdbc0a6ce50fb851be : SUCCESS in 45m 43s\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/6d7a4bfce9cc43eb98ebb7cd8b8584f2 : SUCCESS in 1h 00m 09s\n- nova-next https://zuul.opendev.org/t/openstack/build/0cf540226076403782947f5f29f8db7d : SUCCESS in 1h 55m 23s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/2e17056135e8494e93da1b0d4e26af6d : SUCCESS in 1h 44m 32s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/4592c9843fe74fd5a5914b766bcb3adc : FAILURE in 20m 12s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/c05109a66f754fa69d33cb24089bc58d : FAILURE in 21m 20s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/d0c8a5fc1368447082a9594ac8e66ad7 : SUCCESS in 58m 20s\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/bd464dbb6f6a4829b80a0887d956a268 : SUCCESS in 58m 31s (non-voting)\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/61452261a2334de082beac0c8f9b0e35 : SUCCESS in 1h 34m 09s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"475003b3e9f6b7fe25b61c42b6ff62f3ce46c751","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-02-14 20:57:09.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- legacy-tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/87/707887/1/check/legacy-tempest-dsvm-full-xenial/f16b812/ : TIMED_OUT in 2h 38m 47s\n- legacy-tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/87/707887/1/check/legacy-tempest-dsvm-full-xenial-py3/95f325d/ : TIMED_OUT in 2h 41m 49s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"960941d4df873e8539a4835b8622c12bf7250964","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-02-17 15:47:18.000000000","message":"Abandoned\n\nAs mentioned in the commit message of the previous patch, and I completely missed it, but this is only applicable to \u003e\u003d Rocky.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1444f9e7fb4ad5ae9f38f3c925fbf8039784968f","revisions":{"1444f9e7fb4ad5ae9f38f3c925fbf8039784968f":{"kind":"REWORK","_number":1,"created":"2020-02-14 18:09:51.000000000","uploader":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"ref":"refs/changes/87/707887/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/87/707887/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/707887/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/707887/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/707887/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/87/707887/1"}}},"commit":{"parents":[{"commit":"da60b156a463547a6ab70cd3ed3cce23211d6b02","subject":"Add functional regression recreate test for bug 1839560","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/da60b156a463547a6ab70cd3ed3cce23211d6b02"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-08-12 18:39:16.000000000","tz":-240},"committer":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2020-02-14 18:09:36.000000000","tz":-300},"subject":"Restore soft-deleted compute node with same uuid","message":"Restore soft-deleted compute node with same uuid\n\nThere is a unique index on the compute_nodes.uuid column which\nmeans we can\u0027t have more than one compute_nodes record in the\nsame DB with the same UUID even if one is soft deleted because\nthe deleted column is not part of that unique index constraint.\n\nThis is a problem with ironic nodes where the node is 1:1 with\nthe compute node record, and when a node is undergoing maintenance\nthe driver doesn\u0027t return it from get_available_nodes() so the\nComputeManager.update_available_resource periodic task (soft)\ndeletes the compute node record, but when the node is no longer\nunder maintenance in ironic and the driver reports it, the\nResourceTracker._init_compute_node code will fail to create the\nComputeNode record again because of the duplicate uuid.\n\nThis change handles the DBDuplicateEntry error in compute_node_create\nby finding the soft-deleted compute node with the same uuid and\nsimply updating it to no longer be (soft) deleted.\n\nCloses-Bug: #1839560\n\nChange-Id: Iafba419fe86446ffe636721f523fb619f8f787b3\n(cherry picked from commit 8b007266f438ec0a5a797d05731cce6f2b155f4c)\n(cherry picked from commit 1b021665281b74c865d3571fc90772b52d70e467)\n(cherry picked from commit 9ce94844fa6a43368445182bb086876874256197)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1444f9e7fb4ad5ae9f38f3c925fbf8039784968f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1444f9e7fb4ad5ae9f38f3c925fbf8039784968f"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
