)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5bae7973e883fdb70e90ee2b285c4d5962f829d9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"both support this in os-brick and wire up the required calls in the"},{"line_number":22,"context_line":"volume driver."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This workaround is temporary and will be removed during the W release"},{"line_number":25,"context_line":"once all impacted distributions have been able to update their versions"},{"line_number":26,"context_line":"of the libgcrypt library."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Finally os-brick 3.0.1 is now required as it provides the"},{"line_number":29,"context_line":"Id507109df80391699074773f4787f74507c4b882 fix when attempting to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"df33271e_051820d1","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":25},"updated":"2020-04-06 19:15:39.000000000","message":"with the opencas usecase i get the feeling that if this is intoduced it will not be temperay and instad attaching rbd volums via the host kerenl will get promoted to a normal configuration option.\n\ni hope it is temproay as i consider not useing the native rbd support in qemu to be a regression but i guess we will see.","commit_id":"5d2d8fdc888804d3d5774ec5d6b1fc26e2ae1c49"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0ac683b9870a444c245d9157c0c7e1b7148f111c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"both support this in os-brick and wire up the required calls in the"},{"line_number":22,"context_line":"volume driver."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This workaround is temporary and will be removed during the W release"},{"line_number":25,"context_line":"once all impacted distributions have been able to update their versions"},{"line_number":26,"context_line":"of the libgcrypt library."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Finally os-brick 3.0.1 is now required as it provides the"},{"line_number":29,"context_line":"Id507109df80391699074773f4787f74507c4b882 fix when attempting to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"df33271e_d4ef0be7","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":25},"in_reply_to":"df33271e_051820d1","updated":"2020-04-06 21:09:33.000000000","message":"This workaround implementation is definitely temporary yes.\n\nIf the OpenCAS folks wanted to fully support this for use with their caching features then that would be a spec and a very different implementation IMHO, driven by the connection_info n-cpu gets from c-vol.","commit_id":"5d2d8fdc888804d3d5774ec5d6b1fc26e2ae1c49"}],"nova/conf/workarounds.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"30407386fbdc7c5db4057372c5d5e4ae3b3ce419","unresolved":false,"context_lines":[{"line_number":305,"context_line":"Connect RBD volumes to the compute host as block devices."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"When enabled this option instructs os-brick to connect RBD volumes locally on"},{"line_number":308,"context_line":"the compute host as block devices instead of natively through QEMU."},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"Related options:"},{"line_number":311,"context_line":"* ``compute_driver`` (libvirt)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_09a56904","line":308,"updated":"2020-03-17 21:51:02.000000000","message":"Maybe add another sentence indicating that this option is needs to be used together along with disable_qemu_native_luksv1 to avoid the performance degradation, right? Or does it have usefulness without the other option?","commit_id":"75b0d6363147f926b94665970e1e15c18231c28a"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"56fa7bac749a77fd2d4924aa34ed96921ee66faa","unresolved":false,"context_lines":[{"line_number":305,"context_line":"Connect RBD volumes to the compute host as block devices."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"When enabled this option instructs os-brick to connect RBD volumes locally on"},{"line_number":308,"context_line":"the compute host as block devices instead of natively through QEMU."},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"Related options:"},{"line_number":311,"context_line":"* ``compute_driver`` (libvirt)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_56f644fb","line":308,"in_reply_to":"1fa4df85_09a56904","updated":"2020-03-26 10:46:26.000000000","message":"ACK, there\u0027s little benefit without the other workaround at the moment.","commit_id":"75b0d6363147f926b94665970e1e15c18231c28a"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"f7b0519d5bd5a6703b32515a8f45512a4264a023","unresolved":false,"context_lines":[{"line_number":299,"context_line":"* ``compute_driver`` (libvirt)"},{"line_number":300,"context_line":"* ``rbd_block_device`` (workarounds)"},{"line_number":301,"context_line":"\"\"\"),"},{"line_number":302,"context_line":"    cfg.BoolOpt(\u0027rbd_block_device\u0027,"},{"line_number":303,"context_line":"                default\u003dFalse,"},{"line_number":304,"context_line":"                help\u003d\"\"\""},{"line_number":305,"context_line":"Connect RBD volumes to the compute host as block devices."}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_c5e2b82f","line":302,"range":{"start_line":302,"start_character":17,"end_line":302,"end_character":33},"updated":"2020-04-06 19:10:09.000000000","message":"This is not a deal-breaker for me, especially so close to FF, and this being a workaround that\u0027ll get removed anyways, but can I be the guy to bikeshed on the naming of this? RBD is RADOS Block Device, right? So this is RADOS Block Device Block Device... and it isn\u0027t super clear what it does.\n\n\u003clater\u003e\n\nAt first I was going to suggest disable_rdb_native_qemu, but seeing more of your code, maybe something like rbd_host_blockdev?","commit_id":"5d2d8fdc888804d3d5774ec5d6b1fc26e2ae1c49"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"8f3a0ca8bbb38462921ab165181248e70d0c897d","unresolved":false,"context_lines":[{"line_number":299,"context_line":"* ``compute_driver`` (libvirt)"},{"line_number":300,"context_line":"* ``rbd_block_device`` (workarounds)"},{"line_number":301,"context_line":"\"\"\"),"},{"line_number":302,"context_line":"    cfg.BoolOpt(\u0027rbd_block_device\u0027,"},{"line_number":303,"context_line":"                default\u003dFalse,"},{"line_number":304,"context_line":"                help\u003d\"\"\""},{"line_number":305,"context_line":"Connect RBD volumes to the compute host as block devices."}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_c0ef46ae","line":302,"range":{"start_line":302,"start_character":17,"end_line":302,"end_character":33},"in_reply_to":"df33271e_a5d974f5","updated":"2020-04-06 20:00:53.000000000","message":"Using your other suggestion, maybe rbd_host_mount?","commit_id":"5d2d8fdc888804d3d5774ec5d6b1fc26e2ae1c49"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0ac683b9870a444c245d9157c0c7e1b7148f111c","unresolved":false,"context_lines":[{"line_number":299,"context_line":"* ``compute_driver`` (libvirt)"},{"line_number":300,"context_line":"* ``rbd_block_device`` (workarounds)"},{"line_number":301,"context_line":"\"\"\"),"},{"line_number":302,"context_line":"    cfg.BoolOpt(\u0027rbd_block_device\u0027,"},{"line_number":303,"context_line":"                default\u003dFalse,"},{"line_number":304,"context_line":"                help\u003d\"\"\""},{"line_number":305,"context_line":"Connect RBD volumes to the compute host as block devices."}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_9472a37b","line":302,"range":{"start_line":302,"start_character":17,"end_line":302,"end_character":33},"in_reply_to":"df33271e_c0ef46ae","updated":"2020-04-06 21:09:33.000000000","message":"I\u0027ve gone with rbd_volume_local_attach to keep it in-line with the os-brick verbiage.","commit_id":"5d2d8fdc888804d3d5774ec5d6b1fc26e2ae1c49"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5bae7973e883fdb70e90ee2b285c4d5962f829d9","unresolved":false,"context_lines":[{"line_number":299,"context_line":"* ``compute_driver`` (libvirt)"},{"line_number":300,"context_line":"* ``rbd_block_device`` (workarounds)"},{"line_number":301,"context_line":"\"\"\"),"},{"line_number":302,"context_line":"    cfg.BoolOpt(\u0027rbd_block_device\u0027,"},{"line_number":303,"context_line":"                default\u003dFalse,"},{"line_number":304,"context_line":"                help\u003d\"\"\""},{"line_number":305,"context_line":"Connect RBD volumes to the compute host as block devices."}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_a5d974f5","line":302,"range":{"start_line":302,"start_character":17,"end_line":302,"end_character":33},"in_reply_to":"df33271e_c5e2b82f","updated":"2020-04-06 19:15:39.000000000","message":"blockdev could be consued with the qemu disk vs blockdev feature so i prefer the first suggestion with a slight tweak\n\ndisable_native_qemu_rbd_support\nor\ndisable_native_qemu_rbd_volumes","commit_id":"5d2d8fdc888804d3d5774ec5d6b1fc26e2ae1c49"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5bae7973e883fdb70e90ee2b285c4d5962f829d9","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    cfg.BoolOpt(\u0027rbd_block_device\u0027,"},{"line_number":303,"context_line":"                default\u003dFalse,"},{"line_number":304,"context_line":"                help\u003d\"\"\""},{"line_number":305,"context_line":"Connect RBD volumes to the compute host as block devices."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"When enabled this option instructs os-brick to connect RBD volumes locally on"},{"line_number":308,"context_line":"the compute host as block devices instead of natively through QEMU."}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_85239005","line":305,"range":{"start_line":305,"start_character":3,"end_line":305,"end_character":57},"updated":"2020-04-06 19:15:39.000000000","message":"same question as before this applies to both the rbd image backend and cinder volumes right.","commit_id":"5d2d8fdc888804d3d5774ec5d6b1fc26e2ae1c49"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0ac683b9870a444c245d9157c0c7e1b7148f111c","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    cfg.BoolOpt(\u0027rbd_block_device\u0027,"},{"line_number":303,"context_line":"                default\u003dFalse,"},{"line_number":304,"context_line":"                help\u003d\"\"\""},{"line_number":305,"context_line":"Connect RBD volumes to the compute host as block devices."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"When enabled this option instructs os-brick to connect RBD volumes locally on"},{"line_number":308,"context_line":"the compute host as block devices instead of natively through QEMU."}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_145fb3e5","line":305,"range":{"start_line":305,"start_character":3,"end_line":305,"end_character":57},"in_reply_to":"df33271e_85239005","updated":"2020-04-06 21:09:33.000000000","message":"No, only Cinder volumes.","commit_id":"5d2d8fdc888804d3d5774ec5d6b1fc26e2ae1c49"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"172aac5c32b2b77b087f58c02f5ee39f2160dbcf","unresolved":false,"context_lines":[{"line_number":317,"context_line":"all impacted distributions have been able to update their versions of the"},{"line_number":318,"context_line":"libgcrypt library."},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"Related options:"},{"line_number":321,"context_line":"* ``compute_driver`` (libvirt)"},{"line_number":322,"context_line":"* ``disable_qemu_native_luksv1`` (workarounds)"},{"line_number":323,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_2569d1bd","line":320,"updated":"2020-04-07 13:01:08.000000000","message":"You need a new line under this or it won\u0027t render correctly in the docs [1]\n\n[1] http://rst.ninjs.org/#SGVsbG8KKiB3b3JsZA\u003d\u003d","commit_id":"7c7a25aa1eda9b1815f12cce25dda0a840d562f1"}],"nova/tests/unit/virt/libvirt/volume/test_net.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"f7b0519d5bd5a6703b32515a8f45512a4264a023","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        # Assert that the connector is called correctly and device_path updated"},{"line_number":246,"context_line":"        libvirt_driver.connector.connect_volume.assert_called_once_with("},{"line_number":247,"context_line":"            connection_info[\u0027data\u0027])"},{"line_number":248,"context_line":"        connection_info[\u0027data\u0027][\u0027device_path\u0027] \u003d mock.sentinel.rbd_dev"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def test_libvirt_rbd_driver_block_disconnect(self):"},{"line_number":251,"context_line":"        self.flags(rbd_block_device\u003dTrue, group\u003d\u0027workarounds\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_45b6a8db","line":248,"updated":"2020-04-06 19:10:09.000000000","message":"What\u0027s the point of this line here?","commit_id":"5d2d8fdc888804d3d5774ec5d6b1fc26e2ae1c49"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0ac683b9870a444c245d9157c0c7e1b7148f111c","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        # Assert that the connector is called correctly and device_path updated"},{"line_number":246,"context_line":"        libvirt_driver.connector.connect_volume.assert_called_once_with("},{"line_number":247,"context_line":"            connection_info[\u0027data\u0027])"},{"line_number":248,"context_line":"        connection_info[\u0027data\u0027][\u0027device_path\u0027] \u003d mock.sentinel.rbd_dev"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def test_libvirt_rbd_driver_block_disconnect(self):"},{"line_number":251,"context_line":"        self.flags(rbd_block_device\u003dTrue, group\u003d\u0027workarounds\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_d46c2b9e","line":248,"in_reply_to":"df33271e_45b6a8db","updated":"2020-04-06 21:09:33.000000000","message":"Done","commit_id":"5d2d8fdc888804d3d5774ec5d6b1fc26e2ae1c49"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"f7b0519d5bd5a6703b32515a8f45512a4264a023","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        libvirt_driver.connector.disconnect_volume.assert_called_once_with("},{"line_number":260,"context_line":"            connection_info[\u0027data\u0027], None)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def test_libvirt_rbd_driver_block_config(self):"},{"line_number":263,"context_line":"        self.flags(rbd_block_device\u003dTrue, group\u003d\u0027workarounds\u0027)"},{"line_number":264,"context_line":"        connection_info \u003d self.rbd_connection(self.vol)"},{"line_number":265,"context_line":"        connection_info[\u0027data\u0027][\u0027device_path\u0027] \u003d \u0027/dev/rbd0\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_050ae088","line":262,"updated":"2020-04-06 19:10:09.000000000","message":"I guess you don\u0027t need to test your \"new\" _get_net_config() because it\u0027s already being tested by other tests here that call get_config() without the workaround enabled?","commit_id":"5d2d8fdc888804d3d5774ec5d6b1fc26e2ae1c49"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0ac683b9870a444c245d9157c0c7e1b7148f111c","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        libvirt_driver.connector.disconnect_volume.assert_called_once_with("},{"line_number":260,"context_line":"            connection_info[\u0027data\u0027], None)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def test_libvirt_rbd_driver_block_config(self):"},{"line_number":263,"context_line":"        self.flags(rbd_block_device\u003dTrue, group\u003d\u0027workarounds\u0027)"},{"line_number":264,"context_line":"        connection_info \u003d self.rbd_connection(self.vol)"},{"line_number":265,"context_line":"        connection_info[\u0027data\u0027][\u0027device_path\u0027] \u003d \u0027/dev/rbd0\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_3413d70f","line":262,"in_reply_to":"df33271e_050ae088","updated":"2020-04-06 21:09:33.000000000","message":"Yes correct.","commit_id":"5d2d8fdc888804d3d5774ec5d6b1fc26e2ae1c49"}],"nova/virt/libvirt/volume/net.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"f7b0519d5bd5a6703b32515a8f45512a4264a023","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            # secret_type is always hard-coded to \u0027ceph\u0027 in cinder"},{"line_number":76,"context_line":"            conf.auth_secret_type \u003d netdisk_properties[\u0027secret_type\u0027]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _is_rbd_block_device(self, connection_info):"},{"line_number":79,"context_line":"        return (connection_info[\u0027driver_volume_type\u0027] \u003d\u003d \u0027rbd\u0027 and"},{"line_number":80,"context_line":"            CONF.workarounds.rbd_block_device)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_c51758ed","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":28},"updated":"2020-04-06 19:10:09.000000000","message":"Again with the naming - wouldn\u0027t _is_rbd_host_blockdev() be clearer?","commit_id":"5d2d8fdc888804d3d5774ec5d6b1fc26e2ae1c49"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"f7b0519d5bd5a6703b32515a8f45512a4264a023","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            # secret_type is always hard-coded to \u0027ceph\u0027 in cinder"},{"line_number":76,"context_line":"            conf.auth_secret_type \u003d netdisk_properties[\u0027secret_type\u0027]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _is_rbd_block_device(self, connection_info):"},{"line_number":79,"context_line":"        return (connection_info[\u0027driver_volume_type\u0027] \u003d\u003d \u0027rbd\u0027 and"},{"line_number":80,"context_line":"            CONF.workarounds.rbd_block_device)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_e51a5c15","line":78,"updated":"2020-04-06 19:10:09.000000000","message":"This is technically missing using test coverage for non-RBD and non-workaround cases.","commit_id":"5d2d8fdc888804d3d5774ec5d6b1fc26e2ae1c49"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"8f3a0ca8bbb38462921ab165181248e70d0c897d","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            # secret_type is always hard-coded to \u0027ceph\u0027 in cinder"},{"line_number":76,"context_line":"            conf.auth_secret_type \u003d netdisk_properties[\u0027secret_type\u0027]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _is_rbd_block_device(self, connection_info):"},{"line_number":79,"context_line":"        return (connection_info[\u0027driver_volume_type\u0027] \u003d\u003d \u0027rbd\u0027 and"},{"line_number":80,"context_line":"            CONF.workarounds.rbd_block_device)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_60347a4b","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":28},"in_reply_to":"df33271e_05f4a05a","updated":"2020-04-06 20:00:53.000000000","message":"I like rbd_host_mount :)","commit_id":"5d2d8fdc888804d3d5774ec5d6b1fc26e2ae1c49"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0ac683b9870a444c245d9157c0c7e1b7148f111c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            # secret_type is always hard-coded to \u0027ceph\u0027 in cinder"},{"line_number":76,"context_line":"            conf.auth_secret_type \u003d netdisk_properties[\u0027secret_type\u0027]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _is_rbd_block_device(self, connection_info):"},{"line_number":79,"context_line":"        return (connection_info[\u0027driver_volume_type\u0027] \u003d\u003d \u0027rbd\u0027 and"},{"line_number":80,"context_line":"            CONF.workarounds.rbd_block_device)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_f4d68f27","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":28},"in_reply_to":"df33271e_60347a4b","updated":"2020-04-06 21:09:33.000000000","message":"I\u0027m going with _use_rbd_volume_local_attach to stick close to the os-brick verbiage.","commit_id":"5d2d8fdc888804d3d5774ec5d6b1fc26e2ae1c49"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5bae7973e883fdb70e90ee2b285c4d5962f829d9","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            # secret_type is always hard-coded to \u0027ceph\u0027 in cinder"},{"line_number":76,"context_line":"            conf.auth_secret_type \u003d netdisk_properties[\u0027secret_type\u0027]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _is_rbd_block_device(self, connection_info):"},{"line_number":79,"context_line":"        return (connection_info[\u0027driver_volume_type\u0027] \u003d\u003d \u0027rbd\u0027 and"},{"line_number":80,"context_line":"            CONF.workarounds.rbd_block_device)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_05f4a05a","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":28},"in_reply_to":"df33271e_c51758ed","updated":"2020-04-06 19:15:39.000000000","message":"i dont think so\ni have an issue with the useage of \"is\" and this does not help with that\n\ni would prefer somethng like _use_rbd_host_mount","commit_id":"5d2d8fdc888804d3d5774ec5d6b1fc26e2ae1c49"}],"releasenotes/notes/workarounds-libvirt-rbd-host-block-devices-ca5e3c187342ab4d.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5bae7973e883fdb70e90ee2b285c4d5962f829d9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    This workaround is temporary and will be removed during the W release once"},{"line_number":15,"context_line":"    all impacted distributions have been able to update their versions of the"},{"line_number":16,"context_line":"    libgcrypt library."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    .. warning:: Operators must ensure no instances are running on the compute"},{"line_number":19,"context_line":"      host before enabling this workaround. Any instances with attached RBD"},{"line_number":20,"context_line":"      volumes left running on the hosts will fail to migrate or stop after this"},{"line_number":21,"context_line":"      workaround has been enabled."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    .. __: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1762765"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df33271e_a554d455","line":21,"range":{"start_line":17,"start_character":0,"end_line":21,"end_character":34},"updated":"2020-04-06 19:15:39.000000000","message":"hopefully that will be enough to discurage peole form abusing this to make caching via opencas work.","commit_id":"5d2d8fdc888804d3d5774ec5d6b1fc26e2ae1c49"}]}