)]}'
{"nova/conf/workarounds.py":[{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"6376d8834fad21d3e9d3439099824f5ba5762fba","unresolved":false,"context_lines":[{"line_number":289,"context_line":"Enabling this option will cause Nova to use the legacy dm-crypt based os-brick"},{"line_number":290,"context_line":"encryptor to decrypt the LUKSv1 volume."},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"Note that enabling this option while using volumes that do not provide a host"},{"line_number":293,"context_line":"block device such as RBD will result in a failure to boot from or attach the"},{"line_number":294,"context_line":"volume to an instance."},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_419bde16","line":293,"range":{"start_line":292,"start_character":0,"end_line":293,"end_character":24},"updated":"2020-03-06 10:14:51.000000000","message":"Should think link to a page that shows how to attach a host block device with \"--block-device\"?  Or is that expected knowledge of those who\u0027ll be using this option? :-)","commit_id":"7963b3befdb61ad78df478880de55e58cb9ce7bb"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"e3628941706481fab8cdc25a6f878ebf0ca4166c","unresolved":false,"context_lines":[{"line_number":289,"context_line":"Enabling this option will cause Nova to use the legacy dm-crypt based os-brick"},{"line_number":290,"context_line":"encryptor to decrypt the LUKSv1 volume."},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"Note that enabling this option while using volumes that do not provide a host"},{"line_number":293,"context_line":"block device such as RBD will result in a failure to boot from or attach the"},{"line_number":294,"context_line":"volume to an instance."},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_2f0809d8","line":293,"range":{"start_line":292,"start_character":0,"end_line":293,"end_character":24},"in_reply_to":"1fa4df85_419bde16","updated":"2020-03-06 11:14:49.000000000","message":"That\u0027s defined within os-brick and isn\u0027t something operators would interact with manually.\n\n--block-device-mapping controls the devices presented to the instance and not the host.\n\nI turn this into a ::note and expand the point slightly, making it clear that it\u0027s dependent on the cinder-volume backend being used and how n-cpu \u0026 os-brick then wire up connections to the backend.","commit_id":"7963b3befdb61ad78df478880de55e58cb9ce7bb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3a76d0162135571214c432ad43e4bdc44abc729a","unresolved":false,"context_lines":[{"line_number":289,"context_line":"Enabling this option will cause Nova to use the legacy dm-crypt based os-brick"},{"line_number":290,"context_line":"encryptor to decrypt the LUKSv1 volume."},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"Note that enabling this option while using volumes that do not provide a host"},{"line_number":293,"context_line":"block device such as RBD will result in a failure to boot from or attach the"},{"line_number":294,"context_line":"volume to an instance."},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"Related options:"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_856f1091","line":294,"range":{"start_line":292,"start_character":0,"end_line":294,"end_character":22},"updated":"2020-04-06 19:06:13.000000000","message":"does this option apply to cinder volumes only or will it affect the rbd image backend.\n\nwe only support encypted volumes with cinder right so if we are using the rbd iamge backend and our cider is provdied by say lvm over iscsi we shoudl be able to set this to true","commit_id":"ee4f6b62841b0e9d0108fdde09dd29b3b312bde8"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1a7979706d97b1665cf261d4c60b3a4e46cb2a08","unresolved":false,"context_lines":[{"line_number":289,"context_line":"Enabling this option will cause Nova to use the legacy dm-crypt based os-brick"},{"line_number":290,"context_line":"encryptor to decrypt the LUKSv1 volume."},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"Note that enabling this option while using volumes that do not provide a host"},{"line_number":293,"context_line":"block device such as RBD will result in a failure to boot from or attach the"},{"line_number":294,"context_line":"volume to an instance."},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"Related options:"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_409df657","line":294,"range":{"start_line":292,"start_character":0,"end_line":294,"end_character":22},"in_reply_to":"df33271e_856f1091","updated":"2020-04-06 21:09:37.000000000","message":"Yes this only impacts LUKSv1 encrypted cinder volumes.\n\nWe don\u0027t support LUKS encryption with the imagebackend, only plain/dm-crypt encryption with the LVM imagebackend.","commit_id":"ee4f6b62841b0e9d0108fdde09dd29b3b312bde8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f9cbac30a226ec8c45e2933dd1a07025ba95086e","unresolved":false,"context_lines":[{"line_number":271,"context_line":"* ``compute_driver`` (libvirt)"},{"line_number":272,"context_line":"* ``[libvirt]/images_type`` (rbd)"},{"line_number":273,"context_line":"\"\"\"),"},{"line_number":274,"context_line":"    cfg.BoolOpt("},{"line_number":275,"context_line":"        \u0027disable_native_luksv1\u0027,"},{"line_number":276,"context_line":"        default\u003dFalse,"},{"line_number":277,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"df33271e_62074f1e","line":274,"updated":"2020-04-07 12:54:02.000000000","message":"Could you add a TODO here to remove this in the W release, ideally noting either the libgcrypt version or patch that is necessary in distros?","commit_id":"dbb58e964ad1821e96f3e6758b3add747339d052"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"b2af7e0c4871f22e2b7e3042a1b5a756badb55cc","unresolved":false,"context_lines":[{"line_number":9667,"context_line":"        mock_find_secret.assert_called_once_with(\u0027volume\u0027, uuids.volume_id)"},{"line_number":9668,"context_line":"        mock_get_encryptor.assert_not_called()"},{"line_number":9669,"context_line":""},{"line_number":9670,"context_line":"    def test_is_luks_v1(self):"},{"line_number":9671,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":9672,"context_line":"        self.assertFalse(drvr._is_luks_v1({}))"},{"line_number":9673,"context_line":"        self.assertFalse(drvr._is_luks_v1({"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_1f3936f1","line":9670,"updated":"2020-03-30 13:03:45.000000000","message":"Shouldn\u0027t the unit test for your new code live here instead?","commit_id":"d5966f83b61fbdc99537729e1883163d3a52d1d5"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"936a4d84b255f062547bd6d9226b7e3132d8b7f1","unresolved":false,"context_lines":[{"line_number":9667,"context_line":"        mock_find_secret.assert_called_once_with(\u0027volume\u0027, uuids.volume_id)"},{"line_number":9668,"context_line":"        mock_get_encryptor.assert_not_called()"},{"line_number":9669,"context_line":""},{"line_number":9670,"context_line":"    def test_is_luks_v1(self):"},{"line_number":9671,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":9672,"context_line":"        self.assertFalse(drvr._is_luks_v1({}))"},{"line_number":9673,"context_line":"        self.assertFalse(drvr._is_luks_v1({"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_ab494b33","line":9670,"in_reply_to":"df33271e_1f3936f1","updated":"2020-04-06 15:04:02.000000000","message":"The above tests will already hit this but I\u0027ll add some explicit tests in here for the workaround.","commit_id":"d5966f83b61fbdc99537729e1883163d3a52d1d5"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"681aa60307d4bb621cafcc20084507cbcd97eb63","unresolved":false,"context_lines":[{"line_number":9667,"context_line":"        mock_find_secret.assert_called_once_with(\u0027volume\u0027, uuids.volume_id)"},{"line_number":9668,"context_line":"        mock_get_encryptor.assert_not_called()"},{"line_number":9669,"context_line":""},{"line_number":9670,"context_line":"    def test_is_luks_v1(self):"},{"line_number":9671,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":9672,"context_line":"        self.assertFalse(drvr._is_luks_v1({}))"},{"line_number":9673,"context_line":"        self.assertFalse(drvr._is_luks_v1({"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_0551400f","line":9670,"in_reply_to":"df33271e_ab494b33","updated":"2020-04-06 18:50:25.000000000","message":"Right, I wasn\u0027t disputing coverage, I was suggesting that unit testing your new addition to _is_luks_v1() should be done here, and not in tests for other methods that eventually call down to _is_luks_v1(). As I said, soft -1 :) And yes, I know that our definition of \"unit tests\" in Nova has a very... elastic scope.","commit_id":"d5966f83b61fbdc99537729e1883163d3a52d1d5"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"681aa60307d4bb621cafcc20084507cbcd97eb63","unresolved":false,"context_lines":[{"line_number":9786,"context_line":"        self.assertTrue(drvr._is_luks_v1({"},{"line_number":9787,"context_line":"            \u0027provider\u0027: \u0027LuksEncryptor\u0027}))"},{"line_number":9788,"context_line":"        self.assertTrue(drvr._is_luks_v1({"},{"line_number":9789,"context_line":"            \u0027provider\u0027: encryptors.LUKS}))"},{"line_number":9790,"context_line":""},{"line_number":9791,"context_line":"        # Assert the disable_qemu_native_luksv workaround always returns False"},{"line_number":9792,"context_line":"        self.flags(disable_qemu_native_luksv1\u003dTrue, group\u003d\u0027workarounds\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_656f6cc5","line":9789,"updated":"2020-04-06 18:50:25.000000000","message":"Thanks :)","commit_id":"ee4f6b62841b0e9d0108fdde09dd29b3b312bde8"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"b2af7e0c4871f22e2b7e3042a1b5a756badb55cc","unresolved":false,"context_lines":[{"line_number":1588,"context_line":"        # workarounds configurable in order to aviod known performance issues"},{"line_number":1589,"context_line":"        # with the libgcrypt lib."},{"line_number":1590,"context_line":"        return (provider \u003d\u003d encryptors.LUKS and"},{"line_number":1591,"context_line":"                not CONF.workarounds.disable_qemu_native_luksv1)"},{"line_number":1592,"context_line":""},{"line_number":1593,"context_line":"    def _get_volume_config(self, connection_info, disk_info):"},{"line_number":1594,"context_line":"        vol_driver \u003d self._get_volume_driver(connection_info)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_3f751acc","line":1591,"updated":"2020-03-30 13:03:45.000000000","message":"I don\u0027t have the context to judge whether this is sufficient to fall back on legacy dm-crypt.","commit_id":"d5966f83b61fbdc99537729e1883163d3a52d1d5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5f69e6446af9592fcfbc6c1300cdcec3c4ff07ae","unresolved":false,"context_lines":[{"line_number":1588,"context_line":"        # workarounds configurable in order to aviod known performance issues"},{"line_number":1589,"context_line":"        # with the libgcrypt lib."},{"line_number":1590,"context_line":"        return (provider \u003d\u003d encryptors.LUKS and"},{"line_number":1591,"context_line":"                not CONF.workarounds.disable_qemu_native_luksv1)"},{"line_number":1592,"context_line":""},{"line_number":1593,"context_line":"    def _get_volume_config(self, connection_info, disk_info):"},{"line_number":1594,"context_line":"        vol_driver \u003d self._get_volume_driver(connection_info)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_f3000a04","line":1591,"in_reply_to":"df33271e_3f751acc","updated":"2020-03-30 14:55:02.000000000","message":"it probably would have been clearer to have the below at the top of this function:\n\n  if CONF.workarounds.disable_qemu_native_luksv1:\n      return False","commit_id":"d5966f83b61fbdc99537729e1883163d3a52d1d5"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"936a4d84b255f062547bd6d9226b7e3132d8b7f1","unresolved":false,"context_lines":[{"line_number":1588,"context_line":"        # workarounds configurable in order to aviod known performance issues"},{"line_number":1589,"context_line":"        # with the libgcrypt lib."},{"line_number":1590,"context_line":"        return (provider \u003d\u003d encryptors.LUKS and"},{"line_number":1591,"context_line":"                not CONF.workarounds.disable_qemu_native_luksv1)"},{"line_number":1592,"context_line":""},{"line_number":1593,"context_line":"    def _get_volume_config(self, connection_info, disk_info):"},{"line_number":1594,"context_line":"        vol_driver \u003d self._get_volume_driver(connection_info)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_cb312fef","line":1591,"in_reply_to":"df33271e_f3000a04","updated":"2020-04-06 15:04:02.000000000","message":"Done","commit_id":"d5966f83b61fbdc99537729e1883163d3a52d1d5"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"681aa60307d4bb621cafcc20084507cbcd97eb63","unresolved":false,"context_lines":[{"line_number":1574,"context_line":"    def _is_luks_v1(self, encryption\u003dNone):"},{"line_number":1575,"context_line":"        \"\"\"Check if LUKS (v1) is the encryption \u0027provider\u0027"},{"line_number":1576,"context_line":"        \"\"\""},{"line_number":1577,"context_line":"        # NOTE(lyarwood): Allow native LUKSv1 decryption to be disabled via a"},{"line_number":1578,"context_line":"        # workarounds configurable in order to aviod known performance issues"},{"line_number":1579,"context_line":"        # with the libgcrypt lib."},{"line_number":1580,"context_line":"        if CONF.workarounds.disable_qemu_native_luksv1:"}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_2583a458","line":1577,"updated":"2020-04-06 18:50:25.000000000","message":"As before, I lack the knowledge of this area of the code to judge whether it will do what we want (fall back to dm-crypt).","commit_id":"ee4f6b62841b0e9d0108fdde09dd29b3b312bde8"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1a7979706d97b1665cf261d4c60b3a4e46cb2a08","unresolved":false,"context_lines":[{"line_number":1574,"context_line":"    def _is_luks_v1(self, encryption\u003dNone):"},{"line_number":1575,"context_line":"        \"\"\"Check if LUKS (v1) is the encryption \u0027provider\u0027"},{"line_number":1576,"context_line":"        \"\"\""},{"line_number":1577,"context_line":"        # NOTE(lyarwood): Allow native LUKSv1 decryption to be disabled via a"},{"line_number":1578,"context_line":"        # workarounds configurable in order to aviod known performance issues"},{"line_number":1579,"context_line":"        # with the libgcrypt lib."},{"line_number":1580,"context_line":"        if CONF.workarounds.disable_qemu_native_luksv1:"}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_00bc8eb9","line":1577,"in_reply_to":"df33271e_2583a458","updated":"2020-04-06 21:09:37.000000000","message":"See _attach_encryptor below for that.","commit_id":"ee4f6b62841b0e9d0108fdde09dd29b3b312bde8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3a76d0162135571214c432ad43e4bdc44abc729a","unresolved":false,"context_lines":[{"line_number":1574,"context_line":"    def _is_luks_v1(self, encryption\u003dNone):"},{"line_number":1575,"context_line":"        \"\"\"Check if LUKS (v1) is the encryption \u0027provider\u0027"},{"line_number":1576,"context_line":"        \"\"\""},{"line_number":1577,"context_line":"        # NOTE(lyarwood): Allow native LUKSv1 decryption to be disabled via a"},{"line_number":1578,"context_line":"        # workarounds configurable in order to aviod known performance issues"},{"line_number":1579,"context_line":"        # with the libgcrypt lib."},{"line_number":1580,"context_line":"        if CONF.workarounds.disable_qemu_native_luksv1:"}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_a5f7b4d4","line":1577,"in_reply_to":"df33271e_2583a458","updated":"2020-04-06 19:06:13.000000000","message":"ya without the note this would seam wrong to me based on the fucntion name.\n\nbecause it stilll is luks_v1 but we shoudl not use the luks_v1 native supprot so i would prefer if you renamed the function from \n\n   def _is_luks_v1(self, encryption\u003dNone):\n\nto \n   def _use_luks_v1(self, encryption\u003dNone):\nor\n   def _use_luks_v1_decryptor(self, encryption\u003dNone):","commit_id":"ee4f6b62841b0e9d0108fdde09dd29b3b312bde8"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1a7979706d97b1665cf261d4c60b3a4e46cb2a08","unresolved":false,"context_lines":[{"line_number":1574,"context_line":"    def _is_luks_v1(self, encryption\u003dNone):"},{"line_number":1575,"context_line":"        \"\"\"Check if LUKS (v1) is the encryption \u0027provider\u0027"},{"line_number":1576,"context_line":"        \"\"\""},{"line_number":1577,"context_line":"        # NOTE(lyarwood): Allow native LUKSv1 decryption to be disabled via a"},{"line_number":1578,"context_line":"        # workarounds configurable in order to aviod known performance issues"},{"line_number":1579,"context_line":"        # with the libgcrypt lib."},{"line_number":1580,"context_line":"        if CONF.workarounds.disable_qemu_native_luksv1:"}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_c0a8e678","line":1577,"in_reply_to":"df33271e_a5f7b4d4","updated":"2020-04-06 21:09:37.000000000","message":"I\u0027ll rename it to _allow_native_luksv1_decryption","commit_id":"ee4f6b62841b0e9d0108fdde09dd29b3b312bde8"}],"releasenotes/notes/workarounds-libvirt-disable-native-luks-a4eccca8019db243.yaml":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4da1803412dc68e85f0b5d3e2e4c694d58af8813","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    .. warning:: Operators must ensure no instances are running on the compute"},{"line_number":18,"context_line":"      host before enabling this workaround. Any instances with encrypted LUKSv1"},{"line_number":19,"context_line":"      disks left running on the hosts will fail to migrate or stop after this"},{"line_number":20,"context_line":"      workaround has been enabled."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    .. _libgcrypt library: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1762765"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1fa4df85_d2962895","line":20,"updated":"2020-03-17 09:40:52.000000000","message":"This is scary but I guess if this happen operator can remove the config change, migrate the serves and then apply the config change again.","commit_id":"3eda0b42e859ab8213de0b180cbf9c09463eced7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dc02f655a7da7d46aec3778fa2f0ab3b5b4a13b6","unresolved":false,"context_lines":[{"line_number":19,"context_line":"      disks left running on the hosts will fail to migrate or stop after this"},{"line_number":20,"context_line":"      workaround has been enabled."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    .. _libgcrypt library: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1762765"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1fa4df85_9c3974d8","line":22,"range":{"start_line":22,"start_character":7,"end_line":22,"end_character":25},"updated":"2020-03-19 15:43:18.000000000","message":"nit: Can you use anonymous refs instead? This minimises the chances of conflicts later.\n\n  .. __: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1762765","commit_id":"3eda0b42e859ab8213de0b180cbf9c09463eced7"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"936a4d84b255f062547bd6d9226b7e3132d8b7f1","unresolved":false,"context_lines":[{"line_number":19,"context_line":"      disks left running on the hosts will fail to migrate or stop after this"},{"line_number":20,"context_line":"      workaround has been enabled."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    .. _libgcrypt library: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1762765"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df33271e_b6407037","line":22,"range":{"start_line":22,"start_character":7,"end_line":22,"end_character":25},"in_reply_to":"1fa4df85_9c3974d8","updated":"2020-04-06 15:04:02.000000000","message":"Done","commit_id":"3eda0b42e859ab8213de0b180cbf9c09463eced7"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"b2af7e0c4871f22e2b7e3042a1b5a756badb55cc","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    all impacted distributions have been able to update their versions of the"},{"line_number":19,"context_line":"    libgcrypt library."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    .. warning:: Operators must ensure no instances are running on the compute"},{"line_number":22,"context_line":"      host before enabling this workaround. Any instances with encrypted LUKSv1"},{"line_number":23,"context_line":"      disks left running on the hosts will fail to migrate or stop after this"},{"line_number":24,"context_line":"      workaround has been enabled."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df33271e_9fd545e8","line":21,"updated":"2020-03-30 13:03:45.000000000","message":"nit: I\u0027d maybe move this up a para or two, to make it abundantly clear that it applies to this workaround.","commit_id":"d5966f83b61fbdc99537729e1883163d3a52d1d5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3a76d0162135571214c432ad43e4bdc44abc729a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    option will result in the use of the legacy ``dm-crypt`` based os-brick"},{"line_number":9,"context_line":"    provided encryptors."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    Operators should be aware that this workaround only applies when using the"},{"line_number":12,"context_line":"    libvirt compute driver with attached encrypted volumes using the ``luks``"},{"line_number":13,"context_line":"    encryption provider. The ``luks2`` encryption provider will continue to use"},{"line_number":14,"context_line":"    the ``dm-crypt`` based os-brick encryptors regardless of what this"},{"line_number":15,"context_line":"    configurable is set to."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    This workaround is temporary and will be removed during the W release once"},{"line_number":18,"context_line":"    all impacted distributions have been able to update their versions of the"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df33271e_2505647b","line":15,"range":{"start_line":11,"start_character":4,"end_line":15,"end_character":27},"updated":"2020-04-06 19:06:13.000000000","message":"again as someone who is only vaguely familiar with this part of the code i assume this is specificly for cinder volumes and not also affecting the rbd image backend as i dont think we can have encrypted ephermeral volumes correct.\n\nit might be nice to make the supprot clear but i was also wondering if this affected the lvm image backend which shas basic luks encryption so if you respin can you clarify.","commit_id":"ee4f6b62841b0e9d0108fdde09dd29b3b312bde8"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1a7979706d97b1665cf261d4c60b3a4e46cb2a08","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    option will result in the use of the legacy ``dm-crypt`` based os-brick"},{"line_number":9,"context_line":"    provided encryptors."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    Operators should be aware that this workaround only applies when using the"},{"line_number":12,"context_line":"    libvirt compute driver with attached encrypted volumes using the ``luks``"},{"line_number":13,"context_line":"    encryption provider. The ``luks2`` encryption provider will continue to use"},{"line_number":14,"context_line":"    the ``dm-crypt`` based os-brick encryptors regardless of what this"},{"line_number":15,"context_line":"    configurable is set to."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    This workaround is temporary and will be removed during the W release once"},{"line_number":18,"context_line":"    all impacted distributions have been able to update their versions of the"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df33271e_40eb36af","line":15,"range":{"start_line":11,"start_character":4,"end_line":15,"end_character":27},"in_reply_to":"df33271e_2505647b","updated":"2020-04-06 21:09:37.000000000","message":"There\u0027s no support in the imagebackend for LUKS, the LVM imagebackend on supports plain/dm-crypt based disks and isn\u0027t impacted by this workaround. I\u0027ll spell that out in a respin.","commit_id":"ee4f6b62841b0e9d0108fdde09dd29b3b312bde8"}]}