)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bb7170fcc9590a9f0acf8bf3539ddb6366306560","unresolved":false,"context_lines":[{"line_number":15,"context_line":"oslotest, probably, among others)."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"We wouldn\u0027t bother, except the mock library has broken the world as of"},{"line_number":18,"context_line":"4.0.1 (possibly earlier)."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"TODO(efried): Identify upstream and/or nova bug."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_ba64eeb5","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":25},"updated":"2020-02-17 22:04:07.000000000","message":"confirmed 4.0.0 is broke too.","commit_id":"a816be5828eb4317344b1453ee9c27de0866900e"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ca2a4a2d8f2353b23b3c9a3c384a4df1eba5fc32","unresolved":false,"context_lines":[{"line_number":17,"context_line":"We wouldn\u0027t bother, except the mock library has broken the world as of"},{"line_number":18,"context_line":"4.0.1 (possibly earlier)."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"TODO(efried): Identify upstream and/or nova bug."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ib44b5bff657c8e76c4f701e14d51a4efda3f6d32"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_fa41060b","line":20,"range":{"start_line":20,"start_character":23,"end_line":20,"end_character":31},"updated":"2020-02-17 22:03:48.000000000","message":"https://github.com/testing-cabal/mock/issues/487","commit_id":"a816be5828eb4317344b1453ee9c27de0866900e"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ca2a4a2d8f2353b23b3c9a3c384a4df1eba5fc32","unresolved":false,"context_lines":[{"line_number":18,"context_line":"4.0.1 (possibly earlier)."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"TODO(efried): Identify upstream and/or nova bug."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ib44b5bff657c8e76c4f701e14d51a4efda3f6d32"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_5a561ad0","line":21,"updated":"2020-02-17 22:03:48.000000000","message":"Would also need to reorder imports everywhere, as this will fail pep8.","commit_id":"a816be5828eb4317344b1453ee9c27de0866900e"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c024fb824a16bce7a30a3ba9f9779f8e0f9d1144","unresolved":false,"context_lines":[{"line_number":8916,"context_line":"                xml \u003d \"\"\"\u003cdisk type\u003d\"file\" device\u003d\"disk\"\u003e"},{"line_number":8917,"context_line":"                            \u003csource file\u003d\"/path/to/fake-volume\"/\u003e"},{"line_number":8918,"context_line":"                            \u003ctarget bus\u003d\"virtio\" dev\u003d\"vdc\"/\u003e"},{"line_number":8919,"context_line":"                         \u003c/disk\u003e\"\"\""},{"line_number":8920,"context_line":"                self.assertXmlEqual(xml, call[1][0])"},{"line_number":8921,"context_line":"                self.assertEqual({\"flags\": flags}, call[2])"},{"line_number":8922,"context_line":"                mock_disconnect_volume.assert_called_with("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_fa3d588d","line":8919,"updated":"2020-02-19 23:45:21.000000000","message":"Note to reviewers: The convenience .args and .kwargs properties were added to _Call in py38 and were thus available when we were using mock-the-library since that tracks against $recent python. Until we require py38 at a minimum, we have to go back to this older style of accessing the args/kwargs.","commit_id":"a2504b16979904663526dcb2bf984733a0797bee"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c024fb824a16bce7a30a3ba9f9779f8e0f9d1144","unresolved":false,"context_lines":[{"line_number":15612,"context_line":"        ]"},{"line_number":15613,"context_line":""},{"line_number":15614,"context_line":"        self.assertEqual(2, mock_detachDeviceFlags.call_count)"},{"line_number":15615,"context_line":"        for index, call in enumerate(mock_detachDeviceFlags.mock_calls):"},{"line_number":15616,"context_line":"            self.assertXmlEqual(expected_xml[index], call[1][0])"},{"line_number":15617,"context_line":"            self.assertEqual({\"flags\": 1}, call[2])"},{"line_number":15618,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_9a42240e","line":15615,"updated":"2020-02-19 23:45:21.000000000","message":"ditto","commit_id":"a2504b16979904663526dcb2bf984733a0797bee"}]}