)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"431b75c026fdd030ae011eaffff0c83dedc8e52a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since we dropped support for python 2 [1], we no longer need to use the"},{"line_number":10,"context_line":"mock library, which existed to backport py3 functionality into py2."},{"line_number":11,"context_line":"Change Ib44b5bff657c8e76c4f701e14d51a4efda3f6d32 cut over to importing"},{"line_number":12,"context_line":"the stock mock, which must be done by saying::"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    from unittest import mock"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf51134e_23ec43c6","line":11,"range":{"start_line":11,"start_character":7,"end_line":11,"end_character":48},"updated":"2020-06-17 12:52:15.000000000","message":"This should be Id5b04cf2f6ca24af8e366d23f15cf0e5cac8e1cc now","commit_id":"860e0dd951f2745f7e53a7e04bd8a03f2ff741b9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b9638a44dc4f601b1a88f42e0e684b09000e5859","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c80c5ad6_f8535abe","updated":"2022-07-26 20:41:20.000000000","message":"py3.10 failz look to be legit. Found a related fix elsewhere [1]. Haven\u0027t dug into what it would take to make it work here.\n\n[1] https://review.opendev.org/c/openstack/networking-hyperv/+/839755","commit_id":"0cc6c57313a45e31cc569d00dceefabb9c613507"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"31e3989c181db277b2e30a75026400d9ce328d64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7360ee5e_c026c95c","updated":"2022-07-26 19:15:45.000000000","message":"this is a change that only affect devleopers so i dont think we should have a release note for this so im happy with this","commit_id":"0cc6c57313a45e31cc569d00dceefabb9c613507"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"93b5fe944595407d5ea383ad47c6224909d8c98b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a81dcc76_c32ca547","updated":"2022-07-27 09:38:37.000000000","message":"we probably want to fix the py310 error before we land this. But that fix needs to happen earlier in the series.","commit_id":"0cc6c57313a45e31cc569d00dceefabb9c613507"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bce51be2f401cf17721f001060e59f7f46f82a57","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"04041961_aafd092d","in_reply_to":"6ac010b5_4cc16d17","updated":"2022-08-01 15:05:10.000000000","message":"fixed in https://review.opendev.org/c/openstack/nova/+/851445","commit_id":"0cc6c57313a45e31cc569d00dceefabb9c613507"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"93b5fe944595407d5ea383ad47c6224909d8c98b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6ac010b5_4cc16d17","in_reply_to":"c80c5ad6_f8535abe","updated":"2022-07-27 09:38:37.000000000","message":"/o\\ I believe we have many double mocks. Like in case a fixture mocks a dep generically in the setup of a base test class, and a test case wants to change behavior of the dep an re-mocks it. This will be fun to fix.","commit_id":"0cc6c57313a45e31cc569d00dceefabb9c613507"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1fe3a76e81321721705034b443e9ac7c53f8bbcf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"147bb038_120e5a8e","updated":"2022-08-02 17:50:17.000000000","message":"reading +w since parents are now approved","commit_id":"c36782a96a96ecfc35f8af750c29741c769ed515"}],"nova/tests/unit/test_hacking.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b2ee3f38957bed6f26ab525a8281334b5226d150","unresolved":false,"context_lines":[{"line_number":1017,"context_line":"            filename\u003d\"nova/tests/unit/test_context.py\")"},{"line_number":1018,"context_line":""},{"line_number":1019,"context_line":""},{"line_number":1020,"context_line":"    def test_import_stock_mock(self):"},{"line_number":1021,"context_line":"        self._assert_has_errors("},{"line_number":1022,"context_line":"            \"import mock\","},{"line_number":1023,"context_line":"            checks.import_stock_mock, expected_errors\u003d[(1, 0, \u0027N366\u0027)])"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_2bed89b6","line":1020,"updated":"2020-04-02 10:23:36.000000000","message":"pep8: E303 too many blank lines (2)","commit_id":"d6c41ddabebda75a3305de47ed35f6c70ad209f5"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"67e15cfc2d89a3b155fce8f964ed0ccad2ec6e45","unresolved":false,"context_lines":[{"line_number":1017,"context_line":"            filename\u003d\"nova/tests/unit/test_context.py\")"},{"line_number":1018,"context_line":""},{"line_number":1019,"context_line":""},{"line_number":1020,"context_line":"    def test_import_stock_mock(self):"},{"line_number":1021,"context_line":"        self._assert_has_errors("},{"line_number":1022,"context_line":"            \"import mock\","},{"line_number":1023,"context_line":"            checks.import_stock_mock, expected_errors\u003d[(1, 0, \u0027N366\u0027)])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_e84d513b","line":1020,"updated":"2020-05-01 12:09:15.000000000","message":"pep8: E303 too many blank lines (2)","commit_id":"8f74899a9d3d1e9963c8e6cd0dad686fbfbb93ad"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"31e3989c181db277b2e30a75026400d9ce328d64","unresolved":true,"context_lines":[{"line_number":1042,"context_line":"                    from unittest import mock"},{"line_number":1043,"context_line":"                    import unittest.mock"},{"line_number":1044,"context_line":"               \"\"\""},{"line_number":1045,"context_line":"        self._assert_has_no_errors(code, checks.import_stock_mock)"}],"source_content_type":"text/x-python","patch_set":8,"id":"45f66592_fc4113bc","line":1045,"updated":"2022-07-26 19:15:45.000000000","message":"+1 nice and clear.\n\nit might have been nice to have this be 3 test sbut its short enough that im ok with one","commit_id":"0cc6c57313a45e31cc569d00dceefabb9c613507"}],"tox.ini":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"31e3989c181db277b2e30a75026400d9ce328d64","unresolved":true,"context_lines":[{"line_number":345,"context_line":"  N368 \u003d checks:do_not_use_mock_class_as_new_mock_value"},{"line_number":346,"context_line":"  N369 \u003d checks:check_lockutils_rwlocks"},{"line_number":347,"context_line":"  N370 \u003d checks:check_six"},{"line_number":348,"context_line":"  N371 \u003d checks:import_stock_mock"},{"line_number":349,"context_line":"paths \u003d"},{"line_number":350,"context_line":"  ./nova/hacking"},{"line_number":351,"context_line":""}],"source_content_type":"text/x-properties","patch_set":8,"id":"6fcbbbcb_6bcf1f86","line":348,"range":{"start_line":348,"start_character":0,"end_line":348,"end_character":6},"updated":"2022-07-26 19:15:45.000000000","message":"+1 i think the last time i reviewd a hacking change this was missing but that should enabled it.","commit_id":"0cc6c57313a45e31cc569d00dceefabb9c613507"}]}