)]}'
{"id":"openstack%2Fnova~709233","triplet_id":"openstack%2Fnova~master~I08b2a888b89e0329d9aa22b9ecbb901a2ee42145","project":"openstack/nova","branch":"master","topic":"bp/image-metadata-prefiltering","hashtags":[],"change_id":"I08b2a888b89e0329d9aa22b9ecbb901a2ee42145","subject":"Enforce os-traits/SUPPORTED_STORAGE_BUSES sync","status":"MERGED","created":"2020-02-21 20:25:20.000000000","updated":"2020-03-24 16:27:08.000000000","submitted":"2020-03-24 16:20:24.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"709233-1585066825454-61dee02a","meta_rev_id":"704efc3530d086caf934f22cb17d2934ce9229ab","_number":709233,"virtual_id_number":709233,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2020-02-21 21:46:35.000000000","_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"date":"2020-02-21 22:46:59.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2020-03-09 14:57:15.000000000","_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"date":"2020-03-17 13:07:29.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"date":"2020-02-25 10:23:35.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"date":"2020-02-21 20:49:42.000000000","_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-03-24 16:20:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":2,"date":"2020-02-27 16:46:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":2,"date":"2020-03-24 15:11:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":1,"date":"2020-03-24 15:11:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-21 20:49:42.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2020-02-21 21:46:35.000000000","updated_by":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-02-21 22:46:59.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2020-02-25 10:23:35.000000000","updated_by":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"reviewer":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"state":"REVIEWER"},{"updated":"2020-02-27 16:46:56.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2020-03-09 14:57:15.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2020-03-24 15:11:39.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2020-03-24 16:20:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"273b84697dac012318c6501261c756287ee018cc","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2020-02-21 20:25:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4e1e1a9dd6fe3cd73160beef5e2cb1f512835e3f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-21 20:48:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/0876ae777a054b6bb231350544663b08 : SUCCESS in 17m 00s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/93b0a592e1cc49cca541bc95bb4ec96f : SUCCESS in 15m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d6e3a600811e42bb83291b38bfc3872a : SUCCESS in 8m 13s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7ef1430de7034216b071a9569d81a218 : SUCCESS in 14m 02s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/83cd5dfc4a2540a4a07b0e5fd01ace32 : SUCCESS in 16m 31s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/7545d61cd242458a8ab63115f7dc8a3c : SUCCESS in 14m 53s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9fb4a61d3f124054a21bc4d956c716c6 : SUCCESS in 11m 45s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/2fcd911d6a214130802bdaefddc28f98 : SUCCESS in 15m 32s","accounts_in_message":[],"_revision_number":1},{"id":"d65fa38552f6e7b5f2fab11bed4b876b4b567571","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-02-21 20:49:42.000000000","message":"Patch Set 1:\n\nBuild SUCCESSFUL (check pipeline).\n\n- pmem-tempest-plugin-filtered http://52.27.155.124/33/709233/1/check/pmem-tempest-plugin-filtered/66b7f23/ : SUCCESS in 23m 05s","accounts_in_message":[],"_revision_number":1},{"id":"43f8fc78ad416fa2a2e2e6f3b5f613ee9ffc9c46","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2020-02-21 21:46:35.000000000","message":"Patch Set 1:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-33-709233-1 : SUCCESS \n\nhttps://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI","accounts_in_message":[],"_revision_number":1},{"id":"9bd7b4deea4847e4a4c571f9d7b7dcbaec8edf6f","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-02-21 22:46:59.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/709233/1 : SUCCESS in 2h 20m 18s","accounts_in_message":[],"_revision_number":1},{"id":"d0acd42356fc970b99bf8f7a2c58d2af832d97f6","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2020-02-25 10:23:35.000000000","message":"Patch Set 1:\n\nTesting completed on the zVM Driver CI system check-nova pipeline and failed.  To recheck only the zVM driver plugins, submit a comment with only  zvm: recheck in the comment.. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-41175 : FAILURE in 25m 35s","accounts_in_message":[],"_revision_number":1},{"id":"9e1ac198366b9fe875343d13c091e2e9d7c6a23d","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-02-27 16:46:56.000000000","message":"Patch Set 1: Code-Review+2\n\nSeems sane. Thanks for doing this","accounts_in_message":[],"_revision_number":1},{"id":"f7bf311c76e5c342b2f01423f6d70a34a10cd89c","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2020-03-09 14:57:15.000000000","message":"Patch Set 1:\n\ni actully dont think we should be doing this without changing the name but i wont -1 it either.\nif we are going to make this requirement i think we should revert this back to valid_traits not supproted tratits.\n\nmore testing is good but this defeats teh reason for renaming it from valid to supported in the first place.","accounts_in_message":[],"_revision_number":1},{"id":"d989c435f40e1cb45e6868c86bdfe55992a56491","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2020-03-17 12:01:40.000000000","message":"Patch Set 1:\n\n\u003e i actully dont think we should be doing this without changing the\n \u003e name but i wont -1 it either.\n \u003e if we are going to make this requirement i think we should revert\n \u003e this back to valid_traits not supproted tratits.\n \u003e \n \u003e more testing is good but this defeats teh reason for renaming it\n \u003e from valid to supported in the first place.\n\nDo I understand correctly that this patch would force us to support every new storage bus added to os-traits in libvirt driver?","accounts_in_message":[],"_revision_number":1},{"id":"ab6d8499773923a25c0a23e7699045ad68e81b16","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2020-03-17 12:01:57.000000000","message":"Patch Set 1: Code-Review-1\n\n-1 for visibility of my question above","accounts_in_message":[],"_revision_number":1},{"id":"fae52401adcb5b432987f06a076dbe2c45f9409f","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2020-03-17 13:05:41.000000000","message":"Patch Set 1:\n\n\u003e Do I understand correctly that this patch would force us to support every new storage \u003e bus added to os-traits in libvirt driver?\n\nNot “support”, but yes, that’s the exact purpose of this patch: to make sure that we don’t forget to do it on one side or the other, or misspell something.","accounts_in_message":[],"_revision_number":1},{"id":"3a4fafde21c54591db8cb2b70b62b02cfee57ecf","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2020-03-17 13:07:29.000000000","message":"Patch Set 1:\n\n\u003e think we should revert this back to valid_traits\n\nThat would be fine.","accounts_in_message":[],"_revision_number":1},{"id":"20ce20e8b25debad6a655d0a00d0b5410b90c601","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2020-03-24 15:11:39.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nMake sense now.","accounts_in_message":[],"_revision_number":1},{"id":"b1fd96cf5611800a6b33cab8ab6b6d3639c86558","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-24 15:12:12.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"a8b64c5ea110072aa24ab3c267f36aa2aa7fae9e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-24 16:20:24.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c4bdbd17863040499c07c7ba9866b426 : SUCCESS in 17m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5c473fb18f234b428f76d068d31a903f : SUCCESS in 9m 20s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a0716e9c06c24b3ebae2e3b5e8face81 : SUCCESS in 17m 44s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/0d2961ae94234f299c5d22ed73c023af : SUCCESS in 14m 34s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ad610b8b646741749b3546a265317c50 : SUCCESS in 13m 57s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/3e62c547fe8540bc9cbcc54877abdb1f : SUCCESS in 21m 04s","accounts_in_message":[],"_revision_number":1},{"id":"ef5edabe72aba03393cb284c940f8348df248c31","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-24 16:20:25.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"bcc9efb99368f8a026b05f6095da62be24834b9d","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-24 16:27:08.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d20efdf609414b5ab0ed2f0e81908eca : SUCCESS in 2m 09s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"80775adb5fa8cd8b30d87babe6738fcbeb8bb3c5","revisions":{"80775adb5fa8cd8b30d87babe6738fcbeb8bb3c5":{"kind":"REWORK","_number":1,"created":"2020-02-21 20:25:20.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/33/709233/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/33/709233/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/709233/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/709233/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/709233/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/33/709233/1"}}},"commit":{"parents":[{"commit":"633616258523be9acbf445dada245cb1bd0eaa9a","subject":"libvirt: Report storage bus traits","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/633616258523be9acbf445dada245cb1bd0eaa9a"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2020-02-21 20:17:12.000000000","tz":-360},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2020-02-21 20:17:12.000000000","tz":-360},"subject":"Enforce os-traits/SUPPORTED_STORAGE_BUSES sync","message":"Enforce os-traits/SUPPORTED_STORAGE_BUSES sync\n\nFollowing on from [1], beef up the unit test for libvirt\u0027s\n_get_storage_bus_traits helper to ensure that we\u0027re reporting all and\nonly the buses corresponding to os-traits COMPUTE_STORAGE_BUS_* traits.\nThis will force us to keep nova and os-traits in sync:\n\n- If we add a new COMPUTE_STORAGE_BUS_* trait without adding it to nova,\n  this test will fail in the py* tox job.\n- If we add a new COMPUTE_STORAGE_BUS_* trait and add its corresponding\n  bus name in nova but forget to bump our os-traits minimum, the test\n  will fail in the lower-constraints job.\n\nAnd for completeness:\n\n- If we add a new bus name without adding a corresponding trait, the\n  test will fail (this was true before this commit as well).\n\n[1] https://review.opendev.org/#/c/666914/20/nova/tests/unit/virt/libvirt/test_driver.py@23087\n\nChange-Id: I08b2a888b89e0329d9aa22b9ecbb901a2ee42145\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/80775adb5fa8cd8b30d87babe6738fcbeb8bb3c5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/80775adb5fa8cd8b30d87babe6738fcbeb8bb3c5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}