)]}'
{"nova/api/openstack/compute/volumes.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6f92ebbef1b3c4b567f3fd32175ab5734043e754","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":399,"context_line":"        instance \u003d common.get_instance(self.compute_api, context, server_id)"},{"line_number":400,"context_line":"        context.can(va_policies.POLICY_ROOT % \u0027update\u0027,"},{"line_number":401,"context_line":"                    target\u003d{\u0027project_id\u0027: instance.project_id})"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        old_volume_id \u003d id"},{"line_number":404,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_2af23570","line":401,"range":{"start_line":401,"start_character":20,"end_line":401,"end_character":62},"updated":"2020-04-07 17:01:32.000000000","message":"I don\u0027t think we should have done this one since the \u0027os_compute_api:os-volumes-attachments:update\u0027 policy defaults to \u0027SYSTEM_ADMIN\u0027, right?","commit_id":"763d220504d1e1ef01231bdfbe0f390d28d850b7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0e8cea42d54274440f4b1716d38669b3c4339298","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":399,"context_line":"        instance \u003d common.get_instance(self.compute_api, context, server_id)"},{"line_number":400,"context_line":"        context.can(va_policies.POLICY_ROOT % \u0027update\u0027,"},{"line_number":401,"context_line":"                    target\u003d{\u0027project_id\u0027: instance.project_id})"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        old_volume_id \u003d id"},{"line_number":404,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_6a3d5ddc","line":401,"range":{"start_line":401,"start_character":20,"end_line":401,"end_character":62},"in_reply_to":"df33271e_2af23570","updated":"2020-04-07 17:09:17.000000000","message":"yeah, with scope_type are not overridable for operator so they cannot give access to project scoped role.","commit_id":"763d220504d1e1ef01231bdfbe0f390d28d850b7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"13c0cbd05515cf747781e1e9644aaffb64a23b2a","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":399,"context_line":"        instance \u003d common.get_instance(self.compute_api, context, server_id)"},{"line_number":400,"context_line":"        context.can(va_policies.POLICY_ROOT % \u0027update\u0027,"},{"line_number":401,"context_line":"                    target\u003d{\u0027project_id\u0027: instance.project_id})"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        old_volume_id \u003d id"},{"line_number":404,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_9edc5575","line":401,"range":{"start_line":401,"start_character":20,"end_line":401,"end_character":62},"in_reply_to":"df33271e_6a3d5ddc","updated":"2020-04-08 05:57:18.000000000","message":"Thanks point this error, this will be fixed in https://review.opendev.org/#/c/711194/17/nova/api/openstack/compute/volumes.py@468, when I add target\u003d{} to this, I think I missed the SYSTEM_ADMIN role.","commit_id":"763d220504d1e1ef01231bdfbe0f390d28d850b7"}]}