)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"dc867e95480dc298cd7e6202a293b23267ed3714","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhangbailin \u003czhangbailin@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-03-16 23:26:39 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new default roles in os-volumes-attachments policies"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds new defaults roles in os-volumes-attachments API policies."},{"line_number":10,"context_line":"This policy is default to admin_or_owner and system admin role."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1fa4df85_9c4f6269","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":56},"updated":"2020-03-17 12:37:53.000000000","message":"I\u0027d argue that this isn\u0027t adding but switching policies.","commit_id":"b917ec88f6c74b1df1be0dfed935de658edd6702"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"cb021f4946e031be6d64b66ca520e4b3cf446ff8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhangbailin \u003czhangbailin@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-03-16 23:26:39 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new default roles in os-volumes-attachments policies"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds new defaults roles in os-volumes-attachments API policies."},{"line_number":10,"context_line":"This policy is default to admin_or_owner and system admin role."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1fa4df85_9c08c291","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":56},"in_reply_to":"1fa4df85_9c4f6269","updated":"2020-03-17 13:09:56.000000000","message":"Done","commit_id":"b917ec88f6c74b1df1be0dfed935de658edd6702"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"dc867e95480dc298cd7e6202a293b23267ed3714","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new default roles in os-volumes-attachments policies"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds new defaults roles in os-volumes-attachments API policies."},{"line_number":10,"context_line":"This policy is default to admin_or_owner and system admin role."},{"line_number":11,"context_line":"Policy rules are made more granular to adopt the new defaults."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"And this simulates the future where we drop the deprecation"},{"line_number":14,"context_line":"fall back in the policy by overriding the rules with a version where"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1fa4df85_5c59ea32","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":62},"updated":"2020-03-17 12:37:53.000000000","message":"Can you reference I999f8d84e10ff1a57c1ff6b717801b495032e358 here?","commit_id":"b917ec88f6c74b1df1be0dfed935de658edd6702"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"cb021f4946e031be6d64b66ca520e4b3cf446ff8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new default roles in os-volumes-attachments policies"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds new defaults roles in os-volumes-attachments API policies."},{"line_number":10,"context_line":"This policy is default to admin_or_owner and system admin role."},{"line_number":11,"context_line":"Policy rules are made more granular to adopt the new defaults."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"And this simulates the future where we drop the deprecation"},{"line_number":14,"context_line":"fall back in the policy by overriding the rules with a version where"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1fa4df85_3cff4e68","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":62},"in_reply_to":"1fa4df85_5c59ea32","updated":"2020-03-17 13:09:56.000000000","message":"Done","commit_id":"b917ec88f6c74b1df1be0dfed935de658edd6702"}],"nova/policies/volumes_attachments.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7a548a54460dc339cefb664867cfb65b70d3b619","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027]),"},{"line_number":46,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":47,"context_line":"        name\u003dPOLICY_ROOT % \u0027show\u0027,"},{"line_number":48,"context_line":"        check_str\u003dbase.PROJECT_READER_OR_SYSTEM_READER,"},{"line_number":49,"context_line":"        description\u003d\"Show details of a volume attachment\","},{"line_number":50,"context_line":"        operations\u003d["},{"line_number":51,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_0a2ba482","line":48,"updated":"2020-03-09 09:49:12.000000000","message":"Can you please rebase on this fix, just to be sure:\nhttps://review.opendev.org/#/c/706672/7/nova/policies/base.py","commit_id":"a35cdfed1b183664ec2da09db5c304b7ff20fbd7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"44efe26e0b33b95697aae0027e0aafdb4ace0a9d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027]),"},{"line_number":46,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":47,"context_line":"        name\u003dPOLICY_ROOT % \u0027show\u0027,"},{"line_number":48,"context_line":"        check_str\u003dbase.PROJECT_READER_OR_SYSTEM_READER,"},{"line_number":49,"context_line":"        description\u003d\"Show details of a volume attachment\","},{"line_number":50,"context_line":"        operations\u003d["},{"line_number":51,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_4ba0b490","line":48,"in_reply_to":"1fa4df85_0a2ba482","updated":"2020-03-10 00:20:21.000000000","message":"Done","commit_id":"a35cdfed1b183664ec2da09db5c304b7ff20fbd7"}],"nova/tests/unit/policies/test_volumes.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4836710e792df3db5d06b6aa320d780ba71eae02","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            self.project_admin_context, self.project_member_context,"},{"line_number":203,"context_line":"            self.other_project_member_context,"},{"line_number":204,"context_line":"            self.project_foo_context, self.project_reader_context"},{"line_number":205,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_ad28ce33","line":205,"updated":"2020-03-02 16:40:25.000000000","message":"We have the same issues we have with admin-actions, I really want us to test the case when we don\u0027t have the deprecations active: https://review.opendev.org/#/c/710813","commit_id":"63ef69a09c9d0b4b961bde229efdce113e9c1b67"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"b11cc653a6d3a4045aa90b4e1a1b9cbe34457192","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            self.project_admin_context, self.project_member_context,"},{"line_number":203,"context_line":"            self.other_project_member_context,"},{"line_number":204,"context_line":"            self.project_foo_context, self.project_reader_context"},{"line_number":205,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_a1df3267","line":205,"in_reply_to":"1fa4df85_ad28ce33","updated":"2020-03-06 09:22:46.000000000","message":"Done","commit_id":"63ef69a09c9d0b4b961bde229efdce113e9c1b67"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"8fdc7a7b2b3bf467bc5e8d061b75fa709950ad88","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            self.project_admin_context, self.project_member_context,"},{"line_number":203,"context_line":"            self.other_project_member_context,"},{"line_number":204,"context_line":"            self.project_foo_context, self.project_reader_context"},{"line_number":205,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_9caf397c","line":205,"in_reply_to":"1fa4df85_ad28ce33","updated":"2020-03-03 06:42:24.000000000","message":"Sound greate, but every api has a rule_name, how can I overriding this \"self.policy.set_rules()\"? Can you give some help? And that will be add in another patch to follow up this.","commit_id":"63ef69a09c9d0b4b961bde229efdce113e9c1b67"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7a548a54460dc339cefb664867cfb65b70d3b619","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            self.project_foo_context, self.project_reader_context"},{"line_number":251,"context_line":"        ]"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        self.reader_authorized_contexts \u003d ["},{"line_number":254,"context_line":"            self.system_admin_context, self.system_reader_context,"},{"line_number":255,"context_line":"            self.system_member_context, self.project_admin_context,"},{"line_number":256,"context_line":"            self.project_reader_context, self.project_member_context"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_6f010a06","line":253,"updated":"2020-03-09 09:49:12.000000000","message":"Nice: we have almost all the cases we are wanting in one test here :)","commit_id":"a35cdfed1b183664ec2da09db5c304b7ff20fbd7"}],"nova/tests/unit/test_policy.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4836710e792df3db5d06b6aa320d780ba71eae02","unresolved":false,"context_lines":[{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        self.system_reader_rules \u003d ("},{"line_number":459,"context_line":"\"os_compute_api:os-services:list\","},{"line_number":460,"context_line":"\"os_compute_api:os-volumes-attachments:index\","},{"line_number":461,"context_line":"\"os_compute_api:os-volumes-attachments:show\","},{"line_number":462,"context_line":")"},{"line_number":463,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_ed6006a8","line":460,"updated":"2020-03-02 16:40:25.000000000","message":"There are project_reader_or_system_reader, might need a new list?\n\nThe os-servcies:list is purely system_reader","commit_id":"63ef69a09c9d0b4b961bde229efdce113e9c1b67"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"8fdc7a7b2b3bf467bc5e8d061b75fa709950ad88","unresolved":false,"context_lines":[{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        self.system_reader_rules \u003d ("},{"line_number":459,"context_line":"\"os_compute_api:os-services:list\","},{"line_number":460,"context_line":"\"os_compute_api:os-volumes-attachments:index\","},{"line_number":461,"context_line":"\"os_compute_api:os-volumes-attachments:show\","},{"line_number":462,"context_line":")"},{"line_number":463,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_738710b7","line":460,"in_reply_to":"1fa4df85_ed6006a8","updated":"2020-03-03 06:42:24.000000000","message":"Done","commit_id":"63ef69a09c9d0b4b961bde229efdce113e9c1b67"}]}