)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"1155ceb501d5dd7ed88c4c167d8ecef0f207b6e7","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This commit adds validation for the id parameter the same way it\u0027s"},{"line_number":17,"context_line":"already done for other endpoints."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I83817f7301680801beaee375825f02eda526eda1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_a80c6a3b","line":18,"updated":"2020-02-27 16:09:05.000000000","message":"Need to add Closes-Bug with a bug ID here.\n\nLooks like the author of the other patch for the same fix opened a bug about it:\n\nhttps://review.opendev.org/710290","commit_id":"3ee80c0f905d99935e76d8acd88dbac5e217d2a4"}],"nova/api/openstack/compute/aggregates.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"34c1531aff8a0820b2159ebf2e274ca4d6754159","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        try:"},{"line_number":103,"context_line":"            utils.validate_integer(id, \u0027id\u0027)"},{"line_number":104,"context_line":"        except exception.InvalidInput as e:"},{"line_number":105,"context_line":"            raise exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        try:"},{"line_number":108,"context_line":"            aggregate \u003d self.api.get_aggregate(context, id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_aaf610d6","line":105,"updated":"2020-03-09 10:07:46.000000000","message":"I think it would be nice if we are consistent with the errors we output here, which I believe is the only other place we use integers as ids in the API:\nhttps://github.com/openstack/nova/blob/bb53370197bd3c53858cef0dad8b9b00776a63a6/nova/api/openstack/compute/hypervisors.py#L276","commit_id":"2e70a1717f25652912886cbefa3f40e6df908c00"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"59bcba69aa47e167e2c90d71cf661016d4e14c97","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        try:"},{"line_number":103,"context_line":"            utils.validate_integer(id, \u0027id\u0027)"},{"line_number":104,"context_line":"        except exception.InvalidInput as e:"},{"line_number":105,"context_line":"            raise exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        try:"},{"line_number":108,"context_line":"            aggregate \u003d self.api.get_aggregate(context, id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_eade483c","line":105,"in_reply_to":"1fa4df85_aaf610d6","updated":"2020-03-09 10:14:45.000000000","message":"PS, good spot on this one, its a gap with the json schema validation, it doesn\u0027t check the URL.\n\nI know I link to returning 404 on a bad ID, I prefer the 400 you have here, even though that changes error codes for other DB users, it makes it more correct, and within the expected set of errors anyways (i.e. this does not need a microversion).","commit_id":"2e70a1717f25652912886cbefa3f40e6df908c00"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"59bcba69aa47e167e2c90d71cf661016d4e14c97","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        try:"},{"line_number":125,"context_line":"            utils.validate_integer(id, \u0027id\u0027)"},{"line_number":126,"context_line":"        except exception.InvalidInput as e:"},{"line_number":127,"context_line":"            raise exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        try:"},{"line_number":130,"context_line":"            aggregate \u003d self.api.update_aggregate(context, id, updates)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_6aea58d8","line":127,"updated":"2020-03-09 10:14:45.000000000","message":"Just so we are always consistent, I would be nice to have this as a helper function like \"_validate_id\", particularly if we fix up there error message. It would be good long term to keep this DRY (in case someone in the future only fixes one of these checks).","commit_id":"2e70a1717f25652912886cbefa3f40e6df908c00"}]}