)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"142e5e7004a9253679f3a01de864dad11a556da2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-24 12:01:51 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"trivial: Use \u0027import foo from bar\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In some tests, we were doing an import with a full module path. This has"},{"line_number":10,"context_line":"the side effect of importing every submodule on that path, which led to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_8a2ba62e","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":33},"updated":"2020-02-27 15:09:03.000000000","message":"from bar import foo\n\n(Before checking the patch, I thought this was some subtly different py3-ism.)","commit_id":"614e2d548e2c669fdbf25327c53903c649fc099d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7b55db86297b5cb565b64bee08b5cd204930b046","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-24 12:01:51 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"trivial: Use \u0027import foo from bar\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In some tests, we were doing an import with a full module path. This has"},{"line_number":10,"context_line":"the side effect of importing every submodule on that path, which led to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_4a684e20","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":33},"in_reply_to":"1fa4df85_8a2ba62e","updated":"2020-02-27 15:20:18.000000000","message":"gdi /o\\","commit_id":"614e2d548e2c669fdbf25327c53903c649fc099d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"142e5e7004a9253679f3a01de864dad11a556da2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"trivial: Use \u0027import foo from bar\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In some tests, we were doing an import with a full module path. This has"},{"line_number":10,"context_line":"the side effect of importing every submodule on that path, which led to"},{"line_number":11,"context_line":"some confusing side effects. Use \u0027import foo from bar\u0027 syntax instead"},{"line_number":12,"context_line":"and clean up the damage."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_6add0a41","line":10,"range":{"start_line":10,"start_character":19,"end_line":10,"end_character":44},"updated":"2020-02-27 15:09:03.000000000","message":"On reading, I thought you meant that e.g.\n\n import foo.bar.baz\n\nmeant we were also importing foo and bar as well as baz. Is that really the case?\n\nWhat you meant to say (IIUC) is that importing as foo.bar.baz means you have to *say* foo.bar.baz everywhere you want to use it, which is a lot of noise.","commit_id":"614e2d548e2c669fdbf25327c53903c649fc099d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7b55db86297b5cb565b64bee08b5cd204930b046","unresolved":false,"context_lines":[{"line_number":7,"context_line":"trivial: Use \u0027import foo from bar\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In some tests, we were doing an import with a full module path. This has"},{"line_number":10,"context_line":"the side effect of importing every submodule on that path, which led to"},{"line_number":11,"context_line":"some confusing side effects. Use \u0027import foo from bar\u0027 syntax instead"},{"line_number":12,"context_line":"and clean up the damage."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_aa79c2fc","line":10,"range":{"start_line":10,"start_character":19,"end_line":10,"end_character":44},"in_reply_to":"1fa4df85_6add0a41","updated":"2020-02-27 15:20:18.000000000","message":"\u003e On reading, I thought you meant that e.g.\n \u003e \n \u003e import foo.bar.baz\n \u003e \n \u003e meant we were also importing foo and bar as well as baz. Is that\n \u003e really the case?\n\nIt seems so. See how we use \u0027nova.objects\u0027 in the next file. At least, I think that\u0027s what going on?\n\n \u003e What you meant to say (IIUC) is that importing as foo.bar.baz means\n \u003e you have to *say* foo.bar.baz everywhere you want to use it, which\n \u003e is a lot of noise.\n\nThis is also true though","commit_id":"614e2d548e2c669fdbf25327c53903c649fc099d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"16e2680a97fbe7de286741f4c7ff3f65c515f7ff","unresolved":false,"context_lines":[{"line_number":7,"context_line":"trivial: Use \u0027import foo from bar\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In some tests, we were doing an import with a full module path. This has"},{"line_number":10,"context_line":"the side effect of importing every submodule on that path, which led to"},{"line_number":11,"context_line":"some confusing side effects. Use \u0027import foo from bar\u0027 syntax instead"},{"line_number":12,"context_line":"and clean up the damage."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_0af9f64b","line":10,"range":{"start_line":10,"start_character":19,"end_line":10,"end_character":44},"in_reply_to":"1fa4df85_aa79c2fc","updated":"2020-02-27 15:21:46.000000000","message":"Yup:\n\n  $ python\n  Python 3.6.10 (default, Dec 20 2019, 00:00:00) \n  [GCC 9.2.1 20190827 (Red Hat 9.2.1-1)] on linux\n  Type \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n  \u003e\u003e\u003e import nova.tests.unit.image.fake\n  \u003e\u003e\u003e nova.objects.Service\n  \u003cclass \u0027nova.objects.service.Service\u0027\u003e\n\nThat is weird behavior for me at least","commit_id":"614e2d548e2c669fdbf25327c53903c649fc099d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"142e5e7004a9253679f3a01de864dad11a556da2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In some tests, we were doing an import with a full module path. This has"},{"line_number":10,"context_line":"the side effect of importing every submodule on that path, which led to"},{"line_number":11,"context_line":"some confusing side effects. Use \u0027import foo from bar\u0027 syntax instead"},{"line_number":12,"context_line":"and clean up the damage."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I91a289630f31674dec1d785d67b5acda173b7d7e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_2a22b253","line":11,"range":{"start_line":11,"start_character":34,"end_line":11,"end_character":53},"updated":"2020-02-27 15:09:03.000000000","message":"ditto","commit_id":"614e2d548e2c669fdbf25327c53903c649fc099d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"142e5e7004a9253679f3a01de864dad11a556da2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In some tests, we were doing an import with a full module path. This has"},{"line_number":10,"context_line":"the side effect of importing every submodule on that path, which led to"},{"line_number":11,"context_line":"some confusing side effects. Use \u0027import foo from bar\u0027 syntax instead"},{"line_number":12,"context_line":"and clean up the damage."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I91a289630f31674dec1d785d67b5acda173b7d7e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_2ae71215","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":27},"updated":"2020-02-27 15:09:03.000000000","message":"orly? Like what?","commit_id":"614e2d548e2c669fdbf25327c53903c649fc099d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7b55db86297b5cb565b64bee08b5cd204930b046","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In some tests, we were doing an import with a full module path. This has"},{"line_number":10,"context_line":"the side effect of importing every submodule on that path, which led to"},{"line_number":11,"context_line":"some confusing side effects. Use \u0027import foo from bar\u0027 syntax instead"},{"line_number":12,"context_line":"and clean up the damage."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I91a289630f31674dec1d785d67b5acda173b7d7e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_4a236e06","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":27},"in_reply_to":"1fa4df85_2ae71215","updated":"2020-02-27 15:20:18.000000000","message":"In this case, the fact that if you do\n\n  import nova.tests.unit.image.fake\n\nyou can later do\n\n  nova.objects.Service.get_by_host_and_binary\n\ndespite not having imported \u0027nova\u0027. Maybe it\u0027s just me, but that seems weird","commit_id":"614e2d548e2c669fdbf25327c53903c649fc099d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5a3e15aeca840d38eb9b40f1486056566bd1cfa4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In some tests, we were doing an import with a full module path. This has"},{"line_number":10,"context_line":"the side effect of importing every submodule on that path, which led to"},{"line_number":11,"context_line":"some confusing side effects. Use \u0027import foo from bar\u0027 syntax instead"},{"line_number":12,"context_line":"and clean up the damage."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I91a289630f31674dec1d785d67b5acda173b7d7e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_8a7086de","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":27},"in_reply_to":"1fa4df85_4a236e06","updated":"2020-02-27 15:23:43.000000000","message":"Yeah, agree.","commit_id":"614e2d548e2c669fdbf25327c53903c649fc099d"}]}