)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"bddf328c7c6c31dba8a16e295de12375c23dd549","unresolved":false,"context_lines":[{"line_number":3283,"context_line":"                                            context, instance[\u0027image_ref\u0027])"},{"line_number":3284,"context_line":"            image_meta \u003d compute_utils.get_image_metadata("},{"line_number":3285,"context_line":"                                context, image_service, image_id, instance)"},{"line_number":3286,"context_line":"        network_info_str \u003d str(network_info)"},{"line_number":3287,"context_line":"        LOG.debug(_(\u0027Start to_xml \u0027"},{"line_number":3288,"context_line":"                    \u0027network_info\u003d%(network_info)s \u0027"},{"line_number":3289,"context_line":"                    \u0027disk_info\u003d%(disk_info)s \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9t4I%3D","line":3286,"updated":"2014-02-04 18:15:17.000000000","message":"A comment here might be useful; without knowing about the deadlock, the cast-to-a-string looks unnecessary, so might be removed in a refactoring/cleanup.","commit_id":"fc3c28efa12e6c66d2b787074f3382031dad4445"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"161b155118cc52c0ce4881e04eaeb44d2ac6f04f","unresolved":false,"context_lines":[{"line_number":3289,"context_line":"                    \u0027disk_info\u003d%(disk_info)s \u0027"},{"line_number":3290,"context_line":"                    \u0027image_meta\u003d%(image_meta)s rescue\u003d%(rescue)s\u0027"},{"line_number":3291,"context_line":"                    \u0027block_device_info\u003d%(block_device_info)s\u0027),"},{"line_number":3292,"context_line":"                  {\u0027network_info\u0027: network_info_str, \u0027disk_info\u0027: disk_info,"},{"line_number":3293,"context_line":"                   \u0027image_meta\u0027: image_meta, \u0027rescue\u0027: rescue,"},{"line_number":3294,"context_line":"                   \u0027block_device_info\u0027: block_device_info},"},{"line_number":3295,"context_line":"                  instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9tfY%3D","line":3292,"updated":"2014-02-04 19:04:36.000000000","message":"Dan, nice catch!\n\nBut did you add just here str(netwrork_info) it will be cleaner..","commit_id":"fc3c28efa12e6c66d2b787074f3382031dad4445"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"28d709a25bfe1ebb975f07b897478704a7d8da48","unresolved":false,"context_lines":[{"line_number":3289,"context_line":"                    \u0027disk_info\u003d%(disk_info)s \u0027"},{"line_number":3290,"context_line":"                    \u0027image_meta\u003d%(image_meta)s rescue\u003d%(rescue)s\u0027"},{"line_number":3291,"context_line":"                    \u0027block_device_info\u003d%(block_device_info)s\u0027),"},{"line_number":3292,"context_line":"                  {\u0027network_info\u0027: network_info_str, \u0027disk_info\u0027: disk_info,"},{"line_number":3293,"context_line":"                   \u0027image_meta\u0027: image_meta, \u0027rescue\u0027: rescue,"},{"line_number":3294,"context_line":"                   \u0027block_device_info\u0027: block_device_info},"},{"line_number":3295,"context_line":"                  instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9tRQ%3D","line":3292,"in_reply_to":"AAAAUH%2F9tcE%3D","updated":"2014-02-04 19:35:48.000000000","message":"yep patch set 2 makes sense.","commit_id":"fc3c28efa12e6c66d2b787074f3382031dad4445"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"265d426194d9c7a794d5bf602d45af4631022ded","unresolved":false,"context_lines":[{"line_number":3289,"context_line":"                    \u0027disk_info\u003d%(disk_info)s \u0027"},{"line_number":3290,"context_line":"                    \u0027image_meta\u003d%(image_meta)s rescue\u003d%(rescue)s\u0027"},{"line_number":3291,"context_line":"                    \u0027block_device_info\u003d%(block_device_info)s\u0027),"},{"line_number":3292,"context_line":"                  {\u0027network_info\u0027: network_info_str, \u0027disk_info\u0027: disk_info,"},{"line_number":3293,"context_line":"                   \u0027image_meta\u0027: image_meta, \u0027rescue\u0027: rescue,"},{"line_number":3294,"context_line":"                   \u0027block_device_info\u0027: block_device_info},"},{"line_number":3295,"context_line":"                  instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9tcE%3D","line":3292,"in_reply_to":"AAAAUH%2F9tfY%3D","updated":"2014-02-04 19:12:16.000000000","message":"But less obvious that it\u0027s intentional. Combined with the comment in patch set 2, I think it\u0027s best to leave it up top.","commit_id":"fc3c28efa12e6c66d2b787074f3382031dad4445"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8acd7bd61e92b42b8e2e73adff8ae3fb0e9e8f08","unresolved":false,"context_lines":[{"line_number":3292,"context_line":"                    \u0027disk_info\u003d%(disk_info)s \u0027"},{"line_number":3293,"context_line":"                    \u0027image_meta\u003d%(image_meta)s rescue\u003d%(rescue)s\u0027"},{"line_number":3294,"context_line":"                    \u0027block_device_info\u003d%(block_device_info)s\u0027),"},{"line_number":3295,"context_line":"                  {\u0027network_info\u0027: network_info_str, \u0027disk_info\u0027: disk_info,"},{"line_number":3296,"context_line":"                   \u0027image_meta\u0027: image_meta, \u0027rescue\u0027: rescue,"},{"line_number":3297,"context_line":"                   \u0027block_device_info\u0027: block_device_info},"},{"line_number":3298,"context_line":"                  instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9s6w%3D","line":3295,"updated":"2014-02-04 20:39:48.000000000","message":"Yup, it\u0027s right there in the paste from the bug report:\n\n/opt/stack/nova/nova/virt/libvirt/driver.py:3295 in to_xml\n    `instance\u003dinstance)`\n\nhttp://paste.openstack.org/show/62463/","commit_id":"072e4ad20a6a7f4fff3b59eb7ef3f6fef9aa19d1"}]}
