)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"e2de96139a212c4cf337b404a99811589529f3e4","unresolved":false,"context_lines":[{"line_number":4299,"context_line":""},{"line_number":4300,"context_line":"            # remove the volume connection without detaching from hypervisor"},{"line_number":4301,"context_line":"            # because the instance is not running anymore on the current host"},{"line_number":4302,"context_line":"            if bdm.is_volume:"},{"line_number":4303,"context_line":"                self.volume_api.terminate_connection(ctxt, bdm.volume_id,"},{"line_number":4304,"context_line":"                                                     connector)"},{"line_number":4305,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2FpcA%3D","line":4302,"updated":"2014-02-11 19:08:39.000000000","message":"Need a test for this case (and non-volumes)","commit_id":"771fc095e5adbdb9f4bf68a3eaa209e3177aaefe"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"272d970b7fa016bda72d6fed7ea015bc4f5a100f","unresolved":false,"context_lines":[{"line_number":4463,"context_line":""},{"line_number":4464,"context_line":"        for bdm in (block_device_obj.BlockDeviceMappingList."},{"line_number":4465,"context_line":"                    get_by_instance_uuid(context, instance[\u0027uuid\u0027])):"},{"line_number":4466,"context_line":"            self.compute_rpcapi.remove_volume_connection(context, instance,"},{"line_number":4467,"context_line":"                    bdm.volume_id, dest)"},{"line_number":4468,"context_line":""},{"line_number":4469,"context_line":"        self._notify_about_instance_usage(context, instance,"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAVn%2F%2F1o0%3D","line":4466,"updated":"2014-03-03 21:16:16.000000000","message":"Should this have an \u0027if bdm.is_volume\u0027 check?","commit_id":"d541f4b10799d8c1a5c0f7d62297261a642437f3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"dca36c053bb0aadb504a619ea62e4a91a67511c9","unresolved":false,"context_lines":[{"line_number":4457,"context_line":"        for bdm in (block_device_obj.BlockDeviceMappingList."},{"line_number":4458,"context_line":"                    get_by_instance_uuid(context, instance[\u0027uuid\u0027])):"},{"line_number":4459,"context_line":"            self.compute_rpcapi.remove_volume_connection(context, instance,"},{"line_number":4460,"context_line":"                    bdm.volume_id, dest)"},{"line_number":4461,"context_line":""},{"line_number":4462,"context_line":"        self._notify_about_instance_usage(context, instance,"},{"line_number":4463,"context_line":"                                          \"live_migration._rollback.start\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAVn%2F%2FfyE%3D","line":4460,"updated":"2014-03-05 19:09:16.000000000","message":"This looks like we\u0027re calling it on all BDMs, whereas before we were calling it only for volume BDMs. Should we filter by bdm.is_volume like we do in _post_live_migration() above?","commit_id":"cb2cd981aeec36178db7df9c372846dab24591fb"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"59c1d3d8493ee7000bf82d64ffd1b1536859e92b","unresolved":false,"context_lines":[{"line_number":4457,"context_line":"        for bdm in (block_device_obj.BlockDeviceMappingList."},{"line_number":4458,"context_line":"                    get_by_instance_uuid(context, instance[\u0027uuid\u0027])):"},{"line_number":4459,"context_line":"            self.compute_rpcapi.remove_volume_connection(context, instance,"},{"line_number":4460,"context_line":"                    bdm.volume_id, dest)"},{"line_number":4461,"context_line":""},{"line_number":4462,"context_line":"        self._notify_about_instance_usage(context, instance,"},{"line_number":4463,"context_line":"                                          \"live_migration._rollback.start\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAVn%2F%2FZTE%3D","line":4460,"in_reply_to":"AAAAVn%2F%2FfyE%3D","updated":"2014-03-06 15:35:34.000000000","message":"Done","commit_id":"cb2cd981aeec36178db7df9c372846dab24591fb"}]}