)]}'
{"nova/tests/functional/api_sample_tests/test_volumes.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"79072b48fad33ba49b3907d7211f6e1e1a28bda7","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        subs \u003d self.test_attach_volume_to_server()"},{"line_number":304,"context_line":"        attached_volume_id \u003d subs[\u0027volume_id\u0027]"},{"line_number":305,"context_line":"        subs \u003d {}"},{"line_number":306,"context_line":"        response \u003d self._do_patch(\u0027servers/%s/os-volume_attachments/%s\u0027"},{"line_number":307,"context_line":"                                  % (self.server_id, attached_volume_id),"},{"line_number":308,"context_line":"                                  \u0027patch-volume-attachment-req\u0027, subs)"},{"line_number":309,"context_line":"        self.assertEqual(202, response.status_code)"},{"line_number":310,"context_line":"        self.assertEqual(\u0027\u0027, response.text)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1fa4df85_bce57e3a","line":310,"range":{"start_line":306,"start_character":0,"end_line":310,"end_character":43},"updated":"2020-03-17 12:46:38.000000000","message":"We need to assert that delete_on_terminiation was updated right?","commit_id":"53afefc9d539ec32171d50a5b4d94a553f64e510"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"205e50867d2324ab4bdac5630340e9ee0ae2cc0d","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        subs \u003d self.test_attach_volume_to_server()"},{"line_number":304,"context_line":"        attached_volume_id \u003d subs[\u0027volume_id\u0027]"},{"line_number":305,"context_line":"        subs \u003d {}"},{"line_number":306,"context_line":"        response \u003d self._do_patch(\u0027servers/%s/os-volume_attachments/%s\u0027"},{"line_number":307,"context_line":"                                  % (self.server_id, attached_volume_id),"},{"line_number":308,"context_line":"                                  \u0027patch-volume-attachment-req\u0027, subs)"},{"line_number":309,"context_line":"        self.assertEqual(202, response.status_code)"},{"line_number":310,"context_line":"        self.assertEqual(\u0027\u0027, response.text)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1fa4df85_fa545656","line":310,"range":{"start_line":306,"start_character":0,"end_line":310,"end_character":43},"in_reply_to":"1fa4df85_bce57e3a","updated":"2020-03-17 14:35:56.000000000","message":"No, the PATCH API just update the attached volume, doesnot return anything, we just check it\u0027s status_code\u003d\u003d202, I think it\u0027s enough. And in the unit tests case[1] I was tests the PATCH API update the request attached volume\u0027s delete_on_termination field, and that changed it\u0027s value.\n\n[1]https://review.opendev.org/#/c/693828/19/nova/tests/unit/api/openstack/compute/test_volumes.py@1179","commit_id":"53afefc9d539ec32171d50a5b4d94a553f64e510"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"dcb6ad7a3a81a74f8b0aa00638257a4569a7101e","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        subs \u003d self.test_attach_volume_to_server()"},{"line_number":304,"context_line":"        attached_volume_id \u003d subs[\u0027volume_id\u0027]"},{"line_number":305,"context_line":"        subs \u003d {}"},{"line_number":306,"context_line":"        response \u003d self._do_patch(\u0027servers/%s/os-volume_attachments/%s\u0027"},{"line_number":307,"context_line":"                                  % (self.server_id, attached_volume_id),"},{"line_number":308,"context_line":"                                  \u0027patch-volume-attachment-req\u0027, subs)"},{"line_number":309,"context_line":"        self.assertEqual(202, response.status_code)"},{"line_number":310,"context_line":"        self.assertEqual(\u0027\u0027, response.text)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1fa4df85_109273a0","line":310,"range":{"start_line":306,"start_character":0,"end_line":310,"end_character":43},"in_reply_to":"1fa4df85_d5edadb7","updated":"2020-03-17 15:07:22.000000000","message":"Done","commit_id":"53afefc9d539ec32171d50a5b4d94a553f64e510"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"20e2cf7a5ce3776b274eee70207d785af30eae90","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        subs \u003d self.test_attach_volume_to_server()"},{"line_number":304,"context_line":"        attached_volume_id \u003d subs[\u0027volume_id\u0027]"},{"line_number":305,"context_line":"        subs \u003d {}"},{"line_number":306,"context_line":"        response \u003d self._do_patch(\u0027servers/%s/os-volume_attachments/%s\u0027"},{"line_number":307,"context_line":"                                  % (self.server_id, attached_volume_id),"},{"line_number":308,"context_line":"                                  \u0027patch-volume-attachment-req\u0027, subs)"},{"line_number":309,"context_line":"        self.assertEqual(202, response.status_code)"},{"line_number":310,"context_line":"        self.assertEqual(\u0027\u0027, response.text)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1fa4df85_d5edadb7","line":310,"range":{"start_line":306,"start_character":0,"end_line":310,"end_character":43},"in_reply_to":"1fa4df85_fa545656","updated":"2020-03-17 14:45:00.000000000","message":"It\u0027s not that we should be checking the return, given this is a functional test we should be checking that the attachment is actually updated correctly using os-volume_attachments:\n\nhttps://docs.openstack.org/api-ref/compute/?expanded\u003dlist-volume-attachments-for-an-instance-detail#list-volume-attachments-for-an-instance\n\nSee the following for an example of this:\n\nhttps://github.com/openstack/nova/blob/b341ad700050c7e95e284172c53cf3b5386f7c23/nova/tests/functional/test_multiattach.py#L54-L60","commit_id":"53afefc9d539ec32171d50a5b4d94a553f64e510"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"24c9b4817cdaa300957a94d60360c4d56133d8a8","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        self.assertEqual(202, response.status_code)"},{"line_number":310,"context_line":"        self.assertEqual(\u0027\u0027, response.text)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        # Make sure the attached volume was patched"},{"line_number":313,"context_line":"        attachments \u003d self.api.api_get("},{"line_number":314,"context_line":"            \u0027/servers/%s/os-volume_attachments\u0027 % self.server_id).body["},{"line_number":315,"context_line":"            \u0027volumeAttachments\u0027]"},{"line_number":316,"context_line":"        self.assertEqual(1, len(attachments))"},{"line_number":317,"context_line":"        self.assertEqual(self.server_id, attachments[0][\u0027serverId\u0027])"},{"line_number":318,"context_line":"        self.assertTrue(attachments[0][\u0027delete_on_termination\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_903983a4","line":318,"range":{"start_line":312,"start_character":0,"end_line":318,"end_character":64},"updated":"2020-03-17 15:11:32.000000000","message":"Excellent thanks!","commit_id":"4543bfeba9fc3dfd8b2b7046cf93792b3067a04f"}]}