)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"902830073303e937c4a02d0391cb12c07ee07a4e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix two test cases that use side effects in comprehensions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"List comprehensions with side effects considered harmful. Fix two known"},{"line_number":10,"context_line":"instances."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Idfc05de3b42d08b288ff611b5c87c27d837e1301"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_30966141","line":9,"updated":"2020-03-03 16:13:38.000000000","message":"Is there more context on this? By side effects do you mean Mock.side_effect?","commit_id":"6dd73d191affe49540fc4fca79421c63c48867b7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c26c1d602e566196526d6f351a391dd58dadbcab","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix two test cases that use side effects in comprehensions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"List comprehensions with side effects considered harmful. Fix two known"},{"line_number":10,"context_line":"instances."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Idfc05de3b42d08b288ff611b5c87c27d837e1301"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_d0e4ade2","line":9,"in_reply_to":"1fa4df85_30966141","updated":"2020-03-03 16:16:46.000000000","message":"Oh nevermind it\u0027s just that we\u0027re building a list that we\u0027re not using. Had to read [1] to think that through.\n\n[1] https://stackoverflow.com/questions/5753597/is-it-pythonic-to-use-list-comprehensions-for-just-side-effects","commit_id":"6dd73d191affe49540fc4fca79421c63c48867b7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"fbdc63ff2e662cda3c688ff6cfc7e5315c557bae","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix two test cases that use side effects in comprehensions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"List comprehensions with side effects considered harmful. Fix two known"},{"line_number":10,"context_line":"instances."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Idfc05de3b42d08b288ff611b5c87c27d837e1301"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_7071390c","line":9,"in_reply_to":"1fa4df85_d0e4ade2","updated":"2020-03-03 16:25:43.000000000","message":"It\u0027s more a matter of the comprehension itself affecting database state, but yeah. These statements look like they\u0027re leftover residue that can be removed, but in fact, they set up database state.","commit_id":"6dd73d191affe49540fc4fca79421c63c48867b7"}]}