)]}'
{"nova/conf/compute.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4b160c3dd2db16048e9f7c1efd708d0d21147380","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        choices\u003d["},{"line_number":278,"context_line":"            (\u0027ps2mouse\u0027, \u0027Uses relative movement. Mouse connected by PS2\u0027),"},{"line_number":279,"context_line":"            (\u0027usbtablet\u0027, \u0027Uses absolute movement. Tablet connect by USB\u0027),"},{"line_number":280,"context_line":"            (\u0027none\u0027, \u0027Uses default behavior provided by drivers (mouse on PS2 \u0027"},{"line_number":281,"context_line":"             \u0027for libvirt x86)\u0027),"},{"line_number":282,"context_line":"        ],"},{"line_number":283,"context_line":"        help\u003d\"\"\""},{"line_number":284,"context_line":"Generic property to specify the pointer type."}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_912f003e","line":281,"range":{"start_line":280,"start_character":22,"end_line":281,"end_character":30},"updated":"2020-03-04 19:39:57.000000000","message":"This is wrong now. \u0027none\u0027 explicitly means do not set a pointer device in the guest.","commit_id":"2a5f1061bdd41092b16749a7ad4e8806d2a644dc"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d9de67d95dd644fad102fb491932fb255e3c8aa9","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        choices\u003d["},{"line_number":278,"context_line":"            (\u0027ps2mouse\u0027, \u0027Uses relative movement. Mouse connected by PS2\u0027),"},{"line_number":279,"context_line":"            (\u0027usbtablet\u0027, \u0027Uses absolute movement. Tablet connect by USB\u0027),"},{"line_number":280,"context_line":"            (\u0027none\u0027, \u0027Uses default behavior provided by drivers (mouse on PS2 \u0027"},{"line_number":281,"context_line":"             \u0027for libvirt x86)\u0027),"},{"line_number":282,"context_line":"        ],"},{"line_number":283,"context_line":"        help\u003d\"\"\""},{"line_number":284,"context_line":"Generic property to specify the pointer type."}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_1157905a","line":281,"range":{"start_line":280,"start_character":22,"end_line":281,"end_character":30},"in_reply_to":"1fa4df85_912f003e","updated":"2020-03-04 20:02:44.000000000","message":"Sorry, I don\u0027t understand how this patch changes the behavior in the libvirt driver? I just replaced the use of None with \u0027none\u0027, so if it was using the default behavior provided by drivers before (if setting None were possible in nova.conf) then why is it not with this patch?","commit_id":"2a5f1061bdd41092b16749a7ad4e8806d2a644dc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4b160c3dd2db16048e9f7c1efd708d0d21147380","unresolved":false,"context_lines":[{"line_number":286,"context_line":"Input devices allow interaction with a graphical framebuffer. For"},{"line_number":287,"context_line":"example to provide a graphic tablet for absolute cursor movement."},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"If set, the \u0027hw_pointer_model\u0027 image property takes precedence over"},{"line_number":290,"context_line":"this configuration option."},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_51dae84a","line":289,"updated":"2020-03-04 19:39:57.000000000","message":"Just a note that if there is a metadef for this in glance it will need to be updated as well:\n\nhttps://docs.openstack.org/glance/latest/admin/useful-image-properties.html\n\nSo it\u0027s documented but not with all of the options.\n\nThere is a metadef but it\u0027s enum is limited:\n\nhttps://github.com/openstack/glance/blob/854e425fec7cf84d108c6a07b6a0ebc02ca866cb/etc/metadefs/compute-libvirt-image.json#L124","commit_id":"2a5f1061bdd41092b16749a7ad4e8806d2a644dc"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d9de67d95dd644fad102fb491932fb255e3c8aa9","unresolved":false,"context_lines":[{"line_number":5905,"context_line":"            add_video_driver \u003d True"},{"line_number":5906,"context_line":"        return add_video_driver"},{"line_number":5907,"context_line":""},{"line_number":5908,"context_line":"    def _get_guest_pointer_model(self, os_type, image_meta):"},{"line_number":5909,"context_line":"        pointer_model \u003d image_meta.properties.get("},{"line_number":5910,"context_line":"            \u0027hw_pointer_model\u0027, CONF.pointer_model)"},{"line_number":5911,"context_line":"        if pointer_model \u003d\u003d \u0027none\u0027 and CONF.libvirt.use_usb_tablet:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_b169dcf9","line":5908,"updated":"2020-03-04 20:02:44.000000000","message":"I also notice in this method it looks like if one has set pointer_model \u003d \u0027ps2mouse\u0027 it would also result in None being returned from this method. Not sure what\u0027s up with that.","commit_id":"2a5f1061bdd41092b16749a7ad4e8806d2a644dc"}]}