)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0d52022ea77991f1f528951ee3854ca8b5887e38","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     qiufossen \u003cqiujunting@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-03-06 06:36:14 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"The instance is volume backed and power state is PAUSED，shelve the instance"},{"line_number":8,"context_line":"failed"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"The instance is volume backed and power state is PAUSED，shelve the instance"},{"line_number":11,"context_line":"failed. The reason is that can not attempt a clean shutdown of a paused guest"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_998054f7","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":6},"updated":"2020-03-09 01:42:13.000000000","message":"Your tittle shoud descripbe the changes of your patch, I think you can say: \"Don\u0027t try to clean shutdown a paused guest when shelve\"","commit_id":"d412b1e0b84a05f343aa4eb272c64eaafddd1cfc"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0d52022ea77991f1f528951ee3854ca8b5887e38","unresolved":false,"context_lines":[{"line_number":12,"context_line":"instance some hypervisors will fail the clean shutdown if the guest is not"},{"line_number":13,"context_line":"running."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Co-Authored-By: Qiu Fossen \u003cqiujunting@inspur.com\u003e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I2299a475a7dcd12e137fbbc5bcbb026d87164811"},{"line_number":18,"context_line":"Closes-bug: #1864624"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_59765c40","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":50},"updated":"2020-03-09 01:42:13.000000000","message":"You are the only author, it does not need this flag, or you can use \"Signed-off-by: Qiu Fossen \u003cqiujunting@inspur.com\u003e\" instead of this, AFAIK, it does not matter.","commit_id":"d412b1e0b84a05f343aa4eb272c64eaafddd1cfc"}],"nova/compute/api.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"b6c71caa9be622cb289fb5daad03888da0310989","unresolved":false,"context_lines":[{"line_number":4089,"context_line":"    def shelve_offload(self, context, instance, clean_shutdown\u003dTrue):"},{"line_number":4090,"context_line":"        \"\"\"Remove a shelved instance from the hypervisor.\"\"\""},{"line_number":4091,"context_line":""},{"line_number":4092,"context_line":"        # Do not attempt a clean shutdown of a paused guest since some"},{"line_number":4093,"context_line":"        # hypervisors will fail the clean shutdown if the guest is not"},{"line_number":4094,"context_line":"        # running."},{"line_number":4095,"context_line":"        if instance.power_state \u003d\u003d power_state.PAUSED:"},{"line_number":4096,"context_line":"            clean_shutdown \u003d False"},{"line_number":4097,"context_line":""},{"line_number":4098,"context_line":"        instance.task_state \u003d task_states.SHELVING_OFFLOADING"},{"line_number":4099,"context_line":"        instance.save(expected_task_state\u003d[None])"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_647e206c","line":4096,"range":{"start_line":4092,"start_character":0,"end_line":4096,"end_character":34},"updated":"2020-04-08 08:27:21.000000000","message":"If you\u0027re going to remove this from the manager then it needs to be duplicated here in the API for the shelve call above that will also attempt to clean shutdown paused instances.","commit_id":"61ef8155723e156c5ca489b7758c4245e52688da"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"13ee8760c85684b2d9f6735996564f61d5e4a0c1","unresolved":false,"context_lines":[{"line_number":4089,"context_line":"    def shelve_offload(self, context, instance, clean_shutdown\u003dTrue):"},{"line_number":4090,"context_line":"        \"\"\"Remove a shelved instance from the hypervisor.\"\"\""},{"line_number":4091,"context_line":""},{"line_number":4092,"context_line":"        # Do not attempt a clean shutdown of a paused guest since some"},{"line_number":4093,"context_line":"        # hypervisors will fail the clean shutdown if the guest is not"},{"line_number":4094,"context_line":"        # running."},{"line_number":4095,"context_line":"        if instance.power_state \u003d\u003d power_state.PAUSED:"},{"line_number":4096,"context_line":"            clean_shutdown \u003d False"},{"line_number":4097,"context_line":""},{"line_number":4098,"context_line":"        instance.task_state \u003d task_states.SHELVING_OFFLOADING"},{"line_number":4099,"context_line":"        instance.save(expected_task_state\u003d[None])"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_e124a2c8","line":4096,"range":{"start_line":4092,"start_character":0,"end_line":4096,"end_character":34},"in_reply_to":"df33271e_647e206c","updated":"2020-04-10 10:20:24.000000000","message":"From the bug point of view, as long as the instance is in the PAUSED state, we need to perform \"clean_shutdown\u003dTrue\".\n\nBut the use case from tempest runs ok, it confused for us, we should respin this bug, and get more details.","commit_id":"61ef8155723e156c5ca489b7758c4245e52688da"}],"nova/compute/manager.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0d52022ea77991f1f528951ee3854ca8b5887e38","unresolved":false,"context_lines":[{"line_number":6319,"context_line":"            expected_state \u003d shelving_state_map[expected_state]"},{"line_number":6320,"context_line":"            instance.task_state \u003d task_state"},{"line_number":6321,"context_line":"            instance.save(expected_task_state\u003dexpected_state)"},{"line_number":6322,"context_line":"        # Do not attempt a clean shutdown of a paused guest since some"},{"line_number":6323,"context_line":"        # hypervisors will fail the clean shutdown if the guest is not"},{"line_number":6324,"context_line":"        # running."},{"line_number":6325,"context_line":"        if instance.power_state \u003d\u003d power_state.PAUSED:"},{"line_number":6326,"context_line":"            clean_shutdown \u003d False"},{"line_number":6327,"context_line":"        self._power_off_instance(context, instance, clean_shutdown)"},{"line_number":6328,"context_line":"        self.driver.snapshot(context, instance, image_id, update_task_state)"},{"line_number":6329,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_9997f448","line":6326,"range":{"start_line":6322,"start_character":0,"end_line":6326,"end_character":34},"updated":"2020-03-09 01:42:13.000000000","message":"The bfv server also dont attempt a clean shutdown of a paused gust.\n\nIMO, also move this to the compute api https://opendev.org/openstack/nova/src/branch/master/nova/compute/api.py#L4038","commit_id":"d412b1e0b84a05f343aa4eb272c64eaafddd1cfc"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0d52022ea77991f1f528951ee3854ca8b5887e38","unresolved":false,"context_lines":[{"line_number":6365,"context_line":"        :param clean_shutdown: give the GuestOS a chance to stop"},{"line_number":6366,"context_line":"        \"\"\""},{"line_number":6367,"context_line":""},{"line_number":6368,"context_line":"        if instance.power_state \u003d\u003d power_state.PAUSED:"},{"line_number":6369,"context_line":"            clean_shutdown \u003d False"},{"line_number":6370,"context_line":""},{"line_number":6371,"context_line":"        @utils.synchronized(instance.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_39a7e0bf","line":6368,"updated":"2020-03-09 01:42:13.000000000","message":"I think we can move this to the compute api [1], while we want to shelve a \"PAUSED\" instance whether it is a bfv server or boot from image, that we should set \"clean_shutdown \u003d False\".\n\n[1]https://opendev.org/openstack/nova/src/branch/master/nova/compute/api.py#L4038","commit_id":"d412b1e0b84a05f343aa4eb272c64eaafddd1cfc"},{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"598274ad173352a7461014717ed6bf12ffcd6d6f","unresolved":false,"context_lines":[{"line_number":6365,"context_line":"        :param clean_shutdown: give the GuestOS a chance to stop"},{"line_number":6366,"context_line":"        \"\"\""},{"line_number":6367,"context_line":""},{"line_number":6368,"context_line":"        if instance.power_state \u003d\u003d power_state.PAUSED:"},{"line_number":6369,"context_line":"            clean_shutdown \u003d False"},{"line_number":6370,"context_line":""},{"line_number":6371,"context_line":"        @utils.synchronized(instance.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_ed67de24","line":6368,"in_reply_to":"1fa4df85_39a7e0bf","updated":"2020-03-25 06:17:10.000000000","message":"Hi Brin：\n    I have modified as your suggested. Thank you!","commit_id":"d412b1e0b84a05f343aa4eb272c64eaafddd1cfc"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"b6c71caa9be622cb289fb5daad03888da0310989","unresolved":false,"context_lines":[{"line_number":6399,"context_line":"            expected_state \u003d shelving_state_map[expected_state]"},{"line_number":6400,"context_line":"            instance.task_state \u003d task_state"},{"line_number":6401,"context_line":"            instance.save(expected_task_state\u003dexpected_state)"},{"line_number":6402,"context_line":"        # Do not attempt a clean shutdown of a paused guest since some"},{"line_number":6403,"context_line":"        # hypervisors will fail the clean shutdown if the guest is not"},{"line_number":6404,"context_line":"        # running."},{"line_number":6405,"context_line":"        if instance.power_state \u003d\u003d power_state.PAUSED:"},{"line_number":6406,"context_line":"            clean_shutdown \u003d False"},{"line_number":6407,"context_line":"        self._power_off_instance(context, instance, clean_shutdown)"},{"line_number":6408,"context_line":"        self.driver.snapshot(context, instance, image_id, update_task_state)"},{"line_number":6409,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_44a83cda","side":"PARENT","line":6406,"range":{"start_line":6402,"start_character":0,"end_line":6406,"end_character":34},"updated":"2020-04-08 08:27:21.000000000","message":"If you\u0027re removing this from here you will need to duplicate this check for shelve_instance in the api.","commit_id":"3c002e3c26593a47b3da161e87944e6c0069ea52"},{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"882fd46df9eea00a17580d5e5049e6e93d71ba64","unresolved":false,"context_lines":[{"line_number":6399,"context_line":"            expected_state \u003d shelving_state_map[expected_state]"},{"line_number":6400,"context_line":"            instance.task_state \u003d task_state"},{"line_number":6401,"context_line":"            instance.save(expected_task_state\u003dexpected_state)"},{"line_number":6402,"context_line":"        # Do not attempt a clean shutdown of a paused guest since some"},{"line_number":6403,"context_line":"        # hypervisors will fail the clean shutdown if the guest is not"},{"line_number":6404,"context_line":"        # running."},{"line_number":6405,"context_line":"        if instance.power_state \u003d\u003d power_state.PAUSED:"},{"line_number":6406,"context_line":"            clean_shutdown \u003d False"},{"line_number":6407,"context_line":"        self._power_off_instance(context, instance, clean_shutdown)"},{"line_number":6408,"context_line":"        self.driver.snapshot(context, instance, image_id, update_task_state)"},{"line_number":6409,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f423b7e_cd7cd522","side":"PARENT","line":6406,"range":{"start_line":6402,"start_character":0,"end_line":6406,"end_character":34},"in_reply_to":"df33271e_44a83cda","updated":"2020-04-11 07:47:10.000000000","message":"Hi Lee Yarwood！\nI have add bug details. https://bugs.launchpad.net/nova/+bug/1864624\nThank you!","commit_id":"3c002e3c26593a47b3da161e87944e6c0069ea52"}]}