)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"af51ceed7de272645aac503141ad149a92063670","unresolved":false,"context_lines":[{"line_number":10,"context_line":"when creating QemuImgInfo objects. As such this change makes JSON the"},{"line_number":11,"context_line":"default output_format requested when calling qemu-img info."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"TODO(lyarwood): The huge number of unit tests in Nova using fake human"},{"line_number":14,"context_line":"qemu-img info means that this is mostly test cleanup. Should we even"},{"line_number":15,"context_line":"test this in Nova? IMHO this type of test should live in oslo.utils"},{"line_number":16,"context_line":"along with QemuImgInfo."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I56676713571e79f05ee3f0bffc5da8386e02c5d4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_b75e5010","line":16,"range":{"start_line":13,"start_character":0,"end_line":16,"end_character":23},"updated":"2020-03-11 12:19:02.000000000","message":"im not really shour that qemuimageinfo should be in oslo as that seam ver libvirt virt driver specific. does anyone outher then nova use that?\n\nbut ya i dont know if we should be testing that in nova.\nqemu has broken us a few times but i think moveing to json is defently better if we do keep it.","commit_id":"9a17a2dfb11ac13b3e85fc7acf3492bc78a856b2"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d87fa2e6ce1510fd05d08fd08461cdb60e90bed9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"when creating QemuImgInfo objects. As such this change makes JSON the"},{"line_number":11,"context_line":"default output_format requested when calling qemu-img info."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"TODO(lyarwood): The huge number of unit tests in Nova using fake human"},{"line_number":14,"context_line":"qemu-img info means that this is mostly test cleanup. Should we even"},{"line_number":15,"context_line":"test this in Nova? IMHO this type of test should live in oslo.utils"},{"line_number":16,"context_line":"along with QemuImgInfo."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I56676713571e79f05ee3f0bffc5da8386e02c5d4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_77d6982a","line":16,"range":{"start_line":13,"start_character":0,"end_line":16,"end_character":23},"in_reply_to":"1fa4df85_b75e5010","updated":"2020-03-11 12:32:57.000000000","message":"It\u0027s used by Cinder, Ironic and Nova:\n\nhttp://codesearch.openstack.org/?q\u003dQemuImgInfo\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d\n\nI\u0027ll kill these tests in a respin and migrate them over to oslo.utils if they don\u0027t already exist.","commit_id":"9a17a2dfb11ac13b3e85fc7acf3492bc78a856b2"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"56b785a7fe02e2ece5139b0b8c5435ac74f46892","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"oslo.utils is planning to make JSON the default output format parsed"},{"line_number":10,"context_line":"when creating QemuImgInfo objects. As such this change makes JSON the"},{"line_number":11,"context_line":"default output_format requested when calling qemu-img info."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The majority of this change is actually test removal from"},{"line_number":14,"context_line":"nova.tests.unit.virt.libvirt.test_utils as these human readable qemu-img"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f4c43b2_d01c1715","line":11,"updated":"2020-04-16 14:40:14.000000000","message":"ack","commit_id":"a78ef4bb18cad2fc5dfb64215dff2b666a5ba5b8"}],"nova/virt/images.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"03ae6d23f7c7fd6d1f572c149d1bdc1896dcb871","unresolved":false,"context_lines":[{"line_number":39,"context_line":"IMAGE_API \u003d glance.API()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def qemu_img_info(path, format\u003dNone, output_format\u003d\u0027json\u0027):"},{"line_number":43,"context_line":"    \"\"\"Return an object containing the parsed output from qemu-img info.\"\"\""},{"line_number":44,"context_line":"    if not os.path.exists(path) and not path.startswith(\u0027rbd:\u0027):"},{"line_number":45,"context_line":"        raise exception.DiskNotFound(location\u003dpath)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4c43b2_90872f10","line":42,"range":{"start_line":42,"start_character":37,"end_line":42,"end_character":57},"updated":"2020-04-16 14:47:11.000000000","message":"It seems this is an unused parameter now.","commit_id":"a78ef4bb18cad2fc5dfb64215dff2b666a5ba5b8"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"03ae6d23f7c7fd6d1f572c149d1bdc1896dcb871","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    return imageutils.QemuImgInfo(info, format\u003doutput_format)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def privileged_qemu_img_info(path, format\u003dNone, output_format\u003d\u0027json\u0027):"},{"line_number":54,"context_line":"    \"\"\"Return an object containing the parsed output from qemu-img info.\"\"\""},{"line_number":55,"context_line":"    if not os.path.exists(path) and not path.startswith(\u0027rbd:\u0027):"},{"line_number":56,"context_line":"        raise exception.DiskNotFound(location\u003dpath)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4c43b2_d078972c","line":53,"range":{"start_line":53,"start_character":48,"end_line":53,"end_character":68},"updated":"2020-04-16 14:47:11.000000000","message":"ditto","commit_id":"a78ef4bb18cad2fc5dfb64215dff2b666a5ba5b8"}]}