)]}'
{"nova/virt/ironic/driver.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"67dc5a8474455bd932dd2fa9cc9f2b8bf7463254","unresolved":false,"context_lines":[{"line_number":781,"context_line":""},{"line_number":782,"context_line":"        self.hash_ring \u003d hash_ring.HashRing(services,"},{"line_number":783,"context_line":"                                            partitions\u003d_HASH_RING_PARTITIONS)"},{"line_number":784,"context_line":"        LOG.info(\u0027Refreshed hash ring contains %s nova-compute services\u0027,"},{"line_number":785,"context_line":"                 len(services))"},{"line_number":786,"context_line":"        LOG.debug(\u0027Hash ring members are %s\u0027, services)"},{"line_number":787,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_aede32d7","line":784,"range":{"start_line":784,"start_character":47,"end_line":784,"end_character":49},"updated":"2020-03-06 19:46:06.000000000","message":"Why %s for an integer?\n\nPersonally I think this is too verbose for info level, especially given that when debug is enabled we\u0027re emitting two things back to back with effectively duplicated info. But, that\u0027s just MHO.","commit_id":"9fec91669e3eab222b78d09c70b88236e0632720"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2b9b9220229b085785901e362db16e4cc5bc27bb","unresolved":false,"context_lines":[{"line_number":781,"context_line":""},{"line_number":782,"context_line":"        self.hash_ring \u003d hash_ring.HashRing(services,"},{"line_number":783,"context_line":"                                            partitions\u003d_HASH_RING_PARTITIONS)"},{"line_number":784,"context_line":"        LOG.info(\u0027Refreshed hash ring contains %s nova-compute services\u0027,"},{"line_number":785,"context_line":"                 len(services))"},{"line_number":786,"context_line":"        LOG.debug(\u0027Hash ring members are %s\u0027, services)"},{"line_number":787,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_29247cae","line":784,"range":{"start_line":784,"start_character":47,"end_line":784,"end_character":49},"in_reply_to":"1fa4df85_aede32d7","updated":"2020-03-06 19:55:23.000000000","message":"I\u0027m used to using %s.\n\nThat is fair enough. If customers are facing issues we\u0027d probably have them turn on DEBUG anyway. Also I mistakenly thought the \"Returning \u003cnum\u003e available nodes\" message was being logged at INFO but it\u0027s not, it\u0027s logged at DEBUG.\n\nI\u0027ll remove this.","commit_id":"9fec91669e3eab222b78d09c70b88236e0632720"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"67dc5a8474455bd932dd2fa9cc9f2b8bf7463254","unresolved":false,"context_lines":[{"line_number":827,"context_line":"            # nova while the service was down, and not yet reaped, will not be"},{"line_number":828,"context_line":"            # reported until the periodic task cleans it up."},{"line_number":829,"context_line":"            elif (node.instance_uuid is None and"},{"line_number":830,"context_line":"                  CONF.host in"},{"line_number":831,"context_line":"                  self.hash_ring.get_nodes(node.uuid.encode(\u0027utf-8\u0027))):"},{"line_number":832,"context_line":"                node_cache[node.uuid] \u003d node"},{"line_number":833,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_aea5d248","line":830,"range":{"start_line":830,"start_character":18,"end_line":830,"end_character":27},"updated":"2020-03-06 19:46:06.000000000","message":"Don\u0027t you need to .lower() this? Seems like without doing so, any host with mixed case will be 100% fail, no?","commit_id":"9fec91669e3eab222b78d09c70b88236e0632720"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2b9b9220229b085785901e362db16e4cc5bc27bb","unresolved":false,"context_lines":[{"line_number":827,"context_line":"            # nova while the service was down, and not yet reaped, will not be"},{"line_number":828,"context_line":"            # reported until the periodic task cleans it up."},{"line_number":829,"context_line":"            elif (node.instance_uuid is None and"},{"line_number":830,"context_line":"                  CONF.host in"},{"line_number":831,"context_line":"                  self.hash_ring.get_nodes(node.uuid.encode(\u0027utf-8\u0027))):"},{"line_number":832,"context_line":"                node_cache[node.uuid] \u003d node"},{"line_number":833,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_893490df","line":830,"range":{"start_line":830,"start_character":18,"end_line":830,"end_character":27},"in_reply_to":"1fa4df85_aea5d248","updated":"2020-03-06 19:55:23.000000000","message":"Yeah, I do. Thanks for catching.","commit_id":"9fec91669e3eab222b78d09c70b88236e0632720"}]}