)]}'
{"nova/auth/signer.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"7cf791895d52673892c419de7fdfe1aa8d36f478","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        string_to_sign \u003d \u0027%s\\n%s\\n%s\\n\u0027 % (verb, server_string, path)"},{"line_number":135,"context_line":"        if self.hmac_256:"},{"line_number":136,"context_line":"            current_hmac \u003d self.hmac_256"},{"line_number":137,"context_line":"            params[\u0027SignatureMethod\u0027] \u003d \u0027HmacSHA256\u0027"},{"line_number":138,"context_line":"        else:"},{"line_number":139,"context_line":"            current_hmac \u003d self.hmac"},{"line_number":140,"context_line":"            params[\u0027SignatureMethod\u0027] \u003d \u0027HmacSHA1\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F%2BJI%3D","side":"PARENT","line":137,"updated":"2011-09-28 21:23:35.000000000","message":"Should be able to remove the setting of SignatureMethod","commit_id":"4fb1ac26cb15ea7e21ab9873e1dd253da0c77157"},{"author":{"_account_id":1610,"name":"Brendan Maguire","email":"B_Maguire@Dell.com","username":"b-maguire"},"change_message_id":"f886f8ed56df9f72478e635d05b899d9b6ebe636","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        string_to_sign \u003d \u0027%s\\n%s\\n%s\\n\u0027 % (verb, server_string, path)"},{"line_number":135,"context_line":"        if self.hmac_256:"},{"line_number":136,"context_line":"            current_hmac \u003d self.hmac_256"},{"line_number":137,"context_line":"            params[\u0027SignatureMethod\u0027] \u003d \u0027HmacSHA256\u0027"},{"line_number":138,"context_line":"        else:"},{"line_number":139,"context_line":"            current_hmac \u003d self.hmac"},{"line_number":140,"context_line":"            params[\u0027SignatureMethod\u0027] \u003d \u0027HmacSHA1\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F%2BFs%3D","side":"PARENT","line":137,"in_reply_to":"AAAACX%2F%2F%2BJI%3D","updated":"2011-09-29 10:09:19.000000000","message":"Done","commit_id":"4fb1ac26cb15ea7e21ab9873e1dd253da0c77157"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"7cf791895d52673892c419de7fdfe1aa8d36f478","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        if self.hmac_256 and\\"},{"line_number":136,"context_line":"          (\u0027SignatureMethod\u0027 not in params or"},{"line_number":137,"context_line":"           params[\u0027SignatureMethod\u0027] !\u003d \u0027HmacSHA1\u0027):"},{"line_number":138,"context_line":"            current_hmac \u003d self.hmac_256"},{"line_number":139,"context_line":"            params[\u0027SignatureMethod\u0027] \u003d \u0027HmacSHA256\u0027"},{"line_number":140,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F%2BJM%3D","line":137,"updated":"2011-09-28 21:23:35.000000000","message":"Require SignatureMethod to be set and return an error otherwise","commit_id":"02b57f9c377af9c3e085174f74afb44fcbe682ce"},{"author":{"_account_id":1610,"name":"Brendan Maguire","email":"B_Maguire@Dell.com","username":"b-maguire"},"change_message_id":"f886f8ed56df9f72478e635d05b899d9b6ebe636","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        if self.hmac_256 and\\"},{"line_number":136,"context_line":"          (\u0027SignatureMethod\u0027 not in params or"},{"line_number":137,"context_line":"           params[\u0027SignatureMethod\u0027] !\u003d \u0027HmacSHA1\u0027):"},{"line_number":138,"context_line":"            current_hmac \u003d self.hmac_256"},{"line_number":139,"context_line":"            params[\u0027SignatureMethod\u0027] \u003d \u0027HmacSHA256\u0027"},{"line_number":140,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F%2BFw%3D","line":137,"in_reply_to":"AAAACX%2F%2F%2BJM%3D","updated":"2011-09-29 10:09:19.000000000","message":"Done","commit_id":"02b57f9c377af9c3e085174f74afb44fcbe682ce"}],"nova/tests/test_signer.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"4c634a30fef725ab71b413ad1943ac684d331d27","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                                           \u0027GET\u0027, \u0027server\u0027, \u0027/foo\u0027))"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_generate_invalid_signature_method_defined(self):"},{"line_number":71,"context_line":"        with self.assertRaises(exception.Error):"},{"line_number":72,"context_line":"            self.signer.generate({\u0027SignatureVersion\u0027: \u00272\u0027,"},{"line_number":73,"context_line":"                                  \u0027SignatureMethod\u0027: \u0027invalid_method\u0027},"},{"line_number":74,"context_line":"                                 \u0027GET\u0027, \u0027server\u0027, \u0027/foo\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACX%2F%2F%2BFU%3D","line":71,"updated":"2011-09-29 11:56:44.000000000","message":"This syntax doesn\u0027t work with python 2.6\n\nSee commit 9f8955d270","commit_id":"d44dfb55b6d9fdcf53750422335d01cdf8c42d05"},{"author":{"_account_id":1610,"name":"Brendan Maguire","email":"B_Maguire@Dell.com","username":"b-maguire"},"change_message_id":"dd5b0e24b05c18d117fa8b915ac7e0010a35429d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                                           \u0027GET\u0027, \u0027server\u0027, \u0027/foo\u0027))"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_generate_invalid_signature_method_defined(self):"},{"line_number":71,"context_line":"        with self.assertRaises(exception.Error):"},{"line_number":72,"context_line":"            self.signer.generate({\u0027SignatureVersion\u0027: \u00272\u0027,"},{"line_number":73,"context_line":"                                  \u0027SignatureMethod\u0027: \u0027invalid_method\u0027},"},{"line_number":74,"context_line":"                                 \u0027GET\u0027, \u0027server\u0027, \u0027/foo\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACX%2F%2F%2BFE%3D","line":71,"in_reply_to":"AAAACX%2F%2F%2BFU%3D","updated":"2011-09-29 12:41:00.000000000","message":"Fixed now. Didn\u0027t realise this was an issue with 2.6.","commit_id":"d44dfb55b6d9fdcf53750422335d01cdf8c42d05"}]}