)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"08a8b1380e8d8601f881920bef50d98aaa0a90a0","unresolved":false,"context_lines":[{"line_number":1157,"context_line":"                    instance.uuid)"},{"line_number":1158,"context_line":""},{"line_number":1159,"context_line":"                # NOTE(sbauza): The original allocation is stored with a"},{"line_number":1160,"context_line":"                # customer UUID be the migration UUID"},{"line_number":1161,"context_line":"                allocations \u003d self.reportclient.get_allocs_for_consumer("},{"line_number":1162,"context_line":"                    context, migration.uuid)[\u0027allocations\u0027]"},{"line_number":1163,"context_line":"                self.driver.finish_revert_migration(context, instance,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4c43b2_35b3829a","line":1160,"range":{"start_line":1160,"start_character":18,"end_line":1160,"end_character":26},"updated":"2020-04-20 11:00:08.000000000","message":"consumer?","commit_id":"c6ff4d8747707c411a4af7d8ecfe46b34a5d27d1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"08a8b1380e8d8601f881920bef50d98aaa0a90a0","unresolved":false,"context_lines":[{"line_number":1157,"context_line":"                    instance.uuid)"},{"line_number":1158,"context_line":""},{"line_number":1159,"context_line":"                # NOTE(sbauza): The original allocation is stored with a"},{"line_number":1160,"context_line":"                # customer UUID be the migration UUID"},{"line_number":1161,"context_line":"                allocations \u003d self.reportclient.get_allocs_for_consumer("},{"line_number":1162,"context_line":"                    context, migration.uuid)[\u0027allocations\u0027]"},{"line_number":1163,"context_line":"                self.driver.finish_revert_migration(context, instance,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4c43b2_15b0068a","line":1160,"range":{"start_line":1160,"start_character":32,"end_line":1160,"end_character":34},"updated":"2020-04-20 11:00:08.000000000","message":"set to","commit_id":"c6ff4d8747707c411a4af7d8ecfe46b34a5d27d1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"08a8b1380e8d8601f881920bef50d98aaa0a90a0","unresolved":false,"context_lines":[{"line_number":4802,"context_line":""},{"line_number":4803,"context_line":"        # NOTE(sbauza): We reverted allocations earlier, now the source"},{"line_number":4804,"context_line":"        # allocation that we need to pass to the virt driver has its"},{"line_number":4805,"context_line":"        # customer UUID be the instance UUID."},{"line_number":4806,"context_line":"        allocations \u003d self.reportclient.get_allocs_for_consumer("},{"line_number":4807,"context_line":"            ctxt, instance.uuid)[\u0027allocations\u0027]"},{"line_number":4808,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4c43b2_55a60e55","line":4805,"range":{"start_line":4805,"start_character":10,"end_line":4805,"end_character":18},"updated":"2020-04-20 11:00:08.000000000","message":"consumer","commit_id":"c6ff4d8747707c411a4af7d8ecfe46b34a5d27d1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"50f73ba2eb81c9ac92506d8a3d8f368154ec9443","unresolved":false,"context_lines":[{"line_number":4802,"context_line":""},{"line_number":4803,"context_line":"        # NOTE(sbauza): We reverted allocations earlier, now the source"},{"line_number":4804,"context_line":"        # allocation that we need to pass to the virt driver has its"},{"line_number":4805,"context_line":"        # customer UUID be the instance UUID."},{"line_number":4806,"context_line":"        allocations \u003d self.reportclient.get_allocs_for_consumer("},{"line_number":4807,"context_line":"            ctxt, instance.uuid)[\u0027allocations\u0027]"},{"line_number":4808,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4c43b2_6073b8b2","line":4805,"range":{"start_line":4805,"start_character":24,"end_line":4805,"end_character":26},"updated":"2020-04-16 12:15:59.000000000","message":"nit: set to","commit_id":"c6ff4d8747707c411a4af7d8ecfe46b34a5d27d1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"50f73ba2eb81c9ac92506d8a3d8f368154ec9443","unresolved":false,"context_lines":[{"line_number":5033,"context_line":""},{"line_number":5034,"context_line":"            # NOTE(sbauza): We reverted allocations earlier, now the source"},{"line_number":5035,"context_line":"            # allocation that we need to pass to the virt driver has its"},{"line_number":5036,"context_line":"            # customer UUID be the instance UUID."},{"line_number":5037,"context_line":"            allocations \u003d self.reportclient.get_allocs_for_consumer("},{"line_number":5038,"context_line":"                context, instance.uuid)[\u0027allocations\u0027]"},{"line_number":5039,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4c43b2_a064a0e6","line":5036,"range":{"start_line":5036,"start_character":28,"end_line":5036,"end_character":30},"updated":"2020-04-16 12:15:59.000000000","message":"nit:set to","commit_id":"c6ff4d8747707c411a4af7d8ecfe46b34a5d27d1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"48a98d9e4802abb2bd96765ecdc5417e035267f0","unresolved":false,"context_lines":[{"line_number":5033,"context_line":""},{"line_number":5034,"context_line":"            # NOTE(sbauza): We reverted allocations earlier, now the source"},{"line_number":5035,"context_line":"            # allocation that we need to pass to the virt driver has its"},{"line_number":5036,"context_line":"            # customer UUID be the instance UUID."},{"line_number":5037,"context_line":"            allocations \u003d self.reportclient.get_allocs_for_consumer("},{"line_number":5038,"context_line":"                context, instance.uuid)[\u0027allocations\u0027]"},{"line_number":5039,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4c43b2_bbf851c4","line":5036,"range":{"start_line":5036,"start_character":28,"end_line":5036,"end_character":30},"in_reply_to":"3f4c43b2_a064a0e6","updated":"2020-04-16 13:10:51.000000000","message":"can be done in a FUP if needed.","commit_id":"c6ff4d8747707c411a4af7d8ecfe46b34a5d27d1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2edea58019c66afd7ae3bb6ede75edcbea31170e","unresolved":false,"context_lines":[{"line_number":5033,"context_line":""},{"line_number":5034,"context_line":"            # NOTE(sbauza): We reverted allocations earlier, now the source"},{"line_number":5035,"context_line":"            # allocation that we need to pass to the virt driver has its"},{"line_number":5036,"context_line":"            # customer UUID be the instance UUID."},{"line_number":5037,"context_line":"            allocations \u003d self.reportclient.get_allocs_for_consumer("},{"line_number":5038,"context_line":"                context, instance.uuid)[\u0027allocations\u0027]"},{"line_number":5039,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4c43b2_7bea4975","line":5036,"range":{"start_line":5036,"start_character":28,"end_line":5036,"end_character":30},"in_reply_to":"3f4c43b2_bbf851c4","updated":"2020-04-16 13:36:21.000000000","message":"yep its not important enough to justify a respin.\n\njust noticed it while reviewing is all hence nit.","commit_id":"c6ff4d8747707c411a4af7d8ecfe46b34a5d27d1"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"50f73ba2eb81c9ac92506d8a3d8f368154ec9443","unresolved":false,"context_lines":[{"line_number":21575,"context_line":""},{"line_number":21576,"context_line":"            self.drvr.finish_revert_migration("},{"line_number":21577,"context_line":"                context.get_admin_context(), ins_ref, network_info, migration,"},{"line_number":21578,"context_line":"                mock.ANY, None, power_on)"},{"line_number":21579,"context_line":""},{"line_number":21580,"context_line":"            self.assertTrue(self.fake_create_domain_called)"},{"line_number":21581,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4c43b2_2087f063","line":21578,"range":{"start_line":21578,"start_character":16,"end_line":21578,"end_character":26},"updated":"2020-04-16 12:15:59.000000000","message":"nit: im not goint to -1 over this but passing mock.ANY to a call is kind of strange.\n\nit should work but normally we do not do that. we pass an actual valid value. i dont think this will break anything but from a object type persective tis not really testing with the correct types.","commit_id":"c6ff4d8747707c411a4af7d8ecfe46b34a5d27d1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"42a60e5780c7326b13eeabcd637f0d7a0811cfd0","unresolved":false,"context_lines":[{"line_number":21575,"context_line":""},{"line_number":21576,"context_line":"            self.drvr.finish_revert_migration("},{"line_number":21577,"context_line":"                context.get_admin_context(), ins_ref, network_info, migration,"},{"line_number":21578,"context_line":"                mock.ANY, None, power_on)"},{"line_number":21579,"context_line":""},{"line_number":21580,"context_line":"            self.assertTrue(self.fake_create_domain_called)"},{"line_number":21581,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4c43b2_fb6db998","line":21578,"range":{"start_line":21578,"start_character":16,"end_line":21578,"end_character":26},"in_reply_to":"3f4c43b2_2087f063","updated":"2020-04-16 13:10:19.000000000","message":"See the later change https://review.opendev.org/#/c/712741/2/nova/tests/unit/virt/libvirt/test_driver.py@21588\n\nOf course, I could have created a fake allocations object, either a MagicMock or a dict of fake values, but I don\u0027t really see the added value in adding more complexity since we don\u0027t really have to test the called method (which is done elsewhere).\n\nI do understand using mock.ANY is like \u0027meh, anything works\u0027 and we don\u0027t really test it, but look at the method, and you can already pass *anything*. \nIf you can pass something else but allocations to _allocate_mdevs(), sure, it won\u0027t work but you\u0027ll get exceptions from this method, so the test is there, not here.","commit_id":"c6ff4d8747707c411a4af7d8ecfe46b34a5d27d1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2edea58019c66afd7ae3bb6ede75edcbea31170e","unresolved":false,"context_lines":[{"line_number":21575,"context_line":""},{"line_number":21576,"context_line":"            self.drvr.finish_revert_migration("},{"line_number":21577,"context_line":"                context.get_admin_context(), ins_ref, network_info, migration,"},{"line_number":21578,"context_line":"                mock.ANY, None, power_on)"},{"line_number":21579,"context_line":""},{"line_number":21580,"context_line":"            self.assertTrue(self.fake_create_domain_called)"},{"line_number":21581,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4c43b2_bb5fb13f","line":21578,"range":{"start_line":21578,"start_character":16,"end_line":21578,"end_character":26},"in_reply_to":"3f4c43b2_fb6db998","updated":"2020-04-16 13:36:21.000000000","message":"right but this is just the frist time i have seen mock.ANY used this way. we use it all the time in assertions or when createing mock calls for assertions but i have never see it actully passed when calling a function under test.\n\nthat is what i found odd. \n\ni would have just passed an empty dict or fake allocations.\n\nanyway we can always change this later i gues. it was just surprising to me to see you pass mock.ANY","commit_id":"c6ff4d8747707c411a4af7d8ecfe46b34a5d27d1"}]}