)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a30c6c1f82e76c1aa8faf817e48e9ecb5ddc6534","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"cce5e43d_5a4a0bc1","updated":"2021-11-04 15:01:04.000000000","message":"Adding my +2, but wondering whether you would prefer to hold merging the series until some patch, or if you prefer to let Nova eat one per one, given we\u0027re around Yoga-1","commit_id":"90c2b41f26f70526f37240683c27ca02658a9a4a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8cd16ad1a226bc807df318e7fc193261214fd56a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1a91c94b_79ef1a15","updated":"2021-10-20 15:50:15.000000000","message":"This looks good after the rework.","commit_id":"90c2b41f26f70526f37240683c27ca02658a9a4a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d58a9eb740ad6f6fd27235874bc93e274824e36b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"cf1ad00e_34cc47b4","in_reply_to":"cce5e43d_5a4a0bc1","updated":"2021-11-10 23:21:59.000000000","message":"I think it would make sense to hold merging the series until all patches are reviewed. As you have noted, if we have a partial merge, it would be possible for the config option for enabling unified limits to be present without actually enabling use of unified limits.","commit_id":"90c2b41f26f70526f37240683c27ca02658a9a4a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c7cd0e5418aacca616d933599756e38fce54c3a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"252f118b_66a3932a","updated":"2021-12-03 09:55:26.000000000","message":"+2 again but let\u0027s hold +W until all the series is merged.","commit_id":"fbf27823c9bcec570976a6b72429238ef827701f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6624fccaa15ca82fe3f5808b951740e49aab09a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"5269f48a_33b9e295","updated":"2022-01-21 01:05:43.000000000","message":"recheck bug 1950310","commit_id":"925c42263e53f1ba805431b6d64b2838c3f9843c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"58fcd4c31d7668f9443967baba29110e97b5fcf8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"75b63f45_54d2b8bc","updated":"2022-01-21 19:50:54.000000000","message":"recheck bug 1957941","commit_id":"925c42263e53f1ba805431b6d64b2838c3f9843c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"39c8584ecfd2e176ea8cca411790a6d6d69dac43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"e4c22d65_350be93f","updated":"2022-01-21 22:13:14.000000000","message":"recheck libvirt.libvirtError: operation failed: Failed to connect to remote libvirt URI qemu+ssh://stack@ubuntu-focal-ovh-bhs1-0028120270/system: Cannot recv data: kex_exchange_identification: Connection closed by remote host: Connection reset by peer","commit_id":"925c42263e53f1ba805431b6d64b2838c3f9843c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f08cfa1dbfae9ab1467a79e1818b1d3783d7db4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"2ec2a43e_c9bf1d2f","updated":"2022-01-27 19:22:14.000000000","message":"recheck Could not connect to mirror.gra1.ovh.opendev.org:443 (149.202.160.10). - connect (111: Connection refused)","commit_id":"8269b9e9f145889b5e6111b8d417aada8dc4eb27"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"67adc678de1432e9a08191f8b6393d0fc49941ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"4b842a26_2ef9b720","updated":"2022-01-27 23:27:57.000000000","message":"recheck Jan 27 21:34:56.728768 ubuntu-focal-rax-iad-0028206531 nova-compute[98082]: ERROR nova.compute.manager [None req-49f6eae5-02a9-461b-8657-7133ad10a31c demo admin] [instance: bbada1f6-31f2-48fb-a0f6-83c1a9da43d9] Setting instance vm_state to ERROR: nova.exception.HypervisorUnavailable: Connection to the hypervisor is broken on host","commit_id":"8269b9e9f145889b5e6111b8d417aada8dc4eb27"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ef43822ce75dc392b8bc24e777f66ee7c0e6d056","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"63207919_68ab107b","updated":"2022-02-24 11:32:38.000000000","message":"Now there is at least two +2s on each patch in the series so I plug the missing +A to the patches.","commit_id":"cfff74dcdd3fa94bbb7738cdbf5c41185c0868d4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9d682ee91a7599d4d2a0ff1043e21374b2d0ddf4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"5130b126_d1a1f48e","updated":"2022-02-24 16:33:44.000000000","message":"just lost +A on a rebase","commit_id":"4fbe94a98cecb150b3e2dfacdc57bf0b713a32f3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"fe78f7e46126d676aa07e2aff86f41010a9f4a4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"5be45335_3c12da51","updated":"2022-02-24 22:03:52.000000000","message":"recheck","commit_id":"4fbe94a98cecb150b3e2dfacdc57bf0b713a32f3"}],"nova/conf/quota.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"912733596ebd17a659c5eed995205fc1891731db","unresolved":false,"context_lines":[{"line_number":188,"context_line":"             \u0027options for default quota limit values. Counts quota usage \u0027"},{"line_number":189,"context_line":"             \u0027on-demand.\u0027),"},{"line_number":190,"context_line":"            (\u0027nova.quota.NoopQuotaDriver\u0027, \u0027Ignores quota and treats all \u0027"},{"line_number":191,"context_line":"             \u0027resources as unlimited.\u0027),"},{"line_number":192,"context_line":"        ],"},{"line_number":193,"context_line":"        help\u003d\"\"\""},{"line_number":194,"context_line":"Provides abstraction for quota checks. Users can configure a specific"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_6d3a2dce","line":191,"updated":"2020-03-12 17:38:11.000000000","message":"As noted in the next file, couldn\u0027t we simply add the new \"driver\" to this?","commit_id":"01abf4e3d6108349a2278236ec89393c212c01aa"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0b07cbcf8d2e12c352d567941e0ab64edbd21066","unresolved":false,"context_lines":[{"line_number":31,"context_line":"When true, we hard code the quota driver and ignore any quota"},{"line_number":32,"context_line":"override set in the database. We also ignore the config defaults"},{"line_number":33,"context_line":"for instances, cores and ram, and instead get this information"},{"line_number":34,"context_line":"from the Keystone Unified Limits APIs."},{"line_number":35,"context_line":"\"\"\"),"},{"line_number":36,"context_line":"    cfg.IntOpt(\u0027instances\u0027,"},{"line_number":37,"context_line":"        min\u003d-1,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_2383b806","line":34,"updated":"2020-03-16 23:45:13.000000000","message":"This is fine but I have a feeling we\u0027ll want a more comprehensive info in this config help. Something that includes mention of the fact that you won\u0027t want to enable this until after you\u0027ve migrated your quota limits to keystone via the nova-manage and keystone-manage tools. The way I think about options like these is they have a config help fairly similar to the release note that goes with it.","commit_id":"d08cc7941d210594f2c4e2f07eb730896b27289f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e8c220e115cbf83bb65f2898bd51fb61be2b74c2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"When true, we hard code the quota driver and ignore any quota"},{"line_number":32,"context_line":"override set in the database. We also ignore the config defaults"},{"line_number":33,"context_line":"for instances, cores and ram, and instead get this information"},{"line_number":34,"context_line":"from the Keystone Unified Limits APIs."},{"line_number":35,"context_line":"\"\"\"),"},{"line_number":36,"context_line":"    cfg.IntOpt(\u0027instances\u0027,"},{"line_number":37,"context_line":"        min\u003d-1,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_8c991421","line":34,"in_reply_to":"1fa4df85_2383b806","updated":"2020-03-23 16:53:34.000000000","message":"I agree, been struggling about when to add that in though. Adding here seems wrong, becuase it doesn\u0027t do anything yet. I was thinking of adding this as we go through into the later patches in series. Probably updating a release note as we go.","commit_id":"d08cc7941d210594f2c4e2f07eb730896b27289f"}],"nova/quota.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"912733596ebd17a659c5eed995205fc1891731db","unresolved":false,"context_lines":[{"line_number":775,"context_line":"    paths still work with unified limits. Eventually the expectation is"},{"line_number":776,"context_line":"    all this legacy quota code will go away, leaving the new simpler code"},{"line_number":777,"context_line":"    \"\"\""},{"line_number":778,"context_line":"    pass"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"class BaseResource(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_2d3435de","line":778,"updated":"2020-03-12 17:38:11.000000000","message":"Do we need to raise NotImplementedError from here until this is complete?","commit_id":"01abf4e3d6108349a2278236ec89393c212c01aa"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0710759c8fc18c4c1843d1d1520ac6438164af1a","unresolved":false,"context_lines":[{"line_number":775,"context_line":"    paths still work with unified limits. Eventually the expectation is"},{"line_number":776,"context_line":"    all this legacy quota code will go away, leaving the new simpler code"},{"line_number":777,"context_line":"    \"\"\""},{"line_number":778,"context_line":"    pass"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"class BaseResource(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_7adf1d3a","line":778,"in_reply_to":"1fa4df85_2d3435de","updated":"2020-03-16 11:03:58.000000000","message":"To be clear, this is just the Noop Quota driver that works today. Rather than break everything, I am establish what happens with the noop driver, then adding more limits as we go through the patches... this needs to go in the commit message really.","commit_id":"01abf4e3d6108349a2278236ec89393c212c01aa"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"912733596ebd17a659c5eed995205fc1891731db","unresolved":false,"context_lines":[{"line_number":885,"context_line":"    def _driver(self):"},{"line_number":886,"context_line":"        if self.__driver:"},{"line_number":887,"context_line":"            return self.__driver"},{"line_number":888,"context_line":"        driver_name \u003d CONF.quota.driver"},{"line_number":889,"context_line":"        if CONF.quota.use_unified_limits:"},{"line_number":890,"context_line":"            # NOTE(johngarbutt) eventually this whole code file will get"},{"line_number":891,"context_line":"            # deleted, but for now we use the unified limit compatibility"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_6d11cd53","line":888,"range":{"start_line":888,"start_character":22,"end_line":888,"end_character":39},"updated":"2020-03-12 17:38:11.000000000","message":"Any reason we\u0027re not using this for the unified limits driver? I assume we want to do away with this configuration option entirely?","commit_id":"01abf4e3d6108349a2278236ec89393c212c01aa"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0710759c8fc18c4c1843d1d1520ac6438164af1a","unresolved":false,"context_lines":[{"line_number":885,"context_line":"    def _driver(self):"},{"line_number":886,"context_line":"        if self.__driver:"},{"line_number":887,"context_line":"            return self.__driver"},{"line_number":888,"context_line":"        driver_name \u003d CONF.quota.driver"},{"line_number":889,"context_line":"        if CONF.quota.use_unified_limits:"},{"line_number":890,"context_line":"            # NOTE(johngarbutt) eventually this whole code file will get"},{"line_number":891,"context_line":"            # deleted, but for now we use the unified limit compatibility"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_fac30d56","line":888,"range":{"start_line":888,"start_character":22,"end_line":888,"end_character":39},"in_reply_to":"1fa4df85_6d11cd53","updated":"2020-03-16 11:03:58.000000000","message":"Yes, we will kill this long term.\n\nJust doing what we agreed in the spec here really.","commit_id":"01abf4e3d6108349a2278236ec89393c212c01aa"}]}