)]}'
{"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0eeb6661968c1f809f981311ffd09ab9573bd404","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    exception.BadRequirementEmulatorThreadsPolicy,"},{"line_number":59,"context_line":"    exception.CPUThreadPolicyConfigurationInvalid,"},{"line_number":60,"context_line":"    exception.FlavorImageConflict,"},{"line_number":61,"context_line":"    exception.FlavorDiskTooSmall,"},{"line_number":62,"context_line":"    exception.FlavorMemoryTooSmall,"},{"line_number":63,"context_line":"    exception.ImageCPUPinningForbidden,"},{"line_number":64,"context_line":"    exception.ImageCPUThreadPolicyForbidden,"},{"line_number":65,"context_line":"    exception.ImageNUMATopologyAsymmetric,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_82363050","line":62,"range":{"start_line":61,"start_character":4,"end_line":62,"end_character":35},"updated":"2020-05-21 10:23:22.000000000","message":"am you you also be adding FlavorDiskSmallerThanMinDisk here\nsince you mentioned it in the commit message and i dont see it in the list.","commit_id":"efdcaf00e01b12ac15b938392b2f4b9e7db5eff1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"64494503c2af78fb664e37186ed839a010c938d5","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    exception.BadRequirementEmulatorThreadsPolicy,"},{"line_number":59,"context_line":"    exception.CPUThreadPolicyConfigurationInvalid,"},{"line_number":60,"context_line":"    exception.FlavorImageConflict,"},{"line_number":61,"context_line":"    exception.FlavorDiskTooSmall,"},{"line_number":62,"context_line":"    exception.FlavorMemoryTooSmall,"},{"line_number":63,"context_line":"    exception.ImageCPUPinningForbidden,"},{"line_number":64,"context_line":"    exception.ImageCPUThreadPolicyForbidden,"},{"line_number":65,"context_line":"    exception.ImageNUMATopologyAsymmetric,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_613bacea","line":62,"range":{"start_line":61,"start_character":4,"end_line":62,"end_character":35},"in_reply_to":"ff570b3c_023be7c7","updated":"2020-05-28 08:27:23.000000000","message":"Yeah apologies I was thinking that this somehow impacted the observability of the codebase but as you point out it was already done before and grepping one of the subclasses will quickly show they are using FlavorDiskTooSmall as a parent.","commit_id":"efdcaf00e01b12ac15b938392b2f4b9e7db5eff1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"2f2ee8a05ab658f291d1457fc7b7e2126371cd45","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    exception.BadRequirementEmulatorThreadsPolicy,"},{"line_number":59,"context_line":"    exception.CPUThreadPolicyConfigurationInvalid,"},{"line_number":60,"context_line":"    exception.FlavorImageConflict,"},{"line_number":61,"context_line":"    exception.FlavorDiskTooSmall,"},{"line_number":62,"context_line":"    exception.FlavorMemoryTooSmall,"},{"line_number":63,"context_line":"    exception.ImageCPUPinningForbidden,"},{"line_number":64,"context_line":"    exception.ImageCPUThreadPolicyForbidden,"},{"line_number":65,"context_line":"    exception.ImageNUMATopologyAsymmetric,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_ec27cc63","line":62,"range":{"start_line":61,"start_character":4,"end_line":62,"end_character":35},"in_reply_to":"ff570b3c_19454b71","updated":"2020-05-27 08:47:34.000000000","message":"Can we just be explicit and add all three here?","commit_id":"efdcaf00e01b12ac15b938392b2f4b9e7db5eff1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e00e306f6a12e6f85093543c870a9ab38b4e539a","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    exception.BadRequirementEmulatorThreadsPolicy,"},{"line_number":59,"context_line":"    exception.CPUThreadPolicyConfigurationInvalid,"},{"line_number":60,"context_line":"    exception.FlavorImageConflict,"},{"line_number":61,"context_line":"    exception.FlavorDiskTooSmall,"},{"line_number":62,"context_line":"    exception.FlavorMemoryTooSmall,"},{"line_number":63,"context_line":"    exception.ImageCPUPinningForbidden,"},{"line_number":64,"context_line":"    exception.ImageCPUThreadPolicyForbidden,"},{"line_number":65,"context_line":"    exception.ImageNUMATopologyAsymmetric,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_d96f7a25","line":62,"range":{"start_line":61,"start_character":4,"end_line":62,"end_character":35},"in_reply_to":"ff570b3c_82363050","updated":"2020-05-21 16:11:22.000000000","message":"exception.FlavorDiskSmallerThanMinDisk is subclass of FlavorDiskTooSmall, so by catching that we catch both","commit_id":"efdcaf00e01b12ac15b938392b2f4b9e7db5eff1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b7d5bf6a2dca34d56f12d555986b3f781f54d362","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    exception.BadRequirementEmulatorThreadsPolicy,"},{"line_number":59,"context_line":"    exception.CPUThreadPolicyConfigurationInvalid,"},{"line_number":60,"context_line":"    exception.FlavorImageConflict,"},{"line_number":61,"context_line":"    exception.FlavorDiskTooSmall,"},{"line_number":62,"context_line":"    exception.FlavorMemoryTooSmall,"},{"line_number":63,"context_line":"    exception.ImageCPUPinningForbidden,"},{"line_number":64,"context_line":"    exception.ImageCPUThreadPolicyForbidden,"},{"line_number":65,"context_line":"    exception.ImageNUMATopologyAsymmetric,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_19454b71","line":62,"range":{"start_line":61,"start_character":4,"end_line":62,"end_character":35},"in_reply_to":"ff570b3c_d96f7a25","updated":"2020-05-25 07:33:58.000000000","message":"ah ok then yes this will work thanks.\n\nit was just confusing that you referenced 3 exceptions in the commit message but only added 2.\n\ni would kind of prefer if we did not rely on the inheritance relationship and listed them explicitly but this will work so ill change my -1 to +1","commit_id":"efdcaf00e01b12ac15b938392b2f4b9e7db5eff1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"11e450097c9ce3b290b5d054c71b864bf38db483","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    exception.BadRequirementEmulatorThreadsPolicy,"},{"line_number":59,"context_line":"    exception.CPUThreadPolicyConfigurationInvalid,"},{"line_number":60,"context_line":"    exception.FlavorImageConflict,"},{"line_number":61,"context_line":"    exception.FlavorDiskTooSmall,"},{"line_number":62,"context_line":"    exception.FlavorMemoryTooSmall,"},{"line_number":63,"context_line":"    exception.ImageCPUPinningForbidden,"},{"line_number":64,"context_line":"    exception.ImageCPUThreadPolicyForbidden,"},{"line_number":65,"context_line":"    exception.ImageNUMATopologyAsymmetric,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_023be7c7","line":62,"range":{"start_line":61,"start_character":4,"end_line":62,"end_character":35},"in_reply_to":"ff570b3c_ec27cc63","updated":"2020-05-27 10:03:39.000000000","message":"I _could_, but it goes against my distant future goal of introducing a lot more inheritance of exceptions so we can get rid of code like this. I suspect whoever added these before was thinking along the same lines to say they did things this way. Would you be amenable to a more explicit commit message?","commit_id":"efdcaf00e01b12ac15b938392b2f4b9e7db5eff1"}]}