)]}'
{"tox.ini":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e1397e65e5157533e43c037a3dbb47884e8f1ef","unresolved":false,"context_lines":[{"line_number":319,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":320,"context_line":"  -r{toxinidir}/requirements.txt"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"[testenv:bashate]"},{"line_number":323,"context_line":"# if you want to test out some changes you have made to bashate"},{"line_number":324,"context_line":"# against devstack, just set BASHATE_INSTALL_PATH\u003d/path/... to your"},{"line_number":325,"context_line":"# modified bashate tree"}],"source_content_type":"text/x-properties","patch_set":1,"id":"ff570b3c_3885655b","line":322,"range":{"start_line":322,"start_character":9,"end_line":322,"end_character":16},"updated":"2020-05-14 09:40:31.000000000","message":"by the way instead of adding bashate\nwe might want to just add the linters env instead\nsince that semi stardardised now across openstack projects.\nand then we can add the linters job.\n\nhttps://github.com/openstack/openstack-zuul-jobs/blob/master/zuul.d/jobs.yaml#L186-L195","commit_id":"4293ba4f8abd2d1163b7846f434078048ef7aadb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0b6cd38948f4ca4ce70e2838dc3cdfcad5b413c8","unresolved":false,"context_lines":[{"line_number":320,"context_line":"  -r{toxinidir}/requirements.txt"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"[testenv:bashate]"},{"line_number":323,"context_line":"# if you want to test out some changes you have made to bashate"},{"line_number":324,"context_line":"# against devstack, just set BASHATE_INSTALL_PATH\u003d/path/... to your"},{"line_number":325,"context_line":"# modified bashate tree"},{"line_number":326,"context_line":"deps \u003d"},{"line_number":327,"context_line":"   {env:BASHATE_INSTALL_PATH:bashate\u003d\u003d0.5.1}"},{"line_number":328,"context_line":"whitelist_externals \u003d bash"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1fa4df85_2d8ff1cd","line":325,"range":{"start_line":323,"start_character":0,"end_line":325,"end_character":23},"updated":"2020-03-19 14:31:10.000000000","message":"I assume this is for dev use only and will be dropped before the removal of the WIP tag?","commit_id":"4293ba4f8abd2d1163b7846f434078048ef7aadb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c7423b871c9ea9251776c29e6975e304958d1887","unresolved":false,"context_lines":[{"line_number":320,"context_line":"  -r{toxinidir}/requirements.txt"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"[testenv:bashate]"},{"line_number":323,"context_line":"# if you want to test out some changes you have made to bashate"},{"line_number":324,"context_line":"# against devstack, just set BASHATE_INSTALL_PATH\u003d/path/... to your"},{"line_number":325,"context_line":"# modified bashate tree"},{"line_number":326,"context_line":"deps \u003d"},{"line_number":327,"context_line":"   {env:BASHATE_INSTALL_PATH:bashate\u003d\u003d0.5.1}"},{"line_number":328,"context_line":"whitelist_externals \u003d bash"}],"source_content_type":"text/x-properties","patch_set":1,"id":"ff570b3c_e4feaa35","line":325,"range":{"start_line":323,"start_character":0,"end_line":325,"end_character":23},"in_reply_to":"1fa4df85_2d8ff1cd","updated":"2020-05-14 07:31:36.000000000","message":"i would assume that too.","commit_id":"4293ba4f8abd2d1163b7846f434078048ef7aadb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c7423b871c9ea9251776c29e6975e304958d1887","unresolved":false,"context_lines":[{"line_number":323,"context_line":"# if you want to test out some changes you have made to bashate"},{"line_number":324,"context_line":"# against devstack, just set BASHATE_INSTALL_PATH\u003d/path/... to your"},{"line_number":325,"context_line":"# modified bashate tree"},{"line_number":326,"context_line":"deps \u003d"},{"line_number":327,"context_line":"   {env:BASHATE_INSTALL_PATH:bashate\u003d\u003d0.5.1}"},{"line_number":328,"context_line":"whitelist_externals \u003d bash"},{"line_number":329,"context_line":"commands \u003d bash -c \"find {toxinidir}             \\"},{"line_number":330,"context_line":"         -not \\( -type d -name .?\\* -prune \\)    \\"}],"source_content_type":"text/x-properties","patch_set":1,"id":"ff570b3c_24bf0262","line":327,"range":{"start_line":326,"start_character":0,"end_line":327,"end_character":44},"updated":"2020-05-14 07:31:36.000000000","message":"i don\u0027t think we shoudl be using deps to install this\nwe shoudl add it into test-requiremets.txt or add a\nnew requirements file in the tools directory","commit_id":"4293ba4f8abd2d1163b7846f434078048ef7aadb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0b6cd38948f4ca4ce70e2838dc3cdfcad5b413c8","unresolved":false,"context_lines":[{"line_number":331,"context_line":"         -not \\( -type d -name doc -prune \\)     \\"},{"line_number":332,"context_line":"         -not \\( -type f -name localrc -prune \\) \\"},{"line_number":333,"context_line":"         -type f                                 \\"},{"line_number":334,"context_line":"         -not -name \\*~                          \\"},{"line_number":335,"context_line":"         -not -name \\*.md                        \\"},{"line_number":336,"context_line":"         -not -name stack-screenrc               \\"},{"line_number":337,"context_line":"         -not -name \\*.orig                      \\"},{"line_number":338,"context_line":"         -not -name \\*.rej                       \\"},{"line_number":339,"context_line":"         \\(                                      \\"},{"line_number":340,"context_line":"          -name \\*.sh -or                        \\"},{"line_number":341,"context_line":"          -name \\*rc -or                         \\"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1fa4df85_6db2c996","line":338,"range":{"start_line":334,"start_character":0,"end_line":338,"end_character":50},"updated":"2020-03-19 14:31:10.000000000","message":"Assume this is copy pasted. I wonder if it\u0027s necessary?","commit_id":"4293ba4f8abd2d1163b7846f434078048ef7aadb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c7423b871c9ea9251776c29e6975e304958d1887","unresolved":false,"context_lines":[{"line_number":331,"context_line":"         -not \\( -type d -name doc -prune \\)     \\"},{"line_number":332,"context_line":"         -not \\( -type f -name localrc -prune \\) \\"},{"line_number":333,"context_line":"         -type f                                 \\"},{"line_number":334,"context_line":"         -not -name \\*~                          \\"},{"line_number":335,"context_line":"         -not -name \\*.md                        \\"},{"line_number":336,"context_line":"         -not -name stack-screenrc               \\"},{"line_number":337,"context_line":"         -not -name \\*.orig                      \\"},{"line_number":338,"context_line":"         -not -name \\*.rej                       \\"},{"line_number":339,"context_line":"         \\(                                      \\"},{"line_number":340,"context_line":"          -name \\*.sh -or                        \\"},{"line_number":341,"context_line":"          -name \\*rc -or                         \\"}],"source_content_type":"text/x-properties","patch_set":1,"id":"ff570b3c_64473a7a","line":338,"range":{"start_line":334,"start_character":0,"end_line":338,"end_character":50},"in_reply_to":"1fa4df85_6db2c996","updated":"2020-05-14 07:31:36.000000000","message":"well for the precommit run i jsut did\n\n find -name *.sh | xargs pre-commit run --files\n\nso i think this whole command  can just be \n\n find -name *.sh | xargs bashate -v -iE006 -eE005,E042\n\nalthough\n\nfind -maxdepth 1 -type d -not -name \u0027.*\u0027 | xargs -n 1 -I \u0027{}\u0027 echo -path \"{}/*\" |  xargs -n 2 find -name \"*.sh\" | xargs bashate -v -iE006 -eE005,E042\n\n\nis proably better\n\nubuntu@cyborg-2:/opt/repos/nova$ find -maxdepth 1 -type d -not -name \u0027.*\u0027 | xargs -n 1 -I \u0027{}\u0027 echo -path \"{}/*\" |  xargs -n 2 find -name \"*.sh\" | xargs bashate -v -iE006 -eE005,E042\nRunning bashate on ./nova/tests/unit/ssl_cert/new_cert.sh\n./nova/tests/unit/ssl_cert/new_cert.sh:4:1: E003 Indent not multiple of 4\n./nova/tests/unit/ssl_cert/new_cert.sh:8:1: E003 Indent not multiple of 4\n./nova/tests/unit/ssl_cert/new_cert.sh:8:1: E003 Indent not multiple of 4\n./nova/tests/unit/ssl_cert/new_cert.sh:8:1: E003 Indent not multiple of 4\nRunning bashate on ./gate/test_evacuate.sh\n./gate/test_evacuate.sh:16:1: E003 Indent not multiple of 4\n./gate/test_evacuate.sh:17:1: E003 Indent not multiple of 4\n./gate/test_evacuate.sh:70:1: E020 Function declaration not in format ^function name {$\n./gate/test_evacuate.sh:79:1: E010 The \"do\" should be on same line as while\n./gate/test_evacuate.sh:101:1: E010 The \"do\" should be on same line as while\n./gate/test_evacuate.sh:112:1: E020 Function declaration not in format ^function name {$\n./gate/test_evacuate.sh:119:1: E010 The \"do\" should be on same line as while\nRunning bashate on ./gate/live_migration/hooks/utils.sh\n./gate/live_migration/hooks/utils.sh:9:1: E003 Indent not multiple of 4\nRunning bashate on ./gate/live_migration/hooks/run_tests.sh\nRunning bashate on ./gate/live_migration/hooks/ceph.sh\n./gate/live_migration/hooks/ceph.sh:165:1: E042 local declaration hides errors\nRunning bashate on ./gate/live_migration/hooks/nfs.sh\nRunning bashate on ./gate/post_test_hook.sh\n./gate/post_test_hook.sh:88:1: E003 Indent not multiple of 4\n./gate/post_test_hook.sh:108:1: E020 Function declaration not in format ^function name {$\n./gate/post_test_hook.sh:165:1: E003 Indent not multiple of 4\n./gate/post_test_hook.sh:193:1: E003 Indent not multiple of 4\n./gate/post_test_hook.sh:229:1: E003 Indent not multiple of 4\nRunning bashate on ./tools/run-tests-for-diff.sh\nRunning bashate on ./tools/abandon_old_reviews.sh\nRunning bashate on ./tools/xenserver/rotate_xen_guest_logs.sh\nRunning bashate on ./tools/build_latex_pdf.sh\nRunning bashate on ./tools/hooks/post_test_hook.sh\n./tools/hooks/post_test_hook.sh:88:1: E003 Indent not multiple of 4\n./tools/hooks/post_test_hook.sh:108:1: E020 Function declaration not in format ^function name {$\n./tools/hooks/post_test_hook.sh:165:1: E003 Indent not multiple of 4\n./tools/hooks/post_test_hook.sh:193:1: E003 Indent not multiple of 4\n./tools/hooks/post_test_hook.sh:229:1: E003 Indent not multiple of 4\nRunning bashate on ./tools/test-setup.sh\n./tools/test-setup.sh:39:1: E003 Indent not multiple of 4\nRunning bashate on ./tools/flake8wrap.sh\n24 bashate error(s) found","commit_id":"4293ba4f8abd2d1163b7846f434078048ef7aadb"}]}