)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4c05cbdb1343f3c82ea9ab7f4bc6dd179db1a9c0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-03-16 13:30:34 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix ut error on arm64"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I240e7a1fdd2996957a5d7990e263eeff2b5eebaa"},{"line_number":10,"context_line":"Signed-off-by: Kevin Zhao \u003ckevin.zhao@linaro.org\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df33271e_752094b1","line":8,"updated":"2020-03-26 20:12:47.000000000","message":"What\u0027s the ut error on arm64? Can we please have a little more info about what is the problem in the commit message? :)","commit_id":"eb90c51bbb82be6229ca1522b75ee8b8c2d48ac7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"72637dda834325af2abf8b978eb6705069081fac","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix ut error on Aarch64(And other non-x86 platform)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some ut tests are architecture releated with x86, so add"},{"line_number":10,"context_line":"architecture to fix them."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-bug: #1869707"},{"line_number":13,"context_line":"Change-Id: I240e7a1fdd2996957a5d7990e263eeff2b5eebaa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff570b3c_64b3baeb","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":25},"updated":"2020-05-14 06:52:54.000000000","message":"yep the behavior should not change depening on what host you run them on thanks :)","commit_id":"eff787626fcc6c5c3e800422273ac54c0d18c704"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4c0e5d007f69a093133e01154798320d2ef505c9","unresolved":false,"context_lines":[{"line_number":3001,"context_line":"                                self._test_sev_enabled,"},{"line_number":3002,"context_line":"                                host_sev_enabled\u003dTrue, enc_extra_spec\u003dTrue,"},{"line_number":3003,"context_line":"                                hw_firmware_type\u003d\u0027uefi\u0027)"},{"line_number":3004,"context_line":"        if fields.Architecture.from_host() \u003d\u003d fields.Architecture.AARCH64:"},{"line_number":3005,"context_line":"            self.assertEqual("},{"line_number":3006,"context_line":"                \"Machine type \u0027virt\u0027 is not compatible with image fake_image \""},{"line_number":3007,"context_line":"                \"(150d530b-1c57-4367-b754-1f1b5237923d): q35 type is required \""},{"line_number":3008,"context_line":"                \"for SEV to work\", str(exc))"},{"line_number":3009,"context_line":"        else:"},{"line_number":3010,"context_line":"            self.assertEqual("},{"line_number":3011,"context_line":"                \"Machine type \u0027pc\u0027 is not compatible with image fake_image \""},{"line_number":3012,"context_line":"                \"(150d530b-1c57-4367-b754-1f1b5237923d): q35 type is required \""},{"line_number":3013,"context_line":"                \"for SEV to work\", str(exc))"},{"line_number":3014,"context_line":""},{"line_number":3015,"context_line":"    def test_sev_enabled_host_extra_spec_pc(self):"},{"line_number":3016,"context_line":"        exc \u003d self.assertRaises(exception.InvalidMachineType,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_bfaea27e","line":3013,"range":{"start_line":3004,"start_character":0,"end_line":3013,"end_character":44},"updated":"2020-05-07 09:43:25.000000000","message":"Instead of doing this, could you use a regex and \u0027self.assertRegexpMatches\u0027?\n\n  self.assertRegexpMatches(\n      \"Machine type \u0027\\w+\u0027 is not compatible ....\",\n      str(exc),\n  )\n\nThat\u0027ll fix things for other architectures too","commit_id":"eb90c51bbb82be6229ca1522b75ee8b8c2d48ac7"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ac82d39b4140a065d8d529c5024a54ec774d2ed9","unresolved":false,"context_lines":[{"line_number":4837,"context_line":"                                  vconfig.LibvirtConfigGuestDisk)"},{"line_number":4838,"context_line":"            self.assertIn(\u0027disk.config\u0027, cfg.devices[2].source_path)"},{"line_number":4839,"context_line":"            guestarch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":4840,"context_line":"            if guestarch in ("},{"line_number":4841,"context_line":"                    fields.Architecture.PPC,"},{"line_number":4842,"context_line":"                    fields.Architecture.PPC64,"},{"line_number":4843,"context_line":"                    fields.Architecture.PPCLE,"},{"line_number":4844,"context_line":"                    fields.Architecture.PPC64LE,"},{"line_number":4845,"context_line":"                    fields.Architecture.S390,"},{"line_number":4846,"context_line":"                    fields.Architecture.S390X,"},{"line_number":4847,"context_line":"                    fields.Architecture.AARCH64):"},{"line_number":4848,"context_line":"                self.assertEqual(\u0027sdd\u0027, cfg.devices[2].target_dev)"},{"line_number":4849,"context_line":"                self.assertEqual(\u0027scsi\u0027, cfg.devices[2].target_bus)"},{"line_number":4850,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_b7703e0a","line":4847,"range":{"start_line":4840,"start_character":11,"end_line":4847,"end_character":49},"updated":"2020-03-17 09:19:14.000000000","message":"probably easier would be to do reverse\n\nif x86 then hda/ide, else sdd/scsi.\n\nand what if virtio_blk gets used?","commit_id":"eb90c51bbb82be6229ca1522b75ee8b8c2d48ac7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4c0e5d007f69a093133e01154798320d2ef505c9","unresolved":false,"context_lines":[{"line_number":4837,"context_line":"                                  vconfig.LibvirtConfigGuestDisk)"},{"line_number":4838,"context_line":"            self.assertIn(\u0027disk.config\u0027, cfg.devices[2].source_path)"},{"line_number":4839,"context_line":"            guestarch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":4840,"context_line":"            if guestarch in ("},{"line_number":4841,"context_line":"                    fields.Architecture.PPC,"},{"line_number":4842,"context_line":"                    fields.Architecture.PPC64,"},{"line_number":4843,"context_line":"                    fields.Architecture.PPCLE,"},{"line_number":4844,"context_line":"                    fields.Architecture.PPC64LE,"},{"line_number":4845,"context_line":"                    fields.Architecture.S390,"},{"line_number":4846,"context_line":"                    fields.Architecture.S390X,"},{"line_number":4847,"context_line":"                    fields.Architecture.AARCH64):"},{"line_number":4848,"context_line":"                self.assertEqual(\u0027sdd\u0027, cfg.devices[2].target_dev)"},{"line_number":4849,"context_line":"                self.assertEqual(\u0027scsi\u0027, cfg.devices[2].target_bus)"},{"line_number":4850,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_7f3fca24","line":4847,"range":{"start_line":4840,"start_character":11,"end_line":4847,"end_character":49},"in_reply_to":"1fa4df85_b7703e0a","updated":"2020-05-07 09:43:25.000000000","message":"Agreed. This would make sense","commit_id":"eb90c51bbb82be6229ca1522b75ee8b8c2d48ac7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1b20cdc236a8126eedb939f6dd07e203f70420fc","unresolved":false,"context_lines":[{"line_number":3078,"context_line":"                                self._test_sev_enabled,"},{"line_number":3079,"context_line":"                                host_sev_enabled\u003dTrue, enc_extra_spec\u003dTrue,"},{"line_number":3080,"context_line":"                                hw_firmware_type\u003d\u0027uefi\u0027)"},{"line_number":3081,"context_line":""},{"line_number":3082,"context_line":"        self.assertEqual("},{"line_number":3083,"context_line":"            \"Machine type \u0027pc\u0027 is not compatible with image fake_image \""},{"line_number":3084,"context_line":"            \"(150d530b-1c57-4367-b754-1f1b5237923d): q35 type is required \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4c43b2_1aa7d551","line":3081,"updated":"2020-04-15 14:27:16.000000000","message":"unnecessary change","commit_id":"0b9407baf52ba207c2f8f1bf14363dbaed8bcfee"}],"nova/virt/libvirt/blockinfo.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4c05cbdb1343f3c82ea9ab7f4bc6dd179db1a9c0","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                        obj_fields.Architecture.S390X,"},{"line_number":280,"context_line":"                        obj_fields.Architecture.AARCH64):"},{"line_number":281,"context_line":"                    return \"scsi\""},{"line_number":282,"context_line":"                else:"},{"line_number":283,"context_line":"                    return \"ide\""},{"line_number":284,"context_line":"        elif device_type \u003d\u003d \"disk\":"},{"line_number":285,"context_line":"            return \"virtio\""}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_18297d89","line":282,"updated":"2020-03-26 20:12:47.000000000","message":"As sean-k-mooney mentioned on the other patch:\n\nhttps://review.opendev.org/#/c/709494/3/nova/virt/libvirt/blockinfo.py@282\n\nthis causes a change in behavior ... which seems wrong to change implementation in order to fix a unit test failure? Is there really no other way?\n\nIt would be helpful if you could write up a launchpad bug about this (and use Closes-Bug in the commit message) to include the details so we can all look and understand what\u0027s the best way to approach getting the tests to work on arm64.","commit_id":"eb90c51bbb82be6229ca1522b75ee8b8c2d48ac7"}]}