)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4a37941df524c2fac5f8c768206ae5bc038cef76","unresolved":false,"context_lines":[{"line_number":3471,"context_line":"            # ensure that the port is unbound from the source node"},{"line_number":3472,"context_line":"            # before setting up the networking on the destination."},{"line_number":3473,"context_line":"            self.network_api.cleanup_instance_network_on_host("},{"line_number":3474,"context_line":"                context, instance, migration.source_compute)"},{"line_number":3475,"context_line":"            self.network_api.setup_networks_on_host("},{"line_number":3476,"context_line":"                    context, instance, self.host)"},{"line_number":3477,"context_line":"            # For nova-network this is needed to move floating IPs"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_0336bce8","line":3474,"range":{"start_line":3474,"start_character":35,"end_line":3474,"end_character":59},"updated":"2020-03-16 23:03:49.000000000","message":"maybe i should use instance.host here but im not sure what it will be set to at this point.\n\ni think instance.host would still point to the source node it is evaucating from as we would not be useing self.host below if it was the dest host.","commit_id":"8a5551119022955c9ec58b5aae4de5817a3d1bc1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"848825128112de3d6f309d9cf7b69a8ff884c733","unresolved":false,"context_lines":[{"line_number":3471,"context_line":"            # ensure that the port is unbound from the source node"},{"line_number":3472,"context_line":"            # before setting up the networking on the destination."},{"line_number":3473,"context_line":"            self.network_api.cleanup_instance_network_on_host("},{"line_number":3474,"context_line":"                context, instance, migration.source_compute)"},{"line_number":3475,"context_line":"            self.network_api.setup_networks_on_host("},{"line_number":3476,"context_line":"                    context, instance, self.host)"},{"line_number":3477,"context_line":"            # For nova-network this is needed to move floating IPs"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_ee6faef9","line":3474,"range":{"start_line":3474,"start_character":35,"end_line":3474,"end_character":59},"in_reply_to":"1fa4df85_0336bce8","updated":"2020-03-18 09:10:00.000000000","message":"While I think you could use instance.host I think using migration.source_compute is actually easier for future readers to understand at a glance what you are trying to do here. Without having to know the context of when instance.host is set in this flow.","commit_id":"8a5551119022955c9ec58b5aae4de5817a3d1bc1"}]}