)]}'
{"nova/tests/unit/policies/test_flavor_access.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c502d38fce0de947905ef1cae2d52563fec7165f","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        # Check that everyone is able to list flavor access"},{"line_number":66,"context_line":"        # information which is nothing but bug#1867840."},{"line_number":67,"context_line":"        self.admin_or_owner_authorized_contexts \u003d ["},{"line_number":68,"context_line":"            self.legacy_admin_context, self.system_admin_context,"},{"line_number":69,"context_line":"            self.project_admin_context, self.project_member_context,"},{"line_number":70,"context_line":"            self.project_reader_context, self.project_foo_context,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_d5101f03","line":67,"range":{"start_line":67,"start_character":13,"end_line":67,"end_character":47},"updated":"2020-03-19 17:55:11.000000000","message":"Is this not \"all_authorized_users\"? or maybe \"list flavor access?\"","commit_id":"3393d998203be0cfb1e09f17316177b73343cfdc"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9e5e6a72fac9dc66ed87600e12ee70cbbb2e40a8","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        # Check that everyone is able to list flavor access"},{"line_number":66,"context_line":"        # information which is nothing but bug#1867840."},{"line_number":67,"context_line":"        self.admin_or_owner_authorized_contexts \u003d ["},{"line_number":68,"context_line":"            self.legacy_admin_context, self.system_admin_context,"},{"line_number":69,"context_line":"            self.project_admin_context, self.project_member_context,"},{"line_number":70,"context_line":"            self.project_reader_context, self.project_foo_context,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_544508b3","line":67,"range":{"start_line":67,"start_character":13,"end_line":67,"end_character":47},"in_reply_to":"1fa4df85_75db6bec","updated":"2020-03-20 09:14:38.000000000","message":"yeah, OK, lets go with it for now. We can discuss it in that later patch.","commit_id":"3393d998203be0cfb1e09f17316177b73343cfdc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d86299b44d26b7db935d870c8dd00a4bbaa32eb5","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        # Check that everyone is able to list flavor access"},{"line_number":66,"context_line":"        # information which is nothing but bug#1867840."},{"line_number":67,"context_line":"        self.admin_or_owner_authorized_contexts \u003d ["},{"line_number":68,"context_line":"            self.legacy_admin_context, self.system_admin_context,"},{"line_number":69,"context_line":"            self.project_admin_context, self.project_member_context,"},{"line_number":70,"context_line":"            self.project_reader_context, self.project_foo_context,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_75db6bec","line":67,"range":{"start_line":67,"start_character":13,"end_line":67,"end_character":47},"in_reply_to":"1fa4df85_d5101f03","updated":"2020-03-19 18:13:57.000000000","message":"actually it is bug because we do not pass the owner to policy which is admin_or_owner by default. and owner in flavor case are multiple.\n\nOne way is to fix that bug as separate[1] and then add these tests on top of that. Hut question is it will disallow everyone to access this policy and only allow all tenants who have access to flavor. That should be ok as that should be expected behaviour. what you say ?\n\n[1]by adding the multiple owner enforcement things as commented in https://review.opendev.org/#/c/713697/3/nova/policies/flavor_access.py@68","commit_id":"3393d998203be0cfb1e09f17316177b73343cfdc"}]}