)]}'
{"nova/test.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"bda9161f3f36a552b0139fca4c48fb58fb2f4315","unresolved":false,"context_lines":[{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        return svc.service"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def _start_compute(self, host, cell_name\u003dNone):"},{"line_number":427,"context_line":"        \"\"\"Start a nova compute service on the given host"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        :param host: the name of the host that will be associated to the"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_da890027","line":426,"range":{"start_line":426,"start_character":8,"end_line":426,"end_character":9},"updated":"2020-03-24 14:04:35.000000000","message":"Seems a little weird for this to be a semi-private _function when it calls start_service which is not...","commit_id":"52b020c8b8abae21413055dd541620a9bee96d9c"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"660ab0f49a4dd2e7251f8342c1c1fc4d2e84513b","unresolved":false,"context_lines":[{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        return svc.service"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def _start_compute(self, host, cell_name\u003dNone):"},{"line_number":427,"context_line":"        \"\"\"Start a nova compute service on the given host"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        :param host: the name of the host that will be associated to the"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_3a52ac68","line":426,"range":{"start_line":426,"start_character":8,"end_line":426,"end_character":9},"in_reply_to":"df33271e_da890027","updated":"2020-03-24 14:11:05.000000000","message":"Yeah, would be cleaner without the _.\n\nI can do it in a fup.","commit_id":"52b020c8b8abae21413055dd541620a9bee96d9c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"bda9161f3f36a552b0139fca4c48fb58fb2f4315","unresolved":false,"context_lines":[{"line_number":433,"context_line":"        :return: the nova compute service object"},{"line_number":434,"context_line":"        \"\"\""},{"line_number":435,"context_line":"        compute \u003d self.start_service(\u0027compute\u0027, host\u003dhost, cell_name\u003dcell_name)"},{"line_number":436,"context_line":"        # If this is the first compute service we\u0027re starting, we need to first"},{"line_number":437,"context_line":"        # create an empty self.comptes dict to keep track of the services we"},{"line_number":438,"context_line":"        # start."},{"line_number":439,"context_line":"        self.computes[host] \u003d compute"},{"line_number":440,"context_line":"        return compute"},{"line_number":441,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_5a7df01a","line":438,"range":{"start_line":436,"start_character":0,"end_line":438,"end_character":16},"updated":"2020-03-24 14:04:35.000000000","message":"I believe this is no longer relevant right?","commit_id":"52b020c8b8abae21413055dd541620a9bee96d9c"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"660ab0f49a4dd2e7251f8342c1c1fc4d2e84513b","unresolved":false,"context_lines":[{"line_number":433,"context_line":"        :return: the nova compute service object"},{"line_number":434,"context_line":"        \"\"\""},{"line_number":435,"context_line":"        compute \u003d self.start_service(\u0027compute\u0027, host\u003dhost, cell_name\u003dcell_name)"},{"line_number":436,"context_line":"        # If this is the first compute service we\u0027re starting, we need to first"},{"line_number":437,"context_line":"        # create an empty self.comptes dict to keep track of the services we"},{"line_number":438,"context_line":"        # start."},{"line_number":439,"context_line":"        self.computes[host] \u003d compute"},{"line_number":440,"context_line":"        return compute"},{"line_number":441,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_7a4c34c7","line":438,"range":{"start_line":436,"start_character":0,"end_line":438,"end_character":16},"in_reply_to":"df33271e_5a7df01a","updated":"2020-03-24 14:11:05.000000000","message":"Done","commit_id":"52b020c8b8abae21413055dd541620a9bee96d9c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"bda9161f3f36a552b0139fca4c48fb58fb2f4315","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        return compute"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    def _run_periodics(self):"},{"line_number":443,"context_line":"        \"\"\"Run the update_available_resource task on every compute manager"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"        This runs periodics on the computes in an undefined order; some child"},{"line_number":446,"context_line":"        class redefine this function to force a specific order."}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_ba935c4f","line":443,"range":{"start_line":443,"start_character":58,"end_line":443,"end_character":74},"updated":"2020-03-24 14:04:35.000000000","message":"I just noticed that this method is maybe incorrectly named, I\u0027m sure from wherever you copied. I wonder if we need to make this _run_compute_periodics() to distinguish it from the scheduler and conductors, all of which have periodics.","commit_id":"52b020c8b8abae21413055dd541620a9bee96d9c"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"660ab0f49a4dd2e7251f8342c1c1fc4d2e84513b","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        return compute"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    def _run_periodics(self):"},{"line_number":443,"context_line":"        \"\"\"Run the update_available_resource task on every compute manager"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"        This runs periodics on the computes in an undefined order; some child"},{"line_number":446,"context_line":"        class redefine this function to force a specific order."}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_daef4085","line":443,"range":{"start_line":443,"start_character":58,"end_line":443,"end_character":74},"in_reply_to":"df33271e_ba935c4f","updated":"2020-03-24 14:11:05.000000000","message":"Yeah, I didn\u0027t change the method name, and you\u0027re right, a new name would be more informative.","commit_id":"52b020c8b8abae21413055dd541620a9bee96d9c"}]}