)]}'
{"nova/tests/scheduler/test_ironic_host_manager.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"332140ac284edc2c0154fc8b949c240ef1e7c73b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def host_passes(self, host_state, filter_properties):"},{"line_number":36,"context_line":"        pass"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class IronicHostManagerTestCase(test.NoDBTestCase):"},{"line_number":40,"context_line":"    \"\"\"Test case for IronicHostManager class.\"\"\""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9j%2Bo%3D","line":38,"updated":"2014-02-06 01:43:42.000000000","message":"I don\u0027t see anything testing consume_from_instance or update_from_compute_node -- these are the fundamental differences from the regular Nova scheduler, so it\u0027d be great to test them.","commit_id":"3a90d2de14670821b3f21643a5f70a150f9bd681"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"f98852c3fc7e59cca041fa19c7507ab15c9f609f","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        host.update_from_compute_node(compute)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        instance \u003d dict(root_gb\u003d10, ephemeral_gb\u003d0, memory_mb\u003d1024, vcpus\u003d1)"},{"line_number":185,"context_line":"        host.consume_from_instance(instance)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        self.assertEqual(host.vcpus_used, 1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9iLg%3D","line":184,"updated":"2014-02-06 08:51:07.000000000","message":"This is good, but what if instance !\u003d compute?\n\nI suggest moving the definition of compute \u003d dict(...) into __init__, since it will be shared across several tests, then creating three tests instead of one.\n\n  def test_consume_identical_instance_from_compute:\n    instance \u003d dict(root_gb\u003d10, ...)\n    ...\n\n  def test_consume_larger_instance_from_compute:\n    instance \u003d dict(root_gb\u003d20, ...)\n    ...\n\n  def test_consume_smaller_instance_from_compute:\n    instance \u003d dict(root_gb\u003d5, ...)\n    ....","commit_id":"36722204d0fe118baaf23b34fd4d351519b7c3f0"}]}