)]}'
{"id":"openstack%2Fnova~714295","triplet_id":"openstack%2Fnova~stable%2Ftrain~I0c3f14100a18107f7e416293f3d4fcc641ce5e55","project":"openstack/nova","branch":"stable/train","hashtags":[],"change_id":"I0c3f14100a18107f7e416293f3d4fcc641ce5e55","subject":"libvirt: Correctly resize encrypted LUKSv1 volumes","status":"ABANDONED","created":"2020-03-22 12:43:27.000000000","updated":"2021-02-01 16:35:03.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"20bd6bbcacd3bb5aeee25806d8df878cde0863e6","_number":714295,"virtual_id_number":714295,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"all":[{"date":"2020-03-22 13:09:40.000000000","_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-22 13:09:40.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"}],"messages":[{"id":"94a73a2b0ce9438c9af67d766ef247ac729d4cc6","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-03-22 12:43:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4179f27be356b80719b1fe461eefc8502f8737be","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-03-22 13:09:40.000000000","message":"Patch Set 1:\n\nBuild SUCCESSFUL (check pipeline).\n\n- pmem-tempest-plugin-filtered http://52.27.155.124/95/714295/1/check/pmem-tempest-plugin-filtered/e5d6ae4/ : SUCCESS in 23m 29s","accounts_in_message":[],"_revision_number":1},{"id":"07e1ba32f979bfe174ee905df507d3053850ceb7","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-03-22 13:16:31.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1},{"id":"a0aca7a22cc5e6128256c4f08594e263594fb188","tag":"autogenerated:gerrit:restore","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-02-01 16:15:24.000000000","message":"Restored","accounts_in_message":[],"_revision_number":1},{"id":"20bd6bbcacd3bb5aeee25806d8df878cde0863e6","tag":"autogenerated:gerrit:abandon","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-02-01 16:35:03.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"cdb2937ba5f40d51d03620c8468bd432f7d06691","revisions":{"cdb2937ba5f40d51d03620c8468bd432f7d06691":{"kind":"REWORK","_number":1,"created":"2020-03-22 12:43:27.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/95/714295/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/95/714295/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/95/714295/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/95/714295/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/95/714295/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/95/714295/1"}}},"commit":{"parents":[{"commit":"3edbb9e9fdec25e8a6129742bbd6dbe8e1dfab25","subject":"virt: Pass request context to extend_volume","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3edbb9e9fdec25e8a6129742bbd6dbe8e1dfab25"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-01-31 17:28:27.000000000","tz":0},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-03-22 12:42:42.000000000","tz":0},"subject":"libvirt: Correctly resize encrypted LUKSv1 volumes","message":"libvirt: Correctly resize encrypted LUKSv1 volumes\n\nWhen extending volumes the Libvirt virt driver first calls os-brick to\nrefresh any host block devices so they show their new extended size\nbefore calling down into Libvirt\u0027s virDomainBlockResize API to do the\nsame within the instance.\n\nWhen extending encrypted LUKSv1 volumes the new size of the volume\nprovided to the virDomainBlockResize API did not previously take the\nspace already consumed by the LUKSv1 header into account. As a result\nany attempt to extend a host block device based encrypted LUKSv1 volume\nwould fail as Libvirt would need to grow the device to allow room for\nthe LUKSv1 header.\n\nThis change corrects this by inspecting the host block device or remote\nRBD volume using ``qemu-img info``. Since oslo.utils 4.1.0 the returned\nQemuImgInfo object that encapsulates the output of this call now\nincludes LUKSv1 specific data such as the offset of the encrypted\npayload, essentially where the users data actually starts within the\nvolume.\n\nBy subtracting this offset from the new overall size of the extended\nvolume we can ensure calls to virDomainBlockResize will now succeed as\nno attempt will be made by Libvirt to grow the device.\n\nFuture work will also need to handle this extend_volume use case for\n``dm-crypt`` based encryption providers ``plain`` and ``luks2``.\n\nCloses-Bug: #1861071\nDepends-On: https://review.opendev.org/706880\nChange-Id: I0c3f14100a18107f7e416293f3d4fcc641ce5e55\n(cherry picked from commit 961df123934046b67fb95d1d18501913d5c20f29)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cdb2937ba5f40d51d03620c8468bd432f7d06691"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cdb2937ba5f40d51d03620c8468bd432f7d06691"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}