)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"9050970820f3abacece8fadf55245200ef5fc38f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This results in a failure to remove the instance, with libvirt raising"},{"line_number":13,"context_line":"the following error:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  Instance failed to spawn: libvirt.libvirtError: Requested operation"},{"line_number":16,"context_line":"  is not valid: cannot undefine domain with nvram"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Resolve this by checking *both* the image metadata property and the"},{"line_number":19,"context_line":"machine arch."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f4c43b2_43d7dcc0","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":49},"updated":"2020-04-14 09:11:35.000000000","message":"On the failure itself; it\u0027s due to the reason that one\n\nRefer to the delete_configuration() method in nova/virt/libvirt/guest.py.","commit_id":"a18dbb5670da0c0b63c4bd69055262b4b7b17e58"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"9050970820f3abacece8fadf55245200ef5fc38f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  Instance failed to spawn: libvirt.libvirtError: Requested operation"},{"line_number":16,"context_line":"  is not valid: cannot undefine domain with nvram"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Resolve this by checking *both* the image metadata property and the"},{"line_number":19,"context_line":"machine arch."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I2956fe2e3582c36d1c52a7e3becde1dacd9d41f0"},{"line_number":22,"context_line":"Closes-bug: #1868464"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f4c43b2_c3f48c5e","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":13},"updated":"2020-04-14 09:11:35.000000000","message":"Yep, looks sensible to me.","commit_id":"a18dbb5670da0c0b63c4bd69055262b4b7b17e58"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"16e9e84a59cf6342c49bca1a7595d5cbfb15a3c2","unresolved":false,"context_lines":[{"line_number":5322,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":5323,"context_line":"        support_uefi \u003d (self._has_uefi_support() and"},{"line_number":5324,"context_line":"                        (hw_firmware_type \u003d\u003d fields.FirmwareType.UEFI"},{"line_number":5325,"context_line":"                            or caps.host.cpu.arch \u003d\u003d"},{"line_number":5326,"context_line":"                            fields.Architecture.AARCH64))"},{"line_number":5327,"context_line":""},{"line_number":5328,"context_line":"        return support_uefi"},{"line_number":5329,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_6c12c75a","line":5326,"range":{"start_line":5325,"start_character":31,"end_line":5326,"end_character":55},"updated":"2020-03-24 02:26:03.000000000","message":"Can we also add unit test for CPU AARCH64 host capabilities?","commit_id":"5db5501a836241b82bd8f000e9786fbc7239da69"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1ad7d97bc74aa86b993e016e56a765c620dede26","unresolved":false,"context_lines":[{"line_number":5318,"context_line":"                any((os.path.exists(p)"},{"line_number":5319,"context_line":"                     for p in DEFAULT_UEFI_LOADER_PATH[caps.host.cpu.arch])))"},{"line_number":5320,"context_line":""},{"line_number":5321,"context_line":"    def _check_uefi_support(self, hw_firmware_type):"},{"line_number":5322,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":5323,"context_line":"        support_uefi \u003d (self._has_uefi_support() and"},{"line_number":5324,"context_line":"                        (hw_firmware_type \u003d\u003d fields.FirmwareType.UEFI or"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_0b341cfb","line":5321,"range":{"start_line":5321,"start_character":8,"end_line":5321,"end_character":27},"updated":"2020-04-01 14:35:25.000000000","message":"factoring this out into a private fucntion also makes sese give the amount of time this is checked.","commit_id":"95dea326d16fdcb8472c954f868d8edb1d8ce9e4"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"92dfc91ad0b861211cd3c3de145839f792846feb","unresolved":false,"context_lines":[{"line_number":5320,"context_line":""},{"line_number":5321,"context_line":"    def _check_uefi_support(self, hw_firmware_type):"},{"line_number":5322,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":5323,"context_line":"        support_uefi \u003d (self._has_uefi_support() and"},{"line_number":5324,"context_line":"                        (hw_firmware_type \u003d\u003d fields.FirmwareType.UEFI or"},{"line_number":5325,"context_line":"                         caps.host.cpu.arch \u003d\u003d fields.Architecture.AARCH64))"},{"line_number":5326,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_e57d296f","line":5323,"range":{"start_line":5323,"start_character":8,"end_line":5323,"end_character":22},"updated":"2020-04-07 12:59:04.000000000","message":"supernit - return","commit_id":"95dea326d16fdcb8472c954f868d8edb1d8ce9e4"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"8e12afd6ed06c1f3f884e7461a259e4dbe057aa6","unresolved":false,"context_lines":[{"line_number":5320,"context_line":""},{"line_number":5321,"context_line":"    def _check_uefi_support(self, hw_firmware_type):"},{"line_number":5322,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":5323,"context_line":"        support_uefi \u003d (self._has_uefi_support() and"},{"line_number":5324,"context_line":"                        (hw_firmware_type \u003d\u003d fields.FirmwareType.UEFI or"},{"line_number":5325,"context_line":"                         caps.host.cpu.arch \u003d\u003d fields.Architecture.AARCH64))"},{"line_number":5326,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_6e6a56b3","line":5323,"range":{"start_line":5323,"start_character":8,"end_line":5323,"end_character":22},"in_reply_to":"df33271e_e57d296f","updated":"2020-04-09 08:39:09.000000000","message":"Done","commit_id":"95dea326d16fdcb8472c954f868d8edb1d8ce9e4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1ad7d97bc74aa86b993e016e56a765c620dede26","unresolved":false,"context_lines":[{"line_number":5320,"context_line":""},{"line_number":5321,"context_line":"    def _check_uefi_support(self, hw_firmware_type):"},{"line_number":5322,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":5323,"context_line":"        support_uefi \u003d (self._has_uefi_support() and"},{"line_number":5324,"context_line":"                        (hw_firmware_type \u003d\u003d fields.FirmwareType.UEFI or"},{"line_number":5325,"context_line":"                         caps.host.cpu.arch \u003d\u003d fields.Architecture.AARCH64))"},{"line_number":5326,"context_line":""},{"line_number":5327,"context_line":"        return support_uefi"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_0b66dc2a","line":5324,"range":{"start_line":5323,"start_character":24,"end_line":5324,"end_character":69},"updated":"2020-04-01 14:35:25.000000000","message":"ok so this is still need to have the correct behavior on x86","commit_id":"95dea326d16fdcb8472c954f868d8edb1d8ce9e4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1ad7d97bc74aa86b993e016e56a765c620dede26","unresolved":false,"context_lines":[{"line_number":5322,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":5323,"context_line":"        support_uefi \u003d (self._has_uefi_support() and"},{"line_number":5324,"context_line":"                        (hw_firmware_type \u003d\u003d fields.FirmwareType.UEFI or"},{"line_number":5325,"context_line":"                         caps.host.cpu.arch \u003d\u003d fields.Architecture.AARCH64))"},{"line_number":5326,"context_line":""},{"line_number":5327,"context_line":"        return support_uefi"},{"line_number":5328,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_6b5de845","line":5325,"range":{"start_line":5325,"start_character":24,"end_line":5325,"end_character":74},"updated":"2020-04-01 14:35:25.000000000","message":"and then this reflect the arm default.\nwe might need to make this and \"in\" rathar then a \"\u003d\u003d\" in the future as i suspect power and other architecutre might also eventually switch to uefi by default. for now this looks good to me.","commit_id":"95dea326d16fdcb8472c954f868d8edb1d8ce9e4"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"8e12afd6ed06c1f3f884e7461a259e4dbe057aa6","unresolved":false,"context_lines":[{"line_number":5322,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":5323,"context_line":"        support_uefi \u003d (self._has_uefi_support() and"},{"line_number":5324,"context_line":"                        (hw_firmware_type \u003d\u003d fields.FirmwareType.UEFI or"},{"line_number":5325,"context_line":"                         caps.host.cpu.arch \u003d\u003d fields.Architecture.AARCH64))"},{"line_number":5326,"context_line":""},{"line_number":5327,"context_line":"        return support_uefi"},{"line_number":5328,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_ae60ded0","line":5325,"range":{"start_line":5325,"start_character":24,"end_line":5325,"end_character":74},"in_reply_to":"df33271e_6b5de845","updated":"2020-04-09 08:39:09.000000000","message":"Thanks!\nWill keep this now and change in the future if necessary.","commit_id":"95dea326d16fdcb8472c954f868d8edb1d8ce9e4"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"9050970820f3abacece8fadf55245200ef5fc38f","unresolved":false,"context_lines":[{"line_number":1793,"context_line":"            #             re-defined regardless."},{"line_number":1794,"context_line":"            if guest.has_persistent_configuration():"},{"line_number":1795,"context_line":"                support_uefi \u003d self._check_uefi_support(hw_firmware_type)"},{"line_number":1796,"context_line":"                guest.delete_configuration(support_uefi)"},{"line_number":1797,"context_line":""},{"line_number":1798,"context_line":"            try:"},{"line_number":1799,"context_line":"                # Start copy with VIR_DOMAIN_BLOCK_REBASE_REUSE_EXT flag to"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4c43b2_e6fef603","line":1796,"range":{"start_line":1796,"start_character":16,"end_line":1796,"end_character":56},"updated":"2020-04-14 09:11:35.000000000","message":"Just noting the exact cause of the error you quoted in the commit message; it\u0027s due to the requirement that when undefining a UEFI guest, you need to pass the flag: VIR_DOMAIN_UNDEFINE_NVRAM to the undefineFlags() API.  (This is taken care in the method called above: delete_configuration() in nova/virt/libvirt/guest.py.)","commit_id":"a18dbb5670da0c0b63c4bd69055262b4b7b17e58"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"9050970820f3abacece8fadf55245200ef5fc38f","unresolved":false,"context_lines":[{"line_number":5318,"context_line":"                any((os.path.exists(p)"},{"line_number":5319,"context_line":"                     for p in DEFAULT_UEFI_LOADER_PATH[caps.host.cpu.arch])))"},{"line_number":5320,"context_line":""},{"line_number":5321,"context_line":"    def _check_uefi_support(self, hw_firmware_type):"},{"line_number":5322,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":5323,"context_line":"        return (self._has_uefi_support() and"},{"line_number":5324,"context_line":"                (hw_firmware_type \u003d\u003d fields.FirmwareType.UEFI or"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4c43b2_e62716b6","line":5321,"range":{"start_line":5321,"start_character":8,"end_line":5321,"end_character":27},"updated":"2020-04-14 09:11:35.000000000","message":"Yep, a separate method is clean.","commit_id":"a18dbb5670da0c0b63c4bd69055262b4b7b17e58"}]}