)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f6e72663bd7f8c696ab98ad71113fb9c9f3a81eb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: check for AMD SEV only on x86-64"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\"kernel doesn\u0027t support AMD SEV\" message on aarch64 does not make sense"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I1ae22197dc68751938f524d823f39e5c89cec7b0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f4c43b2_7dd37339","line":9,"updated":"2020-04-15 14:52:33.000000000","message":"well it kind of does. if the kernel is compiles and running on arch64 then it does not supprot SEV on that plathform since SEV is a feature that at present is only availbale on AMD cpus. its not actully a instuction set so its not actuly part of x86_64 even on amd cpus.","commit_id":"0a644c1bb63429e71f6b05f0a50aa3f3fd750cb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"243dba34080efadd74ffb00d99f51dcb0824cfac","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: check for AMD SEV only on x86-64"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\"kernel doesn\u0027t support AMD SEV\" message on aarch64 does not make sense"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I1ae22197dc68751938f524d823f39e5c89cec7b0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f4c43b2_fda2e399","line":9,"in_reply_to":"3f4c43b2_7dd37339","updated":"2020-04-15 14:53:06.000000000","message":"ment to say this need a bug but the code looks fine","commit_id":"0a644c1bb63429e71f6b05f0a50aa3f3fd750cb3"}],"nova/tests/unit/virt/libvirt/test_host.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"510f831292f2b369352d0373a0f023921a3a1340","unresolved":false,"context_lines":[{"line_number":1304,"context_line":"            self.host._set_amd_sev_support()"},{"line_number":1305,"context_line":"            self.assertFalse(self.host.supports_amd_sev)"},{"line_number":1306,"context_line":""},{"line_number":1307,"context_line":"class TestLibvirtSEVSupported(TestLibvirtSEV):"},{"line_number":1308,"context_line":"    \"\"\"Libvirt driver tests for when AMD SEV support is present.\"\"\""},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":"    @mock.patch.object(os.path, \u0027exists\u0027, return_value\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4c43b2_37362ae8","line":1307,"updated":"2020-04-15 13:04:06.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"7a8fc68cf8ef4b7e44fe9b2a6bbc5bba6989daae"}],"nova/virt/libvirt/host.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c722ff7d62e51a8b0254a5cd9105e6da84c42805","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"        self._supports_amd_sev \u003d False"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"        caps \u003d self.get_capabilities()"},{"line_number":1259,"context_line":"        if caps.host.cpu.arch !\u003d fields.Architecture.X86_64:"},{"line_number":1260,"context_line":"            return"},{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":"        if not self._kernel_supports_amd_sev():"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4c43b2_08c79614","line":1259,"updated":"2020-04-15 09:34:27.000000000","message":"I don\u0027t particularly want to be pedantic on unittesting, but I think this conditional is still important to be verified in our gate.\nhttps://github.com/openstack/nova/blob/aa87b9c/nova/tests/unit/virt/libvirt/test_host.py#L1249\n\nAlso, even if that looks silly, we should just return False like below.","commit_id":"3b418334e8af0637bd2f731bee1ffcf7ba6eede3"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"b7b7fa19806cbbf5c0653a2c71048e5964a9b6ac","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"        self._supports_amd_sev \u003d False"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"        caps \u003d self.get_capabilities()"},{"line_number":1259,"context_line":"        if caps.host.cpu.arch !\u003d fields.Architecture.X86_64:"},{"line_number":1260,"context_line":"            return"},{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":"        if not self._kernel_supports_amd_sev():"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4c43b2_887606d8","line":1259,"in_reply_to":"3f4c43b2_08c79614","updated":"2020-04-15 09:48:16.000000000","message":"self._supports_amd_sev is set to False just before that check so does not need to be set again.","commit_id":"3b418334e8af0637bd2f731bee1ffcf7ba6eede3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"dbe2927832145452d7e1c8391270568f91c551ca","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"        self._supports_amd_sev \u003d False"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"        caps \u003d self.get_capabilities()"},{"line_number":1259,"context_line":"        if caps.host.cpu.arch !\u003d fields.Architecture.X86_64:"},{"line_number":1260,"context_line":"            return"},{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":"        if not self._kernel_supports_amd_sev():"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4c43b2_882446c8","line":1259,"in_reply_to":"3f4c43b2_887606d8","updated":"2020-04-15 09:52:10.000000000","message":"You\u0027re right about the variable setting ealier, my bad.\n\nThat still leaves a bit of missing test coverage tho.","commit_id":"3b418334e8af0637bd2f731bee1ffcf7ba6eede3"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9b48beab42099edf5c0514a4139ca1856402f409","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"        self._supports_amd_sev \u003d False"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"        caps \u003d self.get_capabilities()"},{"line_number":1259,"context_line":"        if caps.host.cpu.arch !\u003d fields.Architecture.X86_64:"},{"line_number":1260,"context_line":"            return"},{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":"        if not self._kernel_supports_amd_sev():"},{"line_number":1263,"context_line":"            LOG.info(\"kernel doesn\u0027t support AMD SEV\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_7f77c4d5","line":1260,"range":{"start_line":1259,"start_character":8,"end_line":1260,"end_character":18},"updated":"2020-04-17 09:58:20.000000000","message":"Should we LOG something here?","commit_id":"07209c7c776e9df391af19d1f87512ad9f6146bc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b0a6bcb3ae48cde3db64fd0c8676f9906ef9bd93","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"        self._supports_amd_sev \u003d False"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"        caps \u003d self.get_capabilities()"},{"line_number":1259,"context_line":"        if caps.host.cpu.arch !\u003d fields.Architecture.X86_64:"},{"line_number":1260,"context_line":"            return"},{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":"        if not self._kernel_supports_amd_sev():"},{"line_number":1263,"context_line":"            LOG.info(\"kernel doesn\u0027t support AMD SEV\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_4821b7b4","line":1260,"range":{"start_line":1259,"start_character":8,"end_line":1260,"end_character":18},"in_reply_to":"3f4c43b2_620e0b33","updated":"2020-04-22 05:16:25.000000000","message":"well given it would be at debug level i think a debug log to know which branch we took would be ok but im also fine with not adding a log message here. i dont think it will significantly help in debugging since the later code patch have logs if we dont see those we know we took this branch.","commit_id":"07209c7c776e9df391af19d1f87512ad9f6146bc"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"f60bb77f52933e4c532d47af073f1cf22fd4f31e","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"        self._supports_amd_sev \u003d False"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"        caps \u003d self.get_capabilities()"},{"line_number":1259,"context_line":"        if caps.host.cpu.arch !\u003d fields.Architecture.X86_64:"},{"line_number":1260,"context_line":"            return"},{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":"        if not self._kernel_supports_amd_sev():"},{"line_number":1263,"context_line":"            LOG.info(\"kernel doesn\u0027t support AMD SEV\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_620e0b33","line":1260,"range":{"start_line":1259,"start_character":8,"end_line":1260,"end_character":18},"in_reply_to":"3f4c43b2_7f77c4d5","updated":"2020-04-17 10:05:09.000000000","message":"LOG.debug(\u0027We decided to not check for AMD SEV as it is not x86-64. Please do not send patches to remove that message as it was added instead of other message already\u0027)","commit_id":"07209c7c776e9df391af19d1f87512ad9f6146bc"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9b48beab42099edf5c0514a4139ca1856402f409","unresolved":false,"context_lines":[{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":"        if not self._kernel_supports_amd_sev():"},{"line_number":1263,"context_line":"            LOG.info(\"kernel doesn\u0027t support AMD SEV\")"},{"line_number":1264,"context_line":"            self._supports_amd_sev \u003d False"},{"line_number":1265,"context_line":"            return"},{"line_number":1266,"context_line":""},{"line_number":1267,"context_line":"        domain_caps \u003d self.get_domain_capabilities()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_3f6edc00","line":1264,"range":{"start_line":1264,"start_character":0,"end_line":1264,"end_character":42},"updated":"2020-04-17 09:58:20.000000000","message":"Unrelated but it\u0027s odd that we set this here.","commit_id":"07209c7c776e9df391af19d1f87512ad9f6146bc"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"f68e45a716e1f18de01e4145c9ed23768bf799a2","unresolved":false,"context_lines":[{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":"        if not self._kernel_supports_amd_sev():"},{"line_number":1263,"context_line":"            LOG.info(\"kernel doesn\u0027t support AMD SEV\")"},{"line_number":1264,"context_line":"            self._supports_amd_sev \u003d False"},{"line_number":1265,"context_line":"            return"},{"line_number":1266,"context_line":""},{"line_number":1267,"context_line":"        domain_caps \u003d self.get_domain_capabilities()"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_b5974cec","line":1264,"range":{"start_line":1264,"start_character":0,"end_line":1264,"end_character":42},"in_reply_to":"1f493fa4_8084f8b2","updated":"2020-05-20 09:46:15.000000000","message":"Yeah it\u0027s already set to False there and I can\u0027t see anywhere in-between where it could change?","commit_id":"07209c7c776e9df391af19d1f87512ad9f6146bc"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"af9b3d441b6e124a963dcf20d84b947109e3741b","unresolved":false,"context_lines":[{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":"        if not self._kernel_supports_amd_sev():"},{"line_number":1263,"context_line":"            LOG.info(\"kernel doesn\u0027t support AMD SEV\")"},{"line_number":1264,"context_line":"            self._supports_amd_sev \u003d False"},{"line_number":1265,"context_line":"            return"},{"line_number":1266,"context_line":""},{"line_number":1267,"context_line":"        domain_caps \u003d self.get_domain_capabilities()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_8084f8b2","line":1264,"range":{"start_line":1264,"start_character":0,"end_line":1264,"end_character":42},"in_reply_to":"1f493fa4_88561f29","updated":"2020-04-24 13:17:06.000000000","message":"it is set by default to False @ line 1256","commit_id":"07209c7c776e9df391af19d1f87512ad9f6146bc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b0a6bcb3ae48cde3db64fd0c8676f9906ef9bd93","unresolved":false,"context_lines":[{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":"        if not self._kernel_supports_amd_sev():"},{"line_number":1263,"context_line":"            LOG.info(\"kernel doesn\u0027t support AMD SEV\")"},{"line_number":1264,"context_line":"            self._supports_amd_sev \u003d False"},{"line_number":1265,"context_line":"            return"},{"line_number":1266,"context_line":""},{"line_number":1267,"context_line":"        domain_caps \u003d self.get_domain_capabilities()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_88561f29","line":1264,"range":{"start_line":1264,"start_character":0,"end_line":1264,"end_character":42},"in_reply_to":"3f4c43b2_3f6edc00","updated":"2020-04-22 05:16:25.000000000","message":"well if the kernel does not support it then there is no point checking anythign else so its just an early out which makes sense to me. where else would we set it?","commit_id":"07209c7c776e9df391af19d1f87512ad9f6146bc"}]}