)]}'
{"nova/virt/hardware.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3d7f7f0bff368ef7f330292d7c2b6794a20d7d79","unresolved":false,"context_lines":[{"line_number":1674,"context_line":"    return None"},{"line_number":1675,"context_line":""},{"line_number":1676,"context_line":""},{"line_number":1677,"context_line":"# NOTE(stephenfin): This must be public as it\u0027s used elsewhere"},{"line_number":1678,"context_line":"def get_realtime_cpu_constraint("},{"line_number":1679,"context_line":"    flavor: \u0027objects.Flavor\u0027,"},{"line_number":1680,"context_line":"    image_meta: \u0027objects.ImageMeta\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf51134e_cd76c63e","line":1677,"updated":"2020-06-25 09:18:17.000000000","message":"well, this kind of comment should be only in the commit msg, not here, but okay","commit_id":"c88a35e8ea3ffca8c23798b129ef9446b80efe51"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b503589d0e8db32cc46113c3dd7725bc10e9fddb","unresolved":false,"context_lines":[{"line_number":4854,"context_line":"                        \u0027req\u0027: sorted(shared_ids)})"},{"line_number":4855,"context_line":"                raise exception.Invalid(msg)"},{"line_number":4856,"context_line":"            emulatorpin_cpuset \u003d cpuset"},{"line_number":4857,"context_line":"        elif not vcpus_rt or vcpu not in vcpus_rt:"},{"line_number":4858,"context_line":"            emulatorpin_cpuset \u003d pin_cpuset.cpuset"},{"line_number":4859,"context_line":""},{"line_number":4860,"context_line":"        return emulatorpin_cpuset"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_92bbe60c","line":4857,"range":{"start_line":4857,"start_character":29,"end_line":4857,"end_character":49},"updated":"2020-04-06 08:02:15.000000000","message":"actually, we can just keep this check, then it is enough. If there is no rt vcpus, it should be empty. Then this check is False.","commit_id":"000473ac3400363ffa97985fc193e8e3158638e9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"89204233aee2256ed8651e5671750f5947ffe3ad","unresolved":false,"context_lines":[{"line_number":4854,"context_line":"                        \u0027req\u0027: sorted(shared_ids)})"},{"line_number":4855,"context_line":"                raise exception.Invalid(msg)"},{"line_number":4856,"context_line":"            emulatorpin_cpuset \u003d cpuset"},{"line_number":4857,"context_line":"        elif not vcpus_rt or vcpu not in vcpus_rt:"},{"line_number":4858,"context_line":"            emulatorpin_cpuset \u003d pin_cpuset.cpuset"},{"line_number":4859,"context_line":""},{"line_number":4860,"context_line":"        return emulatorpin_cpuset"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_bf186575","line":4857,"range":{"start_line":4857,"start_character":29,"end_line":4857,"end_character":49},"in_reply_to":"df33271e_3430fc07","updated":"2020-04-06 17:13:43.000000000","message":"Actually, not done. vcpus_rt can be set to None, in which case you can\u0027t do an \u0027in\u0027 check","commit_id":"000473ac3400363ffa97985fc193e8e3158638e9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"41e3c2cf5bd40d5f4c22f571d028efefc91f400e","unresolved":false,"context_lines":[{"line_number":4854,"context_line":"                        \u0027req\u0027: sorted(shared_ids)})"},{"line_number":4855,"context_line":"                raise exception.Invalid(msg)"},{"line_number":4856,"context_line":"            emulatorpin_cpuset \u003d cpuset"},{"line_number":4857,"context_line":"        elif not vcpus_rt or vcpu not in vcpus_rt:"},{"line_number":4858,"context_line":"            emulatorpin_cpuset \u003d pin_cpuset.cpuset"},{"line_number":4859,"context_line":""},{"line_number":4860,"context_line":"        return emulatorpin_cpuset"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_3430fc07","line":4857,"range":{"start_line":4857,"start_character":29,"end_line":4857,"end_character":49},"in_reply_to":"df33271e_92bbe60c","updated":"2020-04-06 17:10:44.000000000","message":"Done","commit_id":"000473ac3400363ffa97985fc193e8e3158638e9"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"0ab7a074b4aba5431a789736832634514ca222e7","unresolved":false,"context_lines":[{"line_number":4854,"context_line":"                        \u0027req\u0027: sorted(shared_ids)})"},{"line_number":4855,"context_line":"                raise exception.Invalid(msg)"},{"line_number":4856,"context_line":"            emulatorpin_cpuset \u003d cpuset"},{"line_number":4857,"context_line":"        elif not vcpus_rt or vcpu not in vcpus_rt:"},{"line_number":4858,"context_line":"            emulatorpin_cpuset \u003d pin_cpuset.cpuset"},{"line_number":4859,"context_line":""},{"line_number":4860,"context_line":"        return emulatorpin_cpuset"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_8a7558cf","line":4857,"range":{"start_line":4857,"start_character":29,"end_line":4857,"end_character":49},"in_reply_to":"df33271e_bf186575","updated":"2020-04-07 00:18:07.000000000","message":"oh, right, sorry.","commit_id":"000473ac3400363ffa97985fc193e8e3158638e9"}]}