)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"77e74f6f36b95c48e061f9666c6da26d22f8bfd9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new default roles in lock server policies"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds new defaults roles in ock server API policies."},{"line_number":10,"context_line":"- lock/unlock policies are default to system admin or project member."},{"line_number":11,"context_line":"- unlock server locked by other is system admin."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df33271e_a26d78cd","line":9,"range":{"start_line":9,"start_character":32,"end_line":9,"end_character":35},"updated":"2020-03-31 09:57:57.000000000","message":"s/ock/lock/","commit_id":"ea3e8f6f91546db32de78abca9e70e7d6afb5c10"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"92a57ac4a77dbbc27344b930bdad1594c8ea0f01","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new default roles in lock server policies"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds new defaults roles in ock server API policies."},{"line_number":10,"context_line":"- lock/unlock policies are default to system admin or project member."},{"line_number":11,"context_line":"- unlock server locked by other is system admin."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df33271e_6fe34bda","line":9,"range":{"start_line":9,"start_character":32,"end_line":9,"end_character":35},"in_reply_to":"df33271e_a26d78cd","updated":"2020-03-31 18:00:12.000000000","message":"Done","commit_id":"ea3e8f6f91546db32de78abca9e70e7d6afb5c10"}],"nova/policies/lock_server.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"697acf1aeb42eec6173a51a2626f917b14f4e65b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    ),"},{"line_number":49,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":50,"context_line":"        name\u003dPOLICY_ROOT % \u0027unlock:unlock_override\u0027,"},{"line_number":51,"context_line":"        check_str\u003dbase.SYSTEM_ADMIN,"},{"line_number":52,"context_line":"        description\u003d\"\"\"Unlock a server, regardless who locked the server."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"This check is performed only after the check"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_e295c041","line":51,"updated":"2020-03-31 10:10:09.000000000","message":"TO be clear, I think this is correct. Assuming system_admin always checks for system scope.","commit_id":"ea3e8f6f91546db32de78abca9e70e7d6afb5c10"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"697acf1aeb42eec6173a51a2626f917b14f4e65b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                \u0027method\u0027: \u0027POST\u0027"},{"line_number":60,"context_line":"            }"},{"line_number":61,"context_line":"        ],"},{"line_number":62,"context_line":"        scope_types\u003d[\u0027system\u0027]"},{"line_number":63,"context_line":"    ),"},{"line_number":64,"context_line":"]"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_c2923c57","line":62,"updated":"2020-03-31 10:10:09.000000000","message":"I think this is probably wrong, should be system and project. To allow operators to customise this as required.\n\nThis assumes that the post deprecation test comes out with the correct answer, i.e. just system_admin allowed to do this.","commit_id":"ea3e8f6f91546db32de78abca9e70e7d6afb5c10"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"39b804334706be8bcd51576f1d7a763464800875","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                \u0027method\u0027: \u0027POST\u0027"},{"line_number":60,"context_line":"            }"},{"line_number":61,"context_line":"        ],"},{"line_number":62,"context_line":"        scope_types\u003d[\u0027system\u0027]"},{"line_number":63,"context_line":"    ),"},{"line_number":64,"context_line":"]"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_ef48fb2d","line":62,"in_reply_to":"df33271e_a2e738ac","updated":"2020-03-31 17:48:43.000000000","message":"Done","commit_id":"ea3e8f6f91546db32de78abca9e70e7d6afb5c10"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"4965b22a27aec87a3c3081375034316375127599","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                \u0027method\u0027: \u0027POST\u0027"},{"line_number":60,"context_line":"            }"},{"line_number":61,"context_line":"        ],"},{"line_number":62,"context_line":"        scope_types\u003d[\u0027system\u0027]"},{"line_number":63,"context_line":"    ),"},{"line_number":64,"context_line":"]"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_a2e738ac","line":62,"in_reply_to":"df33271e_c2923c57","updated":"2020-03-31 10:31:50.000000000","message":"agree to change this sope type to [\u0027system\u0027, \u0027project\u0027], we should allow to unlock the project\u0027s scope server.","commit_id":"ea3e8f6f91546db32de78abca9e70e7d6afb5c10"}],"nova/tests/unit/policies/test_lock_server.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"697acf1aeb42eec6173a51a2626f917b14f4e65b","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        # Check that system admin is able to unlock the server which is"},{"line_number":149,"context_line":"        # locked by other"},{"line_number":150,"context_line":"        self.admin_authorized_contexts \u003d ["},{"line_number":151,"context_line":"            self.system_admin_context]"},{"line_number":152,"context_line":"        # Check that system non-admin is not able to unlock the server"},{"line_number":153,"context_line":"        # which is locked by other"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_02726449","line":150,"updated":"2020-03-31 10:10:09.000000000","message":"FWIW, I think this might move to the test below.","commit_id":"ea3e8f6f91546db32de78abca9e70e7d6afb5c10"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"39b804334706be8bcd51576f1d7a763464800875","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        # Check that system admin is able to unlock the server which is"},{"line_number":149,"context_line":"        # locked by other"},{"line_number":150,"context_line":"        self.admin_authorized_contexts \u003d ["},{"line_number":151,"context_line":"            self.system_admin_context]"},{"line_number":152,"context_line":"        # Check that system non-admin is not able to unlock the server"},{"line_number":153,"context_line":"        # which is locked by other"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_2f4f8334","line":150,"in_reply_to":"df33271e_02726449","updated":"2020-03-31 17:48:43.000000000","message":"yeah.","commit_id":"ea3e8f6f91546db32de78abca9e70e7d6afb5c10"}]}