)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"5b90122bb66d537284efa35b8a5b5724ed470e40","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"api: Add support for new cyborg extra specs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There\u0027s currently only one, as noted at [1]."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[2] https://specs.openstack.org/openstack/nova-specs/specs/train/approved/nova-cyborg-interaction.html"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df33271e_84a2f1ac","line":9,"range":{"start_line":9,"start_character":40,"end_line":9,"end_character":43},"updated":"2020-03-31 20:47:31.000000000","message":"There is no [1] anymore!","commit_id":"9ca6f98d82625b8f836e7be5ab0262011d063646"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"46d244ee0666f92ff1fa61381af1c8a80887f9b4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"api: Add support for new cyborg extra specs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There\u0027s currently only one, as noted at [1]."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[2] https://specs.openstack.org/openstack/nova-specs/specs/train/approved/nova-cyborg-interaction.html"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df33271e_8e9dc3bd","line":9,"range":{"start_line":9,"start_character":40,"end_line":9,"end_character":43},"in_reply_to":"df33271e_84a2f1ac","updated":"2020-04-02 10:47:30.000000000","message":"Done","commit_id":"9ca6f98d82625b8f836e7be5ab0262011d063646"}],"nova/api/validation/extra_specs/accel.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"037dc6a2415c9a596b097b4f0f2b03c019bdfd74","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        },"},{"line_number":44,"context_line":"    ),"},{"line_number":45,"context_line":"    base.ExtraSpecValidator("},{"line_number":46,"context_line":"        name\u003d\u0027accel:device_profile\u0027,"},{"line_number":47,"context_line":"        description\u003d("},{"line_number":48,"context_line":"            \u0027The name of a device profile to configure for the instance. \u0027"},{"line_number":49,"context_line":"            \u0027A device profile may be viewed as a \"flavor for devices\".\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_c541a13b","line":46,"updated":"2020-03-31 14:01:45.000000000","message":"I might be mistaken but I think we only support adding device_profile to the flavor extra_spec. https://review.opendev.org/#/c/631243/63/nova/compute/api.py@1217","commit_id":"22d480c2a74cdbf67d0d9f300e462f7e8ce3d0b4"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"3a92a21e7217047e7a98b304f401a903b40ec854","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        },"},{"line_number":44,"context_line":"    ),"},{"line_number":45,"context_line":"    base.ExtraSpecValidator("},{"line_number":46,"context_line":"        name\u003d\u0027accel:device_profile\u0027,"},{"line_number":47,"context_line":"        description\u003d("},{"line_number":48,"context_line":"            \u0027The name of a device profile to configure for the instance. \u0027"},{"line_number":49,"context_line":"            \u0027A device profile may be viewed as a \"flavor for devices\".\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_fba8c620","line":46,"in_reply_to":"df33271e_c541a13b","updated":"2020-03-31 15:12:06.000000000","message":"Yes. These keys are used by Cyborg but not exposed to Nova. The flavor extra specs should only have \u0027accel:device_profile\u0027, with the name of the dp as its value. That dp name is used by Nova to look up the dp in Cyborg but then Nova looks only at the dp fields that match the extra specs syntax: resources/traits [1].\n\nSo, we don\u0027t need/want to support other \u0027accel:\u0027 fields in Nova.\n\n[1] https://review.opendev.org/#/c/631243/63/nova/accelerator/cyborg.py@138","commit_id":"22d480c2a74cdbf67d0d9f300e462f7e8ce3d0b4"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"5b90122bb66d537284efa35b8a5b5724ed470e40","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        ),"},{"line_number":27,"context_line":"        value\u003d{"},{"line_number":28,"context_line":"            \u0027type\u0027: str,"},{"line_number":29,"context_line":"            \u0027description\u0027: \u0027A name of a device profile.\u0027,"},{"line_number":30,"context_line":"        },"},{"line_number":31,"context_line":"    ),"},{"line_number":32,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_c4b35909","line":29,"range":{"start_line":29,"start_character":28,"end_line":29,"end_character":29},"updated":"2020-03-31 20:47:31.000000000","message":"Nit: \"The\"","commit_id":"9ca6f98d82625b8f836e7be5ab0262011d063646"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"46d244ee0666f92ff1fa61381af1c8a80887f9b4","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        ),"},{"line_number":27,"context_line":"        value\u003d{"},{"line_number":28,"context_line":"            \u0027type\u0027: str,"},{"line_number":29,"context_line":"            \u0027description\u0027: \u0027A name of a device profile.\u0027,"},{"line_number":30,"context_line":"        },"},{"line_number":31,"context_line":"    ),"},{"line_number":32,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_8e3943a5","line":29,"range":{"start_line":29,"start_character":28,"end_line":29,"end_character":29},"in_reply_to":"df33271e_c4b35909","updated":"2020-04-02 10:47:30.000000000","message":"I\u0027m not referring to a specific device profile but rather describing the general type of the value so the indefinite article is correct here, IMO","commit_id":"9ca6f98d82625b8f836e7be5ab0262011d063646"}]}