)]}'
{"nova/tests/unit/policies/base.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c938dfb82669c987a3ec8e25847f6004d2e53c43","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        # the todo_add_reader adjusment."},{"line_number":136,"context_line":"        test_context \u003d len(authorized_contexts) + len(unauthorized_contexts)"},{"line_number":137,"context_line":"        equal \u003d len(self.all_contexts) \u003d\u003d test_context"},{"line_number":138,"context_line":"        todo_add_reader \u003d len(self.all_contexts) \u003d\u003d (test_context + 1)"},{"line_number":139,"context_line":"        self.assertTrue(equal or todo_add_reader,"},{"line_number":140,"context_line":"                        \"Few context are missing. check all contexts \""},{"line_number":141,"context_line":"                        \"mentioned in self.all_contexts are tested\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_dc73c0b0","line":138,"range":{"start_line":138,"start_character":8,"end_line":138,"end_character":70},"updated":"2020-04-06 10:06:00.000000000","message":"This is weak as maybe other_project_reader is added but another one is missing or got deleted. I thin it should be \n\n  todo_add_reader \u003d self.other_project_reader_context not in self.all_context","commit_id":"0a0885dac9e43b50a75d6d5c887b3295df4e0ee2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dcb2a69dc427db980aa1dbb4e4abe64abd4597c6","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        # the todo_add_reader adjusment."},{"line_number":136,"context_line":"        test_context \u003d len(authorized_contexts) + len(unauthorized_contexts)"},{"line_number":137,"context_line":"        equal \u003d len(self.all_contexts) \u003d\u003d test_context"},{"line_number":138,"context_line":"        todo_add_reader \u003d len(self.all_contexts) \u003d\u003d (test_context + 1)"},{"line_number":139,"context_line":"        self.assertTrue(equal or todo_add_reader,"},{"line_number":140,"context_line":"                        \"Few context are missing. check all contexts \""},{"line_number":141,"context_line":"                        \"mentioned in self.all_contexts are tested\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_5ae687ea","line":138,"range":{"start_line":138,"start_character":8,"end_line":138,"end_character":70},"in_reply_to":"df33271e_0b083826","updated":"2020-04-06 21:43:58.000000000","message":"done - https://review.opendev.org/#/c/717825/","commit_id":"0a0885dac9e43b50a75d6d5c887b3295df4e0ee2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b6d7f86f47976e34677b02ebdf0595ec3eca2972","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        # the todo_add_reader adjusment."},{"line_number":136,"context_line":"        test_context \u003d len(authorized_contexts) + len(unauthorized_contexts)"},{"line_number":137,"context_line":"        equal \u003d len(self.all_contexts) \u003d\u003d test_context"},{"line_number":138,"context_line":"        todo_add_reader \u003d len(self.all_contexts) \u003d\u003d (test_context + 1)"},{"line_number":139,"context_line":"        self.assertTrue(equal or todo_add_reader,"},{"line_number":140,"context_line":"                        \"Few context are missing. check all contexts \""},{"line_number":141,"context_line":"                        \"mentioned in self.all_contexts are tested\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_0b083826","line":138,"range":{"start_line":138,"start_character":8,"end_line":138,"end_character":70},"in_reply_to":"df33271e_dc73c0b0","updated":"2020-04-06 14:05:30.000000000","message":"I see. That is valid point. \n\nself.all_contexts will always have this new context as it is deifned in base class. It can be checked in (authorized_contexts + unauthorized_contexts)  and if not present then +1.\n\nI will do in follow up as many patches i made depends on this one.","commit_id":"0a0885dac9e43b50a75d6d5c887b3295df4e0ee2"}],"nova/tests/unit/policies/test_security_groups.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0b5cfa9ff0f470185ce861ef953dd7838b6fd6cd","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        # server security groups."},{"line_number":166,"context_line":"        self.reader_unauthorized_contexts \u003d ["},{"line_number":167,"context_line":"            self.legacy_admin_context, self.project_foo_context,"},{"line_number":168,"context_line":"            self.system_foo_context, self.other_project_member_context"},{"line_number":169,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_07be9afe","line":168,"range":{"start_line":168,"start_character":42,"end_line":168,"end_character":70},"updated":"2020-04-03 14:08:31.000000000","message":"hmm, we don\u0027t have an other_project_reder, which would be hany here, but lets ignore that for now...!","commit_id":"8c4e8e73cad4a0ff30a4568600e73cbb8e4047a9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ce28cb8b30ae6558eefb63197756f229561d483c","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        # server security groups."},{"line_number":166,"context_line":"        self.reader_unauthorized_contexts \u003d ["},{"line_number":167,"context_line":"            self.legacy_admin_context, self.project_foo_context,"},{"line_number":168,"context_line":"            self.system_foo_context, self.other_project_member_context"},{"line_number":169,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_b99d4a0c","line":168,"range":{"start_line":168,"start_character":42,"end_line":168,"end_character":70},"in_reply_to":"df33271e_07be9afe","updated":"2020-04-03 22:32:07.000000000","message":"yeah I think that is good to test for actual verifying other project for reader case. done. i added for this and new policy and later is can add that new context for other tests.","commit_id":"8c4e8e73cad4a0ff30a4568600e73cbb8e4047a9"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c938dfb82669c987a3ec8e25847f6004d2e53c43","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            self.system_foo_context, self.other_project_member_context,"},{"line_number":153,"context_line":"            self.other_project_reader_context]"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        # Check that system reader or projct is able to get"},{"line_number":156,"context_line":"        # server security groups."},{"line_number":157,"context_line":"        self.reader_authorized_contexts \u003d ["},{"line_number":158,"context_line":"            self.system_admin_context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_3cad8cea","line":155,"range":{"start_line":155,"start_character":38,"end_line":155,"end_character":44},"updated":"2020-04-06 10:06:00.000000000","message":"nit:project","commit_id":"0a0885dac9e43b50a75d6d5c887b3295df4e0ee2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dcb2a69dc427db980aa1dbb4e4abe64abd4597c6","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            self.system_foo_context, self.other_project_member_context,"},{"line_number":153,"context_line":"            self.other_project_reader_context]"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        # Check that system reader or projct is able to get"},{"line_number":156,"context_line":"        # server security groups."},{"line_number":157,"context_line":"        self.reader_authorized_contexts \u003d ["},{"line_number":158,"context_line":"            self.system_admin_context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_eb7fd3a8","line":155,"range":{"start_line":155,"start_character":38,"end_line":155,"end_character":44},"in_reply_to":"df33271e_3cad8cea","updated":"2020-04-06 21:43:58.000000000","message":"ACK, adding in followup","commit_id":"0a0885dac9e43b50a75d6d5c887b3295df4e0ee2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c938dfb82669c987a3ec8e25847f6004d2e53c43","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            self.project_member_context,"},{"line_number":162,"context_line":"        ]"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        # Check that non-system reader nd non-admin/owner is not able to get"},{"line_number":165,"context_line":"        # server security groups."},{"line_number":166,"context_line":"        self.reader_unauthorized_contexts \u003d ["},{"line_number":167,"context_line":"            self.legacy_admin_context, self.project_foo_context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_1caa48d1","line":164,"range":{"start_line":164,"start_character":39,"end_line":164,"end_character":41},"updated":"2020-04-06 10:06:00.000000000","message":"nit: and","commit_id":"0a0885dac9e43b50a75d6d5c887b3295df4e0ee2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dcb2a69dc427db980aa1dbb4e4abe64abd4597c6","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            self.project_member_context,"},{"line_number":162,"context_line":"        ]"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        # Check that non-system reader nd non-admin/owner is not able to get"},{"line_number":165,"context_line":"        # server security groups."},{"line_number":166,"context_line":"        self.reader_unauthorized_contexts \u003d ["},{"line_number":167,"context_line":"            self.legacy_admin_context, self.project_foo_context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_0b503732","line":164,"range":{"start_line":164,"start_character":39,"end_line":164,"end_character":41},"in_reply_to":"df33271e_1caa48d1","updated":"2020-04-06 21:43:58.000000000","message":"ACK.","commit_id":"0a0885dac9e43b50a75d6d5c887b3295df4e0ee2"}]}