)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"b0fcedb9f3360ac3942fa4db4eb20fe0c06c7e27","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alexandre Arents \u003calexandre.arents@corp.ovh.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-04-06 16:00:56 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Calculate disk_over_committed for raw instances"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During update_available_resource periodic task, nova-compute reports total"},{"line_number":10,"context_line":"amount of disk_over_committed in order to determine current hypervisor\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df33271e_2fc05e7c","line":7,"updated":"2020-04-08 17:49:09.000000000","message":"nit - libvirt:","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"7e47f261ca1fc1890259c21a434ffa8a35cc411a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alexandre Arents \u003calexandre.arents@corp.ovh.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-04-06 16:00:56 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Calculate disk_over_committed for raw instances"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During update_available_resource periodic task, nova-compute reports total"},{"line_number":10,"context_line":"amount of disk_over_committed in order to determine current hypervisor\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df33271e_bf6009d1","line":7,"in_reply_to":"df33271e_2fc05e7c","updated":"2020-04-09 12:14:20.000000000","message":"Done","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"b0fcedb9f3360ac3942fa4db4eb20fe0c06c7e27","unresolved":false,"context_lines":[{"line_number":11,"context_line":"available_disk_least."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Currently, disk_over_committed is set to 0 for raw instances, which is"},{"line_number":14,"context_line":"appropriate when preallocate_images option is enabled because file size"},{"line_number":15,"context_line":"is equal to allocated size."},{"line_number":16,"context_line":"If not set, the raw disk file is thin and over_committed_disk_size have to be"},{"line_number":17,"context_line":"calculated in order to not mislead available_disk_least value."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df33271e_cf2a92e5","line":14,"range":{"start_line":14,"start_character":17,"end_line":14,"end_character":35},"updated":"2020-04-08 17:49:09.000000000","message":"``[compute]/preallocate_images``","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"b0fcedb9f3360ac3942fa4db4eb20fe0c06c7e27","unresolved":false,"context_lines":[{"line_number":11,"context_line":"available_disk_least."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Currently, disk_over_committed is set to 0 for raw instances, which is"},{"line_number":14,"context_line":"appropriate when preallocate_images option is enabled because file size"},{"line_number":15,"context_line":"is equal to allocated size."},{"line_number":16,"context_line":"If not set, the raw disk file is thin and over_committed_disk_size have to be"},{"line_number":17,"context_line":"calculated in order to not mislead available_disk_least value."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df33271e_2f45fe15","line":14,"range":{"start_line":14,"start_character":46,"end_line":14,"end_character":61},"updated":"2020-04-08 17:49:09.000000000","message":"set to space as images are fully allocated and","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"7e47f261ca1fc1890259c21a434ffa8a35cc411a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"available_disk_least."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Currently, disk_over_committed is set to 0 for raw instances, which is"},{"line_number":14,"context_line":"appropriate when preallocate_images option is enabled because file size"},{"line_number":15,"context_line":"is equal to allocated size."},{"line_number":16,"context_line":"If not set, the raw disk file is thin and over_committed_disk_size have to be"},{"line_number":17,"context_line":"calculated in order to not mislead available_disk_least value."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df33271e_1f2ad52a","line":14,"range":{"start_line":14,"start_character":46,"end_line":14,"end_character":61},"in_reply_to":"df33271e_2f45fe15","updated":"2020-04-09 12:14:20.000000000","message":"Done","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"7e47f261ca1fc1890259c21a434ffa8a35cc411a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"available_disk_least."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Currently, disk_over_committed is set to 0 for raw instances, which is"},{"line_number":14,"context_line":"appropriate when preallocate_images option is enabled because file size"},{"line_number":15,"context_line":"is equal to allocated size."},{"line_number":16,"context_line":"If not set, the raw disk file is thin and over_committed_disk_size have to be"},{"line_number":17,"context_line":"calculated in order to not mislead available_disk_least value."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df33271e_7f220154","line":14,"range":{"start_line":14,"start_character":17,"end_line":14,"end_character":35},"in_reply_to":"df33271e_cf2a92e5","updated":"2020-04-09 12:14:20.000000000","message":"Done","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"b0fcedb9f3360ac3942fa4db4eb20fe0c06c7e27","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Currently, disk_over_committed is set to 0 for raw instances, which is"},{"line_number":14,"context_line":"appropriate when preallocate_images option is enabled because file size"},{"line_number":15,"context_line":"is equal to allocated size."},{"line_number":16,"context_line":"If not set, the raw disk file is thin and over_committed_disk_size have to be"},{"line_number":17,"context_line":"calculated in order to not mislead available_disk_least value."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This change introduces over_committed_disk_size calucation also for raw disk."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df33271e_af62aeab","line":16,"range":{"start_line":16,"start_character":33,"end_line":16,"end_character":37},"updated":"2020-04-08 17:49:09.000000000","message":"sparsely allocated","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"7e47f261ca1fc1890259c21a434ffa8a35cc411a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Currently, disk_over_committed is set to 0 for raw instances, which is"},{"line_number":14,"context_line":"appropriate when preallocate_images option is enabled because file size"},{"line_number":15,"context_line":"is equal to allocated size."},{"line_number":16,"context_line":"If not set, the raw disk file is thin and over_committed_disk_size have to be"},{"line_number":17,"context_line":"calculated in order to not mislead available_disk_least value."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This change introduces over_committed_disk_size calucation also for raw disk."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df33271e_5f1f3d07","line":16,"range":{"start_line":16,"start_character":33,"end_line":16,"end_character":37},"in_reply_to":"df33271e_af62aeab","updated":"2020-04-09 12:14:20.000000000","message":"Done","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"b0fcedb9f3360ac3942fa4db4eb20fe0c06c7e27","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This change introduces over_committed_disk_size calucation also for raw disk."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"In addition, because disk file can have allocated size greater than virtual"},{"line_number":22,"context_line":"disk size, we consider returning 0 instead of a negative value, as a negative"},{"line_number":23,"context_line":"value will inaccurately increase available_disk_least."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: #1870357"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df33271e_0f0f5ae1","line":23,"range":{"start_line":21,"start_character":0,"end_line":23,"end_character":54},"updated":"2020-04-08 17:49:09.000000000","message":"I almost think this needs to live in a separate follow up change tbh, I also wouldn\u0027t even do this for RAW images as their virt size can never be larger than their actual size.","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"7e47f261ca1fc1890259c21a434ffa8a35cc411a","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This change introduces over_committed_disk_size calucation also for raw disk."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"In addition, because disk file can have allocated size greater than virtual"},{"line_number":22,"context_line":"disk size, we consider returning 0 instead of a negative value, as a negative"},{"line_number":23,"context_line":"value will inaccurately increase available_disk_least."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: #1870357"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df33271e_5fcd7d83","line":23,"range":{"start_line":21,"start_character":0,"end_line":23,"end_character":54},"in_reply_to":"df33271e_0f0f5ae1","updated":"2020-04-09 12:14:20.000000000","message":"I hesitated, your comment achieved to convince me, I will open a new change for that.","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"b0fcedb9f3360ac3942fa4db4eb20fe0c06c7e27","unresolved":false,"context_lines":[{"line_number":16688,"context_line":"        c \u003d context.get_admin_context()"},{"line_number":16689,"context_line":"        instance \u003d objects.Instance(root_device_name\u003d\u0027/dev/vda\u0027,"},{"line_number":16690,"context_line":"                                    **self.test_instance)"},{"line_number":16691,"context_line":"        bdms \u003d objects.BlockDeviceMappingList(objects\u003d["},{"line_number":16692,"context_line":"            fake_block_device.fake_bdm_object(c, {"},{"line_number":16693,"context_line":"                \u0027device_name\u0027: \u0027/dev/vda\u0027,"},{"line_number":16694,"context_line":"                \u0027source_type\u0027: \u0027image\u0027,"},{"line_number":16695,"context_line":"                \u0027destination_type\u0027: \u0027local\u0027"},{"line_number":16696,"context_line":"            }),"},{"line_number":16697,"context_line":"        ])"},{"line_number":16698,"context_line":""},{"line_number":16699,"context_line":"        block_device_info \u003d driver.get_block_device_info(instance, bdms)"},{"line_number":16700,"context_line":"        config \u003d vconfig.LibvirtConfigGuest()"},{"line_number":16701,"context_line":"        disk_config \u003d vconfig.LibvirtConfigGuestDisk()"},{"line_number":16702,"context_line":"        disk_config.source_type \u003d \"file\""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_0fb2bae6","line":16699,"range":{"start_line":16691,"start_character":0,"end_line":16699,"end_character":72},"updated":"2020-04-08 17:49:09.000000000","message":"You shouldn\u0027t need this to test your changes, just the config and disk_config stuff below.","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"7e47f261ca1fc1890259c21a434ffa8a35cc411a","unresolved":false,"context_lines":[{"line_number":16688,"context_line":"        c \u003d context.get_admin_context()"},{"line_number":16689,"context_line":"        instance \u003d objects.Instance(root_device_name\u003d\u0027/dev/vda\u0027,"},{"line_number":16690,"context_line":"                                    **self.test_instance)"},{"line_number":16691,"context_line":"        bdms \u003d objects.BlockDeviceMappingList(objects\u003d["},{"line_number":16692,"context_line":"            fake_block_device.fake_bdm_object(c, {"},{"line_number":16693,"context_line":"                \u0027device_name\u0027: \u0027/dev/vda\u0027,"},{"line_number":16694,"context_line":"                \u0027source_type\u0027: \u0027image\u0027,"},{"line_number":16695,"context_line":"                \u0027destination_type\u0027: \u0027local\u0027"},{"line_number":16696,"context_line":"            }),"},{"line_number":16697,"context_line":"        ])"},{"line_number":16698,"context_line":""},{"line_number":16699,"context_line":"        block_device_info \u003d driver.get_block_device_info(instance, bdms)"},{"line_number":16700,"context_line":"        config \u003d vconfig.LibvirtConfigGuest()"},{"line_number":16701,"context_line":"        disk_config \u003d vconfig.LibvirtConfigGuestDisk()"},{"line_number":16702,"context_line":"        disk_config.source_type \u003d \"file\""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_7f95e13f","line":16699,"range":{"start_line":16691,"start_character":0,"end_line":16699,"end_character":72},"in_reply_to":"df33271e_0fb2bae6","updated":"2020-04-09 12:14:20.000000000","message":"exact, much more clearer like this, done.","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"b0fcedb9f3360ac3942fa4db4eb20fe0c06c7e27","unresolved":false,"context_lines":[{"line_number":16699,"context_line":"        block_device_info \u003d driver.get_block_device_info(instance, bdms)"},{"line_number":16700,"context_line":"        config \u003d vconfig.LibvirtConfigGuest()"},{"line_number":16701,"context_line":"        disk_config \u003d vconfig.LibvirtConfigGuestDisk()"},{"line_number":16702,"context_line":"        disk_config.source_type \u003d \"file\""},{"line_number":16703,"context_line":"        disk_config.source_path \u003d \"fake\""},{"line_number":16704,"context_line":"        config.devices.append(disk_config)"},{"line_number":16705,"context_line":""},{"line_number":16706,"context_line":"        mock_getsize.return_value \u003d 53687091200"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_4fd042f8","line":16703,"range":{"start_line":16702,"start_character":0,"end_line":16703,"end_character":40},"updated":"2020-04-08 17:49:09.000000000","message":"I think we can also add the following here are we\u0027d actually expect to see right?\n\n    disk_config.driver_forma \u003d \u0027raw\u0027","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"7e47f261ca1fc1890259c21a434ffa8a35cc411a","unresolved":false,"context_lines":[{"line_number":16699,"context_line":"        block_device_info \u003d driver.get_block_device_info(instance, bdms)"},{"line_number":16700,"context_line":"        config \u003d vconfig.LibvirtConfigGuest()"},{"line_number":16701,"context_line":"        disk_config \u003d vconfig.LibvirtConfigGuestDisk()"},{"line_number":16702,"context_line":"        disk_config.source_type \u003d \"file\""},{"line_number":16703,"context_line":"        disk_config.source_path \u003d \"fake\""},{"line_number":16704,"context_line":"        config.devices.append(disk_config)"},{"line_number":16705,"context_line":""},{"line_number":16706,"context_line":"        mock_getsize.return_value \u003d 53687091200"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_5f929d58","line":16703,"range":{"start_line":16702,"start_character":0,"end_line":16703,"end_character":40},"in_reply_to":"df33271e_4fd042f8","updated":"2020-04-09 12:14:20.000000000","message":"yes","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"b0fcedb9f3360ac3942fa4db4eb20fe0c06c7e27","unresolved":false,"context_lines":[{"line_number":16709,"context_line":"        disk_info \u003d drvr._get_instance_disk_info_from_config(config,"},{"line_number":16710,"context_line":"                                                             block_device_info)"},{"line_number":16711,"context_line":""},{"line_number":16712,"context_line":"        self.assertEqual(disk_info[0][\u0027over_committed_disk_size\u0027],"},{"line_number":16713,"context_line":"                         53687091200 - (7201350 * 512))"},{"line_number":16714,"context_line":""},{"line_number":16715,"context_line":"    @mock.patch(\u0027os.stat\u0027)"},{"line_number":16716,"context_line":"    @mock.patch(\u0027os.path.getsize\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_6fc0a62b","line":16713,"range":{"start_line":16712,"start_character":25,"end_line":16713,"end_character":54},"updated":"2020-04-08 17:49:09.000000000","message":"These should be expected and then actual values.\n\nI\u0027d also like to see these values in variables with meaningful names and calculated outside of the actual assert:\n\n\n   disk_virtual_size \u003d 53687091200\n   disk_actual_size \u003d 3687091200\n   disk_actual_size_blocks \u003d disk_actual_size / 512\n   expected_over_committed_disk_size \u003d disk_virtual_size - disk_actual_size\n\n   [..]\n\n   self.assertEqual(expected_over_committed_disk_size,\n                    disk_info[0][\u0027over_committed_disk_size\u0027])","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"7e47f261ca1fc1890259c21a434ffa8a35cc411a","unresolved":false,"context_lines":[{"line_number":16709,"context_line":"        disk_info \u003d drvr._get_instance_disk_info_from_config(config,"},{"line_number":16710,"context_line":"                                                             block_device_info)"},{"line_number":16711,"context_line":""},{"line_number":16712,"context_line":"        self.assertEqual(disk_info[0][\u0027over_committed_disk_size\u0027],"},{"line_number":16713,"context_line":"                         53687091200 - (7201350 * 512))"},{"line_number":16714,"context_line":""},{"line_number":16715,"context_line":"    @mock.patch(\u0027os.stat\u0027)"},{"line_number":16716,"context_line":"    @mock.patch(\u0027os.path.getsize\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_bf9be970","line":16713,"range":{"start_line":16712,"start_character":25,"end_line":16713,"end_character":54},"in_reply_to":"df33271e_6fc0a62b","updated":"2020-04-09 12:14:20.000000000","message":"done","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"95788ab15fe12f08e08bcf249bb3d98811102afe","unresolved":false,"context_lines":[{"line_number":16667,"context_line":"        disk_virtual_size \u003d 53687091200"},{"line_number":16668,"context_line":"        disk_actual_size \u003d 3687091200"},{"line_number":16669,"context_line":"        disk_actual_size_blocks \u003d disk_actual_size / 512"},{"line_number":16670,"context_line":"        expected_over_committed_disk_size \u003d disk_virtual_size -\\"},{"line_number":16671,"context_line":"                                                disk_actual_size"},{"line_number":16672,"context_line":""},{"line_number":16673,"context_line":"        mock_getsize.return_value \u003d disk_virtual_size"},{"line_number":16674,"context_line":"        mock_stat.return_value \u003d mock.Mock(st_blocks\u003ddisk_actual_size_blocks)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_bf564929","line":16671,"range":{"start_line":16670,"start_character":0,"end_line":16671,"end_character":64},"updated":"2020-04-09 12:29:26.000000000","message":"Apologies, I didn\u0027t mean to cause you to wrap this, if you respin feel free to give this a shorter name.","commit_id":"addd6caddaf2b0b808a414828d98486a9f7ffedd"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"b0fcedb9f3360ac3942fa4db4eb20fe0c06c7e27","unresolved":false,"context_lines":[{"line_number":9554,"context_line":"                qemu_img_info \u003d disk_api.get_disk_info(path)"},{"line_number":9555,"context_line":"                virt_size \u003d qemu_img_info.virtual_size"},{"line_number":9556,"context_line":"                backing_file \u003d libvirt_utils.get_disk_backing_file(path)"},{"line_number":9557,"context_line":"                over_commit_size \u003d max(0, int(virt_size) - dk_size)"},{"line_number":9558,"context_line":""},{"line_number":9559,"context_line":"            elif disk_type \u003d\u003d \u0027file\u0027 and driver_type \u003d\u003d \u0027qcow2\u0027:"},{"line_number":9560,"context_line":"                qemu_img_info \u003d disk_api.get_disk_info(path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_efb836e6","line":9557,"range":{"start_line":9557,"start_character":35,"end_line":9557,"end_character":41},"updated":"2020-04-08 17:49:09.000000000","message":"I don\u0027t know the ploop format but I assume the header can grow over time leading to a need for this?","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"7e47f261ca1fc1890259c21a434ffa8a35cc411a","unresolved":false,"context_lines":[{"line_number":9554,"context_line":"                qemu_img_info \u003d disk_api.get_disk_info(path)"},{"line_number":9555,"context_line":"                virt_size \u003d qemu_img_info.virtual_size"},{"line_number":9556,"context_line":"                backing_file \u003d libvirt_utils.get_disk_backing_file(path)"},{"line_number":9557,"context_line":"                over_commit_size \u003d max(0, int(virt_size) - dk_size)"},{"line_number":9558,"context_line":""},{"line_number":9559,"context_line":"            elif disk_type \u003d\u003d \u0027file\u0027 and driver_type \u003d\u003d \u0027qcow2\u0027:"},{"line_number":9560,"context_line":"                qemu_img_info \u003d disk_api.get_disk_info(path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_9f71c547","line":9557,"range":{"start_line":9557,"start_character":35,"end_line":9557,"end_character":41},"in_reply_to":"df33271e_efb836e6","updated":"2020-04-09 12:14:20.000000000","message":"I will check","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"b0fcedb9f3360ac3942fa4db4eb20fe0c06c7e27","unresolved":false,"context_lines":[{"line_number":9561,"context_line":"                dk_size \u003d qemu_img_info.disk_size"},{"line_number":9562,"context_line":"                virt_size \u003d qemu_img_info.virtual_size"},{"line_number":9563,"context_line":"                backing_file \u003d libvirt_utils.get_disk_backing_file(path)"},{"line_number":9564,"context_line":"                over_commit_size \u003d max(0, int(virt_size) - dk_size)"},{"line_number":9565,"context_line":""},{"line_number":9566,"context_line":"            elif disk_type \u003d\u003d \u0027file\u0027:"},{"line_number":9567,"context_line":"                dk_size \u003d os.stat(path).st_blocks * 512"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_6feb86db","line":9564,"range":{"start_line":9564,"start_character":35,"end_line":9564,"end_character":41},"updated":"2020-04-08 17:49:09.000000000","message":"Makes sense but I wonder if this should be in a separate change.","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"7e47f261ca1fc1890259c21a434ffa8a35cc411a","unresolved":false,"context_lines":[{"line_number":9561,"context_line":"                dk_size \u003d qemu_img_info.disk_size"},{"line_number":9562,"context_line":"                virt_size \u003d qemu_img_info.virtual_size"},{"line_number":9563,"context_line":"                backing_file \u003d libvirt_utils.get_disk_backing_file(path)"},{"line_number":9564,"context_line":"                over_commit_size \u003d max(0, int(virt_size) - dk_size)"},{"line_number":9565,"context_line":""},{"line_number":9566,"context_line":"            elif disk_type \u003d\u003d \u0027file\u0027:"},{"line_number":9567,"context_line":"                dk_size \u003d os.stat(path).st_blocks * 512"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_ff8f3120","line":9564,"range":{"start_line":9564,"start_character":35,"end_line":9564,"end_character":41},"in_reply_to":"df33271e_6feb86db","updated":"2020-04-09 12:14:20.000000000","message":"ok, will open another change for that.","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"b0fcedb9f3360ac3942fa4db4eb20fe0c06c7e27","unresolved":false,"context_lines":[{"line_number":9567,"context_line":"                dk_size \u003d os.stat(path).st_blocks * 512"},{"line_number":9568,"context_line":"                virt_size \u003d os.path.getsize(path)"},{"line_number":9569,"context_line":"                backing_file \u003d \"\""},{"line_number":9570,"context_line":"                over_commit_size \u003d max(0, int(virt_size) - dk_size)"},{"line_number":9571,"context_line":""},{"line_number":9572,"context_line":"            elif disk_type \u003d\u003d \u0027block\u0027 and block_device_info:"},{"line_number":9573,"context_line":"                dk_size \u003d lvm.get_volume_size(path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_8ff08acb","line":9570,"range":{"start_line":9570,"start_character":35,"end_line":9570,"end_character":40},"updated":"2020-04-08 17:49:09.000000000","message":"I\u0027m not sure that we need this, dk_size should never be greater than virt_size for RAW files regardless of if they are sparsely allocated or not.","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"b0fcedb9f3360ac3942fa4db4eb20fe0c06c7e27","unresolved":false,"context_lines":[{"line_number":9567,"context_line":"                dk_size \u003d os.stat(path).st_blocks * 512"},{"line_number":9568,"context_line":"                virt_size \u003d os.path.getsize(path)"},{"line_number":9569,"context_line":"                backing_file \u003d \"\""},{"line_number":9570,"context_line":"                over_commit_size \u003d max(0, int(virt_size) - dk_size)"},{"line_number":9571,"context_line":""},{"line_number":9572,"context_line":"            elif disk_type \u003d\u003d \u0027block\u0027 and block_device_info:"},{"line_number":9573,"context_line":"                dk_size \u003d lvm.get_volume_size(path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_afa3ceb0","line":9570,"range":{"start_line":9570,"start_character":42,"end_line":9570,"end_character":67},"updated":"2020-04-08 17:49:09.000000000","message":"Right, this makes sense for sparsely allocated RAW files as dk_size (actual size) will be less than virt_size (potential size once allocated).","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"7e47f261ca1fc1890259c21a434ffa8a35cc411a","unresolved":false,"context_lines":[{"line_number":9567,"context_line":"                dk_size \u003d os.stat(path).st_blocks * 512"},{"line_number":9568,"context_line":"                virt_size \u003d os.path.getsize(path)"},{"line_number":9569,"context_line":"                backing_file \u003d \"\""},{"line_number":9570,"context_line":"                over_commit_size \u003d max(0, int(virt_size) - dk_size)"},{"line_number":9571,"context_line":""},{"line_number":9572,"context_line":"            elif disk_type \u003d\u003d \u0027block\u0027 and block_device_info:"},{"line_number":9573,"context_line":"                dk_size \u003d lvm.get_volume_size(path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_9fbf05a9","line":9570,"range":{"start_line":9570,"start_character":35,"end_line":9570,"end_character":40},"in_reply_to":"df33271e_8ff08acb","updated":"2020-04-09 12:14:20.000000000","message":"I\u0027ve seen it can be the case for raw allocated(only few kB/mB), let\u0027s discuss that in the the other change.","commit_id":"daebb828c7c2f2e7807eb8e0d48bbfc7311eb18e"}]}